From e7773f764a1b85fcb0b25dc466b95c1ac9375085 Mon Sep 17 00:00:00 2001
From: agiersch <agiersch@48e7efb5-ca39-0410-a469-dd3cf9ba447f>
Date: Wed, 1 Dec 2010 22:00:40 +0000
Subject: [PATCH 1/1] Fix a memory leak in xbt_ex_setup_backtrace.

git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/simgrid/simgrid/trunk@8845 48e7efb5-ca39-0410-a469-dd3cf9ba447f
---
 src/xbt/backtrace_linux.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/xbt/backtrace_linux.c b/src/xbt/backtrace_linux.c
index 29dd7f7a1a..be2ebc476b 100644
--- a/src/xbt/backtrace_linux.c
+++ b/src/xbt/backtrace_linux.c
@@ -64,7 +64,6 @@ void xbt_ex_setup_backtrace(xbt_ex_t * e)
   /* ignore first one, which is this xbt_backtrace_current() */
   e->used--;
   memmove(backtrace_syms, backtrace_syms + 1, sizeof(char *) * e->used);
-  addrs = xbt_new(char *, e->used);
 
   e->bt_strings = NULL;
 
@@ -91,10 +90,10 @@ void xbt_ex_setup_backtrace(xbt_ex_t * e)
             /* Found. */
             DEBUG1("Looked in the PATH for the binary. Found %s",
                    binary_name);
-            xbt_dynar_free(&path);
             break;
           }
         }
+        xbt_dynar_free(&path);
         if (stat(binary_name, &stat_buf)) {
           /* not found */
           e->used = 1;
@@ -102,9 +101,9 @@ void xbt_ex_setup_backtrace(xbt_ex_t * e)
 
           e->bt_strings[0] =
               bprintf("(binary '%s' not found the path)", xbt_binary_name);
+          free(backtrace_syms);
           return;
         }
-        xbt_dynar_free(&path);
         break;
       }
     }
@@ -118,6 +117,7 @@ void xbt_ex_setup_backtrace(xbt_ex_t * e)
   curr += sprintf(curr, "%s -f -e %s ", ADDR2LINE, binary_name);
   free(binary_name);
 
+  addrs = xbt_new(char *, e->used);
   for (i = 0; i < e->used; i++) {
     /* retrieve this address */
     DEBUG2("Retrieving address number %d from '%s'", i, backtrace_syms[i]);
@@ -215,6 +215,7 @@ void xbt_ex_setup_backtrace(xbt_ex_t * e)
       }
       fclose(maps);
       free(maps_name);
+      free(addrs[i]);
 
       if (!found) {
         VERB0
@@ -228,7 +229,6 @@ void xbt_ex_setup_backtrace(xbt_ex_t * e)
          We now need to substract this from the address we got from backtrace.
        */
 
-      free(addrs[i]);
       addrs[i] = bprintf("0x%0*lx", addr_len - 2, addr - offset);
       DEBUG2("offset=%#lx new addr=%s", offset, addrs[i]);
 
@@ -295,12 +295,12 @@ void xbt_ex_setup_backtrace(xbt_ex_t * e)
 
       for (j = i + 1; j < e->used; j++)
         free(addrs[j]);
-      e->used = i;
+      e->used = i + 1;
 
       if (!strncmp
           ("xbt_thread_context_wrapper", line_func,
            strlen("xbt_thread_context_wrapper"))) {
-        e->used++;
+        free(e->bt_strings[i]);
         e->bt_strings[i] = bprintf("**   (in a separate thread)");
       }
     }
-- 
2.20.1