From e58aa70672665643abf2bf6681aaeeae482f3d56 Mon Sep 17 00:00:00 2001
From: Arnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Date: Fri, 16 Apr 2021 14:29:23 +0200
Subject: [PATCH] Use std::find_if when looking for a matching comm.

---
 src/kernel/activity/MailboxImpl.cpp | 42 +++++++++++++----------------
 1 file changed, 18 insertions(+), 24 deletions(-)

diff --git a/src/kernel/activity/MailboxImpl.cpp b/src/kernel/activity/MailboxImpl.cpp
index f812f45522..e2d460358f 100644
--- a/src/kernel/activity/MailboxImpl.cpp
+++ b/src/kernel/activity/MailboxImpl.cpp
@@ -124,35 +124,29 @@ CommImplPtr MailboxImpl::find_matching_comm(CommImpl::Type type, bool (*match_fu
                                             void* this_user_data, const CommImplPtr& my_synchro, bool done,
                                             bool remove_matching)
 {
-  void* other_user_data = nullptr;
   auto& comm_queue      = done ? done_comm_queue_ : comm_queue_;
 
-  for (auto it = comm_queue.begin(); it != comm_queue.end(); it++) {
-    const CommImplPtr& comm = *it;
+  auto iter = std::find_if(
+      comm_queue.begin(), comm_queue.end(), [&type, &match_fun, &this_user_data, &my_synchro](const CommImplPtr& comm) {
+        void* other_user_data = (comm->type_ == CommImpl::Type::SEND ? comm->src_data_ : comm->dst_data_);
+        return (comm->type_ == type && (not match_fun || match_fun(this_user_data, other_user_data, comm.get())) &&
+                (not comm->match_fun || comm->match_fun(other_user_data, this_user_data, my_synchro.get())));
+      });
+  if (iter == comm_queue.end()) {
+    XBT_DEBUG("No matching communication synchro found");
+    return nullptr;
+  }
 
-    if (comm->type_ == CommImpl::Type::SEND) {
-      other_user_data = comm->src_data_;
-    } else if (comm->type_ == CommImpl::Type::RECEIVE) {
-      other_user_data = comm->dst_data_;
-    }
-    if (comm->type_ == type && (match_fun == nullptr || match_fun(this_user_data, other_user_data, comm.get())) &&
-        (not comm->match_fun || comm->match_fun(other_user_data, this_user_data, my_synchro.get()))) {
-      XBT_DEBUG("Found a matching communication synchro %p", comm.get());
+  const CommImplPtr& comm = *iter;
+  XBT_DEBUG("Found a matching communication synchro %p", comm.get());
 #if SIMGRID_HAVE_MC
-      comm->mbox_cpy = comm->get_mailbox();
+  comm->mbox_cpy = comm->get_mailbox();
 #endif
-      comm->set_mailbox(nullptr);
-      CommImplPtr comm_cpy = comm;
-      if (remove_matching)
-        comm_queue.erase(it);
-      return comm_cpy;
-    }
-    XBT_DEBUG("Sorry, communication synchro %p does not match our needs:"
-              " its type is %d but we are looking for a comm of type %d (or maybe the filtering didn't match)",
-              comm.get(), (int)comm->type_, (int)type);
-  }
-  XBT_DEBUG("No matching communication synchro found");
-  return nullptr;
+  comm->set_mailbox(nullptr);
+  CommImplPtr comm_cpy = comm;
+  if (remove_matching)
+    comm_queue.erase(iter);
+  return comm_cpy;
 }
 } // namespace activity
 } // namespace kernel
-- 
2.20.1