From d71293633ab72fc082a6d5f7d9ca2f1cbf4b99dc Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Thu, 5 Oct 2017 21:48:33 +0200 Subject: [PATCH] Fix invalid free when SIMIX_global_init() exits early. --- src/s4u/s4u_engine.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/s4u/s4u_engine.cpp b/src/s4u/s4u_engine.cpp index 07fa11beb4..783ed43c4a 100644 --- a/src/s4u/s4u_engine.cpp +++ b/src/s4u/s4u_engine.cpp @@ -32,11 +32,11 @@ Engine *Engine::instance_ = nullptr; /* That singleton is awful, but I don't see Engine::Engine(int *argc, char **argv) { xbt_assert(s4u::Engine::instance_ == nullptr, "It is currently forbidden to create more than one instance of s4u::Engine"); - s4u::Engine::instance_ = this; - pimpl = new kernel::EngineImpl(); - TRACE_global_init(); SIMIX_global_init(argc, argv); + + pimpl = new kernel::EngineImpl(); + s4u::Engine::instance_ = this; } Engine::~Engine() @@ -54,6 +54,7 @@ Engine* Engine::getInstance() void Engine::shutdown() { delete s4u::Engine::instance_; + s4u::Engine::instance_ = nullptr; } double Engine::getClock() -- 2.20.1