From d685808894710dda03e4734a9e39f617adda0508 Mon Sep 17 00:00:00 2001
From: Arnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Date: Fri, 27 Jan 2023 16:17:35 +0100
Subject: [PATCH] Sonar smells after last changes.

---
 src/kernel/routing/ClusterZone.cpp            | 4 +++-
 teshsuite/s4u/actor-suspend/actor-suspend.cpp | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/kernel/routing/ClusterZone.cpp b/src/kernel/routing/ClusterZone.cpp
index cce406346a..bb269eba5a 100644
--- a/src/kernel/routing/ClusterZone.cpp
+++ b/src/kernel/routing/ClusterZone.cpp
@@ -69,7 +69,9 @@ void ClusterBase::fill_leaf_from_cb(unsigned long position, const std::vector<un
   // auxiliary function to get dims from index
   auto index_to_dims = [&dimensions](unsigned long index) {
     std::vector<unsigned long> dims_array(dimensions.size());
-    for (auto i = static_cast<int>(dimensions.size() - 1); i >= 0 && index > 0; --i) {
+    for (auto i = static_cast<int>(dimensions.size() - 1); i >= 0; --i) {
+      if (index == 0)
+        break;
       unsigned long value = index % dimensions[i];
       dims_array[i]      = value;
       index              = (index / dimensions[i]);
diff --git a/teshsuite/s4u/actor-suspend/actor-suspend.cpp b/teshsuite/s4u/actor-suspend/actor-suspend.cpp
index f7f795d487..ed4d1ed980 100644
--- a/teshsuite/s4u/actor-suspend/actor-suspend.cpp
+++ b/teshsuite/s4u/actor-suspend/actor-suspend.cpp
@@ -29,7 +29,7 @@ class Suspender {
   const simgrid::s4u::ActorPtr& receiver;
 
 public:
-  Suspender(simgrid::s4u::ActorPtr& receiver) : receiver(receiver) {}
+  explicit Suspender(const simgrid::s4u::ActorPtr& receiver) : receiver(receiver) {}
 
   void operator()() const
   {
-- 
2.20.1