From d3e063c03559fb73eaf01865a4455f4646981416 Mon Sep 17 00:00:00 2001 From: Gabriel Corona Date: Wed, 10 Feb 2016 16:51:25 +0100 Subject: [PATCH] [mc] Fix UContext::wrapper The name of the wrapper is used in the MC code introspection so we can't change it without changing the MC code. --- src/simix/UContext.cpp | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/simix/UContext.cpp b/src/simix/UContext.cpp index 33532bb647..45b50be5d9 100644 --- a/src/simix/UContext.cpp +++ b/src/simix/UContext.cpp @@ -76,6 +76,10 @@ static unsigned long sysv_process_index = 0; /* index of the next process to r static simgrid::simix::UContext* sysv_maestro_context; static bool sysv_parallel; +// The name of this function is currently hardcoded in the code (as string). +// Do not change it without fixing those references as well. +static void smx_ctx_sysv_wrapper(int first, ...); + namespace simgrid { namespace simix { @@ -88,8 +92,6 @@ public: UContext(std::function code, void_pfn_smxprocess_t cleanup_func, smx_process_t process); ~UContext(); -protected: - static void wrapper(int first, ...); }; class SerialUContext : public UContext { @@ -224,7 +226,7 @@ UContext::UContext(std::function code, this->stack_, smx_context_usable_stack_size); this->uc_.uc_stack.ss_size = pth_sksize_makecontext( this->stack_, smx_context_usable_stack_size); - simgrid_makecontext(&this->uc_, UContext::wrapper, this); + simgrid_makecontext(&this->uc_, smx_ctx_sysv_wrapper, this); } else { if (process != NULL && sysv_maestro_context == NULL) sysv_maestro_context = this; @@ -243,11 +245,14 @@ UContext::~UContext() SIMIX_context_stack_delete(this->stack_); } -void UContext::wrapper(int first, ...) +} +} + +static void smx_ctx_sysv_wrapper(int first, ...) { // Rebuild the Context* pointer from the integers: int ctx_addr[CTX_ADDR_LEN]; - UContext* context; + simgrid::simix::UContext* context; ctx_addr[0] = first; if (CTX_ADDR_LEN > 1) { va_list ap; @@ -256,12 +261,15 @@ void UContext::wrapper(int first, ...) ctx_addr[i] = va_arg(ap, int); va_end(ap); } - memcpy(&context, ctx_addr, sizeof(UContext*)); + memcpy(&context, ctx_addr, sizeof(simgrid::simix::UContext*)); (*context)(); context->stop(); } +namespace simgrid { +namespace simix { + void SerialUContext::stop() { Context::stop(); -- 2.20.1