From d0fc10056ca5f7ba067fb0f73dd95d939ed610d3 Mon Sep 17 00:00:00 2001 From: Martin Quinson Date: Thu, 25 Jan 2018 06:55:39 +0100 Subject: [PATCH] improve a comment Shorten this a bit, and do not dupplicate things that we can find with a git blame. --- src/simix/ActorImpl.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/simix/ActorImpl.cpp b/src/simix/ActorImpl.cpp index d2b51d4e41..1fd6dc3ab0 100644 --- a/src/simix/ActorImpl.cpp +++ b/src/simix/ActorImpl.cpp @@ -351,10 +351,8 @@ smx_actor_t SIMIX_process_create(const char* name, std::function code, v /* Tracing the process creation */ TRACE_msg_process_create(process->getName(), process->pid, process->host); - /* Note by cheinrich: If you move this directly after the "new ActorImpl", the pid - * will not yet be set and you will cause issues when other code relies on that. - * This is of course also true for the other properties, so I moved this here. - */ + + /* The onCreation() signal must be delayed until there, where the pid and everything is set */ simgrid::s4u::ActorPtr tmp = process->iface(); // Passing this directly to onCreation will lead to crashes simgrid::s4u::Actor::onCreation(tmp); -- 2.20.1