From c9272c386dabc61a6c9f189e2ef7a4fb058eb7b6 Mon Sep 17 00:00:00 2001 From: Martin Quinson Date: Tue, 23 Aug 2016 02:06:22 +0200 Subject: [PATCH] cleanups to please sonar --- examples/java/app/tokenring/Main.java | 2 +- examples/java/app/tokenring/RelayRunner.java | 3 ++- examples/java/async/dsend/Receiver.java | 1 + examples/java/async/dsend/Sender.java | 1 + 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/examples/java/app/tokenring/Main.java b/examples/java/app/tokenring/Main.java index d1423aadc5..2448865a35 100644 --- a/examples/java/app/tokenring/Main.java +++ b/examples/java/app/tokenring/Main.java @@ -26,7 +26,7 @@ class Main { Host[] hosts = Host.all(); for (int rank = 0; rank < hosts.length; rank++) { - Process proc = new RelayRunner(hosts[rank], ""+rank, null); + Process proc = new RelayRunner(hosts[rank], Integer.toString(rank), null); proc.start(); } Msg.info("Number of hosts '"+hosts.length+"'"); diff --git a/examples/java/app/tokenring/RelayRunner.java b/examples/java/app/tokenring/RelayRunner.java index 0f1bf9c1a8..c045cdbb5a 100644 --- a/examples/java/app/tokenring/RelayRunner.java +++ b/examples/java/app/tokenring/RelayRunner.java @@ -21,6 +21,7 @@ public class RelayRunner extends Process { } /* This is the function executed by this kind of processes */ + @Override public void main(String[] args) throws MsgException { // In this example, the processes are given numerical names: "0", "1", "2", and so on int rank = Integer.parseInt(this.getName()); @@ -45,7 +46,7 @@ public class RelayRunner extends Process { Msg.info("Host '"+rank+"' received '"+token.getName()+"'"); - String mailbox = ""+(rank+1); // Java idiomatic to get the String version of rank+1 + String mailbox = Integer.toString(rank+1); if (rank+1 == Host.getCount()) { /* The last process has no right neighbor, so it sends the token back to rank 0 */ mailbox = "0"; diff --git a/examples/java/async/dsend/Receiver.java b/examples/java/async/dsend/Receiver.java index 162a15ee06..7a9aba85dc 100644 --- a/examples/java/async/dsend/Receiver.java +++ b/examples/java/async/dsend/Receiver.java @@ -18,6 +18,7 @@ public class Receiver extends Process { super(host,name); } + @Override public void main(String[] args) throws TransferFailureException, HostFailureException, TimeoutException { Msg.info("Receiving on '"+ getHost().getName() + "'"); Task.receive(getHost().getName()); diff --git a/examples/java/async/dsend/Sender.java b/examples/java/async/dsend/Sender.java index 329d24cedc..85e83db1d2 100644 --- a/examples/java/async/dsend/Sender.java +++ b/examples/java/async/dsend/Sender.java @@ -17,6 +17,7 @@ public class Sender extends Process { super(host,name); } + @Override public void main(String[] args) throws MsgException { double taskComputeSize =0; double taskCommunicateSize = 5000000; -- 2.20.1