From c8f4cd32fa6bfe50360ed8c9f61aa43b33d4e005 Mon Sep 17 00:00:00 2001
From: Arnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Date: Fri, 15 Mar 2019 20:58:53 +0100
Subject: [PATCH] Remove declarations for never used signal slots.

Either not defined, or simply not used.
---
 src/plugins/vm/VirtualMachineImpl.cpp |  2 +-
 src/plugins/vm/VirtualMachineImpl.hpp |  2 --
 src/surf/StorageImpl.hpp              | 17 +++++------------
 src/surf/cpu_interface.hpp            |  4 ----
 4 files changed, 6 insertions(+), 19 deletions(-)

diff --git a/src/plugins/vm/VirtualMachineImpl.cpp b/src/plugins/vm/VirtualMachineImpl.cpp
index 3098d59004..8179ece62b 100644
--- a/src/plugins/vm/VirtualMachineImpl.cpp
+++ b/src/plugins/vm/VirtualMachineImpl.cpp
@@ -25,7 +25,7 @@ namespace vm {
  *************/
 simgrid::xbt::signal<void(VirtualMachineImpl*)> VirtualMachineImpl::on_creation;
 simgrid::xbt::signal<void(VirtualMachineImpl*)> VirtualMachineImpl::on_destruction;
-simgrid::xbt::signal<void(VirtualMachineImpl*)> VirtualMachineImpl::on_state_change;
+
 /*********
  * Model *
  *********/
diff --git a/src/plugins/vm/VirtualMachineImpl.hpp b/src/plugins/vm/VirtualMachineImpl.hpp
index 2e2bce5364..e501789e2a 100644
--- a/src/plugins/vm/VirtualMachineImpl.hpp
+++ b/src/plugins/vm/VirtualMachineImpl.hpp
@@ -35,8 +35,6 @@ public:
   static xbt::signal<void(simgrid::vm::VirtualMachineImpl*)> on_creation;
   /** @brief Callbacks fired after VM destruction. Signature: `void(VirtualMachineImpl*)` */
   static xbt::signal<void(simgrid::vm::VirtualMachineImpl*)> on_destruction;
-  /** @brief Callbacks after VM State changes. Signature: `void(VirtualMachineImpl*)` */
-  static xbt::signal<void(simgrid::vm::VirtualMachineImpl*)> on_state_change;
 
   virtual void suspend(kernel::actor::ActorImpl* issuer);
   virtual void resume();
diff --git a/src/surf/StorageImpl.hpp b/src/surf/StorageImpl.hpp
index 70d8e4b618..99ef00725f 100644
--- a/src/surf/StorageImpl.hpp
+++ b/src/surf/StorageImpl.hpp
@@ -34,18 +34,6 @@ class StorageAction;
 /** @ingroup SURF_storage_interface
  * @brief The possible type of action for the storage component
  */
-/*************
- * Callbacks *
- *************/
-
-/** @ingroup SURF_callbacks
- * @brief Callbacks handler which emit the callbacks after StorageAction State changed *
- * @details Callback functions have the following signature: `void(StorageAction *action,
- * simgrid::kernel::resource::Action::State old, simgrid::kernel::resource::Action::State current)`
- */
-XBT_PUBLIC_DATA
-simgrid::xbt::signal<void(StorageAction*, kernel::resource::Action::State, kernel::resource::Action::State)>
-    on_state_change;
 
 /*********
  * Model *
@@ -135,6 +123,11 @@ private:
  */
 class StorageAction : public Action {
 public:
+  /**
+   * @brief Callbacks handler which emit the callbacks after StorageAction State changed *
+   * @details Callback functions have the following signature: `void(StorageAction& action,
+   * simgrid::kernel::resource::Action::State old, simgrid::kernel::resource::Action::State current)`
+   */
   static xbt::signal<void(StorageAction*, Action::State, Action::State)> on_state_change;
 
   /**
diff --git a/src/surf/cpu_interface.hpp b/src/surf/cpu_interface.hpp
index 93bc683aec..cdecf0e16d 100644
--- a/src/surf/cpu_interface.hpp
+++ b/src/surf/cpu_interface.hpp
@@ -169,10 +169,6 @@ public:
    *  Signature: `void(CpuAction *action, simgrid::kernel::resource::Action::State previous)`
    */
   static simgrid::xbt::signal<void(simgrid::surf::CpuAction*, simgrid::kernel::resource::Action::State)> on_state_change;
-  /** @brief Signal emitted when the action share changes (amount of flops it gets)
-   *  Signature: `void(CpuAction *action)`
-   */
-  static simgrid::xbt::signal<void(simgrid::surf::CpuAction*)> on_share_change;
 
   CpuAction(simgrid::kernel::resource::Model * model, double cost, bool failed) : Action(model, cost, failed) {}
   CpuAction(simgrid::kernel::resource::Model * model, double cost, bool failed, kernel::lmm::Variable* var)
-- 
2.20.1