From be41f8ae755d1edc1e832dea16b045d3885c3f4e Mon Sep 17 00:00:00 2001
From: Martin Quinson <martin.quinson@loria.fr>
Date: Sat, 16 Jun 2018 23:12:25 +0200
Subject: [PATCH] kill simix::onDeadlock that was somewhat dupplicating
 s4u::on_deadlock

---
 ChangeLog                      | 1 +
 include/simgrid/s4u/Engine.hpp | 2 +-
 include/simgrid/simix.hpp      | 5 -----
 src/simix/smx_global.cpp       | 5 -----
 4 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index fd2e22e47e..b07b74bc20 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -16,6 +16,7 @@ Plugins:
 
 simix:
  - Add parameter --cfg=simix/breakpoint to raise a SIGTRAP at given time.
+ - kill simix::onDeadlock() that was somewhat dupplicating s4u::on_deadlock()
 
 SMPI:
  - Replay: The replay file has been re-written in C++.
diff --git a/include/simgrid/s4u/Engine.hpp b/include/simgrid/s4u/Engine.hpp
index 452d152f80..7f9c0ef92d 100644
--- a/include/simgrid/s4u/Engine.hpp
+++ b/include/simgrid/s4u/Engine.hpp
@@ -266,7 +266,7 @@ extern XBT_PUBLIC xbt::signal<void()> on_simulation_end;
 /** Callback fired when the time jumps into the future */
 extern XBT_PUBLIC xbt::signal<void(double)> on_time_advance;
 
-/** Callback fired when the time cannot jump because of inter-actors deadlock */
+/** Callback fired when the time cannot advance because of inter-actors deadlock */
 extern XBT_PUBLIC xbt::signal<void(void)> on_deadlock;
 
 template <class T> XBT_PRIVATE void get_filtered_netzones_recursive(s4u::NetZone* current, std::vector<T*>* whereto)
diff --git a/include/simgrid/simix.hpp b/include/simgrid/simix.hpp
index d6731a9fe4..06a9e30065 100644
--- a/include/simgrid/simix.hpp
+++ b/include/simgrid/simix.hpp
@@ -75,11 +75,6 @@ typedef std::function<ActorCode(std::vector<std::string> args)> ActorCodeFactory
 
 XBT_PUBLIC void register_function(const char* name, ActorCodeFactory factory);
 
-/** These functions will be called when we detect a deadlock: any remaining process is locked on an action
- *
- * If these functions manage to unlock some of the processes, then the deadlock will be avoided.
- */
-XBT_PUBLIC_DATA simgrid::xbt::signal<void()> onDeadlock;
 }
 }
 
diff --git a/src/simix/smx_global.cpp b/src/simix/smx_global.cpp
index 997394599c..1291451690 100644
--- a/src/simix/smx_global.cpp
+++ b/src/simix/smx_global.cpp
@@ -158,8 +158,6 @@ static void kill_process(smx_actor_t process)
 namespace simgrid {
 namespace simix {
 
-simgrid::xbt::signal<void()> onDeadlock;
-
 simgrid::config::Flag<double> breakpoint{"simix/breakpoint",
                                          "When non-negative, raise a SIGTRAP after given (simulated) time", -1.0};
 }
@@ -531,9 +529,6 @@ void SIMIX_run()
     XBT_DEBUG("### time %f, #processes %zu, #to_run %zu", time, simix_global->process_list.size(),
               simix_global->process_to_run.size());
 
-    if (simix_global->process_to_run.empty() && not simix_global->process_list.empty())
-      simgrid::simix::onDeadlock();
-
   } while (time > -1.0 || not simix_global->process_to_run.empty());
 
   if (not simix_global->process_list.empty()) {
-- 
2.20.1