From bcc37ce5513084c64f8c4f5388d9a72f7f8ff113 Mon Sep 17 00:00:00 2001 From: Martin Quinson Date: Sat, 26 Jan 2019 09:28:25 +0100 Subject: [PATCH] sonar was right: this if/else if was missing a else --- src/smpi/internals/smpi_replay.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/smpi/internals/smpi_replay.cpp b/src/smpi/internals/smpi_replay.cpp index 2172bf4d64..cb06266c84 100644 --- a/src/smpi/internals/smpi_replay.cpp +++ b/src/smpi/internals/smpi_replay.cpp @@ -457,17 +457,17 @@ void RecvAction::kernel(simgrid::xbt::ReplayAction&) args.size = status.count; } - bool is_recv = false; if (name == "recv") { Request::recv(nullptr, args.size, args.datatype1, args.partner, args.tag, MPI_COMM_WORLD, &status); - is_recv = true; } else if (name == "irecv") { MPI_Request request = Request::irecv(nullptr, args.size, args.datatype1, args.partner, args.tag, MPI_COMM_WORLD); req_storage.add(request); + } else { + THROW_IMPOSSIBLE; } TRACE_smpi_comm_out(my_proc_id); - if (is_recv && not TRACE_smpi_view_internals()) { + if (name == "recv" && not TRACE_smpi_view_internals()) { int src_traced = MPI_COMM_WORLD->group()->actor(status.MPI_SOURCE)->get_pid(); TRACE_smpi_recv(src_traced, my_proc_id, args.tag); } -- 2.20.1