From b7bfe60402b3c4fb952756e40d9c7b6617a0e18b Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Tue, 28 Jan 2020 14:33:40 +0100 Subject: [PATCH] Emit a warning when a link's latency is smaller than surf/precision. Contributes to FG issue simgrid/simgrid#46. --- src/surf/sg_platf.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/surf/sg_platf.cpp b/src/surf/sg_platf.cpp index 43a1913307..8f89621d27 100644 --- a/src/surf/sg_platf.cpp +++ b/src/surf/sg_platf.cpp @@ -116,6 +116,13 @@ simgrid::kernel::routing::NetPoint* sg_platf_new_router(const std::string& name, static void sg_platf_new_link(const simgrid::kernel::routing::LinkCreationArgs* link, const std::string& link_name) { + static double last_warned_latency = sg_surf_precision; + if (link->latency != 0.0 && link->latency < last_warned_latency) { + XBT_WARN("Latency for link %s is smaller than surf/precision (%g < %g)." + " For more accuracy, consider setting \"--cfg=surf/precision:%g\".", + link_name.c_str(), link->latency, sg_surf_precision, link->latency); + last_warned_latency = link->latency; + } simgrid::kernel::resource::LinkImpl* l = surf_network_model->create_link(link_name, link->bandwidths, link->latency, link->policy); -- 2.20.1