From b52f0fc50553e96f5bb8a8f8f2b2cf74c5a1d38e Mon Sep 17 00:00:00 2001
From: Martin Quinson <martin.quinson@loria.fr>
Date: Sun, 14 Aug 2016 23:40:15 +0200
Subject: [PATCH] sonar cleanups

---
 examples/java/app/bittorrent/MessageTask.java |  2 +-
 src/kernel/context/Context.cpp                | 10 +++-------
 src/kernel/context/Context.hpp                |  2 --
 3 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/examples/java/app/bittorrent/MessageTask.java b/examples/java/app/bittorrent/MessageTask.java
index d0bac8fa16..d84bccd9b6 100644
--- a/examples/java/app/bittorrent/MessageTask.java
+++ b/examples/java/app/bittorrent/MessageTask.java
@@ -39,7 +39,7 @@ public class MessageTask extends Task {
   }
 
   // builds a new bitfield message
-  public MessageTask(Type type, String issuerHostname, String mailbox, int peerId, char bitfield[]) {
+  public MessageTask(Type type, String issuerHostname, String mailbox, int peerId, char[] bitfield) {
     this(type,issuerHostname,mailbox,peerId,-1,false,-1,-1);
     this.bitfield = bitfield;
   }
diff --git a/src/kernel/context/Context.cpp b/src/kernel/context/Context.cpp
index d650e2085a..81d5cb7d98 100644
--- a/src/kernel/context/Context.cpp
+++ b/src/kernel/context/Context.cpp
@@ -38,7 +38,7 @@ namespace context {
 
 ContextFactoryInitializer factory_initializer = nullptr;
 
-ContextFactory::~ContextFactory() {}
+ContextFactory::~ContextFactory() = default;
 
 Context* ContextFactory::self()
 {
@@ -79,9 +79,7 @@ Context::Context(std::function<void()> code,
     SIMIX_context_set_current(this);
 }
 
-Context::~Context()
-{
-}
+Context::~Context() = default;
 
 void Context::stop()
 {
@@ -94,9 +92,7 @@ void Context::stop()
   this->iwannadie = true;
 }
 
-AttachContext::~AttachContext()
-{
-}
+AttachContext::~AttachContext() = default;
 
 }}}
 
diff --git a/src/kernel/context/Context.hpp b/src/kernel/context/Context.hpp
index afe7200fa0..72f73ec1ee 100644
--- a/src/kernel/context/Context.hpp
+++ b/src/kernel/context/Context.hpp
@@ -41,8 +41,6 @@ namespace simgrid {
 namespace kernel {
 namespace context {
 
-  class Context;
-
   XBT_PUBLIC_CLASS ContextFactory {
   private:
     std::string name_;
-- 
2.20.1