From 965c39fd23f892a7bc2ec88b33695c2631c4b17a Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Fri, 23 Jul 2021 11:23:59 +0200 Subject: [PATCH] Fix a fixme (kill dead code). MPI_UNIVERSE_SIZE is already handled as a special case in PMPI_Attr_get. --- src/smpi/internals/smpi_deployment.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/smpi/internals/smpi_deployment.cpp b/src/smpi/internals/smpi_deployment.cpp index a095f01f06..a9d4450b5f 100644 --- a/src/smpi/internals/smpi_deployment.cpp +++ b/src/smpi/internals/smpi_deployment.cpp @@ -24,11 +24,6 @@ public: { auto* group = new simgrid::smpi::Group(size_); comm_world_ = new simgrid::smpi::Comm(group, nullptr, false, -1); - if (false) { - // FIXME : using MPI_Attr_put with MPI_UNIVERSE_SIZE is forbidden and we make it a no-op (which triggers a warning - // as MPI_ERR_ARG is returned). Directly calling Comm::attr_put breaks for now, as MPI_UNIVERSE_SIZE,is <0 - comm_world_->attr_put(MPI_UNIVERSE_SIZE, reinterpret_cast(size_)); - } universe_size += max_no_processes; } -- 2.20.1