From 8b3c1c7507bdf1c21b9484fac5c09b8420ca25c3 Mon Sep 17 00:00:00 2001 From: Frederic Suter Date: Sun, 3 Nov 2019 18:54:21 +0100 Subject: [PATCH] make msg task extendable too --- src/msg/msg_private.hpp | 8 ++++---- src/msg/msg_task.cpp | 7 ++++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/msg/msg_private.hpp b/src/msg/msg_private.hpp index 8b0378eb5a..505c892d4c 100644 --- a/src/msg/msg_private.hpp +++ b/src/msg/msg_private.hpp @@ -10,16 +10,16 @@ #include "simgrid/msg.h" #include "src/kernel/activity/CommImpl.hpp" #include +#include #include /**************** datatypes **********************************/ namespace simgrid { namespace msg { -class Task { +class Task : public xbt::Extendable { std::string name_ = ""; std::string tracing_category_ = ""; - void* userdata_ = nullptr; long long int id_; double timeout_ = 0.0; @@ -59,8 +59,8 @@ public: void set_tracing_category(const char* category) { tracing_category_ = category ? std::string(category) : ""; } const std::string& get_tracing_category() { return tracing_category_; } bool has_tracing_category() { return not tracing_category_.empty(); } - void* get_user_data() { return userdata_; } - void set_user_data(void* data) { userdata_ = data; } + XBT_ATTRIB_DEPRECATED_v329("Please use set_data()") void* get_user_data() { return get_data(); } + XBT_ATTRIB_DEPRECATED_v329("Please use get_data()") void set_user_data(void* data) { set_data(data); } long long int get_id() { return id_; } double get_priority() { return priority_; } void set_priority(double priority); diff --git a/src/msg/msg_task.cpp b/src/msg/msg_task.cpp index 9a62572283..f87e1d8561 100644 --- a/src/msg/msg_task.cpp +++ b/src/msg/msg_task.cpp @@ -19,10 +19,11 @@ namespace simgrid { namespace msg { Task::Task(const std::string& name, double flops_amount, double bytes_amount, void* data) - : name_(name), userdata_(data), flops_amount(flops_amount), bytes_amount(bytes_amount) + : name_(name), flops_amount(flops_amount), bytes_amount(bytes_amount) { static std::atomic_ullong counter{0}; id_ = counter++; + set_data(data); if (MC_is_active()) MC_ignore_heap(&(id_), sizeof(id_)); } @@ -243,13 +244,13 @@ msg_task_t MSG_parallel_task_create(const char *name, int host_nb, const msg_hos /** @brief Return the user data of the given task */ void* MSG_task_get_data(msg_task_t task) { - return task->get_user_data(); + return task->get_data(); } /** @brief Sets the user data of a given task */ void MSG_task_set_data(msg_task_t task, void *data) { - task->set_user_data(data); + task->set_data(data); } /** @brief Returns the sender of the given task */ -- 2.20.1