From 71c3b4fb3e9d8c5890f353b51296cc150396024a Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Sun, 22 Nov 2020 15:11:27 +0100 Subject: [PATCH] [sonar] Extract assignment from sub-expression. --- src/mc/inspect/DwarfExpression.hpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mc/inspect/DwarfExpression.hpp b/src/mc/inspect/DwarfExpression.hpp index ab229ded85..bf318422a4 100644 --- a/src/mc/inspect/DwarfExpression.hpp +++ b/src/mc/inspect/DwarfExpression.hpp @@ -100,7 +100,8 @@ public: { if (size_ == stack_.size()) throw evaluation_error("DWARF stack overflow"); - stack_[size_++] = value; + stack_[size_] = value; + size_++; } /* Pop a value from the top of the stack */ @@ -108,7 +109,8 @@ public: { if (size_ == 0) throw evaluation_error("DWARF stack underflow"); - return stack_[--size_]; + --size_; + return stack_[size_]; } // These are DWARF operations (DW_OP_foo): -- 2.20.1