From 70833ee10a946ee18d9fab348392653b15fdc924 Mon Sep 17 00:00:00 2001 From: Frederic Suter Date: Tue, 7 Mar 2017 17:25:07 +0100 Subject: [PATCH] cosmetics --- src/kernel/routing/ClusterZone.hpp | 5 ++++- src/kernel/routing/EmptyZone.cpp | 4 ---- src/kernel/routing/EmptyZone.hpp | 6 +++++- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/kernel/routing/ClusterZone.hpp b/src/kernel/routing/ClusterZone.hpp index 497096cbd6..7a347a86af 100644 --- a/src/kernel/routing/ClusterZone.hpp +++ b/src/kernel/routing/ClusterZone.hpp @@ -73,7 +73,10 @@ public: void getGraph(xbt_graph_t graph, xbt_dict_t nodes, xbt_dict_t edges) override; virtual void create_links_for_node(sg_platf_cluster_cbarg_t cluster, int id, int rank, int position); - virtual void parse_specific_arguments(sg_platf_cluster_cbarg_t cluster) {} + virtual void parse_specific_arguments(sg_platf_cluster_cbarg_t cluster) + { + /* this routing method does not require any specific argument */ + } /* We use a map instead of a std::vector here because that's a sparse vector. Some values may not exist */ /* The pair is {linkUp, linkDown} */ diff --git a/src/kernel/routing/EmptyZone.cpp b/src/kernel/routing/EmptyZone.cpp index b861258a8e..732cab82c1 100644 --- a/src/kernel/routing/EmptyZone.cpp +++ b/src/kernel/routing/EmptyZone.cpp @@ -21,10 +21,6 @@ EmptyZone::EmptyZone(NetZone* father, const char* name) : NetZoneImpl(father, na EmptyZone::~EmptyZone() = default; -void EmptyZone::getLocalRoute(NetPoint* /*src*/, NetPoint* /*dst*/, sg_platf_route_cbarg_t /*res*/, double* /*lat*/) -{ -} - void EmptyZone::getGraph(xbt_graph_t /*graph*/, xbt_dict_t /*nodes*/, xbt_dict_t /*edges*/) { XBT_ERROR("No routing no graph"); diff --git a/src/kernel/routing/EmptyZone.hpp b/src/kernel/routing/EmptyZone.hpp index 90036ff87d..2bbc9af52f 100644 --- a/src/kernel/routing/EmptyZone.hpp +++ b/src/kernel/routing/EmptyZone.hpp @@ -24,7 +24,11 @@ public: explicit EmptyZone(NetZone* father, const char* name); ~EmptyZone() override; - void getLocalRoute(NetPoint* src, NetPoint* dst, sg_platf_route_cbarg_t into, double* latency) override; + void getLocalRoute(NetPoint* src, NetPoint* dst, sg_platf_route_cbarg_t into, double* latency) + { + /* There can't be route in an Empty zone */ + } + void getGraph(xbt_graph_t graph, xbt_dict_t nodes, xbt_dict_t edges) override; }; } -- 2.20.1