From 6e9d86d55beb0e4da8e689bbd3ca576250c46cb4 Mon Sep 17 00:00:00 2001
From: SUTER Frederic <frederic.suter@cc.in2p3.fr>
Date: Thu, 15 Apr 2021 16:03:18 +0200
Subject: [PATCH] simplification

---
 src/kernel/routing/VivaldiZone.cpp | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/src/kernel/routing/VivaldiZone.cpp b/src/kernel/routing/VivaldiZone.cpp
index 577dc7a1dd..9f27b1bcf6 100644
--- a/src/kernel/routing/VivaldiZone.cpp
+++ b/src/kernel/routing/VivaldiZone.cpp
@@ -45,20 +45,17 @@ Coords::Coords(NetPoint* netpoint, const std::string& coordStr)
 }
 } // namespace vivaldi
 
-static inline double euclidean_dist_comp(int index, std::vector<double>* src, std::vector<double>* dst)
+static inline double euclidean_dist_comp(double src_coord, double dst_coord)
 {
-  double src_coord = src->at(index);
-  double dst_coord = dst->at(index);
-
   return (src_coord - dst_coord) * (src_coord - dst_coord);
 }
 
-static std::vector<double>* netpoint_get_coords(NetPoint* np)
+static const std::vector<double>& netpoint_get_coords(NetPoint* np)
 {
   auto* coords = np->extension<vivaldi::Coords>();
   xbt_assert(coords, "Please specify the Vivaldi coordinates of %s %s (%p)",
              (np->is_netzone() ? "Netzone" : (np->is_host() ? "Host" : "Router")), np->get_cname(), np);
-  return &coords->coords;
+  return coords->coords;
 }
 
 void VivaldiZone::set_peer_link(NetPoint* netpoint, double bw_in, double bw_out)
@@ -88,12 +85,12 @@ void VivaldiZone::get_local_route(NetPoint* src, NetPoint* dst, RouteCreationArg
   StarZone::get_local_route(src, dst, route, lat);
   /* Compute the extra latency due to the euclidean distance if needed */
   if (lat) {
-    std::vector<double>* srcCoords = netpoint_get_coords(src);
-    std::vector<double>* dstCoords = netpoint_get_coords(dst);
+    std::vector<double> srcCoords = netpoint_get_coords(src);
+    std::vector<double> dstCoords = netpoint_get_coords(dst);
 
     double euclidean_dist =
-        sqrt(euclidean_dist_comp(0, srcCoords, dstCoords) + euclidean_dist_comp(1, srcCoords, dstCoords)) +
-        fabs(srcCoords->at(2)) + fabs(dstCoords->at(2));
+        sqrt(euclidean_dist_comp(srcCoords[0], dstCoords[0]) + euclidean_dist_comp(srcCoords[1], dstCoords[1])) +
+        fabs(srcCoords[2]) + fabs(dstCoords[2]);
 
     XBT_DEBUG("Updating latency %f += %f", *lat, euclidean_dist);
     *lat += euclidean_dist / 1000.0; // From .ms to .s
-- 
2.20.1