From 62091cbe9596de8172716a97e61867e09e83151c Mon Sep 17 00:00:00 2001 From: degomme Date: Fri, 4 Nov 2016 14:55:59 +0100 Subject: [PATCH] clang complains about these seemingly unecessary std::move. --- src/mc/LivenessChecker.cpp | 2 +- src/mc/VisitedState.cpp | 4 ++-- src/xbt/backtrace_linux.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mc/LivenessChecker.cpp b/src/mc/LivenessChecker.cpp index f573622cf1..19e634779c 100644 --- a/src/mc/LivenessChecker.cpp +++ b/src/mc/LivenessChecker.cpp @@ -454,7 +454,7 @@ std::shared_ptr LivenessChecker::newPair(Pair* current_pair, xbt_automaton next_pair->search_cycle = true; else next_pair->search_cycle = false; - return std::move(next_pair); + return next_pair; } void LivenessChecker::backtrack() diff --git a/src/mc/VisitedState.cpp b/src/mc/VisitedState.cpp index 3aa0e5f9ee..5d547bfd50 100644 --- a/src/mc/VisitedState.cpp +++ b/src/mc/VisitedState.cpp @@ -118,7 +118,7 @@ std::unique_ptr VisitedStates::addVisitedState( old_state->num, new_state->num); visited_state = std::move(new_state); - return std::move(old_state); + return old_state; } } @@ -129,4 +129,4 @@ std::unique_ptr VisitedStates::addVisitedState( } } -} \ No newline at end of file +} diff --git a/src/xbt/backtrace_linux.cpp b/src/xbt/backtrace_linux.cpp index e37bbcc151..0e191b4283 100644 --- a/src/xbt/backtrace_linux.cpp +++ b/src/xbt/backtrace_linux.cpp @@ -158,7 +158,7 @@ std::vector resolveBacktrace( if (binary_name.empty()) { for (std::size_t i = 0; i < count; i++) result.push_back(simgrid::xbt::string_printf("%p", loc[i])); - return std::move(result); + return result; } // Create the system command for add2line: -- 2.20.1