From 4bb5b0cce7c4e83bd911d4b46c02d041815b3819 Mon Sep 17 00:00:00 2001 From: Christian Heinrich Date: Thu, 21 Jun 2018 16:21:14 +0200 Subject: [PATCH 1/1] [TRACING] Rename TIT action allToAll -> alltoall --- include/simgrid/smpi/replay.hpp | 2 +- src/instr/instr_private.hpp | 2 +- src/smpi/bindings/smpi_pmpi_coll.cpp | 2 +- src/smpi/internals/smpi_replay.cpp | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/simgrid/smpi/replay.hpp b/include/simgrid/smpi/replay.hpp index b933032d8f..193ad33062 100644 --- a/include/simgrid/smpi/replay.hpp +++ b/include/simgrid/smpi/replay.hpp @@ -283,7 +283,7 @@ public: class AllToAllAction : public ReplayAction { public: - explicit AllToAllAction() : ReplayAction("allToAll") {} + explicit AllToAllAction() : ReplayAction("alltoall") {} void kernel(simgrid::xbt::ReplayAction& action) override; }; diff --git a/src/instr/instr_private.hpp b/src/instr/instr_private.hpp index 2535d096f0..4bdfd3ea64 100644 --- a/src/instr/instr_private.hpp +++ b/src/instr/instr_private.hpp @@ -66,7 +66,7 @@ public: // Pt2PtTI: send, isend, sssend, issend, recv, irecv explicit TIData(std::string name, int endpoint, int size, std::string datatype) : name_(name), endpoint(endpoint), send_size(size), send_type(datatype){}; - // CollTI: bcast, reduce, allreduce, gather, scatter, allgather, allToAll + // CollTI: bcast, reduce, allreduce, gather, scatter, allgather, alltoall explicit TIData(std::string name, int root, double amount, int send_size, int recv_size, std::string send_type, std::string recv_type) : name_(name) diff --git a/src/smpi/bindings/smpi_pmpi_coll.cpp b/src/smpi/bindings/smpi_pmpi_coll.cpp index a29ba4d7c9..586f9b7f9f 100644 --- a/src/smpi/bindings/smpi_pmpi_coll.cpp +++ b/src/smpi/bindings/smpi_pmpi_coll.cpp @@ -587,7 +587,7 @@ int PMPI_Alltoall(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* rec TRACE_smpi_comm_in(rank, __func__, new simgrid::instr::CollTIData( - "allToAll", -1, -1.0, + "alltoall", -1, -1.0, sendtmptype->is_replayable() ? sendtmpcount : sendtmpcount * sendtmptype->size(), recvtype->is_replayable() ? recvcount : recvcount * recvtype->size(), simgrid::smpi::Datatype::encode(sendtmptype), simgrid::smpi::Datatype::encode(recvtype))); diff --git a/src/smpi/internals/smpi_replay.cpp b/src/smpi/internals/smpi_replay.cpp index 5d5bf7f981..14c1bff8e0 100644 --- a/src/smpi/internals/smpi_replay.cpp +++ b/src/smpi/internals/smpi_replay.cpp @@ -588,8 +588,8 @@ void AllReduceAction::kernel(simgrid::xbt::ReplayAction& action) void AllToAllAction::kernel(simgrid::xbt::ReplayAction& action) { - TRACE_smpi_comm_in(my_proc_id, "action_allToAll", - new simgrid::instr::CollTIData("allToAll", -1, -1.0, args.send_size, args.recv_size, + TRACE_smpi_comm_in(my_proc_id, "action_alltoall", + new simgrid::instr::CollTIData("alltoall", -1, -1.0, args.send_size, args.recv_size, Datatype::encode(args.datatype1), Datatype::encode(args.datatype2))); @@ -728,7 +728,7 @@ void smpi_replay_init(int* argc, char*** argv) xbt_replay_action_register("bcast", [](simgrid::xbt::ReplayAction& action) { simgrid::smpi::replay::BcastAction().execute(action); }); xbt_replay_action_register("reduce", [](simgrid::xbt::ReplayAction& action) { simgrid::smpi::replay::ReduceAction().execute(action); }); xbt_replay_action_register("allreduce", [](simgrid::xbt::ReplayAction& action) { simgrid::smpi::replay::AllReduceAction().execute(action); }); - xbt_replay_action_register("allToAll", [](simgrid::xbt::ReplayAction& action) { simgrid::smpi::replay::AllToAllAction().execute(action); }); + xbt_replay_action_register("alltoall", [](simgrid::xbt::ReplayAction& action) { simgrid::smpi::replay::AllToAllAction().execute(action); }); xbt_replay_action_register("alltoallv", [](simgrid::xbt::ReplayAction& action) { simgrid::smpi::replay::AllToAllVAction().execute(action); }); xbt_replay_action_register("gather", [](simgrid::xbt::ReplayAction& action) { simgrid::smpi::replay::GatherAction("gather").execute(action); }); xbt_replay_action_register("scatter", [](simgrid::xbt::ReplayAction& action) { simgrid::smpi::replay::ScatterAction().execute(action); }); -- 2.20.1