From 4922023786798feb890924ade51028e72bc791ac Mon Sep 17 00:00:00 2001
From: Martin Quinson <martin.quinson@loria.fr>
Date: Tue, 18 Apr 2017 15:41:19 +0200
Subject: [PATCH] please sonar a tiny bit

---
 src/smpi/smpi_global.cpp | 2 +-
 src/xbt/dynar.cpp        | 3 ++-
 src/xbt/heap.c           | 3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/smpi/smpi_global.cpp b/src/smpi/smpi_global.cpp
index a47b7e976a..6234227715 100644
--- a/src/smpi/smpi_global.cpp
+++ b/src/smpi/smpi_global.cpp
@@ -484,7 +484,7 @@ static void smpi_init_options(){
 
 typedef std::function<int(int argc, char *argv[])> smpi_entry_point_type;
 typedef int (* smpi_c_entry_point_type)(int argc, char **argv);
-typedef void (* smpi_fortran_entry_point_type)(void);
+typedef void (*smpi_fortran_entry_point_type)();
 
 static int smpi_run_entry_point(smpi_entry_point_type entry_point, std::vector<std::string> args)
 {
diff --git a/src/xbt/dynar.cpp b/src/xbt/dynar.cpp
index 292ca3eaef..b7df27ff0d 100644
--- a/src/xbt/dynar.cpp
+++ b/src/xbt/dynar.cpp
@@ -574,7 +574,8 @@ extern "C" void xbt_dynar_map(const xbt_dynar_t dynar, void_f_pvoid_t const op)
  */
 extern "C" void xbt_dynar_cursor_rm(xbt_dynar_t dynar, unsigned int* const cursor)
 {
-  xbt_dynar_remove_at(dynar, (*cursor)--, nullptr);
+  xbt_dynar_remove_at(dynar, *cursor, nullptr);
+  *cursor -= 1;
 }
 
 /** @brief Sorts a dynar according to the function <tt>compar_fn</tt>
diff --git a/src/xbt/heap.c b/src/xbt/heap.c
index e32dfc4807..5bd06f3d8a 100644
--- a/src/xbt/heap.c
+++ b/src/xbt/heap.c
@@ -83,7 +83,8 @@ inline int xbt_heap_size(xbt_heap_t H)
  */
 void xbt_heap_push(xbt_heap_t H, void *content, double key)
 {
-  int count = ++(H->count);
+  H->count += 1;
+  int count = H->count;
 
   int size = H->size;
   xbt_heap_item_t item;
-- 
2.20.1