From 4347df3835009b6526b26de2a7f3bc5ac39a3d0a Mon Sep 17 00:00:00 2001 From: Christian Heinrich Date: Thu, 25 Jan 2018 00:37:09 +0100 Subject: [PATCH] Revert "[TESTS] SMPI/MPICH3: Fix failing rma test" This reverts commit 1630b8c2917fce5760c0065b240764cda0a70eb4. We decided to rather have a failing test than a test with some logic disabled... --- teshsuite/smpi/mpich3-test/rma/rget-testall.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/teshsuite/smpi/mpich3-test/rma/rget-testall.c b/teshsuite/smpi/mpich3-test/rma/rget-testall.c index dee88b3533..4f3eec243b 100644 --- a/teshsuite/smpi/mpich3-test/rma/rget-testall.c +++ b/teshsuite/smpi/mpich3-test/rma/rget-testall.c @@ -33,19 +33,10 @@ int main(int argc, char **argv) MPI_Win_allocate(2 * sizeof(int), sizeof(int), MPI_INFO_NULL, MPI_COMM_WORLD, &baseptr, &win); - /* - * TODO cheinrich: These assignments were originally after the MPI_Win_lock - * and before the MPI_Win_unlock call. However, with compile time optimizations on, - * this seems to cause issues with at least gcc. If valgrind or gcc is activated, - * everything works fine though. - * - * I don't know what causes these issues, but moving this here solves the problem for now. - */ - baseptr[0] = 1; - baseptr[1] = 2; - /* Initialize window buffer */ MPI_Win_lock(MPI_LOCK_EXCLUSIVE, rank, 0, win); + baseptr[0] = 1; + baseptr[1] = 2; MPI_Win_unlock(rank, win); /* Issue request-based get with testall. */ -- 2.20.1