From 42e383007df6506a0a9e8188fb38627ea0256352 Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Thu, 27 Jul 2017 14:09:46 +0200 Subject: [PATCH 1/1] Add -Wformat-signedness to warnCFLAGS for GCC >= 5.0. --- tools/cmake/GCCFlags.cmake | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/cmake/GCCFlags.cmake b/tools/cmake/GCCFlags.cmake index 5731bdac15..309a69a472 100644 --- a/tools/cmake/GCCFlags.cmake +++ b/tools/cmake/GCCFlags.cmake @@ -15,6 +15,9 @@ set(warnCXXFLAGS "") if(enable_compile_warnings) set(warnCFLAGS "-fno-common -Wall -Wunused -Wmissing-declarations -Wpointer-arith -Wchar-subscripts -Wcomment -Wformat -Wwrite-strings -Wno-unused-function -Wno-unused-parameter -Wno-strict-aliasing") + if(CMAKE_COMPILER_IS_GNUCC AND (NOT (CMAKE_C_COMPILER_VERSION VERSION_LESS "5.0"))) + set(warnCFLAGS "${warnCFLAGS} -Wformat-signedness") + endif() if(CMAKE_C_COMPILER_ID MATCHES "Clang|GCC") set(warnCFLAGS "${warnCFLAGS} -Wno-format-nonliteral") endif() @@ -22,7 +25,10 @@ if(enable_compile_warnings) set(warnCFLAGS "${warnCFLAGS} -Wclobbered -Wno-error=clobbered -Wno-unused-local-typedefs -Wno-error=attributes") endif() - set(warnCXXFLAGS "${warnCFLAGS} -Wall -Wextra -Wunused -Wmissing-declarations -Wpointer-arith -Wchar-subscripts -Wcomment -Wformat -Wwrite-strings -Wno-unused-function -Wno-unused-parameter -Wno-strict-aliasing") + set(warnCXXFLAGS "${warnCFLAGS} -Wall -Wextra -Wunused -Wmissing-declarations -Wpointer-arith -Wchar-subscripts -Wcomment -Wformat -Wwrite-strings -Wno-unused-function -Wno-unused-parameter -Wno-strict-aliasing") + if(CMAKE_COMPILER_IS_GNUCXX AND (NOT (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "5.0"))) + set(warnCFLAGS "${warnCFLAGS} -Wformat-signedness") + endif() if(CMAKE_CXX_COMPILER_ID MATCHES "Clang|GCC") set(warnCXXFLAGS "${warnCXXFLAGS} -Wno-format-nonliteral") endif() -- 2.20.1