From 406aea71498dca53009d9ddc0a9af44aaff21618 Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Tue, 23 Mar 2021 13:39:05 +0100 Subject: [PATCH 1/1] [sonar] Pass large object by reference to const. --- include/xbt/replay.hpp | 2 +- src/xbt/xbt_replay.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/xbt/replay.hpp b/include/xbt/replay.hpp index c9336b2ce8..ce0d124908 100644 --- a/include/xbt/replay.hpp +++ b/include/xbt/replay.hpp @@ -32,6 +32,6 @@ XBT_PUBLIC int replay_runner(const char* actor_name, const char* trace_filename using action_fun = std::function; XBT_PUBLIC void xbt_replay_action_register(const char* action_name, const action_fun& function); XBT_PUBLIC action_fun xbt_replay_action_get(const char* action_name); -XBT_PUBLIC void xbt_replay_set_tracefile(std::string filename); +XBT_PUBLIC void xbt_replay_set_tracefile(const std::string& filename); #endif diff --git a/src/xbt/xbt_replay.cpp b/src/xbt/xbt_replay.cpp index ce546bea3c..6bebd90c8e 100644 --- a/src/xbt/xbt_replay.cpp +++ b/src/xbt/xbt_replay.cpp @@ -184,9 +184,9 @@ action_fun xbt_replay_action_get(const char* action_name) return simgrid::xbt::action_funs.at(std::string(action_name)); } -void xbt_replay_set_tracefile(std::string filename) +void xbt_replay_set_tracefile(const std::string& filename) { xbt_assert(not simgrid::xbt::action_fs_inited, "Tracefile already set"); simgrid::xbt::action_fs.open(filename, std::ifstream::in); simgrid::xbt::action_fs_inited = true; -} \ No newline at end of file +} -- 2.20.1