From 36bbb3ccc91325b1ab657c221248ec19e227de4a Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Mon, 23 Dec 2019 22:59:04 +0100 Subject: [PATCH 1/1] [sonar] Constify pointer and reference local variables in src/simdag/. --- src/simdag/sd_dotloader.cpp | 6 +++--- src/simdag/sd_global.cpp | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/simdag/sd_dotloader.cpp b/src/simdag/sd_dotloader.cpp index bfd0ddb8c8..9ba3e5f2ac 100644 --- a/src/simdag/sd_dotloader.cpp +++ b/src/simdag/sd_dotloader.cpp @@ -103,7 +103,7 @@ xbt_dynar_t SD_dotload_generic(const char* filename, bool sequential, bool sched computers.insert({char_performer, computer}); } if (static_cast(order) < computer->size()) { - SD_task_t task_test = computer->at(order); + const s_SD_task_t* task_test = computer->at(order); if (task_test && task_test != task) { /* the user gave the same order to several tasks */ schedule_success = false; @@ -153,8 +153,8 @@ xbt_dynar_t SD_dotload_generic(const char* filename, bool sequential, bool sched std::sort(edges.begin(), edges.end(), [](const Agedge_t* a, const Agedge_t* b) { return AGSEQ(a) < AGSEQ(b); }); for (Agedge_t* edge : edges) { - char *src_name=agnameof(agtail(edge)); - char *dst_name=agnameof(aghead(edge)); + const char* src_name = agnameof(agtail(edge)); + const char* dst_name = agnameof(aghead(edge)); double size = atof(agget(edge, (char *) "size")); SD_task_t src = jobs.at(src_name); diff --git a/src/simdag/sd_global.cpp b/src/simdag/sd_global.cpp index b09207188c..54c0aeb909 100644 --- a/src/simdag/sd_global.cpp +++ b/src/simdag/sd_global.cpp @@ -42,7 +42,7 @@ std::set* simulate(double how_long){ /* let's see which tasks are done */ for (auto const& model : all_existing_models) { - simgrid::kernel::resource::Action* action = model->extract_done_action(); + const simgrid::kernel::resource::Action* action = model->extract_done_action(); while (action != nullptr && action->get_data() != nullptr) { SD_task_t task = static_cast(action->get_data()); XBT_VERB("Task '%s' done", SD_task_get_name(task)); @@ -213,7 +213,7 @@ void SD_simulate(double how_long) void SD_simulate_with_update(double how_long, xbt_dynar_t changed_tasks_dynar) { - std::set *changed_tasks = simgrid::sd::simulate(how_long); + const std::set* changed_tasks = simgrid::sd::simulate(how_long); for (auto const& task : *changed_tasks) xbt_dynar_push(changed_tasks_dynar, &task); } -- 2.20.1