From 34fca02736fe4770232b5454596e841f27d261e5 Mon Sep 17 00:00:00 2001 From: Martin Quinson Date: Fri, 26 May 2017 10:21:27 +0200 Subject: [PATCH] codacy treats --- examples/msg/app-bittorrent/peer.c | 2 +- examples/msg/trace-masterworker/trace-masterworker.c | 3 +-- examples/smpi/mc/bugged1_liveness.c | 2 +- examples/smpi/mc/only_send_deterministic.c | 4 ++-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/examples/msg/app-bittorrent/peer.c b/examples/msg/app-bittorrent/peer.c index d7875192ce..40a8256a13 100644 --- a/examples/msg/app-bittorrent/peer.c +++ b/examples/msg/app-bittorrent/peer.c @@ -673,8 +673,8 @@ void update_interested_after_receive(peer_t peer) xbt_dict_cursor_t cursor; connection_t connection; xbt_dict_foreach(peer->peers, cursor, key, connection) { - int interested = 0; if (connection->am_interested != 0) { + int interested = 0; //Check if the peer still has a piece we want. for (int i = 0; i < FILE_PIECES; i++) { if (peer_has_not_piece(peer, i) && connection_has_piece(connection,i)) { diff --git a/examples/msg/trace-masterworker/trace-masterworker.c b/examples/msg/trace-masterworker/trace-masterworker.c index 651d968a5d..2ebf78d686 100644 --- a/examples/msg/trace-masterworker/trace-masterworker.c +++ b/examples/msg/trace-masterworker/trace-masterworker.c @@ -19,8 +19,7 @@ static int master(int argc, char *argv[]) TRACE_mark("msmark", "start_send_tasks"); for (int i = 0; i < number_of_tasks; i++) { - msg_task_t task = NULL; - task = MSG_task_create("task", task_comp_size, task_comm_size, NULL); + msg_task_t task = MSG_task_create("task", task_comp_size, task_comm_size, NULL); //setting the variable "task_creation" to value i TRACE_host_variable_set(MSG_host_get_name(MSG_host_self()), "task_creation", i); diff --git a/examples/smpi/mc/bugged1_liveness.c b/examples/smpi/mc/bugged1_liveness.c index 213c888a4e..5ec2c2b24a 100644 --- a/examples/smpi/mc/bugged1_liveness.c +++ b/examples/smpi/mc/bugged1_liveness.c @@ -27,7 +27,6 @@ int main(int argc, char **argv){ int err, size, rank; int recv_buff; MPI_Status status; - int CS_used = 0; xbt_dynar_t requests = xbt_dynar_new(sizeof(int), NULL); /* Initialize MPI */ @@ -48,6 +47,7 @@ int main(int argc, char **argv){ MPI_Comm_rank(MPI_COMM_WORLD, &rank); if(rank == 0){ /* Coordinator */ + int CS_used = 0; while(1){ MPI_Recv(&recv_buff, 1, MPI_INT, MPI_ANY_SOURCE, MPI_ANY_TAG, MPI_COMM_WORLD, &status); if(status.MPI_TAG == REQUEST_TAG){ diff --git a/examples/smpi/mc/only_send_deterministic.c b/examples/smpi/mc/only_send_deterministic.c index ffc01310ee..01188f1412 100644 --- a/examples/smpi/mc/only_send_deterministic.c +++ b/examples/smpi/mc/only_send_deterministic.c @@ -12,7 +12,7 @@ int main(int argc, char **argv) { - int recv_buff, err, size, rank, i; + int recv_buff, err, size, rank; MPI_Status status; /* Initialize MPI */ @@ -33,7 +33,7 @@ int main(int argc, char **argv) if (rank == 0) { //printf("MPI_ISend / MPI_IRecv Test \n"); - for(i=0; i < size - 1; i++){ + for (int i = 0; i < size - 1; i++) { MPI_Recv(&recv_buff, 1, MPI_INT, MPI_ANY_SOURCE, MPI_ANY_TAG, MPI_COMM_WORLD, &status); //printf("Message received from %d\n", recv_buff); } -- 2.20.1