From 3362740a9eb3127adc84bf0e7fb49e37d30d056f Mon Sep 17 00:00:00 2001 From: Martin Quinson Date: Sun, 13 Nov 2016 16:18:20 +0100 Subject: [PATCH] less strdup/free --- src/surf/surf_interface.cpp | 14 +++++--------- src/surf/surf_interface.hpp | 2 +- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/surf/surf_interface.cpp b/src/surf/surf_interface.cpp index 50107a3e56..b2cedc19f9 100644 --- a/src/surf/surf_interface.cpp +++ b/src/surf/surf_interface.cpp @@ -528,15 +528,11 @@ void Model::updateActionsStateFull(double /*now*/, double /*delta*/) namespace simgrid { namespace surf { -Resource::Resource(Model *model, const char *name, lmm_constraint_t constraint) - : name_(xbt_strdup(name)) - , model_(model) - , constraint_(constraint) +Resource::Resource(Model* model, const char* name, lmm_constraint_t constraint) + : name_(name), model_(model), constraint_(constraint) {} -Resource::~Resource() { - free(name_); -} +Resource::~Resource() = default; bool Resource::isOn() const { return isOn_; @@ -560,11 +556,11 @@ Model *Resource::getModel() const { } const char *Resource::getName() const { - return name_; + return name_.c_str(); } bool Resource::operator==(const Resource &other) const { - return strcmp(name_, other.name_); + return name_ == other.name_; } lmm_constraint_t Resource::getConstraint() const { diff --git a/src/surf/surf_interface.hpp b/src/surf/surf_interface.hpp index 42f4c85c31..998d260167 100644 --- a/src/surf/surf_interface.hpp +++ b/src/surf/surf_interface.hpp @@ -423,7 +423,7 @@ public: virtual void turnOff(); private: - char* name_; + std::string name_; Model *model_; bool isOn_ = true; -- 2.20.1