From 30c0dd6aa9c864e251eb1496595e05307c965c19 Mon Sep 17 00:00:00 2001 From: Martin Quinson Date: Tue, 5 Mar 2019 07:29:53 +0100 Subject: [PATCH] sonar: pass large parameters as const; don't name unused params --- src/s4u/s4u_Actor.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/s4u/s4u_Actor.cpp b/src/s4u/s4u_Actor.cpp index 005dc0bc71..b20d8c6d37 100644 --- a/src/s4u/s4u_Actor.cpp +++ b/src/s4u/s4u_Actor.cpp @@ -92,10 +92,10 @@ void Actor::on_exit(int_f_pvoid_pvoid_t fun, simgrid::simix::simcall([this, fun, data] { SIMIX_process_on_exit(pimpl_, fun, data); }); } -void Actor::on_exit(std::function fun) +void Actor::on_exit(std::function const fun) { simgrid::simix::simcall( - [this, fun] { SIMIX_process_on_exit(pimpl_, [fun](int a, void* data) { fun(a != 0); }, nullptr); }); + [this, fun] { SIMIX_process_on_exit(pimpl_, [fun](int a, void* /*data*/) { fun(a != 0); }, nullptr); }); } void Actor::migrate(Host* new_host) @@ -405,12 +405,12 @@ void exit() simgrid::simix::simcall([actor] { actor->exit(); }); } -void on_exit(std::function fun) +void on_exit(std::function const fun) { SIMIX_process_self()->iface()->on_exit(fun); } -void on_exit(std::function fun, void* data) /* deprecated */ +void on_exit(std::function const fun, void* data) /* deprecated */ { SIMIX_process_self()->iface()->on_exit([fun, data](bool exit) { fun(exit, data); }); } -- 2.20.1