From 27dc82be40d8e0e0bc5e5d1301b66f36f676dea6 Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Sun, 11 Oct 2020 22:14:36 +0200 Subject: [PATCH] [sonar] Constructors of an "abstract" class should not be "public". --- src/bindings/java/org/simgrid/msg/MsgException.java | 4 ++-- src/bindings/java/org/simgrid/msg/Process.java | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/bindings/java/org/simgrid/msg/MsgException.java b/src/bindings/java/org/simgrid/msg/MsgException.java index 7826c2e905..a48671b38e 100644 --- a/src/bindings/java/org/simgrid/msg/MsgException.java +++ b/src/bindings/java/org/simgrid/msg/MsgException.java @@ -12,11 +12,11 @@ public abstract class MsgException extends Exception { private static final long serialVersionUID = 1L; /** Constructs an MsgException without a detail message. */ - public MsgException() { + protected MsgException() { super(); } /** Constructs an MsgException with a detail message. */ - public MsgException(String msg) { + protected MsgException(String msg) { super(msg); } } diff --git a/src/bindings/java/org/simgrid/msg/Process.java b/src/bindings/java/org/simgrid/msg/Process.java index d8f1f3bdfd..5fb1b2600a 100644 --- a/src/bindings/java/org/simgrid/msg/Process.java +++ b/src/bindings/java/org/simgrid/msg/Process.java @@ -73,7 +73,7 @@ public abstract class Process implements Runnable { * * */ - public Process(String hostname, String name) throws HostNotFoundException { + protected Process(String hostname, String name) throws HostNotFoundException { this(Host.getByName(hostname), name, null); } /** @@ -87,7 +87,7 @@ public abstract class Process implements Runnable { * @exception HostNotFoundException if no host with this name exists. * */ - public Process(String hostname, String name, String[] args) throws HostNotFoundException { + protected Process(String hostname, String name, String[] args) throws HostNotFoundException { this(Host.getByName(hostname), name, args); } /** @@ -98,7 +98,7 @@ public abstract class Process implements Runnable { * @param name The name of the process. * */ - public Process(Host host, String name) { + protected Process(Host host, String name) { this(host, name, null); } /** @@ -109,7 +109,7 @@ public abstract class Process implements Runnable { * @param name The name of the process. * @param argsParam The arguments of main method of the process. */ - public Process(Host host, String name, String[]argsParam) + protected Process(Host host, String name, String[]argsParam) { if (host == null) throw new IllegalArgumentException("Cannot create a process on the null host"); @@ -134,7 +134,7 @@ public abstract class Process implements Runnable { * @param killTime Kill time of the process * */ - public Process(Host host, String name, String[]args, double startTime, double killTime) { + protected Process(Host host, String name, String[]args, double startTime, double killTime) { this(host, name, args); this.startTime = startTime; this.killTime = killTime; -- 2.20.1