From 26768ad6d8ab26deb53d8df8a7d71baceba805ef Mon Sep 17 00:00:00 2001 From: Frederic Suter Date: Thu, 26 Apr 2018 14:59:16 +0200 Subject: [PATCH] TODO-- (SO says it won't improve performance though) --- examples/java/dht/kademlia/Answer.java | 10 +++++----- examples/java/dht/kademlia/RoutingTable.java | 5 ++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/examples/java/dht/kademlia/Answer.java b/examples/java/dht/kademlia/Answer.java index 0a30cf60e3..03a4923380 100644 --- a/examples/java/dht/kademlia/Answer.java +++ b/examples/java/dht/kademlia/Answer.java @@ -31,8 +31,9 @@ public class Answer { return nodes.size(); } - public void remove(int index) { - nodes.remove(index); + public void trim() { + if (nodes.size() > Common.BUCKET_SIZE) + nodes.subList(nodes.size() - Common.BUCKET_SIZE, nodes.size()).clear(); } public void add(Contact contact) { @@ -51,9 +52,8 @@ public class Answer { } Collections.sort(nodes); //Trim the list - while (answer.size() > Common.BUCKET_SIZE) { - answer.remove(answer.size() - 1); - } + answer.trim(); + return nbAdded; } diff --git a/examples/java/dht/kademlia/RoutingTable.java b/examples/java/dht/kademlia/RoutingTable.java index 78f80ad495..d8fd0c9529 100644 --- a/examples/java/dht/kademlia/RoutingTable.java +++ b/examples/java/dht/kademlia/RoutingTable.java @@ -95,9 +95,8 @@ public class RoutingTable { //We sort the list Collections.sort(answer.getNodes()); //We trim the list - while (answer.size() > Common.BUCKET_SIZE) { - answer.remove(answer.size() - 1); //TODO: Not the best thing. - } + answer.trim(); + return answer; } -- 2.20.1