From 220c2b4eb4847d916bbf4114a4f1b9e7cb0c7d41 Mon Sep 17 00:00:00 2001 From: Martin Quinson Date: Tue, 27 Aug 2019 09:28:06 +0200 Subject: [PATCH] modernize our C++ - Use auto when using new to not repeat the type - Pass parameter by value + std::move instead of pass by reference This was advized by clang advanced warnings --- src/kernel/actor/ActorImpl.cpp | 9 +++++---- src/kernel/actor/ActorImpl.hpp | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/kernel/actor/ActorImpl.cpp b/src/kernel/actor/ActorImpl.cpp index 161321033c..e57a46ee3a 100644 --- a/src/kernel/actor/ActorImpl.cpp +++ b/src/kernel/actor/ActorImpl.cpp @@ -19,6 +19,7 @@ #include "src/surf/cpu_interface.hpp" #include +#include XBT_LOG_NEW_DEFAULT_SUBCATEGORY(simix_process, simix, "Logging specific to SIMIX (process)"); @@ -57,7 +58,7 @@ int get_maxpid() return maxpid; } -ActorImpl::ActorImpl(const simgrid::xbt::string& name, s4u::Host* host) : host_(host), name_(name), piface_(this) +ActorImpl::ActorImpl(simgrid::xbt::string name, s4u::Host* host) : host_(host), name_(std::move(name)), piface_(this) { pid_ = maxpid++; simcall.issuer_ = this; @@ -367,7 +368,7 @@ void ActorImpl::suspend(ActorImpl* issuer) /* If the suspended actor is waiting on a sync, suspend its synchronization. */ if (waiting_synchro == nullptr) { - activity::ExecImpl* exec = new activity::ExecImpl(); + auto exec = new activity::ExecImpl(); exec->set_name("suspend").set_host(host_).set_flops_amount(0.0).start(); waiting_synchro = activity::ExecImplPtr(exec); @@ -412,8 +413,8 @@ activity::ActivityImplPtr ActorImpl::sleep(double duration) throw_exception(std::make_exception_ptr(simgrid::HostFailureException( XBT_THROW_POINT, std::string("Host ") + host_->get_cname() + " failed, you cannot sleep there."))); - activity::SleepImpl* sleep = new activity::SleepImpl(); - (*sleep).set_name("sleep").set_host(host_).set_duration(duration).start(); + auto sleep = new activity::SleepImpl(); + sleep->set_name("sleep").set_host(host_).set_duration(duration).start(); return activity::SleepImplPtr(sleep); } diff --git a/src/kernel/actor/ActorImpl.hpp b/src/kernel/actor/ActorImpl.hpp index d118e36bb6..a560305cb3 100644 --- a/src/kernel/actor/ActorImpl.hpp +++ b/src/kernel/actor/ActorImpl.hpp @@ -29,7 +29,7 @@ class XBT_PUBLIC ActorImpl : public surf::PropertyHolder { public: xbt::string name_; - ActorImpl(const xbt::string& name, s4u::Host* host); + ActorImpl(xbt::string name, s4u::Host* host); ActorImpl(const ActorImpl&) = delete; ActorImpl& operator=(const ActorImpl&) = delete; ~ActorImpl(); -- 2.20.1