From 1d5a3d36e9868cfd03eb3d067a9047c296ce3cb5 Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Tue, 1 Jun 2021 15:26:10 +0200 Subject: [PATCH 1/1] Prefer std algorithms. --- src/kernel/routing/NetZoneImpl.cpp | 14 +++++--------- src/mc/remote/AppSide.cpp | 12 +++--------- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/src/kernel/routing/NetZoneImpl.cpp b/src/kernel/routing/NetZoneImpl.cpp index 6d59bda4dc..72c8f19baf 100644 --- a/src/kernel/routing/NetZoneImpl.cpp +++ b/src/kernel/routing/NetZoneImpl.cpp @@ -558,16 +558,12 @@ const NetZoneImpl* NetZoneImpl::get_netzone_recursive(const NetPoint* netpoint) bool NetZoneImpl::is_component_recursive(const NetPoint* netpoint) const { /* check direct components */ - for (const auto* elem : vertices_) { - if (elem == netpoint) - return true; - } + if (std::any_of(begin(vertices_), end(vertices_), [netpoint](const auto* elem) { return elem == netpoint; })) + return true; + /* check childrens */ - for (const auto* children : children_) { - if (children->is_component_recursive(netpoint)) - return true; - } - return false; + return std::any_of(begin(children_), end(children_), + [netpoint](const auto* child) { return child->is_component_recursive(netpoint); }); } } // namespace routing } // namespace kernel diff --git a/src/mc/remote/AppSide.cpp b/src/mc/remote/AppSide.cpp index 27b560ddb6..8d908998e1 100644 --- a/src/mc/remote/AppSide.cpp +++ b/src/mc/remote/AppSide.cpp @@ -85,15 +85,9 @@ AppSide* AppSide::initialize() void AppSide::handle_deadlock_check(const s_mc_message_t*) const { const auto& actor_list = kernel::EngineImpl::get_instance()->get_actor_list(); - bool deadlock = false; - if (not actor_list.empty()) { - deadlock = true; - for (auto const& kv : actor_list) - if (mc::actor_is_enabled(kv.second)) { - deadlock = false; - break; - } - } + bool deadlock = not actor_list.empty() && std::none_of(begin(actor_list), end(actor_list), [](const auto& kv) { + return mc::actor_is_enabled(kv.second); + }); // Send result: s_mc_message_int_t answer{MessageType::DEADLOCK_CHECK_REPLY, deadlock}; -- 2.20.1