From 136b2dc7bfe5ff67d78a23f0e9e031b1b4bed639 Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Fri, 3 May 2019 14:14:01 +0200 Subject: [PATCH] [sonar] Extract nested conditionals. --- teshsuite/simdag/is-router/is-router.cpp | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/teshsuite/simdag/is-router/is-router.cpp b/teshsuite/simdag/is-router/is-router.cpp index ef1a90cc2d..35441dfc55 100644 --- a/teshsuite/simdag/is-router/is-router.cpp +++ b/teshsuite/simdag/is-router/is-router.cpp @@ -42,9 +42,17 @@ int main(int argc, char **argv) xbt_dynar_free(&hosts); std::printf("NetCards count: %zu\n", netpoints.size()); - for (auto const& nc : netpoints) - std::printf(" - Seen: \"%s\". Type: %s\n", nc->get_cname(), - nc->is_router() ? "router" : (nc->is_netzone() ? "netzone" : (nc->is_host() ? "host" : "buggy"))); - + for (auto const& nc : netpoints) { + const char* type; + if (nc->is_router()) + type = "router"; + else if (nc->is_netzone()) + type = "netzone"; + else if (nc->is_host()) + type = "host"; + else + type = "buggy"; + std::printf(" - Seen: \"%s\". Type: %s\n", nc->get_cname(), type); + } return 0; } -- 2.20.1