From 111369f755b08e89e1fb6049d89a5703349b1b74 Mon Sep 17 00:00:00 2001 From: Bruno Donassolo Date: Mon, 2 Aug 2021 10:32:42 +0200 Subject: [PATCH] Sonar and minor improv in doc --- docs/source/tuto_disk/analysis.org | 17 ++++++++++++----- docs/source/tuto_disk/analysis.rst | 22 ++++++++++++++++------ teshsuite/s4u/io-set-bw/io-set-bw.cpp | 4 ++-- 3 files changed, 30 insertions(+), 13 deletions(-) diff --git a/docs/source/tuto_disk/analysis.org b/docs/source/tuto_disk/analysis.org index 92efd2e395..04d6d88da5 100644 --- a/docs/source/tuto_disk/analysis.org +++ b/docs/source/tuto_disk/analysis.org @@ -15,16 +15,23 @@ The paper presents a series of experiments to analyze the performance of IO operations (read/write) on different kinds of disks (SATA, SAS, - SSD). In this tutorial, we show how to extract this data to simulate - both performance degradation with concurrent operations (Fig. 8 in the - paper) and variability in IO operations (Fig. 5 to 7). + SSD). In this tutorial, we present a detailed example of how to + extract experimental data to simulate: i) performance degradation + with concurrent operations (Fig. 8 in the paper) and ii) variability + in IO operations (Fig. 5 to 7). - Link for paper: https://hal.inria.fr/hal-01197128 - Link for data: https://figshare.com/articles/dataset/Companion_of_the_SimGrid_storage_modeling_article/1175156 - *WARNING*: The purpose of this document is to illustrate how we can + *Disclaimer*: +- The purpose of this document is to illustrate how we can extract data from experiments and inject on SimGrid. However, the - results may *not* reflect the reality. + data shown on this page may *not* reflect the reality. +- You must run similar experiments on your hardware to get realistic + data for your context. +- SimGrid has been in active development since the paper release in + 2015, thus the MSG and XML description used in the paper may have + evolved and may not be available anymore. *** Running this tutorial diff --git a/docs/source/tuto_disk/analysis.rst b/docs/source/tuto_disk/analysis.rst index 9b60616e9a..e07daf0779 100644 --- a/docs/source/tuto_disk/analysis.rst +++ b/docs/source/tuto_disk/analysis.rst @@ -15,17 +15,27 @@ Capacities to the SimGridToolkit: Concepts, Models, and API". The paper presents a series of experiments to analyze the performance of IO operations (read/write) on different kinds of disks (SATA, SAS, -SSD). In this tutorial, we show how to extract this data to simulate -both performance degradation with concurrent operations (Fig. 8 in the -paper) and variability in IO operations (Fig. 5 to 7). +SSD). In this tutorial, we present a detailed example of how to +extract experimental data to simulate: i) performance degradation +with concurrent operations (Fig. 8 in the paper) and ii) variability +in IO operations (Fig. 5 to 7). - Link for paper: `https://hal.inria.fr/hal-01197128 `_ - Link for data: `https://figshare.com/articles/dataset/Companion_of_the_SimGrid_storage_modeling_article/1175156 `_ -**WARNING**: The purpose of this document is to illustrate how we can -extract data from experiments and inject on SimGrid. However, the -results may **not** reflect the reality. +**Disclaimer**: + +- The purpose of this document is to illustrate how we can + extract data from experiments and inject on SimGrid. However, the + data shown on this page may **not** reflect the reality. + +- You must run similar experiments on your hardware to get realistic + data for your context. + +- SimGrid has been in active development since the paper release in + 2015, thus the MSG and XML description used in the paper may have + evolved and may not be available anymore. Running this tutorial ^^^^^^^^^^^^^^^^^^^^^ diff --git a/teshsuite/s4u/io-set-bw/io-set-bw.cpp b/teshsuite/s4u/io-set-bw/io-set-bw.cpp index cb0c5e2b6f..2710815bb5 100644 --- a/teshsuite/s4u/io-set-bw/io-set-bw.cpp +++ b/teshsuite/s4u/io-set-bw/io-set-bw.cpp @@ -63,8 +63,8 @@ static void host() XBT_INFO("Setting readwrite limit to half (.5e6) in the middle of IO. Read and write should take 1.5s"); cur_time = sg4::Engine::get_clock(); - act = disk->write_async(1e6 / 2); - sg4::IoPtr act2 = disk->read_async(1e6 / 2); + act = disk->write_async(.5e6); + sg4::IoPtr act2 = disk->read_async(.5e6); sg4::this_actor::sleep_for(.5); disk->set_readwrite_bandwidth(.5e6); act->wait(); -- 2.20.1