Arnaud Giersch [Thu, 19 May 2022 14:53:04 +0000 (14:53 +0000)]
Merge branch 'dev-hosts_to_activity' into 'master'
Move hosts_ attribute from ExecImpl to ActivityImpl to better handle detached cases
See merge request simgrid/simgrid!100
Fabien Chaix [Thu, 19 May 2022 14:47:19 +0000 (17:47 +0300)]
Cosmetics
Arnaud Giersch [Thu, 19 May 2022 09:38:36 +0000 (11:38 +0200)]
Reorder (sort) file lists.
Arnaud Giersch [Thu, 19 May 2022 08:45:57 +0000 (10:45 +0200)]
Make distcheck.
Arnaud Giersch [Thu, 19 May 2022 08:45:31 +0000 (10:45 +0200)]
Merge branch 'Ezibenroc/simgrid-example_platform'
Tom Cornebize [Thu, 19 May 2022 07:57:29 +0000 (09:57 +0200)]
clang-format
Tom Cornebize [Thu, 19 May 2022 07:54:04 +0000 (09:54 +0200)]
Cosmetic
Fabien Chaix [Thu, 19 May 2022 07:16:10 +0000 (10:16 +0300)]
No need to check for activities_ nullness
Fabien Chaix [Thu, 19 May 2022 07:12:45 +0000 (10:12 +0300)]
Move hosts_ to private, and deal with consequences
Tom Cornebize [Wed, 18 May 2022 15:21:09 +0000 (17:21 +0200)]
Add a 'supernode' example platform
- supernode.cpp is the actual C++ platform file,
- supernode.svg is a graphical representation of this platform,
- supernode.py is the script that was used to generate the SVG
Fabien Chaix [Wed, 18 May 2022 14:26:28 +0000 (17:26 +0300)]
Fix the addition of detached comms to maestro
Fabien Chaix [Wed, 18 May 2022 12:27:07 +0000 (15:27 +0300)]
Add detached isend to maestro to allow tracking in case of fault
Fabien Chaix [Tue, 17 May 2022 11:00:53 +0000 (14:00 +0300)]
Move hosts_ to ActivityImpl_ to allow tracking of detached comms by maestro
Augustin Degomme [Tue, 17 May 2022 21:24:54 +0000 (21:24 +0000)]
cosmetics
Augustin Degomme [Tue, 17 May 2022 21:20:57 +0000 (21:20 +0000)]
Merge branch 'dev-unit_test_cleanup' into 'master'
Dev unit test cleanup
See merge request simgrid/simgrid!98
Fabien Chaix [Tue, 17 May 2022 21:15:19 +0000 (00:15 +0300)]
Fix cosmetics
Fabien Chaix [Tue, 17 May 2022 20:59:54 +0000 (23:59 +0300)]
Add trace2selist and re-enable unit tests for the stochastic profiles
Arnaud Giersch [Tue, 17 May 2022 19:59:49 +0000 (21:59 +0200)]
StarZone::get_graph: link to the gateway router when available.
This may happen e.g. with nested StarZones.
Arnaud Giersch [Tue, 17 May 2022 19:08:57 +0000 (21:08 +0200)]
Cosmetics: declare graph edges with the "right" direction.
Arnaud Giersch [Tue, 17 May 2022 19:06:59 +0000 (19:06 +0000)]
Merge branch 'dev-s4u-dirty-termination' into 'master'
Make S4u dirty termination better looking
See merge request simgrid/simgrid!97
Fabien Chaix [Tue, 17 May 2022 12:12:59 +0000 (15:12 +0300)]
Make S4u dirty termination better looking
Augustin Degomme [Tue, 17 May 2022 12:27:44 +0000 (12:27 +0000)]
Merge branch 'dev-fix-get-eager-activities' into 'master'
add eager get comms to actor activities
See merge request simgrid/simgrid!96
Fabien Chaix [Tue, 17 May 2022 11:02:50 +0000 (14:02 +0300)]
add eager get comms to actor activities
Arnaud Giersch [Fri, 13 May 2022 11:10:52 +0000 (13:10 +0200)]
Enable test only on 64bits.
Arnaud Giersch [Fri, 13 May 2022 10:06:51 +0000 (12:06 +0200)]
Give another try to test mc-bugged1-liveness-visited...
... and see if the situation has changed since commit
73e643057a95ed6f20d6bd03bc8cd13a7042f9aa
Arnaud Giersch [Thu, 12 May 2022 15:59:35 +0000 (17:59 +0200)]
Fix build with Eigen3 and Imtel compiler.
Arnaud Giersch [Thu, 12 May 2022 15:51:27 +0000 (17:51 +0200)]
Remove from CFLAGS warnings already enabled by -Wall.
Arnaud Giersch [Thu, 12 May 2022 08:43:08 +0000 (10:43 +0200)]
Rename VM signals to distinguish them from Host::on_creation/on_destruction.
Arnaud Giersch [Thu, 12 May 2022 08:37:47 +0000 (10:37 +0200)]
Reduce scope for variables.
Arnaud Giersch [Thu, 12 May 2022 08:29:08 +0000 (10:29 +0200)]
Rename variables to avoid shadowed declarations.
Bruno Donassolo [Thu, 12 May 2022 12:50:51 +0000 (14:50 +0200)]
Link-load plugin: check no link exists
Plugin must be initialized before creating any link.
Arnaud Giersch [Tue, 10 May 2022 19:25:16 +0000 (21:25 +0200)]
Define duplicated function get_graph() only once, in common ancestor.
Arnaud Giersch [Tue, 10 May 2022 19:24:06 +0000 (21:24 +0200)]
Make helper functions static members of NetZoneImpl.
Arnaud Giersch [Tue, 10 May 2022 16:59:47 +0000 (18:59 +0200)]
Apply last sonar-related changes to the new function platform_graph_export_csv().
Martin Quinson [Tue, 10 May 2022 15:52:19 +0000 (15:52 +0000)]
Merge branch 'master' into 'master'
Enhance graphicator program
See merge request simgrid/simgrid!95
Tom Cornebize [Tue, 10 May 2022 15:52:19 +0000 (15:52 +0000)]
Enhance graphicator program
Arnaud Giersch [Tue, 10 May 2022 15:11:09 +0000 (17:11 +0200)]
Prefer \n over std::endl (no need to flush at each end-of-line).
Arnaud Giersch [Tue, 10 May 2022 11:38:43 +0000 (13:38 +0200)]
Update generator script to match the current code.
Arnaud Giersch [Tue, 10 May 2022 08:48:52 +0000 (10:48 +0200)]
Concatenate nested namespaces (sonar).
Arnaud Giersch [Tue, 10 May 2022 08:47:36 +0000 (10:47 +0200)]
Remove spurious "using" declarations.
Arnaud Giersch [Tue, 10 May 2022 07:21:46 +0000 (09:21 +0200)]
Apply exclusion to any file in include/ (*.h may be concerned).
Arnaud Giersch [Mon, 9 May 2022 19:42:15 +0000 (21:42 +0200)]
[sonar] Ignore C++17 rules in public headers, where we still support C++14.
[ci-skip]
Arnaud Giersch [Mon, 9 May 2022 19:31:59 +0000 (21:31 +0200)]
[sonar] IIUC, there is no need to duplicate exclusion rule.
[ci-skip]
Arnaud Giersch [Mon, 9 May 2022 13:02:08 +0000 (15:02 +0200)]
Replace const reference to std::string by std::string_view (sonar).
Arnaud Giersch [Fri, 6 May 2022 07:15:25 +0000 (09:15 +0200)]
Structured binding here too.
Arnaud Giersch [Mon, 9 May 2022 09:24:03 +0000 (11:24 +0200)]
Test is normally always true: replace by an assert.
Arnaud Giersch [Sat, 7 May 2022 07:43:54 +0000 (09:43 +0200)]
Use the init-statement to declare variables inside the if statement (sonar).
Arnaud Giersch [Sat, 7 May 2022 07:20:42 +0000 (09:20 +0200)]
Remove superfluous parentheses.
Arnaud Giersch [Fri, 6 May 2022 10:46:24 +0000 (12:46 +0200)]
Disable bogus warning with g++: add -Wno-free-nonheap-object.
Build fails on mc_dwarf.cpp with g++ 12.0.1.
This kind of error should be caught by valgrind and/or ASan anyway.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Reduce scope for temporary variables.
Use the init-statement to declare variables inside the if statement (sonar).
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Reduce scope for static variables.
Use the init-statement to declare variables inside the if statement (sonar).
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Reduce scope for variables used for dynamic_cast to subclass.
Use the init-statement to declare variables inside the if statement (sonar).
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Simplify a bit smpi_sample_* functions.
* merge smpi_sample_1 and smpi_sample_2 into smpi_sample_cond
* rename smpi_sample_3 to smpi_sample_iter
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Slighly improve readbility.
(and address a few sonar smells)
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Search in map once only.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
No need to have two code paths.
Arnaud Giersch [Wed, 4 May 2022 06:30:25 +0000 (08:30 +0200)]
Nested conditional operators are not Sonar-compliant; revert previous change.
Arnaud Giersch [Wed, 4 May 2022 06:12:55 +0000 (08:12 +0200)]
Oops, it's stoi() for integers.
Arnaud Giersch [Tue, 3 May 2022 19:56:18 +0000 (21:56 +0200)]
Kill unused variable.
Arnaud Giersch [Tue, 3 May 2022 19:56:07 +0000 (21:56 +0200)]
Spurious blank line.
Arnaud Giersch [Sat, 30 Apr 2022 13:08:59 +0000 (15:08 +0200)]
Declare local variables inside the if statement.
Arnaud Giersch [Sat, 30 Apr 2022 13:07:03 +0000 (15:07 +0200)]
Misc code simplifications guided by Sonar smells.
Arnaud Giersch [Tue, 3 May 2022 19:01:36 +0000 (21:01 +0200)]
Save an indirection for replay/action_queues.
Arnaud Giersch [Mon, 2 May 2022 17:27:36 +0000 (19:27 +0200)]
Avoid old-style C string processing in C++ example.
Augustin Degomme [Sun, 1 May 2022 20:39:53 +0000 (20:39 +0000)]
[ci-skip] [no-ci] bigdft ci: temporary fix for nvidia key change
see https://github.com/NVIDIA/nvidia-docker/issues/1631
Arnaud Giersch [Thu, 28 Apr 2022 17:16:20 +0000 (19:16 +0200)]
Explicit cast to double (sonar).
Arnaud Giersch [Thu, 28 Apr 2022 13:53:51 +0000 (15:53 +0200)]
Use const references (sonar).
Arnaud Giersch [Thu, 28 Apr 2022 13:50:58 +0000 (15:50 +0200)]
Add comment for workaround.
Arnaud Giersch [Wed, 27 Apr 2022 19:58:42 +0000 (21:58 +0200)]
Cosmetics: gcc is now always >= 5.0.
Arnaud Giersch [Wed, 27 Apr 2022 19:43:42 +0000 (21:43 +0200)]
Fix build with -Werror on older g++.
Arnaud Giersch [Tue, 26 Apr 2022 22:02:38 +0000 (00:02 +0200)]
Use structured binding declarations (sonar, c++17).
Arnaud Giersch [Tue, 26 Apr 2022 10:58:09 +0000 (12:58 +0200)]
De-obfuscation.
Arnaud Giersch [Tue, 26 Apr 2022 08:03:10 +0000 (10:03 +0200)]
Pointer-to-const (sonar).
Arnaud Giersch [Tue, 26 Apr 2022 07:55:12 +0000 (09:55 +0200)]
Don't build useless temporary object (sonar, c++17).
Arnaud Giersch [Mon, 25 Apr 2022 13:36:20 +0000 (15:36 +0200)]
Replace is_xxx::value with is_xxx_v (sonar, c++17).
Arnaud Giersch [Mon, 25 Apr 2022 12:54:12 +0000 (14:54 +0200)]
Rely on template argument deduction (sonar, c++17).
Arnaud Giersch [Mon, 25 Apr 2022 12:28:10 +0000 (14:28 +0200)]
Define as "constexpr".
Arnaud Giersch [Mon, 25 Apr 2022 13:03:11 +0000 (15:03 +0200)]
Remaining "try_emplace" (sonar, c++!7).
Arnaud Giersch [Mon, 25 Apr 2022 09:43:57 +0000 (11:43 +0200)]
Prefer using "try_emplace" (sonar, c++17).
Arnaud Giersch [Mon, 25 Apr 2022 09:43:04 +0000 (11:43 +0200)]
Use std::string.
Arnaud Giersch [Mon, 25 Apr 2022 10:16:39 +0000 (12:16 +0200)]
Kill redundant code.
Arnaud Giersch [Sun, 24 Apr 2022 16:39:24 +0000 (18:39 +0200)]
Const ref for catch.
Augustin Degomme [Sat, 23 Apr 2022 15:48:57 +0000 (15:48 +0000)]
[ci-skip] Update project_description.sh
Arnaud Giersch [Sat, 23 Apr 2022 15:12:02 +0000 (17:12 +0200)]
Don't throw exception in destructor (sonar).
Augustin Degomme [Sat, 23 Apr 2022 11:15:05 +0000 (11:15 +0000)]
[ci-skip] help flags build finding ns3
Augustin Degomme [Fri, 22 Apr 2022 19:59:33 +0000 (19:59 +0000)]
... I'm certain I tested this yesterday
Augustin Degomme [Fri, 22 Apr 2022 19:00:06 +0000 (19:00 +0000)]
Update network_ns3.cpp
Augustin Degomme [Fri, 22 Apr 2022 18:21:29 +0000 (18:21 +0000)]
try to use ns3-dev on ubuntu.
Augustin Degomme [Fri, 22 Apr 2022 15:38:53 +0000 (15:38 +0000)]
disable LTO on the arm builder, as it is believed to be too heavy for this particular system since c++17 upgrade
Arnaud Giersch [Fri, 22 Apr 2022 12:22:56 +0000 (14:22 +0200)]
Fix some warnings in doc generation.
Arnaud Giersch [Thu, 21 Apr 2022 14:00:22 +0000 (16:00 +0200)]
Align exec-async with C++ example (also define python binding).
Arnaud Giersch [Thu, 21 Apr 2022 08:19:59 +0000 (10:19 +0200)]
Type size_t for every variant of get_host_count().
Arnaud Giersch [Thu, 21 Apr 2022 08:05:08 +0000 (10:05 +0200)]
Add "explicit" keyword.
Arnaud Giersch [Fri, 22 Apr 2022 09:34:54 +0000 (11:34 +0200)]
Workaround build error with older versions of Eigen3.
Make it build on the freebsd CI node.
Augustin Degomme [Thu, 21 Apr 2022 23:06:29 +0000 (01:06 +0200)]
try to help clang builds
Augustin Degomme [Thu, 21 Apr 2022 22:40:16 +0000 (00:40 +0200)]
bump C++ requirement to 17 (ns3 will need it for v3.26)
Augustin Degomme [Thu, 21 Apr 2022 11:16:46 +0000 (13:16 +0200)]
prepare for next NS3 release
Augustin Degomme [Thu, 21 Apr 2022 11:08:40 +0000 (13:08 +0200)]
ns3: allow use of -dev version from manually compiled one.
Arnaud Giersch [Wed, 20 Apr 2022 13:51:20 +0000 (15:51 +0200)]
Disable ns3 on ubuntu until version 3.36.
The programs crash (sigsegv) when loading libns3.35-wifi.so
Hope that the following patch will fix that
https://gitlab.com/nsnam/ns-3-dev/-/commit/
62ab4ade4215bfa91ff95eab4d5e0422e18028f0
Arnaud Giersch [Tue, 12 Apr 2022 10:00:54 +0000 (12:00 +0200)]
Cosmetics: *elem is already null here.