Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
3 years agoChange color of "barrier" in trace. It was too close to "computing"
degomme [Tue, 26 Feb 2019 12:07:45 +0000 (13:07 +0100)]
Change color of "barrier" in trace. It was too close to "computing"

3 years agoAdd simple gemm example for SMPI with sampling macros.
degomme [Tue, 26 Feb 2019 10:59:36 +0000 (11:59 +0100)]
Add simple gemm example for SMPI with sampling macros.
Adapted from the proxy app from Codevault.
This could be a good basis for the tuto

3 years agoYet again change the way SMPI_SAMPLE_MACRO works
degomme [Tue, 26 Feb 2019 10:58:12 +0000 (11:58 +0100)]
Yet again change the way SMPI_SAMPLE_MACRO works
There is no need anymore to have the body of the loop inside the macro. Kudos to Arnaud L for the ideas.

now usage is just turning
for(x;y;z) into SMPI_SAMPLE_GLOBAL(x,y,z,iters,thres)

Time injection will be done only once for all the section, speeding up the simulation.

TODO : iterator value will not be correct at the end of the loop for now.
Not important if iterator is local to the loop, but may be annoying if not.

3 years agofix (#324)
Frederic Suter [Tue, 26 Feb 2019 10:28:47 +0000 (11:28 +0100)]
fix (#324)
Throw a HostFailureException when one tries to create (or attach) an
actor an a host that is not on.
If this happens during the parsing of the deployment file, just let it
go.
for MSG, we could die if this happens (we don't for now)

3 years agoBuild still broken with ld 2.31.1. Check only version for gcc.
Arnaud Giersch [Mon, 25 Feb 2019 22:22:10 +0000 (23:22 +0100)]
Build still broken with ld 2.31.1.  Check only version for gcc.

3 years ago[sonar] Improve Cognitive Complexity.
Arnaud Giersch [Mon, 25 Feb 2019 13:58:10 +0000 (14:58 +0100)]
[sonar] Improve Cognitive Complexity.

3 years agoNO_MAX_DURATION is a special value, use (in)equality for testing.
Arnaud Giersch [Mon, 25 Feb 2019 13:39:22 +0000 (14:39 +0100)]
NO_MAX_DURATION is a special value, use (in)equality for testing.

3 years agoMove common test to Action::update_max_duration.
Arnaud Giersch [Mon, 25 Feb 2019 13:20:22 +0000 (14:20 +0100)]
Move common test to Action::update_max_duration.

3 years agoKill now unused functions SIMIX_mutex_{un}ref.
Arnaud Giersch [Sat, 23 Feb 2019 13:31:46 +0000 (14:31 +0100)]
Kill now unused functions SIMIX_mutex_{un}ref.

3 years agoConvert last call to SIMIX_mutex_unref.
Arnaud Giersch [Sat, 23 Feb 2019 13:31:16 +0000 (14:31 +0100)]
Convert last call to SIMIX_mutex_unref.

3 years agofix last issues
Frederic Suter [Mon, 25 Feb 2019 18:09:49 +0000 (19:09 +0100)]
fix last issues
+ counter_ is used by heaps, use id_ instead
+ fix dumb find/replace

3 years agoend objectification of MSG tasks
Frederic Suter [Mon, 25 Feb 2019 16:10:19 +0000 (17:10 +0100)]
end objectification of MSG tasks

3 years agomv counter from msg_task_t to simgrid::msg::Task
Frederic Suter [Mon, 25 Feb 2019 15:48:49 +0000 (16:48 +0100)]
mv counter from msg_task_t to simgrid::msg::Task
this was the last field, MSG tasks are now objects
have to remove the useless layer now!

3 years agomv data from msg_task_t to simgrid::msg::Task
Frederic Suter [Mon, 25 Feb 2019 15:30:39 +0000 (16:30 +0100)]
mv data from msg_task_t to simgrid::msg::Task

3 years agosimplify these tests
Frederic Suter [Mon, 25 Feb 2019 15:14:00 +0000 (16:14 +0100)]
simplify these tests

3 years agomv category from msg_task_t to simgrid::msg::Task
Frederic Suter [Mon, 25 Feb 2019 14:48:36 +0000 (15:48 +0100)]
mv category from msg_task_t to simgrid::msg::Task

3 years agomove name from msg_task_t to simgrid::msg::Task
Frederic Suter [Mon, 25 Feb 2019 14:19:50 +0000 (15:19 +0100)]
move name from msg_task_t to simgrid::msg::Task

3 years agodo not promote bad practices: use "accessor" to get task name
Frederic Suter [Mon, 25 Feb 2019 14:16:32 +0000 (15:16 +0100)]
do not promote bad practices: use "accessor" to get task name

3 years agoobjectify simdata_task_t
Frederic Suter [Mon, 25 Feb 2019 13:16:57 +0000 (14:16 +0100)]
objectify simdata_task_t

3 years agopriority and bound of MSG tasks can only be set BEFORE execution
Frederic Suter [Mon, 25 Feb 2019 10:44:47 +0000 (11:44 +0100)]
priority and bound of MSG tasks can only be set BEFORE execution

this is the rule for S4U, should be the same for MSG.
BTW, the behavior of the LMM is likely to be confused by such dynamic
changes during execution.

Side effect: we should remove the setters in ExecImpl, but there are
used by two simcalls that are tagged as deprected with v3.25

3 years agosource is sender's host. One field is enough
Frederic Suter [Mon, 25 Feb 2019 10:28:36 +0000 (11:28 +0100)]
source is sender's host. One field is enough

3 years agoplay with (parallel) execs. still not satisfying
Frederic Suter [Sat, 23 Feb 2019 12:46:01 +0000 (13:46 +0100)]
play with (parallel) execs. still not satisfying

3 years agoSIMIX_mutex_{un}ref become MutexImpl::{un}ref
Frederic Suter [Sat, 23 Feb 2019 11:27:27 +0000 (12:27 +0100)]
SIMIX_mutex_{un}ref become MutexImpl::{un}ref

3 years agodont call HANDLER
Frederic Suter [Sat, 23 Feb 2019 11:27:13 +0000 (12:27 +0100)]
dont call HANDLER

3 years agoplease sonar
Frederic Suter [Sat, 23 Feb 2019 11:13:13 +0000 (12:13 +0100)]
please sonar

3 years agoMerge branch 'master' of framagit.org:simgrid/simgrid
Arnaud Giersch [Fri, 22 Feb 2019 21:28:57 +0000 (22:28 +0100)]
Merge branch 'master' of framagit.org:simgrid/simgrid

3 years agomake destructor public
Frederic Suter [Fri, 22 Feb 2019 21:15:05 +0000 (22:15 +0100)]
make destructor public

3 years agoFix build error with mingw.
Arnaud Giersch [Fri, 22 Feb 2019 21:07:01 +0000 (22:07 +0100)]
Fix build error with mingw.

3 years agodo not use xbt_mutex_t in SMPI
Frederic Suter [Fri, 22 Feb 2019 20:32:54 +0000 (21:32 +0100)]
do not use xbt_mutex_t in SMPI

3 years agoconvert maestro-set to S4U
Frederic Suter [Fri, 22 Feb 2019 18:13:15 +0000 (19:13 +0100)]
convert maestro-set to S4U

3 years agodumb me.
Frederic Suter [Fri, 22 Feb 2019 14:55:50 +0000 (15:55 +0100)]
dumb me.

3 years agodeprecate SIMIX_process_{a,de}tach
Frederic Suter [Fri, 22 Feb 2019 13:14:07 +0000 (14:14 +0100)]
deprecate SIMIX_process_{a,de}tach
* replaced by ActorImpl::{a,de}tach
* add sg_actor_{a,de}tach to the C API of actors
* MSG_process_{a,de}tach go to msg_legacy

3 years agoforgot that one
Frederic Suter [Fri, 22 Feb 2019 13:04:04 +0000 (14:04 +0100)]
forgot that one

3 years agostop using old simcalls in our own code
Frederic Suter [Fri, 22 Feb 2019 12:15:37 +0000 (13:15 +0100)]
stop using old simcalls in our own code

3 years agosnake casing
Frederic Suter [Fri, 22 Feb 2019 11:43:27 +0000 (12:43 +0100)]
snake casing

3 years agotrim instr_msg code
Frederic Suter [Fri, 22 Feb 2019 11:29:42 +0000 (12:29 +0100)]
trim instr_msg code

3 years agouse TASK_CANCELED rather than HOST_FAILURE for CancelExeption
Frederic Suter [Fri, 22 Feb 2019 11:28:01 +0000 (12:28 +0100)]
use TASK_CANCELED rather than HOST_FAILURE for CancelExeption

3 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Fri, 22 Feb 2019 11:08:29 +0000 (12:08 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

3 years agoThrow exception when comm was canceled.
Arnaud Giersch [Fri, 22 Feb 2019 10:03:56 +0000 (11:03 +0100)]
Throw exception when comm was canceled.

3 years agoHandle CancelException in MSG_{comm,test} too.
Arnaud Giersch [Fri, 22 Feb 2019 10:02:35 +0000 (11:02 +0100)]
Handle CancelException in MSG_{comm,test} too.

3 years agoMSG is a C API and should not throw.
Arnaud Giersch [Fri, 22 Feb 2019 10:01:45 +0000 (11:01 +0100)]
MSG is a C API and should not throw.

3 years agoremove doublons caused by extra pop
Frederic Suter [Thu, 21 Feb 2019 20:47:17 +0000 (21:47 +0100)]
remove doublons caused by extra pop

3 years agoremove useless code
Frederic Suter [Thu, 21 Feb 2019 20:36:20 +0000 (21:36 +0100)]
remove useless code
this is handled by callbacks in instr-platform now

3 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Thu, 21 Feb 2019 19:32:54 +0000 (20:32 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

3 years agouse more s4u calls in MSG
Frederic Suter [Thu, 21 Feb 2019 19:32:04 +0000 (20:32 +0100)]
use more s4u calls in MSG
One more step to transform MSG into a S4U wrapper \o/

3 years agorevalidate tesh file
Frederic Suter [Thu, 21 Feb 2019 19:31:46 +0000 (20:31 +0100)]
revalidate tesh file

3 years agofix some issues with Cancel
Frederic Suter [Thu, 21 Feb 2019 19:29:21 +0000 (20:29 +0100)]
fix some issues with Cancel
* Comm::cancel can be called when there is no pimpl
* if we wait for a canceled activity we can return not let the
impossible happen.

3 years agoParameter is a boolean.
Arnaud Giersch [Thu, 21 Feb 2019 13:54:43 +0000 (14:54 +0100)]
Parameter is a boolean.

3 years agoDon't strip last component of cwd.
Arnaud Giersch [Wed, 20 Feb 2019 22:02:48 +0000 (23:02 +0100)]
Don't strip last component of cwd.

3 years agodamned picky clang
Frederic Suter [Wed, 20 Feb 2019 17:40:21 +0000 (18:40 +0100)]
damned picky clang

3 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Wed, 20 Feb 2019 17:33:30 +0000 (18:33 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

3 years agoa few simplifications
Frederic Suter [Wed, 20 Feb 2019 17:31:27 +0000 (18:31 +0100)]
a few simplifications

3 years agoreplace another old simcall in MSG
Frederic Suter [Wed, 20 Feb 2019 17:19:22 +0000 (18:19 +0100)]
replace another old simcall in MSG

3 years agosave a cast
Frederic Suter [Wed, 20 Feb 2019 16:04:52 +0000 (17:04 +0100)]
save a cast

3 years agomodernize a simcall in MSG
Frederic Suter [Wed, 20 Feb 2019 15:48:31 +0000 (16:48 +0100)]
modernize a simcall in MSG

3 years ago(Hope to) fix number of cores for VMs.
Arnaud Giersch [Wed, 20 Feb 2019 15:12:02 +0000 (16:12 +0100)]
(Hope to) fix number of cores for VMs.

The bug was apparently introduced by commit 5a469c9dca9ce25cee1a52682d7eb7bbd736a49b.

3 years agocleanups and uniformization in Activity headers
Frederic Suter [Wed, 20 Feb 2019 14:02:02 +0000 (15:02 +0100)]
cleanups and uniformization in Activity headers

3 years agoThis is a CommImpl*.
Arnaud Giersch [Wed, 20 Feb 2019 14:03:16 +0000 (15:03 +0100)]
This is a CommImpl*.

3 years agomove a function to a righter place
Frederic Suter [Wed, 20 Feb 2019 13:08:55 +0000 (14:08 +0100)]
move a function to a righter place

3 years agoprevent segfault when DEBUG is activated
Frederic Suter [Wed, 20 Feb 2019 13:00:37 +0000 (14:00 +0100)]
prevent segfault when DEBUG is activated

3 years agoChange the syntax of SMPI_SAMPLE_* macros.
degomme [Wed, 20 Feb 2019 10:54:34 +0000 (11:54 +0100)]
Change the syntax of SMPI_SAMPLE_* macros.
To handle the end of the computing loop when sampling is still on, we need to wrap it.

This replaces this syntax
for(k = 1; k <= np; k++) { SMPI_SAMPLE_GLOBAL(0.25 * np, 0.03) {
where the macro had no idea of the loop conditions

by this
SMPI_SAMPLE_GLOBAL(k = 1, k <= np, k++, 0.25 * np, 0.03,
 {...}
)
syntax, where the body of loop is itself a parameter. This is not perfect, and may change soon. But now we can exit gracefully the sampling whenever the upper loop exits.

3 years agoDefine and use optimized variants for simcalls comm_testany and comm_waitany.
Arnaud Giersch [Tue, 19 Feb 2019 22:10:16 +0000 (23:10 +0100)]
Define and use optimized variants for simcalls comm_testany and comm_waitany.

3 years agoSpecialize parameter for simcall comm_waitany.
Arnaud Giersch [Tue, 19 Feb 2019 21:19:42 +0000 (22:19 +0100)]
Specialize parameter for simcall comm_waitany.

3 years agoSpecialize parameter for simcall comm_testany.
Arnaud Giersch [Tue, 19 Feb 2019 21:03:42 +0000 (22:03 +0100)]
Specialize parameter for simcall comm_testany.

3 years agoSpecialize parameter for simcall comm_wait.
Arnaud Giersch [Tue, 19 Feb 2019 20:40:41 +0000 (21:40 +0100)]
Specialize parameter for simcall comm_wait.

3 years agoSpecialize parameter for simcall comm_test.
Arnaud Giersch [Tue, 19 Feb 2019 20:28:25 +0000 (21:28 +0100)]
Specialize parameter for simcall comm_test.

3 years agoSpecialize parameter for simcall execution_wait.
Arnaud Giersch [Tue, 19 Feb 2019 20:18:02 +0000 (21:18 +0100)]
Specialize parameter for simcall execution_wait.

3 years agoSpecialize parameter for simcall execution_test.
Arnaud Giersch [Tue, 19 Feb 2019 20:15:41 +0000 (21:15 +0100)]
Specialize parameter for simcall execution_test.

3 years agoSpecialize parameter for simcall io_wait.
Arnaud Giersch [Tue, 19 Feb 2019 17:16:12 +0000 (18:16 +0100)]
Specialize parameter for simcall io_wait.

3 years agoKill now unused mc_xbt.
Arnaud Giersch [Tue, 19 Feb 2019 15:36:31 +0000 (16:36 +0100)]
Kill now unused mc_xbt.

3 years agoFix MC build after changes for waitany.
Arnaud Giersch [Tue, 19 Feb 2019 15:35:06 +0000 (16:35 +0100)]
Fix MC build after changes for waitany.

3 years agoChange dynar parameter for waitany to a raw array (mimic testany).
Arnaud Giersch [Tue, 19 Feb 2019 15:11:43 +0000 (16:11 +0100)]
Change dynar parameter for waitany to a raw array (mimic testany).

3 years agoRemove superfluous refcounting.
Arnaud Giersch [Tue, 19 Feb 2019 14:19:18 +0000 (15:19 +0100)]
Remove superfluous refcounting.

3 years agoSimcall waitany really takes a dynar of ActivityImpl*.
Arnaud Giersch [Tue, 19 Feb 2019 11:09:19 +0000 (12:09 +0100)]
Simcall waitany really takes a dynar of ActivityImpl*.

3 years agoUse CommImpl* for comm_copy callbacks.
Arnaud Giersch [Tue, 19 Feb 2019 13:07:49 +0000 (14:07 +0100)]
Use CommImpl* for comm_copy callbacks.

It's in fact already used for match_fun.

3 years agoCosmetics: adjust method names in debug messages.
Arnaud Giersch [Tue, 19 Feb 2019 20:00:28 +0000 (21:00 +0100)]
Cosmetics: adjust method names in debug messages.

3 years agoMake cleanupSurf() private.
Arnaud Giersch [Mon, 18 Feb 2019 17:24:59 +0000 (18:24 +0100)]
Make cleanupSurf() private.

3 years agotiny doc improvement
Martin Quinson [Tue, 19 Feb 2019 23:17:13 +0000 (00:17 +0100)]
tiny doc improvement

3 years agosonar: point to framagit instead of github
Martin Quinson [Mon, 11 Feb 2019 00:34:01 +0000 (01:34 +0100)]
sonar: point to framagit instead of github

3 years ago[SMPI] Change sampling behavior.
degomme [Tue, 19 Feb 2019 15:54:41 +0000 (16:54 +0100)]
[SMPI] Change sampling behavior.
Before, in sampling mode, each sampled loop was executed once, and the process would inject the time it took immediately.
This lead to a simcall being executed, which would then yield execution and possibly give the hand to another process.
This was destroying the caches, and resulted in over-estimated times.

This modification holds the injected time until the end of the sampling phase, trying to do the most of it on one process, without swapping contextes in between.

TODO :
- check what happens if num sampling iters < num iters/process (mandatory swapping)
Issues might be triggered if process leaves sampling before reaching the given bounds first.

3 years agoremove doxygen css and py tools scripts from codacy
Augustin Degomme [Thu, 7 Feb 2019 09:52:57 +0000 (10:52 +0100)]
remove doxygen css and py tools scripts from codacy

3 years agoreduce size of message sent ..
Augustin Degomme [Wed, 6 Feb 2019 09:40:04 +0000 (10:40 +0100)]
reduce size of message sent ..
For collectives we have to allocate fake buffers, and these ones may be a bit too large for some small systems (arm)

3 years agoAll activities have their own finish method \o/
Frederic Suter [Tue, 19 Feb 2019 09:02:03 +0000 (10:02 +0100)]
All activities have their own finish method \o/
The only sparks were of joy ...

3 years agoSIMIX_io_finish becomes IoImp::finish
Frederic Suter [Mon, 18 Feb 2019 22:24:58 +0000 (23:24 +0100)]
SIMIX_io_finish becomes IoImp::finish

get rid of smx_io*
the simcall_handlers will go at the beginning of the
kernel/activity/*Impl.cpp

3 years agoadd a StorageFailureException
Frederic Suter [Mon, 18 Feb 2019 22:01:04 +0000 (23:01 +0100)]
add a StorageFailureException

3 years ago_SIMIX_cond_wait becomes ConditionVariable::wait
Frederic Suter [Mon, 18 Feb 2019 20:23:46 +0000 (21:23 +0100)]
_SIMIX_cond_wait becomes ConditionVariable::wait

3 years agoSIMIX_synchro_wait becomes RawImpl::start
Frederic Suter [Mon, 18 Feb 2019 19:49:42 +0000 (20:49 +0100)]
SIMIX_synchro_wait becomes RawImpl::start

3 years agoobjectify simix timers.
Frederic Suter [Mon, 18 Feb 2019 18:32:54 +0000 (19:32 +0100)]
objectify simix timers.
public C API remains for now. Might be deprecated or removed (?)

3 years agoAvoid some casts and copies of CommImplPtr.
Arnaud Giersch [Mon, 18 Feb 2019 12:35:40 +0000 (13:35 +0100)]
Avoid some casts and copies of CommImplPtr.

3 years agolate modification wasn't tested, former was better
Frederic Suter [Sun, 17 Feb 2019 22:57:07 +0000 (23:57 +0100)]
late modification wasn't tested, former was better

3 years agoSIMIX_process_cleanup becomes ActorImpl::Cleanup
Frederic Suter [Sun, 17 Feb 2019 22:12:36 +0000 (23:12 +0100)]
SIMIX_process_cleanup becomes ActorImpl::Cleanup
There is no more need to pass the callback on an external function
when creating context.

3 years agoweek-end cleanups in ActorImpl
Frederic Suter [Sat, 16 Feb 2019 22:29:07 +0000 (23:29 +0100)]
week-end cleanups in ActorImpl
That excalated quickly ...

3 years agodead header
Frederic Suter [Sat, 16 Feb 2019 21:54:44 +0000 (22:54 +0100)]
dead header

3 years agoSIMIX_process_yield becomes ActorImpl::yield
Frederic Suter [Sat, 16 Feb 2019 21:42:16 +0000 (22:42 +0100)]
SIMIX_process_yield becomes ActorImpl::yield

3 years agoMethods and renaming in simix::Global
Frederic Suter [Sat, 16 Feb 2019 20:49:06 +0000 (21:49 +0100)]
Methods and renaming in simix::Global
+ s/process/actors/
+ empty_trash and process_runall should be here

3 years agoadd support for CancelException
Frederic Suter [Sat, 16 Feb 2019 19:08:50 +0000 (20:08 +0100)]
add support for CancelException

3 years agoDynamic cast without checking result is slow and useless. Use static cast.
Arnaud Giersch [Fri, 15 Feb 2019 14:04:15 +0000 (15:04 +0100)]
Dynamic cast without checking result is slow and useless. Use static cast.

It brings for example > 1.2 speedup on s4u-dht-kademlia.

3 years agoCosmetics (and please scan-build about potential null surf_action_).
Arnaud Giersch [Thu, 14 Feb 2019 12:45:52 +0000 (13:45 +0100)]
Cosmetics (and please scan-build about potential null surf_action_).

3 years agoUnsigned cannot become negative.
Arnaud Giersch [Thu, 14 Feb 2019 12:45:52 +0000 (13:45 +0100)]
Unsigned cannot become negative.

3 years agoUse const references for parameters.
Arnaud Giersch [Thu, 14 Feb 2019 12:45:52 +0000 (13:45 +0100)]
Use const references for parameters.