Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
17 months agoMerge branch 'faster_activity_removal' into 'master'
Augustin Degomme [Thu, 1 Dec 2022 17:56:23 +0000 (17:56 +0000)]
Merge branch 'faster_activity_removal' into 'master'

Replaced std::list by std::set to keep track of activities

See merge request simgrid/simgrid!123

17 months agoReplaced std::list by std::set to keep track of activities
Henri Casanova [Thu, 1 Dec 2022 17:33:13 +0000 (07:33 -1000)]
Replaced std::list by std::set to keep track of activities

17 months agoCosmetics.
Arnaud Giersch [Wed, 23 Nov 2022 16:12:52 +0000 (17:12 +0100)]
Cosmetics.

* use existing functions sthread_enable/disable
* useless casts
* static variables are already zero initialized

17 months agoUse C++ string_view.
Arnaud Giersch [Wed, 23 Nov 2022 14:48:27 +0000 (15:48 +0100)]
Use C++ string_view.

17 months agoReplace static function by a lambda.
Arnaud Giersch [Wed, 23 Nov 2022 14:29:39 +0000 (15:29 +0100)]
Replace static function by a lambda.

17 months agoFix doc.
Arnaud Giersch [Tue, 22 Nov 2022 10:43:28 +0000 (11:43 +0100)]
Fix doc.

17 months agobetter failure handling for streams
Fred Suter [Mon, 21 Nov 2022 17:03:00 +0000 (12:03 -0500)]
better failure handling for streams

17 months agoAddress misc Sonar issues.
Arnaud Giersch [Mon, 21 Nov 2022 14:36:37 +0000 (15:36 +0100)]
Address misc Sonar issues.

17 months agoCosmetics: "transfert" -> "transfer".
Arnaud Giersch [Mon, 21 Nov 2022 13:11:00 +0000 (14:11 +0100)]
Cosmetics: "transfert" -> "transfer".

17 months agoKill useless computation.
Arnaud Giersch [Thu, 17 Nov 2022 15:19:56 +0000 (16:19 +0100)]
Kill useless computation.

17 months agoCheck bounds.
Arnaud Giersch [Thu, 17 Nov 2022 15:18:40 +0000 (16:18 +0100)]
Check bounds.

17 months ago[ci skip] some release notes about the I/O streams
Fred Suter [Thu, 10 Nov 2022 19:29:10 +0000 (14:29 -0500)]
[ci skip] some release notes about the I/O streams

17 months agoCompletely revise the way to deal with Streamed I/Os
Fred Suter [Wed, 9 Nov 2022 22:43:12 +0000 (17:43 -0500)]
Completely revise the way to deal with Streamed I/Os

Do not implement a new funky HostModel but handle the io_stream call
in CLM03. Basic idea (thx alegrand): start from a regular
NetworkAction and add some extra constraints if it is an I/O stream.

+ Pros: easy to implement and inherit of all the complexity of the
network part. This would have been too much work and redundancy with a
new model. No extra flag, just a new type of I/Os (similar to the
Comm::sendto spirit)

+ Cons: had to cheat a bit to NOT inherit some of the network model
(LV08) complexity for the I/O part (bandwidth factor). Still has to
find a way to not pay the network latency if the stream starts from a
disk. Had to add a little hack to reserve more space in communicate
for the extra constraints.

This new type of I/O is tested in teshsuite/s4u/io-stream (with the
basic CM02 model without crosstraffic to verify if bottlenecks are
correctly handled, and then with the default config)

17 months agothis belongs to the Impl not a specific model
Fred Suter [Tue, 8 Nov 2022 20:06:29 +0000 (15:06 -0500)]
this belongs to the Impl not a specific model

17 months agofurther simplification/cleanups
Fred Suter [Tue, 8 Nov 2022 19:24:03 +0000 (14:24 -0500)]
further simplification/cleanups

17 months agoReduce the number of lambdas involved for python bindings.
Arnaud Giersch [Tue, 8 Nov 2022 14:43:05 +0000 (15:43 +0100)]
Reduce the number of lambdas involved for python bindings.

17 months agoTry to fix build by installing binutils.
Arnaud Giersch [Tue, 8 Nov 2022 09:59:41 +0000 (10:59 +0100)]
Try to fix build by installing binutils.

17 months agoRemove explicit conversion to std::string when it's not required.
Arnaud Giersch [Mon, 7 Nov 2022 15:03:13 +0000 (16:03 +0100)]
Remove explicit conversion to std::string when it's not required.

Some of them were redundant.
Some of them became optional after the removal of xbt::string.

17 months agoTypo.
Arnaud Giersch [Fri, 4 Nov 2022 17:47:40 +0000 (18:47 +0100)]
Typo.

17 months agoKeep integer operations.
Arnaud Giersch [Thu, 3 Nov 2022 17:36:30 +0000 (18:36 +0100)]
Keep integer operations.

17 months agoUse boolean value.
Arnaud Giersch [Thu, 3 Nov 2022 16:22:52 +0000 (17:22 +0100)]
Use boolean value.

17 months agoMark "override" (Sonar).
Arnaud Giersch [Thu, 3 Nov 2022 13:46:07 +0000 (14:46 +0100)]
Mark "override" (Sonar).

17 months agoCosmetics.
Arnaud Giersch [Thu, 3 Nov 2022 13:39:48 +0000 (14:39 +0100)]
Cosmetics.

17 months agosimplify the I/O stream thing A LOT. Might be plunged in CLM03 afterall
Fred Suter [Mon, 7 Nov 2022 21:25:24 +0000 (16:25 -0500)]
simplify the I/O stream thing A LOT. Might be plunged in CLM03 afterall

17 months agoAlso ignore the brand new python 3.11 on appveyor
Martin Quinson [Sun, 6 Nov 2022 10:39:24 +0000 (11:39 +0100)]
Also ignore the brand new python 3.11 on appveyor

17 months agoRemove a work around for a 2017 bug in Python + Windows
Martin Quinson [Sun, 6 Nov 2022 10:33:57 +0000 (11:33 +0100)]
Remove a work around for a 2017 bug in Python + Windows

17 months agoHelp windows builds: do not redefine XBT_PUBLIC
Martin Quinson [Sun, 6 Nov 2022 10:26:07 +0000 (11:26 +0100)]
Help windows builds: do not redefine XBT_PUBLIC

17 months agoPublic headers must remain C++14 for now
Martin Quinson [Sun, 6 Nov 2022 09:46:34 +0000 (10:46 +0100)]
Public headers must remain C++14 for now

17 months agoRevalidate a tesh file in Java after recent changes
Martin Quinson [Sun, 6 Nov 2022 09:42:22 +0000 (10:42 +0100)]
Revalidate a tesh file in Java after recent changes

17 months agoMissing include
Martin Quinson [Sun, 6 Nov 2022 09:22:48 +0000 (10:22 +0100)]
Missing include

18 months agosetter function only need a simcall in MC or with parallel execs
Martin Quinson [Sun, 6 Nov 2022 00:17:57 +0000 (01:17 +0100)]
setter function only need a simcall in MC or with parallel execs

This change introduce a new kind of simcalls alongside
simcall_answered and simcall_blocking: simcall_run_object_access that
is dedicated to object setter functions.

This is an answered simcall if running in // or in MC, and just a
regular function call if runnning a plain simulation.

This may speed up large simulations with a huge amount of activities,
but the perf improvement is not evaluated yet.

The performance could be further improved with a SIMGRID_HAVE_PARALLEL
option allowing the compiler to know beforhand that the simcall branch
will never be taken. But such an option would require to be tested and
I'm too lazy for that.

18 months agoAllow the MC replay to use the 'zero' buffering
Martin Quinson [Sat, 5 Nov 2022 19:04:43 +0000 (20:04 +0100)]
Allow the MC replay to use the 'zero' buffering

18 months agoDo not MC_assert on failed xbt_assert, it's too shaky
Martin Quinson [Sat, 5 Nov 2022 18:59:49 +0000 (19:59 +0100)]
Do not MC_assert on failed xbt_assert, it's too shaky

I'll handle it from the MC side instead

18 months agoMove a function to the right file and other cleanups
Martin Quinson [Fri, 4 Nov 2022 23:50:14 +0000 (00:50 +0100)]
Move a function to the right file and other cleanups

18 months agoKill a now unused field
Martin Quinson [Fri, 4 Nov 2022 23:44:25 +0000 (00:44 +0100)]
Kill a now unused field

18 months agoReduce the amount of header files loading xbt/string.hpp
Martin Quinson [Fri, 4 Nov 2022 23:23:35 +0000 (00:23 +0100)]
Reduce the amount of header files loading xbt/string.hpp

Prefer to load this file from the source files (as usual) to reduce
the amount of files to be rebuilt when this file changes.

18 months agoKill the now useless type xbt::string
Martin Quinson [Fri, 4 Nov 2022 22:37:27 +0000 (23:37 +0100)]
Kill the now useless type xbt::string

18 months agoanother attempt to avoid deadlocks in wrench when using sio host model
Fred Suter [Fri, 4 Nov 2022 12:26:40 +0000 (08:26 -0400)]
another attempt to avoid deadlocks in wrench when using sio host model

18 months agotypo
Fred Suter [Fri, 4 Nov 2022 12:00:34 +0000 (08:00 -0400)]
typo

18 months agofix deadlock found by hcasanova in case of self communications
Fred Suter [Fri, 4 Nov 2022 01:50:46 +0000 (21:50 -0400)]
fix deadlock found by hcasanova in case of self communications

18 months agocomplexify the test a bit further
Fred Suter [Thu, 3 Nov 2022 21:29:23 +0000 (17:29 -0400)]
complexify the test a bit further

18 months agoReuse existing variable, and shorten conditional.
Arnaud Giersch [Thu, 3 Nov 2022 09:05:57 +0000 (10:05 +0100)]
Reuse existing variable, and shorten conditional.

18 months agoDon't call function with side effect twice in the same expression.
Arnaud Giersch [Wed, 2 Nov 2022 22:33:20 +0000 (23:33 +0100)]
Don't call function with side effect twice in the same expression.

The evaluation order is undecided and may give different results (e.g. using clang vs. gcc).

18 months agoUpdate random-bug-nocrash.tesh after last changes.
Arnaud Giersch [Wed, 2 Nov 2022 22:12:50 +0000 (23:12 +0100)]
Update random-bug-nocrash.tesh after last changes.

18 months agoVariable is declared in xbt/asserts.h.
Arnaud Giersch [Wed, 2 Nov 2022 19:52:05 +0000 (20:52 +0100)]
Variable is declared in xbt/asserts.h.

18 months agoSpurious #include.
Arnaud Giersch [Wed, 2 Nov 2022 19:51:13 +0000 (20:51 +0100)]
Spurious #include.

18 months agoMerge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Tue, 1 Nov 2022 22:55:04 +0000 (23:55 +0100)]
Merge branch 'master' of framagit.org:simgrid/simgrid

18 months agoDisplay the mailbox name when showing a deadlocking situation
Martin Quinson [Tue, 1 Nov 2022 22:54:56 +0000 (23:54 +0100)]
Display the mailbox name when showing a deadlocking situation

18 months agoMC: display the status of all actors in case of deadlock
Martin Quinson [Tue, 1 Nov 2022 21:29:27 +0000 (22:29 +0100)]
MC: display the status of all actors in case of deadlock

18 months agoMC: tell the user about how to use the replay path in case of problem
Martin Quinson [Tue, 1 Nov 2022 21:16:35 +0000 (22:16 +0100)]
MC: tell the user about how to use the replay path in case of problem

18 months agoDisplay the stack of each actor during a MC replay (unless --log=no_log for the tests)
Martin Quinson [Tue, 1 Nov 2022 18:39:55 +0000 (19:39 +0100)]
Display the stack of each actor during a MC replay (unless --log=no_log for the tests)

18 months agoMerge branch 'fluidio' into 'master'
Fred Suter [Tue, 1 Nov 2022 13:15:57 +0000 (13:15 +0000)]
Merge branch 'fluidio' into 'master'

Fluidio

See merge request simgrid/simgrid!121

18 months agofix issues spotted by agriersch
Fred Suter [Tue, 1 Nov 2022 13:04:18 +0000 (09:04 -0400)]
fix issues spotted by agriersch

18 months agoMC replay: check whether there is a deadlock after running the trace
Martin Quinson [Mon, 31 Oct 2022 23:35:54 +0000 (00:35 +0100)]
MC replay: check whether there  is a deadlock after running the trace

18 months agoAlign the behavior of MC and MC_replay in SMPI, so that replay actually works
Martin Quinson [Mon, 31 Oct 2022 23:25:43 +0000 (00:25 +0100)]
Align the behavior of MC and MC_replay in SMPI, so that replay actually works

+ improved debug messages

18 months agoBe more verbose on the blocking transition when displaying the actor state on Ctrl-C
Martin Quinson [Mon, 31 Oct 2022 21:41:10 +0000 (22:41 +0100)]
Be more verbose on the blocking transition when displaying the actor state on Ctrl-C

18 months agoextend test
Fred Suter [Mon, 31 Oct 2022 14:34:58 +0000 (10:34 -0400)]
extend test

18 months agoplug leak and more consistency with other models
Fred Suter [Mon, 31 Oct 2022 14:33:21 +0000 (10:33 -0400)]
plug leak and more consistency with other models

18 months agoMC_replay: Ensure that times_considered is always set
Martin Quinson [Sun, 30 Oct 2022 23:27:14 +0000 (00:27 +0100)]
MC_replay: Ensure that times_considered is always set

+ small cosmetics while reading again that code

18 months agoMBI: display the expected diagnostic on error
Martin Quinson [Tue, 25 Oct 2022 22:28:43 +0000 (00:28 +0200)]
MBI: display the expected diagnostic on error

18 months agocheck that disk has been given as argument before accessing its pimpl
Fred Suter [Fri, 28 Oct 2022 18:51:20 +0000 (14:51 -0400)]
check that disk has been given as argument before accessing its pimpl

18 months agoadd a transfer bottleneck case
Fred Suter [Fri, 28 Oct 2022 15:23:12 +0000 (11:23 -0400)]
add a transfer bottleneck case

18 months agorevalidate tesh
Fred Suter [Fri, 28 Oct 2022 11:48:13 +0000 (07:48 -0400)]
revalidate tesh

18 months agoupdate
Fred Suter [Fri, 28 Oct 2022 11:39:12 +0000 (07:39 -0400)]
update

18 months agoadd example
Fred Suter [Fri, 28 Oct 2022 11:38:47 +0000 (07:38 -0400)]
add example

18 months agointroduce s4u::Io::streamto
Fred Suter [Fri, 28 Oct 2022 11:36:22 +0000 (07:36 -0400)]
introduce s4u::Io::streamto

18 months agofixes
Fred Suter [Fri, 28 Oct 2022 11:36:11 +0000 (07:36 -0400)]
fixes

18 months agoeasier to store and use DiskImpl at kernel level
Fred Suter [Thu, 27 Oct 2022 12:59:09 +0000 (08:59 -0400)]
easier to store and use DiskImpl at kernel level

18 months agotypo spotted by Henri during a call
Fred Suter [Thu, 27 Oct 2022 12:31:05 +0000 (08:31 -0400)]
typo spotted by Henri during a call

18 months agoadd io_stream as a HostModel pure method
Fred Suter [Thu, 27 Oct 2022 12:29:45 +0000 (08:29 -0400)]
add io_stream as a HostModel pure method

18 months agofirst attempt to fluid comm/IO model
Fred Suter [Tue, 25 Oct 2022 13:16:34 +0000 (09:16 -0400)]
first attempt to fluid comm/IO model

18 months agomove update_remains_lazy to the pimpl (as for CPUs)
Fred Suter [Fri, 21 Oct 2022 18:17:48 +0000 (14:17 -0400)]
move update_remains_lazy to the pimpl (as for CPUs)

18 months agosimplify the way I/O actions are created (CPU style)
Fred Suter [Wed, 19 Oct 2022 16:20:10 +0000 (12:20 -0400)]
simplify the way I/O actions are created (CPU style)

18 months agoHave the disk model be part of the host models
Fred Suter [Tue, 18 Oct 2022 12:50:28 +0000 (08:50 -0400)]
Have the disk model be part of the host models

18 months agomention disk model in host model descriptions
Fred Suter [Tue, 18 Oct 2022 12:34:39 +0000 (08:34 -0400)]
mention disk model in host model descriptions

18 months agorename disk model init function: default is S19
Fred Suter [Tue, 18 Oct 2022 12:29:54 +0000 (08:29 -0400)]
rename disk model init function: default is S19

18 months agoMore functions declared "const" (Sonar).
Arnaud Giersch [Fri, 28 Oct 2022 09:09:15 +0000 (11:09 +0200)]
More functions declared "const" (Sonar).

18 months agoDeclare functions "const" (Sonar).
Arnaud Giersch [Thu, 27 Oct 2022 11:57:41 +0000 (13:57 +0200)]
Declare functions "const" (Sonar).

18 months agoFix infinite recursion.
Arnaud Giersch [Thu, 27 Oct 2022 11:50:11 +0000 (13:50 +0200)]
Fix infinite recursion.

18 months agoUse true/false for boolean variable (Sonar).
Arnaud Giersch [Thu, 27 Oct 2022 11:40:12 +0000 (13:40 +0200)]
Use true/false for boolean variable (Sonar).

18 months agoRemove redundant cast (Sonar).
Arnaud Giersch [Thu, 27 Oct 2022 11:23:40 +0000 (13:23 +0200)]
Remove redundant cast (Sonar).

18 months agoFix stack-use-after-scope (ASan).
Arnaud Giersch [Thu, 27 Oct 2022 11:22:31 +0000 (13:22 +0200)]
Fix stack-use-after-scope (ASan).

18 months agoCosmetics.
Arnaud Giersch [Thu, 27 Oct 2022 11:21:32 +0000 (13:21 +0200)]
Cosmetics.

18 months ago [ci-skip] end of the pass
Fred Suter [Wed, 26 Oct 2022 18:54:34 +0000 (14:54 -0400)]
 [ci-skip] end of the pass

18 months agostart a pass on that part of the doc
Fred Suter [Tue, 25 Oct 2022 16:04:09 +0000 (12:04 -0400)]
start a pass on that part of the doc

18 months agoMore x -> varrho in the doc
Martin Quinson [Tue, 25 Oct 2022 13:21:23 +0000 (15:21 +0200)]
More x -> varrho in the doc

18 months agoTry to make the abort() inconditionnal in failed xbt_assert, to please the checkers
Martin Quinson [Tue, 25 Oct 2022 13:05:49 +0000 (15:05 +0200)]
Try to make the abort() inconditionnal in failed xbt_assert, to please the checkers

18 months agoAdd a ref to the disk paper
Martin Quinson [Tue, 25 Oct 2022 13:04:27 +0000 (15:04 +0200)]
Add a ref to the disk paper

18 months agoArnaud prefers ϱ to x (+depict the simulated platform)
Martin Quinson [Tue, 25 Oct 2022 12:53:55 +0000 (14:53 +0200)]
Arnaud prefers ϱ to x (+depict the simulated platform)

18 months agoMerge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Tue, 25 Oct 2022 12:03:19 +0000 (14:03 +0200)]
Merge branch 'master' of framagit.org:simgrid/simgrid

18 months agoDraft a first version of the Models chapter in the doc
Martin Quinson [Tue, 25 Oct 2022 12:01:49 +0000 (14:01 +0200)]
Draft a first version of the Models chapter in the doc

18 months agoCosmetics
Arnaud Legrand [Tue, 25 Oct 2022 06:16:39 +0000 (08:16 +0200)]
Cosmetics

18 months agodoc: link to some more existing examples
Martin Quinson [Mon, 24 Oct 2022 07:01:22 +0000 (09:01 +0200)]
doc: link to some more existing examples

18 months agoMinor rewording
Arnaud Legrand [Mon, 24 Oct 2022 11:19:15 +0000 (13:19 +0200)]
Minor rewording

18 months agoFix non-smpi builds
Martin Quinson [Mon, 24 Oct 2022 06:35:44 +0000 (08:35 +0200)]
Fix non-smpi builds

18 months agoMake the factor callbacks private in NetworkModelFactors
Martin Quinson [Sun, 23 Oct 2022 22:53:48 +0000 (00:53 +0200)]
Make the factor callbacks private in NetworkModelFactors

18 months agoMove get_{bandwidth,latency}_factor to the NetworkModelFactors trait
Martin Quinson [Sun, 23 Oct 2022 22:23:27 +0000 (00:23 +0200)]
Move get_{bandwidth,latency}_factor to the NetworkModelFactors trait

18 months agoCleanups. Kill useless code
Martin Quinson [Sun, 23 Oct 2022 22:12:01 +0000 (00:12 +0200)]
Cleanups. Kill useless code

- Kill check_lat_factor_cb() and check_bw_factor_cb(): Now cleanly in NetworkModelFactors
- Kill the NetworkSmpiModel type: useless and empty
- Kill files network_smpi.[ch]pp: empty

18 months agoRename NetworkModelIntf into NetworkModelFactors
Martin Quinson [Sun, 23 Oct 2022 21:55:51 +0000 (23:55 +0200)]
Rename NetworkModelIntf into NetworkModelFactors

18 months agoMove set_lat_factor_cb and friends to NetworkModelFactors
Martin Quinson [Sun, 23 Oct 2022 20:40:57 +0000 (22:40 +0200)]
Move set_lat_factor_cb and friends to NetworkModelFactors