Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
2 years agocosmetics
Martin Quinson [Mon, 19 Dec 2016 14:00:11 +0000 (15:00 +0100)]
cosmetics

2 years agoexplicitely capture variables in lambda to please sonar
Martin Quinson [Mon, 19 Dec 2016 13:59:23 +0000 (14:59 +0100)]
explicitely capture variables in lambda to please sonar

2 years agocosmetics
Martin Quinson [Mon, 19 Dec 2016 13:38:35 +0000 (14:38 +0100)]
cosmetics

2 years agoTwo variables must be defined without using cmakedefine macros.
Matthieu Volat [Mon, 19 Dec 2016 18:41:10 +0000 (19:41 +0100)]
Two variables must be defined without using cmakedefine macros.

They have values other than 0|1, mea culpa...

2 years agodisable mc for sanitizers to have a cleaner output
Augustin Degomme [Mon, 19 Dec 2016 18:01:31 +0000 (19:01 +0100)]
disable mc for sanitizers to have a cleaner output

2 years agoUse the CMake macro #cmakedefine01 in configurable files.
Matthieu Volat [Mon, 19 Dec 2016 16:38:50 +0000 (17:38 +0100)]
Use the CMake macro #cmakedefine01 in configurable files.

cmakedefine01 allows to perform C preprocessor replacements
that define a variable to 0 or 1 when configure_file is called,
instead of (not) defining the variable (see
https://cmake.org/cmake/help/v2.8.8/cmake.html#command:configure_file
for the 2.8.8 doc).

This ease the defining of config.h variables (no foreach loops
that preset them to 0), but two requirements must be met:
 1. variable name must match in cmake and config.h.in
 2. no comment on the macro line

2 years agoPrepare the next release
Martin Quinson [Mon, 19 Dec 2016 11:21:13 +0000 (12:21 +0100)]
Prepare the next release

2 years agomove content from MSG_VM to s4u::VM
Martin Quinson [Mon, 19 Dec 2016 11:15:36 +0000 (12:15 +0100)]
move content from MSG_VM to s4u::VM

2 years agoreduce the amount of static casts
Martin Quinson [Mon, 19 Dec 2016 11:01:55 +0000 (12:01 +0100)]
reduce the amount of static casts

2 years agoimprove test (and stop using unqualified printf)
Martin Quinson [Mon, 19 Dec 2016 10:37:09 +0000 (11:37 +0100)]
improve test (and stop using unqualified printf)

2 years agocosmetics
Martin Quinson [Mon, 19 Dec 2016 10:15:58 +0000 (11:15 +0100)]
cosmetics

- less new/delete when avoidable
- rename some misnamed variables

2 years agonew function: Engine::netcardList()
Martin Quinson [Mon, 19 Dec 2016 09:22:37 +0000 (10:22 +0100)]
new function: Engine::netcardList()

2 years agoMove all netcards into the dict, and the dict to the engine
Martin Quinson [Sun, 18 Dec 2016 15:14:36 +0000 (16:14 +0100)]
Move all netcards into the dict, and the dict to the engine

2 years agouse std::string instead of bprintf
Martin Quinson [Sun, 18 Dec 2016 10:27:43 +0000 (11:27 +0100)]
use std::string instead of bprintf

2 years agoreduce the public exposure of netcards_dict
Martin Quinson [Sat, 17 Dec 2016 18:14:40 +0000 (19:14 +0100)]
reduce the public exposure of netcards_dict

2 years agono need for a lib to store the netcards. A dict is easier
Martin Quinson [Sat, 17 Dec 2016 16:59:27 +0000 (17:59 +0100)]
no need for a lib to store the netcards. A dict is easier

2 years agoremove surf_routing.hpp
Martin Quinson [Sat, 17 Dec 2016 16:37:42 +0000 (17:37 +0100)]
remove surf_routing.hpp

2 years agonext release is 3.14
Martin Quinson [Sat, 17 Dec 2016 16:19:53 +0000 (17:19 +0100)]
next release is 3.14

2 years agoplease sonar on yesterday's commits
Martin Quinson [Sat, 17 Dec 2016 15:11:51 +0000 (16:11 +0100)]
please sonar on yesterday's commits

2 years agoyou mean I should compile the code before commiting? Hu ho, ok...
Martin Quinson [Fri, 16 Dec 2016 17:34:50 +0000 (18:34 +0100)]
you mean I should compile the code before commiting? Hu ho, ok...

2 years agoCompletely rework the properties of netzones
Martin Quinson [Fri, 16 Dec 2016 08:15:24 +0000 (09:15 +0100)]
Completely rework the properties of netzones

- This changes some MSG functions, but I doubt that any users really
  used them. Even if someone did, there is no real loss of
  functionnality. The only missing thing would be if someone wants to
  traverse the whole set, but I don't have no good idea here since the
  data is stored in a C++ container. It's hard to let C code traverse
  it. I could add a _dump() method to just display it.
- the change in the tesh file denotes an old bug that this change
  fixes. The name property was not defined in the cluster tag, but in
  the previous one in the XML, so it should not have landed in the
  properties of the cluster's hosts.
- the code in the XML to stack the dictionnaries for each AS is simply
  gone. The AS is created in the STag function, so simply retrieve it
  by name and use it when we need it. No need for an additional storage.
- surf_routing is almost gone, now \o/

2 years agobypass MSG in the java bindings
Martin Quinson [Thu, 15 Dec 2016 14:46:27 +0000 (15:46 +0100)]
bypass MSG in the java bindings

2 years agomsg_as_t -> msg_netzone_t
Martin Quinson [Thu, 15 Dec 2016 10:38:32 +0000 (11:38 +0100)]
msg_as_t  ->  msg_netzone_t

2 years agosmall cosmetics advised by sonar
Martin Quinson [Thu, 15 Dec 2016 10:35:00 +0000 (11:35 +0100)]
small cosmetics advised by sonar

2 years agoMC: ignore a new boost-related library
Martin Quinson [Thu, 15 Dec 2016 08:35:45 +0000 (09:35 +0100)]
MC: ignore a new boost-related library

The new lib is libboost_context-mt, but clang-format insisted on
making my patch unreadable.

2 years agofix MC build with paranoid flags
Martin Quinson [Thu, 15 Dec 2016 07:56:55 +0000 (08:56 +0100)]
fix MC build with paranoid flags

2 years agofix jedule builds
Martin Quinson [Thu, 15 Dec 2016 07:21:25 +0000 (08:21 +0100)]
fix jedule builds

2 years agostart rewriting the platform documentation now that AS are called netzones
Martin Quinson [Wed, 14 Dec 2016 22:12:24 +0000 (23:12 +0100)]
start rewriting the platform documentation now that AS are called netzones

2 years agostart reformating the manual for the AS -> NetZone transition (ignorable changes)
Martin Quinson [Tue, 13 Dec 2016 10:23:10 +0000 (11:23 +0100)]
start reformating the manual for the AS -> NetZone transition (ignorable changes)

2 years agoupdate function documentation and variable names in the As -> NetZone transition
Martin Quinson [Tue, 13 Dec 2016 10:17:21 +0000 (11:17 +0100)]
update function documentation and variable names in the As -> NetZone transition

2 years agorename the class objects and C types for the As -> NetZone transition
Martin Quinson [Tue, 13 Dec 2016 09:35:26 +0000 (10:35 +0100)]
rename the class objects and C types for the As -> NetZone transition

2 years agoclang-format changes related to the previous commit
Martin Quinson [Tue, 13 Dec 2016 08:57:00 +0000 (09:57 +0100)]
clang-format changes related to the previous commit

2 years agostart renaming AS to NetZone
Martin Quinson [Tue, 13 Dec 2016 08:55:07 +0000 (09:55 +0100)]
start renaming AS to NetZone

These things are obviously not Autonomous Systems as in Internet:
they form a hierarchy...

That's an intrusive change ongoing, but we want the best for SimGrid,
don't we?

2 years agocontinue emptying the surf_routing files
Martin Quinson [Mon, 12 Dec 2016 21:26:04 +0000 (22:26 +0100)]
continue emptying the surf_routing files

2 years agomove some storage-related content out of routing into storage area
Martin Quinson [Mon, 12 Dec 2016 21:13:27 +0000 (22:13 +0100)]
move some storage-related content out of routing into storage area

2 years agosonar: try harder to not choke on casting pointers into literals
Martin Quinson [Mon, 12 Dec 2016 15:35:40 +0000 (16:35 +0100)]
sonar: try harder to not choke on casting pointers into literals

2 years agocosmetics: .name().c_str() becomes .cname()
Martin Quinson [Mon, 12 Dec 2016 15:06:15 +0000 (16:06 +0100)]
cosmetics: .name().c_str() becomes .cname()

2 years agosonar: ignore 'Pointers should not be cast to integral types' and bump version to...
Martin Quinson [Mon, 12 Dec 2016 14:43:57 +0000 (15:43 +0100)]
sonar: ignore 'Pointers should not be cast to integral types' and bump version to 3.13.91

2 years agodon't fool sonar if we can avoid it
Martin Quinson [Mon, 12 Dec 2016 14:30:04 +0000 (15:30 +0100)]
don't fool sonar if we can avoid it

2 years agothese are redundent tests of which we already have the answer
Martin Quinson [Mon, 12 Dec 2016 14:23:13 +0000 (15:23 +0100)]
these are redundent tests of which we already have the answer

2 years agodon't test pointers after dereferencing them (thanks, sonar)
Martin Quinson [Mon, 12 Dec 2016 14:19:50 +0000 (15:19 +0100)]
don't test pointers after dereferencing them (thanks, sonar)

2 years agotry to not disable our logs on sonar, just to see
Martin Quinson [Mon, 12 Dec 2016 09:39:38 +0000 (10:39 +0100)]
try to not disable our logs on sonar, just to see

2 years agorevalidate this test now that I updated the corresponding errmsg
Martin Quinson [Mon, 12 Dec 2016 07:59:30 +0000 (08:59 +0100)]
revalidate this test now that I updated the corresponding errmsg

2 years agoplease sonar: dont apply binary operators to signed ints
Martin Quinson [Mon, 12 Dec 2016 07:57:07 +0000 (08:57 +0100)]
please sonar: dont apply binary operators to signed ints

2 years agoimprove an error message
Martin Quinson [Sun, 11 Dec 2016 21:14:07 +0000 (22:14 +0100)]
improve an error message

2 years agotypo
Martin Quinson [Sun, 11 Dec 2016 20:55:15 +0000 (21:55 +0100)]
typo

2 years agoplease sonar, and other small cleanups
Martin Quinson [Sun, 11 Dec 2016 20:29:50 +0000 (21:29 +0100)]
please sonar, and other small cleanups

- Init members during initialization
- One operation per line at most
- Don't let fields uninited after the constructor
- Obey our naming schema (fields' name end with _)

2 years agokill the s_surf_parsing_link_up_down_t datatype
Martin Quinson [Sun, 11 Dec 2016 20:18:46 +0000 (21:18 +0100)]
kill the s_surf_parsing_link_up_down_t datatype

2 years agocosmetics
Martin Quinson [Sun, 11 Dec 2016 20:07:06 +0000 (21:07 +0100)]
cosmetics

2 years agouse std::pair instead of s_surf_parsing_link_up_down_t for Cluster private links
Martin Quinson [Sun, 11 Dec 2016 19:56:41 +0000 (20:56 +0100)]
use std::pair instead of s_surf_parsing_link_up_down_t for Cluster private links

2 years agorevalidate the surf_usage tests
Martin Quinson [Sun, 11 Dec 2016 18:22:12 +0000 (19:22 +0100)]
revalidate the surf_usage tests

These tests are meaningless anyway and should be replaced with unit
tests at some point. Hopefully soon.

2 years agoNo need for the AS creation callback
Martin Quinson [Sun, 11 Dec 2016 17:48:59 +0000 (18:48 +0100)]
No need for the AS creation callback

2 years agoMy detection of user errors creates some invalid accesses
Martin Quinson [Sun, 11 Dec 2016 17:48:29 +0000 (18:48 +0100)]
My detection of user errors creates some invalid accesses

2 years agorename a field for cosmetics
Martin Quinson [Sun, 11 Dec 2016 13:56:16 +0000 (14:56 +0100)]
rename a field for cosmetics

2 years agogreatly simplify the way peers are created in Vivaldi AS
Martin Quinson [Sun, 11 Dec 2016 13:13:49 +0000 (14:13 +0100)]
greatly simplify the way peers are created in Vivaldi AS

We used to create a mini cluster for each added peer, which is useless
since they are already in a Vivaldi AS. So instead, add the link
up&down to the Vivaldi containing AS.

This way, we can hide again the netcard of the AsImpl, that was made
public only a few commits ago.

2 years agonetwork/coordinates option is now useless
Martin Quinson [Sat, 10 Dec 2016 21:55:46 +0000 (22:55 +0100)]
network/coordinates option is  now useless

2 years agoDetect and diagnose a possible user error
Martin Quinson [Sat, 10 Dec 2016 16:50:02 +0000 (17:50 +0100)]
Detect and diagnose a possible user error

2 years agomake our FindSimGrid.cmake more visible (and improve it)
Martin Quinson [Sat, 10 Dec 2016 15:54:48 +0000 (16:54 +0100)]
make our FindSimGrid.cmake more visible (and improve it)

2 years agoplease sonar, praise sonar
Martin Quinson [Fri, 9 Dec 2016 21:39:00 +0000 (22:39 +0100)]
please sonar, praise sonar

2 years agoUse boost instead of xbt in Vivaldi
Martin Quinson [Fri, 9 Dec 2016 21:21:28 +0000 (22:21 +0100)]
Use boost instead of xbt in Vivaldi

2 years agouse NetCard extension to store vivaldi coordinates
Martin Quinson [Fri, 9 Dec 2016 21:14:38 +0000 (22:14 +0100)]
use NetCard extension to store vivaldi coordinates

2 years agomake NetCards extendable, and use this for NS3 extension
Martin Quinson [Thu, 8 Dec 2016 21:34:14 +0000 (22:34 +0100)]
make NetCards extendable, and use this for NS3 extension

2 years agocosmetics
Martin Quinson [Thu, 8 Dec 2016 20:36:07 +0000 (21:36 +0100)]
cosmetics

2 years agouse std::vector instead of xbt_dynar_t (in NS3)
Martin Quinson [Thu, 8 Dec 2016 20:26:49 +0000 (21:26 +0100)]
use std::vector instead of xbt_dynar_t (in NS3)

This should fix quite a lot of leaks, too.

2 years agoNS3 extensions are for netcards, not for hosts
Martin Quinson [Thu, 8 Dec 2016 19:42:25 +0000 (20:42 +0100)]
NS3 extensions are for netcards, not for hosts

We need to have it for every netcard, be it an host, an AS or an
host-less router.

It's cumbersome to put it onto hosts when possible and onto netcard
for routers and ASes, and then search first in the host and if not
found in the netcards.

Instead, only put it on netcards, and we're set.

2 years agomove the NetCard related functions into a NetCard.cpp
Martin Quinson [Thu, 8 Dec 2016 10:29:49 +0000 (11:29 +0100)]
move the NetCard related functions into a NetCard.cpp

2 years agoactually, BypassRoute can be made private to AsImpl
Martin Quinson [Thu, 8 Dec 2016 09:21:09 +0000 (10:21 +0100)]
actually, BypassRoute can be made private to AsImpl

2 years agorename AsRoute to BypassRoute, and move it to its own file
Martin Quinson [Thu, 8 Dec 2016 09:03:04 +0000 (10:03 +0100)]
rename AsRoute to BypassRoute, and move it to its own file

2 years agoKill Onelink now that NS3 does not use it anymore
Martin Quinson [Thu, 8 Dec 2016 08:48:24 +0000 (09:48 +0100)]
Kill Onelink now that NS3 does not use it anymore

2 years agomake an As::onRouteCreation signal so that NS3 does not need getOneLinkRoutes afterward
Martin Quinson [Thu, 8 Dec 2016 08:44:47 +0000 (09:44 +0100)]
make an As::onRouteCreation signal so that NS3 does not need getOneLinkRoutes afterward

2 years agokill the last remainings of RoutingPlatf
Martin Quinson [Wed, 7 Dec 2016 19:29:45 +0000 (20:29 +0100)]
kill the last remainings of RoutingPlatf

2 years agocosmetics
Martin Quinson [Wed, 7 Dec 2016 18:16:37 +0000 (19:16 +0100)]
cosmetics

2 years agoless VM in surf.h
Martin Quinson [Wed, 7 Dec 2016 16:13:01 +0000 (17:13 +0100)]
less VM in surf.h

2 years agoKill the fact that several model VM models may be provided.
Martin Quinson [Wed, 7 Dec 2016 15:57:11 +0000 (16:57 +0100)]
Kill the fact that several model VM models may be provided.

- VM are a plugin: take it, copy it and change it yourself
- helps removing VMs from the trunk (I demand you to enter this plugin!)

2 years agoplease sonar and use & when creating function pointers
Martin Quinson [Tue, 6 Dec 2016 20:32:29 +0000 (21:32 +0100)]
please sonar and use & when creating function pointers

2 years agocosmetics
Martin Quinson [Tue, 6 Dec 2016 20:16:50 +0000 (21:16 +0100)]
cosmetics

2 years agomove NetCard to its own header file
Martin Quinson [Tue, 6 Dec 2016 20:14:58 +0000 (21:14 +0100)]
move NetCard to its own header file

2 years agono need for a NetCard and a NetCardImpl when both are in the same file
Martin Quinson [Tue, 6 Dec 2016 09:04:51 +0000 (10:04 +0100)]
no need for a NetCard and a NetCardImpl when both are in the same file

2 years agoadd -no-pie flag to thread sanitizer (see https://bugs.debian.org/cgi-bin/bugreport...
Augustin Degomme [Tue, 6 Dec 2016 08:32:27 +0000 (09:32 +0100)]
add -no-pie flag to thread sanitizer (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=796246)

2 years agoplease my old friend SonarQube now that it's back
Martin Quinson [Mon, 5 Dec 2016 23:06:06 +0000 (00:06 +0100)]
please my old friend SonarQube now that it's back

2 years agoSonarQube: upgrade scanner to the latest version 2.8
Evgeny Mandrikov [Mon, 5 Dec 2016 19:18:03 +0000 (20:18 +0100)]
SonarQube: upgrade scanner to the latest version 2.8

2.6.1 fixes https://jira.sonarsource.com/browse/SQSCANNER-18
so that warning message are properly displayed in log.

2 years agoSonarQube: remove useless properties "sonar.c.std" and "sonar.cpp.std"
Evgeny Mandrikov [Mon, 5 Dec 2016 18:55:41 +0000 (19:55 +0100)]
SonarQube: remove useless properties "sonar.c.std" and "sonar.cpp.std"

When using build-wrapper this is inferred based on an actual build.

2 years agoplease sonar: this variable will be overwritten in the next loop cycle
Martin Quinson [Mon, 5 Dec 2016 20:29:37 +0000 (21:29 +0100)]
please sonar: this variable will be overwritten in the next loop cycle

2 years agotry to fix a shell syntax error, bummer
Martin Quinson [Mon, 5 Dec 2016 19:58:48 +0000 (20:58 +0100)]
try to fix a shell syntax error, bummer

2 years agofix the syntax in the sonar configuration (fix #126)
Martin Quinson [Mon, 5 Dec 2016 19:45:09 +0000 (20:45 +0100)]
fix the syntax in the sonar configuration (fix #126)

I drop the #126 PR that propose to kill that config item all together
because I really think that sonar should not feel too much concerned
by our logging macros.

Yes they increase the nesting level if you expend them, but nobody
expends them mentaly. We use them as inline functions even if we
cannot implement them as functions for technical reasons.

2 years agoDon't show the sonar token in the logs (fix #127)
Martin Quinson [Mon, 5 Dec 2016 19:31:34 +0000 (20:31 +0100)]
Don't show the sonar token in the logs (fix #127)

the token was regenerated, too.

2 years agokill the now empty RoutingPlatf datatype \o/
Martin Quinson [Mon, 5 Dec 2016 19:27:06 +0000 (20:27 +0100)]
kill the now empty RoutingPlatf datatype \o/

2 years agomove the rootAS from routing_platf into the EngineImpl
Martin Quinson [Mon, 5 Dec 2016 08:18:05 +0000 (09:18 +0100)]
move the rootAS from routing_platf into the EngineImpl

Now that we instanciate a s4u::Engine when using the routing, the
surf_usage tests don't have to manually call surf_exit(): it called
atexit() during initialization. Gosh, it took me so long to figure out
why these two tests would break when the rootAs is moved...

2 years agotiny optim
Martin Quinson [Mon, 5 Dec 2016 10:03:46 +0000 (11:03 +0100)]
tiny optim

2 years agoConvert routing_platf->getRouteAndLatency into s4u::Host->routeTo
Martin Quinson [Mon, 5 Dec 2016 09:36:07 +0000 (10:36 +0100)]
Convert routing_platf->getRouteAndLatency into s4u::Host->routeTo

The bad thing is that the public API does not expose the surf::Link
type, so there is little you can do about it. For now.

2 years agodon't really use netCards in the network model. Keep at the host level
Martin Quinson [Mon, 5 Dec 2016 09:45:02 +0000 (10:45 +0100)]
don't really use netCards in the network model. Keep at the host level

2 years agofix java build
Martin Quinson [Sun, 4 Dec 2016 21:21:06 +0000 (22:21 +0100)]
fix java build

2 years agocleanups in the dict and dynar tests
Martin Quinson [Sun, 4 Dec 2016 20:23:15 +0000 (21:23 +0100)]
cleanups in the dict and dynar tests

2 years agostop testing heterogeneous dicts, too
Martin Quinson [Sun, 4 Dec 2016 20:05:11 +0000 (21:05 +0100)]
stop testing heterogeneous dicts, too

2 years agoDeprecate xbt_dict_new()
Martin Quinson [Sun, 4 Dec 2016 17:47:09 +0000 (18:47 +0100)]
Deprecate xbt_dict_new()

Please people, use xbt_dict_new_homogeneous(). Non-homogeneous dicts
were a very bad idea that could have only originated in Perl anyway.

2 years agodon't pass the free_f parameter to MSG_*_set_property_value()
Martin Quinson [Sun, 4 Dec 2016 18:26:03 +0000 (19:26 +0100)]
don't pass the free_f parameter to MSG_*_set_property_value()

2 years agoDon't store raw objects as host properties, which must be strings
Martin Quinson [Sun, 4 Dec 2016 17:49:40 +0000 (18:49 +0100)]
Don't store raw objects as host properties, which must be strings

2 years agocosmetics
Martin Quinson [Sat, 3 Dec 2016 21:02:20 +0000 (22:02 +0100)]
cosmetics

2 years agoupdate a teshfile that was affected by #123, which Fabien just fixed
Martin Quinson [Fri, 2 Dec 2016 22:59:06 +0000 (23:59 +0100)]
update a teshfile that was affected by #123, which Fabien just fixed

2 years agocall updateRemaining when the action is suspended (fix #123)
Fabien Chaix [Fri, 2 Dec 2016 13:30:57 +0000 (05:30 -0800)]
call updateRemaining when the action is suspended (fix #123)

if not, the LMM is giving the right results, but surf does not notice.

Thus the fix does not touch LMM, only surf_interface.cpp. Note that
suspend has the specificity that we cannot estimate when it will end.
Thus it does not seem appropriate to use the nextOccuringEventLazy
method which is essentially trying to find when will be the next step.
Instead I propose to call updateReaminingLazy from the suspend
function.