Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
3 years agoRename variable to unhide class field with same name.
Arnaud Giersch [Mon, 16 Apr 2018 10:02:40 +0000 (12:02 +0200)]
Rename variable to unhide class field with same name.

3 years agoRename instr_interface.h and mc_ignore.h to .hpp.
Arnaud Giersch [Mon, 16 Apr 2018 09:33:50 +0000 (11:33 +0200)]
Rename instr_interface.h and mc_ignore.h to .hpp.

3 years agoRemove unneeded extern "C".
Arnaud Giersch [Mon, 16 Apr 2018 09:29:14 +0000 (11:29 +0200)]
Remove unneeded extern "C".

3 years agoRemove old and unclear todo comment.
Arnaud Giersch [Mon, 16 Apr 2018 09:19:25 +0000 (11:19 +0200)]
Remove old and unclear todo comment.

3 years ago[INSTR] Move enum instr_fmt_type_t to enum class TraceFormat
Christian Heinrich [Mon, 16 Apr 2018 11:47:51 +0000 (13:47 +0200)]
[INSTR] Move enum instr_fmt_type_t to enum class TraceFormat

3 years ago[INSTR] Remove 'extern C' from instr_private.hpp
Christian Heinrich [Mon, 16 Apr 2018 09:01:52 +0000 (11:01 +0200)]
[INSTR] Remove 'extern C' from instr_private.hpp

3 years agorefactor
Frederic Suter [Mon, 16 Apr 2018 10:18:41 +0000 (12:18 +0200)]
refactor

3 years agoFix potential buffer overflow.
Arnaud Giersch [Mon, 16 Apr 2018 08:29:49 +0000 (10:29 +0200)]
Fix potential buffer overflow.

3 years agoRemove superfluous indirection.
Arnaud Giersch [Mon, 16 Apr 2018 08:18:02 +0000 (10:18 +0200)]
Remove superfluous indirection.

3 years agoUse a reference instead of a pointer.
Arnaud Giersch [Sun, 15 Apr 2018 19:29:38 +0000 (21:29 +0200)]
Use a reference instead of a pointer.

Define req_storage when it's needed.

3 years agoIncrease test timeout when using tsan.
Arnaud Giersch [Sat, 14 Apr 2018 13:29:50 +0000 (15:29 +0200)]
Increase test timeout when using tsan.

3 years agoTODO-- ;)
Arnaud Giersch [Fri, 13 Apr 2018 20:59:53 +0000 (22:59 +0200)]
TODO-- ;)

3 years agoReindent.
Arnaud Giersch [Fri, 13 Apr 2018 20:55:30 +0000 (22:55 +0200)]
Reindent.

3 years agoPlease sonar: promote struct to class.
Arnaud Giersch [Fri, 13 Apr 2018 20:55:30 +0000 (22:55 +0200)]
Please sonar: promote struct to class.

3 years agoUnused.
Arnaud Giersch [Fri, 13 Apr 2018 20:55:30 +0000 (22:55 +0200)]
Unused.

3 years agoAdd explicit qualifier.
Arnaud Giersch [Fri, 13 Apr 2018 20:55:30 +0000 (22:55 +0200)]
Add explicit qualifier.

3 years agoMake member variable private (sonar).
Arnaud Giersch [Fri, 13 Apr 2018 20:55:30 +0000 (22:55 +0200)]
Make member variable private (sonar).

3 years agoUseless extern "C".
Arnaud Giersch [Fri, 13 Apr 2018 20:55:30 +0000 (22:55 +0200)]
Useless extern "C".

3 years agoChange "extern" for "XBT_PUBLIC_DATA".
Arnaud Giersch [Fri, 13 Apr 2018 20:55:30 +0000 (22:55 +0200)]
Change "extern" for "XBT_PUBLIC_DATA".

3 years agouse timestamps with precision in container creation/destruction too
Frederic Suter [Mon, 16 Apr 2018 08:09:12 +0000 (10:09 +0200)]
use timestamps with precision in container creation/destruction too

3 years agoplease sonar and simplify
Frederic Suter [Mon, 16 Apr 2018 07:26:23 +0000 (09:26 +0200)]
please sonar and simplify

3 years agoassume that timestamps are always double
Frederic Suter [Mon, 16 Apr 2018 07:25:11 +0000 (09:25 +0200)]
assume that timestamps are always double
0 is not an exception and will be trace with the same precision

3 years agopainful typo(s)
Martin Quinson [Sun, 15 Apr 2018 22:23:11 +0000 (00:23 +0200)]
painful typo(s)

3 years agostart modernizing ConditionVariableImpl
Martin Quinson [Sun, 15 Apr 2018 21:01:40 +0000 (23:01 +0200)]
start modernizing ConditionVariableImpl

3 years agoSeparate ConditionVariableImpl into its own files
Martin Quinson [Sun, 15 Apr 2018 19:56:19 +0000 (21:56 +0200)]
Separate ConditionVariableImpl into its own files

First step toward modernity in this area.
That's a detour while snake_casing s4u::ConditionVariable :(

3 years agoinline s4u/forward.hpp to its only include location
Martin Quinson [Sat, 14 Apr 2018 20:10:53 +0000 (22:10 +0200)]
inline s4u/forward.hpp to its only include location

3 years agomake sure that simgrid/s4u/forward.hpp is loaded from only one file
Martin Quinson [Fri, 13 Apr 2018 21:14:41 +0000 (23:14 +0200)]
make sure that simgrid/s4u/forward.hpp is loaded from only one file

3 years agojenkins: also install MC builds, somewhere else
Martin Quinson [Fri, 13 Apr 2018 19:58:41 +0000 (21:58 +0200)]
jenkins: also install MC builds, somewhere else

3 years agoalign the doc with the code
Martin Quinson [Fri, 13 Apr 2018 09:36:05 +0000 (11:36 +0200)]
align the doc with the code

3 years ago[SMPI] Replay: Clear all requests after waitall
Christian Heinrich [Fri, 13 Apr 2018 14:41:11 +0000 (16:41 +0200)]
[SMPI] Replay: Clear all requests after waitall

3 years agothat was fixed locally, shouldn't have been able to push...
degomme [Fri, 13 Apr 2018 12:06:31 +0000 (14:06 +0200)]
that was fixed locally, shouldn't have been able to push...

3 years agohandle MPI_IN_PLACE for MPI_Scan
degomme [Fri, 13 Apr 2018 11:52:49 +0000 (13:52 +0200)]
handle MPI_IN_PLACE for MPI_Scan

3 years agoDisable mpich3 testsuite for mc builds. Save some bears.
degomme [Fri, 13 Apr 2018 11:45:14 +0000 (13:45 +0200)]
Disable mpich3 testsuite for mc builds. Save some bears.

3 years agosomehow one allgather algorithn was forgotten in tests
degomme [Fri, 13 Apr 2018 09:22:55 +0000 (11:22 +0200)]
somehow one allgather algorithn was forgotten in tests

3 years agoMake protected field const (sonar).
Arnaud Giersch [Thu, 12 Apr 2018 21:03:47 +0000 (23:03 +0200)]
Make protected field const (sonar).

3 years agoKill unused DynarRange; move newDeleteDynar() in dynar.h.
Arnaud Giersch [Thu, 12 Apr 2018 20:00:22 +0000 (22:00 +0200)]
Kill unused DynarRange; move newDeleteDynar() in dynar.h.

3 years agoKill unused exception class.
Arnaud Giersch [Thu, 12 Apr 2018 16:26:31 +0000 (18:26 +0200)]
Kill unused exception class.

3 years agoC exceptions are gone. Simplify the code.
Arnaud Giersch [Thu, 12 Apr 2018 14:59:26 +0000 (16:59 +0200)]
C exceptions are gone. Simplify the code.

3 years agoPlease cppcheck.
Arnaud Giersch [Thu, 12 Apr 2018 14:31:57 +0000 (16:31 +0200)]
Please cppcheck.

Partially reverts commit 54c3a9078274046acfa14099061c6fa1a9195723.

3 years ago[SMPI] Replay: Remove old functions / datatype
Christian Heinrich [Fri, 13 Apr 2018 08:15:43 +0000 (10:15 +0200)]
[SMPI] Replay: Remove old functions / datatype

3 years ago[SMPI] Replay: Move replay_init to the RequestStore
Christian Heinrich [Fri, 13 Apr 2018 08:15:03 +0000 (10:15 +0200)]
[SMPI] Replay: Move replay_init to the RequestStore

3 years ago[SMPI] Replay: Move WaitAllAction to the RequestStore
Christian Heinrich [Fri, 13 Apr 2018 08:13:46 +0000 (10:13 +0200)]
[SMPI] Replay: Move WaitAllAction to the RequestStore

3 years ago[SMPI] Replay: Move TestAction to the RequestStore
Christian Heinrich [Fri, 13 Apr 2018 08:12:35 +0000 (10:12 +0200)]
[SMPI] Replay: Move TestAction to the RequestStore

3 years ago[SMPI] Replay: Move SendAction + RecvAction to the RequestStore
Christian Heinrich [Fri, 13 Apr 2018 08:11:54 +0000 (10:11 +0200)]
[SMPI] Replay: Move SendAction + RecvAction to the RequestStore

3 years ago[SMPI] Replay: Move ActionWait to the RequestStore
Christian Heinrich [Fri, 13 Apr 2018 08:08:59 +0000 (10:08 +0200)]
[SMPI] Replay: Move ActionWait to the RequestStore

3 years ago[SMPI] Replay: Pass storage obj to actions (but don't use it yet)
Christian Heinrich [Fri, 13 Apr 2018 08:01:21 +0000 (10:01 +0200)]
[SMPI] Replay: Pass storage obj to actions (but don't use it yet)

The code that will use this will be in one of the next commits

3 years ago[SMPI] Replay: Add typedefs
Christian Heinrich [Fri, 13 Apr 2018 07:59:24 +0000 (09:59 +0200)]
[SMPI] Replay: Add typedefs

3 years ago[SMPI] Replay: Use MPI_REQUEST_NULL instead of nullptr
Christian Heinrich [Fri, 13 Apr 2018 07:56:18 +0000 (09:56 +0200)]
[SMPI] Replay: Use MPI_REQUEST_NULL instead of nullptr

3 years ago[SMPI] Replay: Added class RequestStorage (but not yet in use)
Christian Heinrich [Fri, 13 Apr 2018 07:48:09 +0000 (09:48 +0200)]
[SMPI] Replay: Added class RequestStorage (but not yet in use)

3 years ago[SMPI] Replay: Introduce and use WaitTestParser
Christian Heinrich [Fri, 13 Apr 2018 07:29:59 +0000 (09:29 +0200)]
[SMPI] Replay: Introduce and use WaitTestParser

3 years ago[SMPI] Add code to support std::tuple for std::unordered_map
Christian Heinrich [Fri, 13 Apr 2018 07:26:54 +0000 (09:26 +0200)]
[SMPI] Add code to support std::tuple for std::unordered_map

This is currently in the replay file because it's only needed there.
I hope that a better solution can be proposed (or we should move
this to a header file).

The reason for adding this code here is that it will be used in
future commits (for identifying replay send/recv actions through
triplets, (src,dst,tag)).

This commit has been split from others to make the commits smaller.

3 years ago[S4U] Remove the const for now
Christian Heinrich [Thu, 12 Apr 2018 09:07:01 +0000 (11:07 +0200)]
[S4U] Remove the const for now

Won't compile otherwise, because we need to move other functions
to be const as well and to return const values.

3 years ago[SMPI] Request: Be more verbose when wrong refcount occurs
Christian Heinrich [Thu, 12 Apr 2018 09:04:55 +0000 (11:04 +0200)]
[SMPI] Request: Be more verbose when wrong refcount occurs

3 years ago[SMPI] Replay: Cosmetics. (Align '\' in a macro)
Christian Heinrich [Tue, 10 Apr 2018 06:28:56 +0000 (08:28 +0200)]
[SMPI] Replay: Cosmetics. (Align '\' in a macro)

3 years ago[ChangeLog] Updated SMPI/Replay part.
Christian Heinrich [Tue, 10 Apr 2018 06:14:01 +0000 (08:14 +0200)]
[ChangeLog] Updated SMPI/Replay part.

3 years ago[S4U] Make s4u::Host::get_actor_count() available
Christian Heinrich [Tue, 10 Apr 2018 06:05:20 +0000 (08:05 +0200)]
[S4U] Make s4u::Host::get_actor_count() available

This function returns the number of actors that are running
on that specific host.

3 years agocosmetics and brain overload
Frederic Suter [Thu, 12 Apr 2018 13:21:56 +0000 (15:21 +0200)]
cosmetics and brain overload

3 years agoreindent
Frederic Suter [Thu, 12 Apr 2018 13:20:30 +0000 (15:20 +0200)]
reindent

3 years agoFix mingw builds (?)
Arnaud Giersch [Thu, 12 Apr 2018 11:05:48 +0000 (13:05 +0200)]
Fix mingw builds (?)

3 years agoactivate some tests for cancel
degomme [Thu, 12 Apr 2018 10:27:04 +0000 (12:27 +0200)]
activate some tests for cancel

3 years agoBasic implementation of MPI_Cancel
degomme [Thu, 12 Apr 2018 10:26:25 +0000 (12:26 +0200)]
Basic implementation of MPI_Cancel

3 years agofix boost-context builds
Martin Quinson [Thu, 12 Apr 2018 09:52:15 +0000 (11:52 +0200)]
fix boost-context builds

3 years agofurther cut include files
Martin Quinson [Wed, 11 Apr 2018 07:21:16 +0000 (09:21 +0200)]
further cut include files

3 years agosnake_case s4u::Comm
Martin Quinson [Tue, 10 Apr 2018 22:27:03 +0000 (00:27 +0200)]
snake_case s4u::Comm

3 years agoExclude preexisting region when computing smpi_data_exe_size.
Arnaud Giersch [Wed, 11 Apr 2018 20:38:31 +0000 (22:38 +0200)]
Exclude preexisting region when computing smpi_data_exe_size.

The goal is to fix thread context+mmap privatization errors seen under Tsan.

3 years agoRemove unused constant; change const for constexpr.
Arnaud Giersch [Wed, 11 Apr 2018 20:06:56 +0000 (22:06 +0200)]
Remove unused constant; change const for constexpr.

3 years agoMake function static.
Arnaud Giersch [Wed, 11 Apr 2018 20:03:51 +0000 (22:03 +0200)]
Make function static.

3 years agosmpi/priv: backup global memory segment at a better place.
Arnaud Giersch [Wed, 11 Apr 2018 16:45:38 +0000 (18:45 +0200)]
smpi/priv: backup global memory segment at a better place.

3 years agoCosmetics.
Arnaud Giersch [Wed, 11 Apr 2018 16:28:32 +0000 (18:28 +0200)]
Cosmetics.

3 years agoFix scan-build warning (link may be null).
Arnaud Giersch [Tue, 10 Apr 2018 09:56:32 +0000 (11:56 +0200)]
Fix scan-build warning (link may be null).

3 years agoCosmetics: rename tests with context factory at the end of the name.
Arnaud Giersch [Tue, 10 Apr 2018 10:20:45 +0000 (12:20 +0200)]
Cosmetics: rename tests with context factory at the end of the name.

3 years agobasic implem of MPI_Win_allocate_shared, MPI_Win_shared_query, MPI_Comm_split_type
degomme [Wed, 11 Apr 2018 20:05:58 +0000 (22:05 +0200)]
basic implem of MPI_Win_allocate_shared, MPI_Win_shared_query, MPI_Comm_split_type

3 years agofurther snake_case s4u::Actor
Martin Quinson [Tue, 10 Apr 2018 21:59:57 +0000 (23:59 +0200)]
further snake_case s4u::Actor

3 years agoonly test for these on non-root processes
Augustin Degomme [Tue, 10 Apr 2018 18:21:37 +0000 (20:21 +0200)]
only test for these on non-root processes

3 years agofix java builds, sorry
Martin Quinson [Mon, 9 Apr 2018 21:17:36 +0000 (23:17 +0200)]
fix java builds, sorry

3 years agoTODO++ in the documentation
Martin Quinson [Mon, 9 Apr 2018 20:33:17 +0000 (22:33 +0200)]
TODO++ in the documentation

3 years agofurther snake_case Actor (::this_actor remains)
Martin Quinson [Mon, 9 Apr 2018 20:24:19 +0000 (22:24 +0200)]
further snake_case Actor (::this_actor remains)

3 years agoFix tesh for smpi-replay.
Arnaud Giersch [Mon, 9 Apr 2018 15:48:05 +0000 (17:48 +0200)]
Fix tesh for smpi-replay.

3 years agoReduce code duplication.
Arnaud Giersch [Mon, 9 Apr 2018 13:33:03 +0000 (15:33 +0200)]
Reduce code duplication.

3 years agoRemove indentation (sonar).
Arnaud Giersch [Mon, 9 Apr 2018 13:23:01 +0000 (15:23 +0200)]
Remove indentation (sonar).

3 years agos/free/xbt_free/ and hope to hide bogus report from codacy.
Arnaud Giersch [Mon, 9 Apr 2018 13:18:49 +0000 (15:18 +0200)]
s/free/xbt_free/ and hope to hide bogus report from codacy.

3 years agoRewrite without delegated constructor.
Arnaud Giersch [Mon, 9 Apr 2018 13:11:19 +0000 (15:11 +0200)]
Rewrite without delegated constructor.

Cppcheck (codacy) gives false positive about address_ being uninitialized.

3 years agoCheck return value of MSG_task_isend_internal (codacy).
Arnaud Giersch [Mon, 9 Apr 2018 12:27:23 +0000 (14:27 +0200)]
Check return value of MSG_task_isend_internal (codacy).

3 years agoRemove redundant assignment (value enforced by previous call to xbt_assert).
Arnaud Giersch [Mon, 9 Apr 2018 12:08:57 +0000 (14:08 +0200)]
Remove redundant assignment (value enforced by previous call to xbt_assert).

3 years agoMSG_action* have been removed.
Arnaud Giersch [Sun, 8 Apr 2018 22:07:48 +0000 (00:07 +0200)]
MSG_action* have been removed.

3 years ago[TESTS] Included tags in tests and traces
Christian Heinrich [Mon, 9 Apr 2018 12:43:39 +0000 (14:43 +0200)]
[TESTS] Included tags in tests and traces

3 years ago[SMPI] Added a FIXME for a weird hardcoded value
Christian Heinrich [Mon, 9 Apr 2018 12:41:58 +0000 (14:41 +0200)]
[SMPI] Added a FIXME for a weird hardcoded value

3 years ago[SMPI] Replay: Enable usage of tags
Christian Heinrich [Fri, 30 Mar 2018 15:19:24 +0000 (17:19 +0200)]
[SMPI] Replay: Enable usage of tags

With this commit, tags of messages sent through the MPI Send/Recv
mechanism(s) are recorded in traces and also used when replayed.

This allows SimGrid to replay also more complex scenarios.

Tests and traces will be adjusted in a separate commit to prevent
this commit from being bloated. (This means, however, that the
smpi-replay tests will fail in this commit.)

3 years ago[SMPI] Add 'tag' parameter for instr::Pt2PtTI class
Christian Heinrich [Fri, 30 Mar 2018 15:11:29 +0000 (17:11 +0200)]
[SMPI] Add 'tag' parameter for instr::Pt2PtTI class

3 years ago[SMPI] Replay: Make error message more verbose
Christian Heinrich [Fri, 30 Mar 2018 09:15:29 +0000 (11:15 +0200)]
[SMPI] Replay: Make error message more verbose

3 years agoUse const references to pass vector as parameters.
Arnaud Giersch [Sun, 8 Apr 2018 21:16:23 +0000 (23:16 +0200)]
Use const references to pass vector as parameters.

3 years agoUpdate copyright headers.
Arnaud Giersch [Sun, 8 Apr 2018 20:45:26 +0000 (22:45 +0200)]
Update copyright headers.

Simplify year ranges; end by 2018.
Starting year was kept as-is. Shall it be changed to 2003?

3 years agoDelete copy assignment operator when copy constructor is already deleted.
Arnaud Giersch [Sun, 8 Apr 2018 20:21:37 +0000 (22:21 +0200)]
Delete copy assignment operator when copy constructor is already deleted.

3 years agoFix old typo: CpuTiTgmr -> CpuTiTmgr.
Arnaud Giersch [Sun, 8 Apr 2018 20:11:28 +0000 (22:11 +0200)]
Fix old typo: CpuTiTgmr -> CpuTiTmgr.

3 years agoDisable unused copy constructors (and please cppcheck).
Arnaud Giersch [Sun, 8 Apr 2018 19:58:31 +0000 (21:58 +0200)]
Disable unused copy constructors (and please cppcheck).

3 years agoAvoid multiple initializations for active_processes.
Arnaud Giersch [Sun, 8 Apr 2018 16:58:13 +0000 (18:58 +0200)]
Avoid multiple initializations for active_processes.

Fixes a memory leak seen with smpi-replay-multiple
(smpi_free_replay_tmp_buffers() was not called).

3 years agoRemove option -o for uname, which is not supported on Darwin.
Arnaud Giersch [Sat, 7 Apr 2018 15:01:18 +0000 (17:01 +0200)]
Remove option -o for uname, which is not supported on Darwin.

3 years agoWe use nowadays standard C++ exceptions. No need to test them.
Arnaud Giersch [Sat, 7 Apr 2018 12:25:52 +0000 (14:25 +0200)]
We use nowadays standard C++ exceptions. No need to test them.

3 years agoFix format string.
Arnaud Giersch [Sat, 7 Apr 2018 12:18:18 +0000 (14:18 +0200)]
Fix format string.

3 years agostart snake_casing s4u::Actor
Martin Quinson [Sun, 8 Apr 2018 20:32:26 +0000 (22:32 +0200)]
start snake_casing s4u::Actor