Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
4 years ago[sonar] Constify pointer and reference parameters in src/surf/.
Arnaud Giersch [Sun, 29 Dec 2019 22:37:48 +0000 (23:37 +0100)]
[sonar] Constify pointer and reference parameters in src/surf/.

4 years ago[sonar] Constify pointer and reference parameters in src/smpi/.
Arnaud Giersch [Sun, 29 Dec 2019 20:56:46 +0000 (21:56 +0100)]
[sonar] Constify pointer and reference parameters in src/smpi/.

4 years ago[sonar] Constify pointer and reference parameters in src/simdag/.
Arnaud Giersch [Sun, 29 Dec 2019 20:24:48 +0000 (21:24 +0100)]
[sonar] Constify pointer and reference parameters in src/simdag/.

4 years ago[sonar] Constify pointer and reference parameters in src/s4u/.
Arnaud Giersch [Sun, 29 Dec 2019 11:43:14 +0000 (12:43 +0100)]
[sonar] Constify pointer and reference parameters in src/s4u/.

This commit is too big, but it's too late to split it :(

4 years agoSonar consts of the day.
Arnaud Giersch [Sun, 29 Dec 2019 08:31:38 +0000 (09:31 +0100)]
Sonar consts of the day.

4 years ago[sonar] Ignore cpp:S995 for src/smpi/bindings/.
Arnaud Giersch [Sat, 28 Dec 2019 22:47:44 +0000 (23:47 +0100)]
[sonar] Ignore cpp:S995 for src/smpi/bindings/.

4 years ago[sonar] Constify pointer and reference parameters in src/plugins/.
Arnaud Giersch [Sat, 28 Dec 2019 22:02:11 +0000 (23:02 +0100)]
[sonar] Constify pointer and reference parameters in src/plugins/.

4 years ago[sonar] Constify pointer parameters in src/msg/.
Arnaud Giersch [Sat, 28 Dec 2019 21:51:55 +0000 (22:51 +0100)]
[sonar] Constify pointer parameters in src/msg/.

4 years ago[sonar] Constify pointer and reference parameters in src/mc/.
Arnaud Giersch [Sat, 28 Dec 2019 13:11:19 +0000 (14:11 +0100)]
[sonar] Constify pointer and reference parameters in src/mc/.

4 years ago[sonar] More const for pointer and reference local variables and parameters.
Arnaud Giersch [Sat, 28 Dec 2019 10:28:59 +0000 (11:28 +0100)]
[sonar] More const for pointer and reference local variables and parameters.

4 years agoCosmetics: use 's_xbt_mheap_t' instead of 'struct mdesc'.
Arnaud Giersch [Sat, 28 Dec 2019 13:44:26 +0000 (14:44 +0100)]
Cosmetics: use 's_xbt_mheap_t' instead of 'struct mdesc'.

4 years agoKill unused code.
Arnaud Giersch [Sat, 28 Dec 2019 10:51:07 +0000 (11:51 +0100)]
Kill unused code.

4 years ago[sonar] Constify pointer and reference parameters in src/kernel/.
Arnaud Giersch [Fri, 27 Dec 2019 22:45:30 +0000 (23:45 +0100)]
[sonar] Constify pointer and reference parameters in src/kernel/.

4 years ago[sonar] Constify pointer and reference parameters in src/instr/.
Arnaud Giersch [Fri, 27 Dec 2019 22:19:09 +0000 (23:19 +0100)]
[sonar] Constify pointer and reference parameters in src/instr/.

4 years ago[sonar] Constify pointer and reference parameters in src/bindings/.
Arnaud Giersch [Fri, 27 Dec 2019 21:52:03 +0000 (22:52 +0100)]
[sonar] Constify pointer and reference parameters in src/bindings/.

4 years ago[sonar] Constify pointer and reference parameters in dicts and dynars.
Arnaud Giersch [Fri, 27 Dec 2019 16:59:21 +0000 (17:59 +0100)]
[sonar] Constify pointer and reference parameters in dicts and dynars.

4 years ago[sonar] Constify pointer and reference parameters in examples/deprecated/.
Arnaud Giersch [Fri, 27 Dec 2019 16:30:51 +0000 (17:30 +0100)]
[sonar] Constify pointer and reference parameters in examples/deprecated/.

4 years ago[sonar] Constify pointer and reference parameters in examples/.
Arnaud Giersch [Fri, 27 Dec 2019 16:09:41 +0000 (17:09 +0100)]
[sonar] Constify pointer and reference parameters in examples/.

4 years agoUse type bool for boolean variables in smpi::Comm too.
Arnaud Giersch [Thu, 26 Dec 2019 23:00:36 +0000 (00:00 +0100)]
Use type bool for boolean variables in smpi::Comm too.

Don't touch members is_blocked_ and is_uniform_ which are used by MPI
communications with type MPI_INT.

4 years agoUse type bool for boolean variables in smpi/colls/.
Arnaud Giersch [Thu, 26 Dec 2019 22:59:49 +0000 (23:59 +0100)]
Use type bool for boolean variables in smpi/colls/.

4 years agoUse type jboolean for boolean variables.
Arnaud Giersch [Thu, 26 Dec 2019 13:33:22 +0000 (14:33 +0100)]
Use type jboolean for boolean variables.

4 years agoUse type bool for boolean variables.
Arnaud Giersch [Thu, 26 Dec 2019 13:38:47 +0000 (14:38 +0100)]
Use type bool for boolean variables.

4 years agoField is not used (and apparently has never been used).
Arnaud Giersch [Thu, 26 Dec 2019 11:45:19 +0000 (12:45 +0100)]
Field is not used (and apparently has never been used).

4 years ago[sonar] Don't remove const qualification with cast.
Arnaud Giersch [Thu, 26 Dec 2019 23:32:16 +0000 (00:32 +0100)]
[sonar] Don't remove const qualification with cast.

4 years ago[sonar] A few more const local pointers.
Arnaud Giersch [Thu, 26 Dec 2019 16:40:24 +0000 (17:40 +0100)]
[sonar] A few more const local pointers.

4 years agoRestore explicitely defined constructor (with empty body).
Arnaud Giersch [Thu, 26 Dec 2019 10:50:41 +0000 (11:50 +0100)]
Restore explicitely defined constructor (with empty body).

It seems to make a difference on freebsd with clang 10.

4 years agoHost may be null (fix crash with logs).
Arnaud Giersch [Wed, 25 Dec 2019 21:29:51 +0000 (22:29 +0100)]
Host may be null (fix crash with logs).

4 years ago[sonar] Constify pointer and reference local variables in examples/.
Arnaud Giersch [Mon, 23 Dec 2019 23:16:01 +0000 (00:16 +0100)]
[sonar] Constify pointer and reference local variables in examples/.

4 years ago[sonar] Constify pointer and reference local variables in src/bindings/.
Arnaud Giersch [Mon, 23 Dec 2019 23:02:38 +0000 (00:02 +0100)]
[sonar] Constify pointer and reference local variables in src/bindings/.

4 years ago[sonar] Constify pointer and reference local variables in src/instr/.
Arnaud Giersch [Mon, 23 Dec 2019 22:53:17 +0000 (23:53 +0100)]
[sonar] Constify pointer and reference local variables in src/instr/.

4 years ago[sonar] Constify pointer and reference local variables in src/kernel/.
Arnaud Giersch [Mon, 23 Dec 2019 22:46:44 +0000 (23:46 +0100)]
[sonar] Constify pointer and reference local variables in src/kernel/.

4 years ago[sonar] Constify pointer and reference local variables in src/mc/.
Arnaud Giersch [Mon, 23 Dec 2019 22:31:57 +0000 (23:31 +0100)]
[sonar] Constify pointer and reference local variables in src/mc/.

4 years ago[sonar] Constify pointer and reference local variables in src/plugins/.
Arnaud Giersch [Mon, 23 Dec 2019 22:07:00 +0000 (23:07 +0100)]
[sonar] Constify pointer and reference local variables in src/plugins/.

4 years ago[sonar] Constify pointer and reference local variables in src/s4u/.
Arnaud Giersch [Mon, 23 Dec 2019 22:02:40 +0000 (23:02 +0100)]
[sonar] Constify pointer and reference local variables in src/s4u/.

4 years ago[sonar] Constify pointer and reference local variables in src/simdag/.
Arnaud Giersch [Mon, 23 Dec 2019 21:59:04 +0000 (22:59 +0100)]
[sonar] Constify pointer and reference local variables in src/simdag/.

4 years ago[sonar] Constify pointer and reference local variables in src/simix/.
Arnaud Giersch [Mon, 23 Dec 2019 21:56:35 +0000 (22:56 +0100)]
[sonar] Constify pointer and reference local variables in src/simix/.

4 years ago[sonar] Constify pointer and reference local variables in src/smpi/.
Arnaud Giersch [Mon, 23 Dec 2019 21:47:37 +0000 (22:47 +0100)]
[sonar] Constify pointer and reference local variables in src/smpi/.

4 years ago[sonar] Constify pointer and reference local variables in src/surf/.
Arnaud Giersch [Mon, 23 Dec 2019 21:24:24 +0000 (22:24 +0100)]
[sonar] Constify pointer and reference local variables in src/surf/.

4 years ago[sonar] Constify pointer and reference local variables in src/xbt/.
Arnaud Giersch [Mon, 23 Dec 2019 21:09:47 +0000 (22:09 +0100)]
[sonar] Constify pointer and reference local variables in src/xbt/.

4 years ago[sonar] Constify pointer and reference local variables in teshsuite/.
Arnaud Giersch [Mon, 23 Dec 2019 20:56:43 +0000 (21:56 +0100)]
[sonar] Constify pointer and reference local variables in teshsuite/.

4 years agoKill no-op.
Arnaud Giersch [Mon, 23 Dec 2019 21:55:16 +0000 (22:55 +0100)]
Kill no-op.

4 years agoDefault ctor is good enough.
Arnaud Giersch [Mon, 23 Dec 2019 18:04:54 +0000 (19:04 +0100)]
Default ctor is good enough.

4 years agoUnused code.
Arnaud Giersch [Mon, 23 Dec 2019 17:55:18 +0000 (18:55 +0100)]
Unused code.

4 years agoSmall cleanups in parmap.hpp.
Arnaud Giersch [Mon, 23 Dec 2019 14:22:33 +0000 (15:22 +0100)]
Small cleanups in parmap.hpp.

4 years agoVarious docs update
Martin Quinson [Sun, 22 Dec 2019 17:32:36 +0000 (18:32 +0100)]
Various docs update

- Change the introduction on Routing to make it more self-contained.
- Move the Routing part to a specific page, as it's an advanced topic about platforms.
- Fix the formating of some examples
- Fix the formating of \beginrst blocks in doxygen
- Document the <disk> tag a bit, as well as the filesystem plugin
- Remove the doc about storage from the doxygen doc to be converted

- Document Engine with autodoxy
- Document the C API of Engine and Actor

- Teach autodoxy to produce the doc of C functions (that don't have '::' in their name)
- Teach find_missing to rant about undocumented C functions

4 years agodocs: dupplicate platform examples in the right section
Martin Quinson [Sun, 22 Dec 2019 17:17:14 +0000 (18:17 +0100)]
docs: dupplicate platform examples in the right section

4 years agoMerge branch 'master' of framagit.org:simgrid/simgrid
Arnaud Giersch [Mon, 23 Dec 2019 13:55:49 +0000 (14:55 +0100)]
Merge branch 'master' of framagit.org:simgrid/simgrid

4 years ago[sonar] Initialize data members with class initializers, or initialization lists.
Arnaud Giersch [Sun, 22 Dec 2019 20:43:59 +0000 (21:43 +0100)]
[sonar] Initialize data members with class initializers, or initialization lists.

4 years agoCosmetics: use empty parentheses for new std::container.
Arnaud Giersch [Mon, 23 Dec 2019 13:39:27 +0000 (14:39 +0100)]
Cosmetics: use empty parentheses for new std::container.

4 years ago[sonar] initialization lists and co.
Frederic Suter [Mon, 23 Dec 2019 13:08:29 +0000 (14:08 +0100)]
[sonar] initialization lists and co.

4 years agoKill useless field 'parallel_' in context factories.
Arnaud Giersch [Sun, 22 Dec 2019 22:45:08 +0000 (23:45 +0100)]
Kill useless field 'parallel_' in context factories.

4 years agoObey coding standard for the field names in mc:State.
Arnaud Giersch [Sun, 22 Dec 2019 22:02:38 +0000 (23:02 +0100)]
Obey coding standard for the field names in mc:State.

4 years agoEnsure xbt_new0 is called with a size > 0.
Arnaud Giersch [Sun, 22 Dec 2019 17:10:37 +0000 (18:10 +0100)]
Ensure xbt_new0 is called with a size > 0.

4 years agoKill dead code.
Arnaud Giersch [Sun, 22 Dec 2019 16:27:30 +0000 (17:27 +0100)]
Kill dead code.

4 years ago[sonar] This is still ot a forwarding reference.
Arnaud Giersch [Sun, 22 Dec 2019 15:45:41 +0000 (16:45 +0100)]
[sonar] This is still ot a forwarding reference.

See https://rules.sonarsource.com/cpp/RSPEC-5417 ;
completes commit a96793ec8c496eec19daf68f3aa0c4eded2ea166.

I hope it's correct this time.

4 years agoKill unused includes, and put the remaining ones at the top of the file.
Arnaud Giersch [Sat, 21 Dec 2019 20:33:05 +0000 (21:33 +0100)]
Kill unused includes, and put the remaining ones at the top of the file.

4 years ago[sonar] Use a RAII idiom instead of calling lock() explicitely.
Arnaud Giersch [Sat, 21 Dec 2019 14:55:59 +0000 (15:55 +0100)]
[sonar] Use a RAII idiom instead of calling lock() explicitely.

4 years agoEnsure malloc is not called with a size of 0.
Arnaud Giersch [Fri, 20 Dec 2019 22:57:22 +0000 (23:57 +0100)]
Ensure malloc is not called with a size of 0.

4 years ago[sonar] Fix casts to pointer type without const qualifier.
Arnaud Giersch [Fri, 20 Dec 2019 21:58:48 +0000 (22:58 +0100)]
[sonar] Fix casts to pointer type without const qualifier.

4 years agoFix prototype, and use boolean operators.
Arnaud Giersch [Fri, 20 Dec 2019 22:08:14 +0000 (23:08 +0100)]
Fix prototype, and use boolean operators.

4 years ago[sonar] "std::forward" should only be called on a forwarding reference.
Arnaud Giersch [Fri, 20 Dec 2019 21:20:07 +0000 (22:20 +0100)]
[sonar] "std::forward" should only be called on a forwarding reference.

4 years ago[sonar] A single statement should not have more than one resource allocation.
Arnaud Giersch [Fri, 20 Dec 2019 21:05:03 +0000 (22:05 +0100)]
[sonar] A single statement should not have more than one resource allocation.

4 years agoBe less verbose.
Arnaud Giersch [Fri, 20 Dec 2019 14:41:49 +0000 (15:41 +0100)]
Be less verbose.

The job exceeded the maximum log length...

4 years agoCmake commands are redundant with root CMakeLists.txt.
Arnaud Giersch [Wed, 18 Dec 2019 16:51:32 +0000 (17:51 +0100)]
Cmake commands are redundant with root CMakeLists.txt.

4 years agoreorder elements in the API ref guide
Martin Quinson [Thu, 19 Dec 2019 22:14:17 +0000 (23:14 +0100)]
reorder elements in the API ref guide

4 years agoLet all smpi wrapper obey the VERBOSE variable
Martin Quinson [Thu, 19 Dec 2019 22:25:35 +0000 (23:25 +0100)]
Let all smpi wrapper obey the VERBOSE variable

When used, they display the real compilation line. That's useful in
particular on debian builders, to have BLHC inspecting the command
line parameters.

4 years agodocs: these methods were renamed recently
Martin Quinson [Thu, 19 Dec 2019 11:08:41 +0000 (12:08 +0100)]
docs: these methods were renamed recently

4 years agodocs: restore some non-breaking spaces where needed
Martin Quinson [Thu, 19 Dec 2019 07:32:17 +0000 (08:32 +0100)]
docs: restore some non-breaking spaces where needed

They are needed to show the doc hierarchy in the left navbar.

This partially reverts 6c8dd229d394fdaf20facf604f7be86a5df1e368.

4 years agodocs: try to document the dependencies
Martin Quinson [Thu, 19 Dec 2019 00:28:08 +0000 (01:28 +0100)]
docs: try to document the dependencies

4 years agocodefactor: a few more annoying spaces
Frederic Suter [Wed, 18 Dec 2019 15:22:34 +0000 (16:22 +0100)]
codefactor: a few more annoying spaces

4 years agocodefactor: build-in redefinitions
Frederic Suter [Wed, 18 Dec 2019 15:05:40 +0000 (16:05 +0100)]
codefactor: build-in redefinitions

4 years agocodefactor: reduce complexity in s4u_FileSystem.cpp
Frederic Suter [Wed, 18 Dec 2019 14:27:20 +0000 (15:27 +0100)]
codefactor: reduce complexity in s4u_FileSystem.cpp
(and use a bool when it's a boolean parameter)

4 years agofix SimGrid-FMI
Martin Quinson [Wed, 18 Dec 2019 13:56:22 +0000 (14:56 +0100)]
fix SimGrid-FMI

See https://framagit.org/simgrid/simgrid-FMI/-/jobs/636515

4 years agoStrip -f[a-z]+-prefix-map from compiler flags in smpi* scripts.
Arnaud Giersch [Wed, 18 Dec 2019 12:25:06 +0000 (13:25 +0100)]
Strip -f[a-z]+-prefix-map from compiler flags in smpi* scripts.

Ref: FG simgrid/simgrid#4 and GH #39.

4 years agouse same "main" syntax for this example as for others
Frederic Suter [Wed, 18 Dec 2019 10:12:59 +0000 (11:12 +0100)]
use same "main" syntax for this example as for others
(still not able to test python ...)

4 years agocodefactor: malformed whitespace issues
Frederic Suter [Wed, 18 Dec 2019 09:09:28 +0000 (10:09 +0100)]
codefactor: malformed whitespace issues

4 years agocodefactor: fix comparison to litteral maintainability issue
Frederic Suter [Wed, 18 Dec 2019 08:55:55 +0000 (09:55 +0100)]
codefactor: fix comparison to litteral maintainability issue

4 years agocodefactor: fix use len(Seq) to determine Seq is empty issue
Frederic Suter [Wed, 18 Dec 2019 08:53:27 +0000 (09:53 +0100)]
codefactor: fix use len(Seq) to determine Seq is empty issue

4 years agocodefactor: fix unnecessary else after return maintainability issue
Frederic Suter [Wed, 18 Dec 2019 08:31:30 +0000 (09:31 +0100)]
codefactor: fix unnecessary else after return maintainability issue

4 years agocodefactor: fix multiple statements on one line maintenability issue
Frederic Suter [Wed, 18 Dec 2019 08:20:10 +0000 (09:20 +0100)]
codefactor: fix multiple statements on one line maintenability issue

4 years agosave a vector, kill a dynar!
Frederic Suter [Tue, 17 Dec 2019 14:00:45 +0000 (15:00 +0100)]
save a vector, kill a dynar!

4 years agoanother bunch of cleanups
Frederic Suter [Tue, 17 Dec 2019 09:25:36 +0000 (10:25 +0100)]
another bunch of cleanups

4 years agoFix (#313) on Github
Frederic Suter [Tue, 17 Dec 2019 09:02:07 +0000 (10:02 +0100)]
Fix (#313) on Github

4 years agocosmetics in kernel/resource
Frederic Suter [Mon, 16 Dec 2019 09:54:53 +0000 (10:54 +0100)]
cosmetics in kernel/resource

4 years agoUse -ffile-prefix-map with gcc >= 8.0.
Arnaud Giersch [Mon, 16 Dec 2019 12:03:40 +0000 (13:03 +0100)]
Use -ffile-prefix-map with gcc >= 8.0.

See https://github.com/simgrid/simgrid/issues/39

4 years agoReduce code duplication.
Arnaud Giersch [Thu, 12 Dec 2019 21:34:17 +0000 (22:34 +0100)]
Reduce code duplication.

4 years agoMake mailbox matching functions return a bool.
Arnaud Giersch [Thu, 12 Dec 2019 20:54:17 +0000 (21:54 +0100)]
Make mailbox matching functions return a bool.

4 years agoremove an instance of namespace surf
Frederic Suter [Mon, 16 Dec 2019 09:09:18 +0000 (10:09 +0100)]
remove an instance of namespace surf

4 years agomornign cleanups
Frederic Suter [Mon, 16 Dec 2019 08:42:22 +0000 (09:42 +0100)]
mornign cleanups

4 years agodocument fixed issue GH#321
Frederic Suter [Fri, 13 Dec 2019 14:23:44 +0000 (15:23 +0100)]
document fixed issue GH#321
extend the exec-ptask example with an asynhcronous one

4 years agoyet another bunch of cleanups
Frederic Suter [Fri, 13 Dec 2019 11:29:20 +0000 (12:29 +0100)]
yet another bunch of cleanups

4 years agoend the implementation of Io::test with a new simcall
Frederic Suter [Fri, 13 Dec 2019 10:45:41 +0000 (11:45 +0100)]
end the implementation of Io::test with a new simcall

4 years agoadd waitfor of Io too
Frederic Suter [Fri, 13 Dec 2019 09:46:54 +0000 (10:46 +0100)]
add waitfor of Io too

4 years agocleanups after introduction of Exec::wait_for(timeout)
Frederic Suter [Thu, 12 Dec 2019 20:19:47 +0000 (21:19 +0100)]
cleanups after introduction of Exec::wait_for(timeout)

4 years agoimplement Exec::wait_for()
Frederic Suter [Thu, 12 Dec 2019 17:09:03 +0000 (18:09 +0100)]
implement Exec::wait_for()

4 years agoFix refcounting of smpi::Errhandler.
Arnaud Giersch [Thu, 12 Dec 2019 09:35:23 +0000 (10:35 +0100)]
Fix refcounting of smpi::Errhandler.

4 years agoFix refcounting of smpi::Info.
Arnaud Giersch [Wed, 11 Dec 2019 21:45:08 +0000 (22:45 +0100)]
Fix refcounting of smpi::Info.

4 years agoLink Topo and Comm in both directions, and fix memory leak.
Arnaud Giersch [Thu, 5 Dec 2019 15:54:08 +0000 (16:54 +0100)]
Link Topo and Comm in both directions, and fix memory leak.

4 years ago[sonar] Unused parameters.
Arnaud Giersch [Thu, 12 Dec 2019 10:35:21 +0000 (11:35 +0100)]
[sonar] Unused parameters.

4 years agoFix parameter when calling MC_assert.
Arnaud Giersch [Wed, 11 Dec 2019 21:20:41 +0000 (22:20 +0100)]
Fix parameter when calling MC_assert.

A cast to (int) is wrong with e.g. (0.2) or (1UL<<32).