Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
23 months agoCosmetics: declare graph edges with the "right" direction.
Arnaud Giersch [Tue, 17 May 2022 19:08:57 +0000 (21:08 +0200)]
Cosmetics: declare graph edges with the "right" direction.

23 months agoMerge branch 'dev-s4u-dirty-termination' into 'master'
Arnaud Giersch [Tue, 17 May 2022 19:06:59 +0000 (19:06 +0000)]
Merge branch 'dev-s4u-dirty-termination' into 'master'

Make S4u dirty termination better looking

See merge request simgrid/simgrid!97

23 months agoMake S4u dirty termination better looking
Fabien Chaix [Tue, 17 May 2022 12:12:59 +0000 (15:12 +0300)]
Make S4u dirty termination better looking

23 months agoMerge branch 'dev-fix-get-eager-activities' into 'master'
Augustin Degomme [Tue, 17 May 2022 12:27:44 +0000 (12:27 +0000)]
Merge branch 'dev-fix-get-eager-activities' into 'master'

add eager get comms to actor activities

See merge request simgrid/simgrid!96

23 months agoadd eager get comms to actor activities
Fabien Chaix [Tue, 17 May 2022 11:02:50 +0000 (14:02 +0300)]
add eager get comms to actor activities

23 months agoEnable test only on 64bits.
Arnaud Giersch [Fri, 13 May 2022 11:10:52 +0000 (13:10 +0200)]
Enable test only on 64bits.

23 months agoGive another try to test mc-bugged1-liveness-visited...
Arnaud Giersch [Fri, 13 May 2022 10:06:51 +0000 (12:06 +0200)]
Give another try to test mc-bugged1-liveness-visited...

... and see if the situation has changed since commit 73e643057a95ed6f20d6bd03bc8cd13a7042f9aa

23 months agoFix build with Eigen3 and Imtel compiler.
Arnaud Giersch [Thu, 12 May 2022 15:59:35 +0000 (17:59 +0200)]
Fix build with Eigen3 and Imtel compiler.

23 months agoRemove from CFLAGS warnings already enabled by -Wall.
Arnaud Giersch [Thu, 12 May 2022 15:51:27 +0000 (17:51 +0200)]
Remove from CFLAGS warnings already enabled by -Wall.

23 months agoRename VM signals to distinguish them from Host::on_creation/on_destruction.
Arnaud Giersch [Thu, 12 May 2022 08:43:08 +0000 (10:43 +0200)]
Rename VM signals to distinguish them from Host::on_creation/on_destruction.

23 months agoReduce scope for variables.
Arnaud Giersch [Thu, 12 May 2022 08:37:47 +0000 (10:37 +0200)]
Reduce scope for variables.

23 months agoRename variables to avoid shadowed declarations.
Arnaud Giersch [Thu, 12 May 2022 08:29:08 +0000 (10:29 +0200)]
Rename variables to avoid shadowed declarations.

23 months agoLink-load plugin: check no link exists
Bruno Donassolo [Thu, 12 May 2022 12:50:51 +0000 (14:50 +0200)]
Link-load plugin: check no link exists

Plugin must be initialized before creating any link.

23 months agoDefine duplicated function get_graph() only once, in common ancestor.
Arnaud Giersch [Tue, 10 May 2022 19:25:16 +0000 (21:25 +0200)]
Define duplicated function get_graph() only once, in common ancestor.

23 months agoMake helper functions static members of NetZoneImpl.
Arnaud Giersch [Tue, 10 May 2022 19:24:06 +0000 (21:24 +0200)]
Make helper functions static members of NetZoneImpl.

23 months agoApply last sonar-related changes to the new function platform_graph_export_csv().
Arnaud Giersch [Tue, 10 May 2022 16:59:47 +0000 (18:59 +0200)]
Apply last sonar-related changes to the new function platform_graph_export_csv().

23 months agoMerge branch 'master' into 'master'
Martin Quinson [Tue, 10 May 2022 15:52:19 +0000 (15:52 +0000)]
Merge branch 'master' into 'master'

Enhance graphicator program

See merge request simgrid/simgrid!95

23 months agoEnhance graphicator program
Tom Cornebize [Tue, 10 May 2022 15:52:19 +0000 (15:52 +0000)]
Enhance graphicator program

23 months agoPrefer \n over std::endl (no need to flush at each end-of-line).
Arnaud Giersch [Tue, 10 May 2022 15:11:09 +0000 (17:11 +0200)]
Prefer \n over std::endl (no need to flush at each end-of-line).

23 months agoUpdate generator script to match the current code.
Arnaud Giersch [Tue, 10 May 2022 11:38:43 +0000 (13:38 +0200)]
Update generator script to match the current code.

23 months agoConcatenate nested namespaces (sonar).
Arnaud Giersch [Tue, 10 May 2022 08:48:52 +0000 (10:48 +0200)]
Concatenate nested namespaces (sonar).

23 months agoRemove spurious "using" declarations.
Arnaud Giersch [Tue, 10 May 2022 08:47:36 +0000 (10:47 +0200)]
Remove spurious "using" declarations.

23 months agoApply exclusion to any file in include/ (*.h may be concerned).
Arnaud Giersch [Tue, 10 May 2022 07:21:46 +0000 (09:21 +0200)]
Apply exclusion to any file in include/ (*.h may be concerned).

23 months ago[sonar] Ignore C++17 rules in public headers, where we still support C++14.
Arnaud Giersch [Mon, 9 May 2022 19:42:15 +0000 (21:42 +0200)]
[sonar] Ignore C++17 rules in public headers, where we still support C++14.

[ci-skip]

23 months ago[sonar] IIUC, there is no need to duplicate exclusion rule.
Arnaud Giersch [Mon, 9 May 2022 19:31:59 +0000 (21:31 +0200)]
[sonar] IIUC, there is no need to duplicate exclusion rule.

[ci-skip]

23 months agoReplace const reference to std::string by std::string_view (sonar).
Arnaud Giersch [Mon, 9 May 2022 13:02:08 +0000 (15:02 +0200)]
Replace const reference to std::string by std::string_view (sonar).

23 months agoStructured binding here too.
Arnaud Giersch [Fri, 6 May 2022 07:15:25 +0000 (09:15 +0200)]
Structured binding here too.

23 months agoTest is normally always true: replace by an assert.
Arnaud Giersch [Mon, 9 May 2022 09:24:03 +0000 (11:24 +0200)]
Test is normally always true: replace by an assert.

23 months agoUse the init-statement to declare variables inside the if statement (sonar).
Arnaud Giersch [Sat, 7 May 2022 07:43:54 +0000 (09:43 +0200)]
Use the init-statement to declare variables inside the if statement (sonar).

23 months agoRemove superfluous parentheses.
Arnaud Giersch [Sat, 7 May 2022 07:20:42 +0000 (09:20 +0200)]
Remove superfluous parentheses.

23 months agoDisable bogus warning with g++: add -Wno-free-nonheap-object.
Arnaud Giersch [Fri, 6 May 2022 10:46:24 +0000 (12:46 +0200)]
Disable bogus warning with g++: add -Wno-free-nonheap-object.

Build fails on mc_dwarf.cpp with g++ 12.0.1.
This kind of error should be caught by valgrind and/or ASan anyway.

23 months agoReduce scope for temporary variables.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Reduce scope for temporary variables.

Use the init-statement to declare variables inside the if statement (sonar).

23 months agoReduce scope for static variables.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Reduce scope for static variables.

Use the init-statement to declare variables inside the if statement (sonar).

23 months agoReduce scope for variables used for dynamic_cast to subclass.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Reduce scope for variables used for dynamic_cast to subclass.

Use the init-statement to declare variables inside the if statement (sonar).

23 months agoSimplify a bit smpi_sample_* functions.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Simplify a bit smpi_sample_* functions.

* merge smpi_sample_1 and smpi_sample_2 into smpi_sample_cond
* rename smpi_sample_3 to smpi_sample_iter

23 months agoSlighly improve readbility.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Slighly improve readbility.

(and address a few sonar smells)

23 months agoSearch in map once only.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
Search in map once only.

23 months agoNo need to have two code paths.
Arnaud Giersch [Fri, 6 May 2022 08:17:57 +0000 (10:17 +0200)]
No need to have two code paths.

23 months agoNested conditional operators are not Sonar-compliant; revert previous change.
Arnaud Giersch [Wed, 4 May 2022 06:30:25 +0000 (08:30 +0200)]
Nested conditional operators are not Sonar-compliant; revert previous change.

23 months agoOops, it's stoi() for integers.
Arnaud Giersch [Wed, 4 May 2022 06:12:55 +0000 (08:12 +0200)]
Oops, it's stoi() for integers.

23 months agoKill unused variable.
Arnaud Giersch [Tue, 3 May 2022 19:56:18 +0000 (21:56 +0200)]
Kill unused variable.

23 months agoSpurious blank line.
Arnaud Giersch [Tue, 3 May 2022 19:56:07 +0000 (21:56 +0200)]
Spurious blank line.

23 months agoDeclare local variables inside the if statement.
Arnaud Giersch [Sat, 30 Apr 2022 13:08:59 +0000 (15:08 +0200)]
Declare local variables inside the if statement.

23 months agoMisc code simplifications guided by Sonar smells.
Arnaud Giersch [Sat, 30 Apr 2022 13:07:03 +0000 (15:07 +0200)]
Misc code simplifications guided by Sonar smells.

23 months agoSave an indirection for replay/action_queues.
Arnaud Giersch [Tue, 3 May 2022 19:01:36 +0000 (21:01 +0200)]
Save an indirection for replay/action_queues.

23 months agoAvoid old-style C string processing in C++ example.
Arnaud Giersch [Mon, 2 May 2022 17:27:36 +0000 (19:27 +0200)]
Avoid old-style C string processing in C++ example.

23 months ago[ci-skip] [no-ci] bigdft ci: temporary fix for nvidia key change
Augustin Degomme [Sun, 1 May 2022 20:39:53 +0000 (20:39 +0000)]
[ci-skip] [no-ci] bigdft ci: temporary fix for nvidia key change
see https://github.com/NVIDIA/nvidia-docker/issues/1631

2 years agoExplicit cast to double (sonar).
Arnaud Giersch [Thu, 28 Apr 2022 17:16:20 +0000 (19:16 +0200)]
Explicit cast to double (sonar).

2 years agoUse const references (sonar).
Arnaud Giersch [Thu, 28 Apr 2022 13:53:51 +0000 (15:53 +0200)]
Use const references (sonar).

2 years agoAdd comment for workaround.
Arnaud Giersch [Thu, 28 Apr 2022 13:50:58 +0000 (15:50 +0200)]
Add comment for workaround.

2 years agoCosmetics: gcc is now always >= 5.0.
Arnaud Giersch [Wed, 27 Apr 2022 19:58:42 +0000 (21:58 +0200)]
Cosmetics: gcc is now always >= 5.0.

2 years agoFix build with -Werror on older g++.
Arnaud Giersch [Wed, 27 Apr 2022 19:43:42 +0000 (21:43 +0200)]
Fix build with -Werror on older g++.

2 years agoUse structured binding declarations (sonar, c++17).
Arnaud Giersch [Tue, 26 Apr 2022 22:02:38 +0000 (00:02 +0200)]
Use structured binding declarations (sonar, c++17).

2 years agoDe-obfuscation.
Arnaud Giersch [Tue, 26 Apr 2022 10:58:09 +0000 (12:58 +0200)]
De-obfuscation.

2 years agoPointer-to-const (sonar).
Arnaud Giersch [Tue, 26 Apr 2022 08:03:10 +0000 (10:03 +0200)]
Pointer-to-const (sonar).

2 years agoDon't build useless temporary object (sonar, c++17).
Arnaud Giersch [Tue, 26 Apr 2022 07:55:12 +0000 (09:55 +0200)]
Don't build useless temporary object (sonar, c++17).

2 years agoReplace is_xxx::value with is_xxx_v (sonar, c++17).
Arnaud Giersch [Mon, 25 Apr 2022 13:36:20 +0000 (15:36 +0200)]
Replace is_xxx::value with is_xxx_v (sonar, c++17).

2 years agoRely on template argument deduction (sonar, c++17).
Arnaud Giersch [Mon, 25 Apr 2022 12:54:12 +0000 (14:54 +0200)]
Rely on template argument deduction (sonar, c++17).

2 years agoDefine as "constexpr".
Arnaud Giersch [Mon, 25 Apr 2022 12:28:10 +0000 (14:28 +0200)]
Define as "constexpr".

2 years agoRemaining "try_emplace" (sonar, c++!7).
Arnaud Giersch [Mon, 25 Apr 2022 13:03:11 +0000 (15:03 +0200)]
Remaining "try_emplace" (sonar, c++!7).

2 years agoPrefer using "try_emplace" (sonar, c++17).
Arnaud Giersch [Mon, 25 Apr 2022 09:43:57 +0000 (11:43 +0200)]
Prefer using "try_emplace" (sonar, c++17).

2 years agoUse std::string.
Arnaud Giersch [Mon, 25 Apr 2022 09:43:04 +0000 (11:43 +0200)]
Use std::string.

2 years agoKill redundant code.
Arnaud Giersch [Mon, 25 Apr 2022 10:16:39 +0000 (12:16 +0200)]
Kill redundant code.

2 years agoConst ref for catch.
Arnaud Giersch [Sun, 24 Apr 2022 16:39:24 +0000 (18:39 +0200)]
Const ref for catch.

2 years ago[ci-skip] Update project_description.sh
Augustin Degomme [Sat, 23 Apr 2022 15:48:57 +0000 (15:48 +0000)]
[ci-skip] Update project_description.sh

2 years agoDon't throw exception in destructor (sonar).
Arnaud Giersch [Sat, 23 Apr 2022 15:12:02 +0000 (17:12 +0200)]
Don't throw exception in destructor (sonar).

2 years ago[ci-skip] help flags build finding ns3
Augustin Degomme [Sat, 23 Apr 2022 11:15:05 +0000 (11:15 +0000)]
[ci-skip] help flags build finding ns3

2 years ago... I'm certain I tested this yesterday
Augustin Degomme [Fri, 22 Apr 2022 19:59:33 +0000 (19:59 +0000)]
... I'm certain I tested this yesterday

2 years agoUpdate network_ns3.cpp
Augustin Degomme [Fri, 22 Apr 2022 19:00:06 +0000 (19:00 +0000)]
Update network_ns3.cpp

2 years agotry to use ns3-dev on ubuntu.
Augustin Degomme [Fri, 22 Apr 2022 18:21:29 +0000 (18:21 +0000)]
try to use ns3-dev on ubuntu.

2 years agodisable LTO on the arm builder, as it is believed to be too heavy for this particular...
Augustin Degomme [Fri, 22 Apr 2022 15:38:53 +0000 (15:38 +0000)]
disable LTO on the arm builder, as it is believed to be too heavy for this particular system since c++17 upgrade

2 years agoFix some warnings in doc generation.
Arnaud Giersch [Fri, 22 Apr 2022 12:22:56 +0000 (14:22 +0200)]
Fix some warnings in doc generation.

2 years agoAlign exec-async with C++ example (also define python binding).
Arnaud Giersch [Thu, 21 Apr 2022 14:00:22 +0000 (16:00 +0200)]
Align exec-async with C++ example (also define python binding).

2 years agoType size_t for every variant of get_host_count().
Arnaud Giersch [Thu, 21 Apr 2022 08:19:59 +0000 (10:19 +0200)]
Type size_t for every variant of get_host_count().

2 years agoAdd "explicit" keyword.
Arnaud Giersch [Thu, 21 Apr 2022 08:05:08 +0000 (10:05 +0200)]
Add "explicit" keyword.

2 years agoWorkaround build error with older versions of Eigen3.
Arnaud Giersch [Fri, 22 Apr 2022 09:34:54 +0000 (11:34 +0200)]
Workaround build error with older versions of Eigen3.

Make it build on the freebsd CI node.

2 years agotry to help clang builds
Augustin Degomme [Thu, 21 Apr 2022 23:06:29 +0000 (01:06 +0200)]
try to help clang builds

2 years agobump C++ requirement to 17 (ns3 will need it for v3.26)
Augustin Degomme [Thu, 21 Apr 2022 22:40:16 +0000 (00:40 +0200)]
bump C++ requirement to 17 (ns3 will need it for v3.26)

2 years agoprepare for next NS3 release
Augustin Degomme [Thu, 21 Apr 2022 11:16:46 +0000 (13:16 +0200)]
prepare for next NS3 release

2 years agons3: allow use of -dev version from manually compiled one.
Augustin Degomme [Thu, 21 Apr 2022 11:08:40 +0000 (13:08 +0200)]
ns3: allow use of -dev version from manually compiled one.

2 years agoDisable ns3 on ubuntu until version 3.36.
Arnaud Giersch [Wed, 20 Apr 2022 13:51:20 +0000 (15:51 +0200)]
Disable ns3 on ubuntu until version 3.36.

The programs crash (sigsegv) when loading libns3.35-wifi.so

Hope that the following patch will fix that
https://gitlab.com/nsnam/ns-3-dev/-/commit/62ab4ade4215bfa91ff95eab4d5e0422e18028f0

2 years agoCosmetics: *elem is already null here.
Arnaud Giersch [Tue, 12 Apr 2022 10:00:54 +0000 (12:00 +0200)]
Cosmetics: *elem is already null here.

2 years agoSet s4u::VirtualMachine as deprecated
Bruno Donassolo [Tue, 19 Apr 2022 17:13:58 +0000 (19:13 +0200)]
Set s4u::VirtualMachine as deprecated

Use s4u::Host::create_vm instead.

Workaround to keep it working meanwhile.

2 years agoFix wrench test, use s4u method to generate the good signal.
Bruno Donassolo [Tue, 19 Apr 2022 16:09:58 +0000 (18:09 +0200)]
Fix wrench test, use s4u method to generate the good signal.

2 years agoMerge branch 'dev/s4u_tuto_fixes' into 'master'
Arnaud Giersch [Fri, 15 Apr 2022 11:33:05 +0000 (11:33 +0000)]
Merge branch 'dev/s4u_tuto_fixes' into 'master'

Dev/s4u tuto fixes

See merge request simgrid/simgrid!94

2 years agospecify in the doc that SMPI_PRETEND_CC is good for cmake too
Martin Quinson [Thu, 14 Apr 2022 08:21:05 +0000 (10:21 +0200)]
specify in the doc that SMPI_PRETEND_CC is good for cmake too

2 years agotypo
Martin Quinson [Wed, 13 Apr 2022 14:38:43 +0000 (16:38 +0200)]
typo

2 years agoPlug memleak seen by valgrind.
Arnaud Giersch [Tue, 12 Apr 2022 08:37:40 +0000 (10:37 +0200)]
Plug memleak seen by valgrind.

2 years agoFix use after free.
Arnaud Giersch [Mon, 11 Apr 2022 12:38:55 +0000 (14:38 +0200)]
Fix use after free.

2 years agoUpdate .mailmap.
Arnaud Giersch [Wed, 6 Apr 2022 08:53:09 +0000 (10:53 +0200)]
Update .mailmap.

2 years agoIt seems important to keep destruction order for hosts and links.
Bruno Donassolo [Mon, 11 Apr 2022 08:55:06 +0000 (10:55 +0200)]
It seems important to keep destruction order for hosts and links.

Keep a "determinist" behavior based on the map order.

2 years agoHosts and VMs internal refactor.
Bruno Donassolo [Fri, 8 Apr 2022 08:15:36 +0000 (10:15 +0200)]
Hosts and VMs internal refactor.

Main changes:
- Netzones contains their hosts.
- Hosts saves their VMs.
- Remove "global" Engine::hosts_.

Possible mapped impacts:
- Hosts destruction order: it was global in the past, now it depends on
the netzones. However, no test affected

Other changes:
- Move code from VirtualMachine interface to VirtualMachineImpl
- Add a HostImpl::create_vm to create VMs: similar to create_host for
NetZoneImpl

2 years agoSonar smells
Bruno Donassolo [Tue, 5 Apr 2022 09:16:16 +0000 (11:16 +0200)]
Sonar smells

2 years agoallow Engine::link_by_name_or_null(__loopback__)
Fred Suter [Tue, 5 Apr 2022 20:53:00 +0000 (16:53 -0400)]
allow Engine::link_by_name_or_null(__loopback__)

2 years agoEven more unused variable.
Arnaud Giersch [Tue, 5 Apr 2022 10:21:27 +0000 (12:21 +0200)]
Even more unused variable.

2 years agoMore unused variables breaking new clang builds.
Arnaud Giersch [Tue, 5 Apr 2022 09:36:35 +0000 (11:36 +0200)]
More unused variables breaking new clang builds.

2 years agoUnused variable.
Arnaud Giersch [Tue, 5 Apr 2022 07:50:00 +0000 (09:50 +0200)]
Unused variable.

2 years agoSeparate NetworkModel from LinkImpl.
Bruno Donassolo [Sat, 2 Apr 2022 16:28:59 +0000 (18:28 +0200)]
Separate NetworkModel from LinkImpl.

Fix memleak in internal loopback link

2 years agoMove links_ to the netzone their are declared
Bruno Donassolo [Fri, 1 Apr 2022 21:32:01 +0000 (23:32 +0200)]
Move links_ to the netzone their are declared

Starting moving things out Engine class.

Links are stored in the netzone which their were declared.
Exception for __loopback__ link that is a special "model" link.

No changes in external Engine::get_links API.
Internally cleanup so someone can change the API.

-

2 years agodoc/tuto: Engine.instance is a python property
msimonin [Mon, 4 Apr 2022 08:28:11 +0000 (10:28 +0200)]
doc/tuto: Engine.instance is a python property