Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
2 years agoremove cruft [ci-skip]
SUTER Frederic [Tue, 25 May 2021 14:28:56 +0000 (16:28 +0200)]
remove cruft [ci-skip]

2 years agoChange way Mailboxes are create, stored, and destroyed
SUTER Frederic [Tue, 25 May 2021 14:13:40 +0000 (16:13 +0200)]
Change way Mailboxes are create, stored, and destroyed

- keep the global map in EngineImpl (not as a static global in
  MailboxImpl.cpp)
- Delete mailboxes in ~EngineImpl() and get rid of SIMIX_mailbox_exit
- replace MailboxImpl::by_name_or_null and
  MailboxImpl::by_name_or_create by Engine::mailbox_by_name_or_create
  + better match with what is done for hosts, links, and actors
  + Mailbox::by_name cause two searchs in the map. One to check if
    name already points to a mailbox (by_name_or_null) and if not
    search again before creating a new mailbox. As there is no
    Mailbox::by_name_or_null, just keep the latter.
- Revalidate a bunch of tests (message ordering mostly)

2 years agodelete Timer when shutting down EngineImpl
SUTER Frederic [Tue, 25 May 2021 13:17:58 +0000 (15:17 +0200)]
delete Timer when shutting down EngineImpl

2 years agoContinue to migrate contents of simix_global to EngineImpl
SUTER Frederic [Tue, 25 May 2021 12:03:10 +0000 (14:03 +0200)]
Continue to migrate contents of simix_global to EngineImpl

thx @agiersch for unblocking this commit with the usual magic!

2 years agoPrefer using emplace() to insert() for smpi keyvals/attributes.
Arnaud Giersch [Sat, 22 May 2021 11:33:17 +0000 (13:33 +0200)]
Prefer using emplace() to insert() for smpi keyvals/attributes.

2 years agoMake smpi::Keyval::attribute() return a reference.
Arnaud Giersch [Sat, 22 May 2021 11:20:02 +0000 (13:20 +0200)]
Make smpi::Keyval::attribute() return a reference.

2 years agoNo need to test for attributes()->empty().
Arnaud Giersch [Sun, 23 May 2021 12:41:53 +0000 (14:41 +0200)]
No need to test for attributes()->empty().

2 years agoFix parameter names.
Arnaud Giersch [Sun, 23 May 2021 20:40:22 +0000 (22:40 +0200)]
Fix parameter names.

2 years agoCoding style: ! -> 'not'.
Arnaud Giersch [Sat, 22 May 2021 16:22:43 +0000 (18:22 +0200)]
Coding style: ! -> 'not'.

2 years agoUpdate filter line for recent versions of Asan.
Arnaud Giersch [Sun, 23 May 2021 22:39:33 +0000 (00:39 +0200)]
Update filter line for recent versions of Asan.

2 years agoDefine variables outside of header file.
Arnaud Giersch [Thu, 20 May 2021 08:37:48 +0000 (10:37 +0200)]
Define variables outside of header file.

2 years ago[sonar] Unused parameter.
Arnaud Giersch [Thu, 20 May 2021 08:28:36 +0000 (10:28 +0200)]
[sonar] Unused parameter.

2 years ago[sonar] Const/explicit methods.
Arnaud Giersch [Thu, 20 May 2021 08:23:58 +0000 (10:23 +0200)]
[sonar] Const/explicit methods.

2 years agoPlease sonar
Bruno Donassolo [Tue, 25 May 2021 08:35:34 +0000 (10:35 +0200)]
Please sonar

2 years agoAdjust test timing
Bruno Donassolo [Thu, 20 May 2021 15:13:59 +0000 (17:13 +0200)]
Adjust test timing

Minor changement in rounding up.
No real changement in timing (manually verified).

2 years agoSingle get_bandwidth_constraint function.
Bruno Donassolo [Thu, 20 May 2021 15:07:52 +0000 (17:07 +0200)]
Single get_bandwidth_constraint function.

Unify behavior of get_bandwidth_constraint function.

Note: Possible side-effect in SMPI communications with user defined
rate. Do not scale the user rate with bandwidth factor.

No impact on tests

2 years agoRefactor of NetworkCm02Model::communicate
Bruno Donassolo [Wed, 19 May 2021 18:55:39 +0000 (20:55 +0200)]
Refactor of NetworkCm02Model::communicate

Divide and conquer.
Reorganize code.
Cosmetics.

2 years agoDynamic factors: implement and test
Bruno Donassolo [Mon, 17 May 2021 17:26:18 +0000 (19:26 +0200)]
Dynamic factors: implement and test

Fully implements the dynamic factors through the NetworkModelIntf API.

Added an example showing its usage.

Added UT and doc.

2 years agoNetworkModelIntf: Interface to dynamic factors
Bruno Donassolo [Fri, 26 Mar 2021 17:27:38 +0000 (18:27 +0100)]
NetworkModelIntf: Interface to dynamic factors

Adding API to set user callbacks for bandwidth and network factors.
Valid for CM02 models and its childrens (SMPI, IB, etc).

Not fully working yet.

2 years agoGet netzones traversed by a route
Bruno Donassolo [Thu, 13 May 2021 16:41:26 +0000 (18:41 +0200)]
Get netzones traversed by a route

Preparing field to implement dynamic bandwidth and latency factors

2 years agomigrate actors_to_run and actors_that_ran to EngineImpl
SUTER Frederic [Fri, 21 May 2021 13:38:56 +0000 (15:38 +0200)]
migrate actors_to_run and actors_that_ran to EngineImpl

2 years agoSMPI should not eat up all exceptions in wait/waitany simcalls silently
Augustin Degomme [Fri, 21 May 2021 10:37:39 +0000 (12:37 +0200)]
SMPI should not eat up all exceptions in wait/waitany simcalls silently
It only deals with cancel ones

2 years agotypo --
Augustin Degomme [Fri, 21 May 2021 10:36:15 +0000 (12:36 +0200)]
typo --

2 years agoprocess -> actor
SUTER Frederic [Fri, 21 May 2021 07:46:15 +0000 (09:46 +0200)]
process -> actor

2 years agofix changelog [ci-skip]
Martin Quinson [Fri, 21 May 2021 08:12:08 +0000 (10:12 +0200)]
fix changelog [ci-skip]

2 years agoAdd a word to the tutorial for older versions of SimGrid
Martin Quinson [Fri, 21 May 2021 08:03:19 +0000 (10:03 +0200)]
Add a word to the tutorial for older versions of SimGrid

Closes https://framagit.org/simgrid/simgrid/-/issues/69

2 years ago [sonar] const
SUTER Frederic [Thu, 20 May 2021 07:30:18 +0000 (09:30 +0200)]
 [sonar] const

2 years ago[sonar] Don't mix public and private data members
SUTER Frederic [Thu, 20 May 2021 07:21:37 +0000 (09:21 +0200)]
[sonar] Don't mix public and private data members

2 years agointroduce a new plugin: stock implementation of a Producer-Consumer with a monitor
SUTER Frederic [Wed, 19 May 2021 16:27:18 +0000 (18:27 +0200)]
introduce a new plugin: stock implementation of a Producer-Consumer with a monitor

2 years agoTypos.
Arnaud Giersch [Wed, 19 May 2021 10:52:00 +0000 (12:52 +0200)]
Typos.

2 years agomigrate daemons from simix::Global to kernel::EngineImpl
SUTER Frederic [Mon, 17 May 2021 18:05:49 +0000 (20:05 +0200)]
migrate daemons from simix::Global to kernel::EngineImpl

go from a public vector to a private set (order doesn't matter) in the
process.

2 years agomigrate execute_tasks from simix::Global to kernel::EngineImpl
SUTER Frederic [Mon, 17 May 2021 09:33:28 +0000 (11:33 +0200)]
migrate execute_tasks from simix::Global to kernel::EngineImpl

2 years agomigrate wake_all_waiting_actors from simix::Global to kernel::EngineImpl
SUTER Frederic [Mon, 17 May 2021 08:33:14 +0000 (10:33 +0200)]
migrate wake_all_waiting_actors from simix::Global to kernel::EngineImpl

2 years agoSIMIX_run becomes EngineImpl::run
SUTER Frederic [Mon, 17 May 2021 08:23:13 +0000 (10:23 +0200)]
SIMIX_run becomes EngineImpl::run

2 years agomove another function out of simix + private field
SUTER Frederic [Sun, 16 May 2021 15:12:34 +0000 (17:12 +0200)]
move another function out of simix + private field

2 years agoMore informative error message when the user does not provide a main() to smpirun...
Martin Quinson [Mon, 17 May 2021 07:33:06 +0000 (09:33 +0200)]
More informative error message when the user does not provide a main() to smpirun [ci-skip]

2 years agomove kernel timers from simix:: to kernel::timer::
SUTER Frederic [Sun, 16 May 2021 12:51:27 +0000 (14:51 +0200)]
move kernel timers from simix:: to kernel::timer::

2 years agoUse correct types for temporary variables.
Arnaud Giersch [Wed, 12 May 2021 10:46:41 +0000 (12:46 +0200)]
Use correct types for temporary variables.

2 years agoCosmetics.
Arnaud Giersch [Wed, 12 May 2021 09:48:38 +0000 (11:48 +0200)]
Cosmetics.

(reduce length of lambda, for sonar).

2 years agoChecking access before open is useless (fix race condition).
Arnaud Giersch [Wed, 12 May 2021 08:09:36 +0000 (10:09 +0200)]
Checking access before open is useless (fix race condition).

2 years agoaccept functions with parameters in Actor::start
SUTER Frederic [Wed, 12 May 2021 10:07:45 +0000 (12:07 +0200)]
accept functions with parameters in Actor::start

2 years agoMinor sonar related changes
Bruno Donassolo [Wed, 12 May 2021 09:11:06 +0000 (11:11 +0200)]
Minor sonar related changes

2 years agoallow to get the number of queued communications in a Mailbox
SUTER Frederic [Tue, 11 May 2021 16:02:54 +0000 (18:02 +0200)]
allow to get the number of queued communications in a Mailbox

2 years agoSeal objects at Engine::run
Bruno Donassolo [Tue, 11 May 2021 14:34:16 +0000 (16:34 +0200)]
Seal objects at Engine::run

Seal, recursively, netzones, hosts, links and disks.
Some extra checks when creating and sealing resources.
Add test for this case.

2 years agoSome cleanup around model description tables.
Arnaud Giersch [Tue, 11 May 2021 12:04:34 +0000 (14:04 +0200)]
Some cleanup around model description tables.

* save a new/delete for plugin descriptions;
* use sdt::function for model_init_preparse;
* return a pointer from find_model_description().

2 years agoConst.
Arnaud Giersch [Tue, 11 May 2021 08:05:53 +0000 (10:05 +0200)]
Const.

2 years agoFix lua compilation
Bruno Donassolo [Mon, 10 May 2021 16:17:22 +0000 (18:17 +0200)]
Fix lua compilation

Get code back to sg_platf since it's used by lua_platf.cpp

2 years agoFix memleak.
Bruno Donassolo [Mon, 10 May 2021 15:11:46 +0000 (17:11 +0200)]
Fix memleak.

Thanks @agiersch

2 years agoWorkaround to unblock.
Bruno Donassolo [Mon, 10 May 2021 14:38:05 +0000 (16:38 +0200)]
Workaround to unblock.

Seems a gcc-11 problem anyway

2 years agoFix NS-3 tests
Bruno Donassolo [Mon, 10 May 2021 14:16:42 +0000 (16:16 +0200)]
Fix NS-3 tests

Since cluster zones are now based on star, we cannot keep the checks

2 years agoFix example: seal zone
Bruno Donassolo [Mon, 10 May 2021 12:24:40 +0000 (14:24 +0200)]
Fix example: seal zone

2 years agoAdjust tests after changes in cluster tag
Bruno Donassolo [Mon, 10 May 2021 10:43:53 +0000 (12:43 +0200)]
Adjust tests after changes in cluster tag

Minor changes in graphicator and flatifier due to internals of StarZone
compared to old ClusterZone

No timing changes in tests.

2 years agoClusterZone placeholder and kill some old code
Bruno Donassolo [Fri, 7 May 2021 18:50:57 +0000 (20:50 +0200)]
ClusterZone placeholder and kill some old code

Put the old ClusterZone class as a placeholder for other "Cluster"
classes.

Keep the same behavior of Engine::get_filtered_netzones for wrench
projects.

The old ClusterZone is now BaseCluster and it's used to implement the
"complex" Clusters (Torus, DragonFly and Fat-Tree).

Kill old code that doesn't make sense for these netzones

2 years agoCluster with StarZones
Bruno Donassolo [Wed, 5 May 2021 16:53:08 +0000 (18:53 +0200)]
Cluster with StarZones

Finish cleaning-up of old cluster zones.
Implements <cluster> and <zone routing="cluster"> with StarZones.

Keep old ClusterZone as base for Torus, Dragonfly and Fat-Tree.

2 years agoFactor common code.
Arnaud Giersch [Mon, 10 May 2021 09:40:55 +0000 (11:40 +0200)]
Factor common code.

2 years agoReduce code duplication.
Arnaud Giersch [Mon, 10 May 2021 09:28:08 +0000 (11:28 +0200)]
Reduce code duplication.

2 years ago[sonar] Prefer empty() to check for emptyness.
Arnaud Giersch [Sun, 9 May 2021 12:39:58 +0000 (14:39 +0200)]
[sonar] Prefer empty() to check for emptyness.

2 years ago[sonar] Minor simplifications.
Arnaud Giersch [Sat, 8 May 2021 12:00:38 +0000 (14:00 +0200)]
[sonar] Minor simplifications.

2 years ago[cppcheck] Pass parameters by const reference.
Arnaud Giersch [Thu, 6 May 2021 13:44:22 +0000 (15:44 +0200)]
[cppcheck] Pass parameters by const reference.

2 years ago[codefactor] Cosmetics.
Arnaud Giersch [Thu, 6 May 2021 13:38:43 +0000 (15:38 +0200)]
[codefactor] Cosmetics.

2 years agoRename kernel::resource:Cpu to CpuImpl
SUTER Frederic [Sun, 9 May 2021 14:41:39 +0000 (16:41 +0200)]
Rename kernel::resource:Cpu to CpuImpl

2 years agouse .data() instead of &v[0] to avoid annoying analyzers.
Augustin Degomme [Fri, 7 May 2021 21:49:48 +0000 (23:49 +0200)]
use .data() instead of &v[0] to avoid annoying analyzers.

2 years agoRevert "Try to activate -Wsugests-override in GNU compiler, as it may help if it...
Martin Quinson [Fri, 7 May 2021 22:16:11 +0000 (00:16 +0200)]
Revert "Try to activate -Wsugests-override in GNU compiler, as it may help if it works"

This fails for old versions of GCC, which could be worked around, but
also on ns-3 headers, which is harder to fix properly.

This reverts commit 694a2b171a6e03d42d5068bc6ba6c353cb0e34e3.

2 years agoTry to activate -Wsugests-override in GNU compiler, as it may help if it works
Martin Quinson [Fri, 7 May 2021 22:01:35 +0000 (00:01 +0200)]
Try to activate -Wsugests-override in GNU compiler, as it may help if it works

2 years agoClose those bugs in the Changelog [ci-skip]
Martin Quinson [Wed, 5 May 2021 18:37:24 +0000 (20:37 +0200)]
Close those bugs in the Changelog [ci-skip]

2 years agonon blocking collectives : array->vector
Augustin Degomme [Fri, 7 May 2021 16:14:52 +0000 (18:14 +0200)]
non blocking collectives : array->vector

2 years agoFix previous fix.
Augustin Degomme [Fri, 7 May 2021 13:45:16 +0000 (15:45 +0200)]
Fix previous fix.
It was turning test into wait for non blocking collectives, which is not what we wanted.

2 years agoFix build with -Werror=undef.
Arnaud Giersch [Fri, 7 May 2021 12:08:43 +0000 (14:08 +0200)]
Fix build with -Werror=undef.

2 years agoAllow an actor to destroy its own VM.
Arnaud Giersch [Fri, 7 May 2021 11:39:11 +0000 (13:39 +0200)]
Allow an actor to destroy its own VM.

Fix https://github.com/simgrid/simgrid/issues/322

2 years agoAdd test for VM (self) destruction.
Arnaud Giersch [Fri, 7 May 2021 09:38:13 +0000 (11:38 +0200)]
Add test for VM (self) destruction.

Adapted from https://github.com/simgrid/simgrid/issues/322

2 years agoDistcheck.
Arnaud Giersch [Fri, 7 May 2021 11:28:40 +0000 (13:28 +0200)]
Distcheck.

2 years agoactivate the last nonblocking test in mpich3 suite, as now we should pass it.. probably.
Augustin Degomme [Fri, 7 May 2021 10:20:16 +0000 (12:20 +0200)]
activate the last nonblocking test in mpich3 suite, as now we should pass it.. probably.

2 years agoProperly terminate non blocking collective requests in all cases (mpi_test/testall...
Augustin Degomme [Fri, 7 May 2021 10:17:54 +0000 (12:17 +0200)]
Properly terminate non blocking collective requests in all cases (mpi_test/testall/testany/testsome/waitsome/waitany).
Also use flags to identify non blocking collectivre requests instead of the size of an array (which should be turned in a vector soon)
Fix one issue reported in #67

2 years agoChecks concerning StarZone and NS3
Bruno Donassolo [Fri, 7 May 2021 09:33:26 +0000 (11:33 +0200)]
Checks concerning StarZone and NS3

2 years agoReduce scope for variable.
Arnaud Giersch [Thu, 6 May 2021 21:38:41 +0000 (23:38 +0200)]
Reduce scope for variable.

2 years agoCapitalize enum class.
Arnaud Giersch [Thu, 6 May 2021 21:38:41 +0000 (23:38 +0200)]
Capitalize enum class.

2 years agoCannot destroy iface before impl.
Arnaud Giersch [Thu, 6 May 2021 12:29:52 +0000 (14:29 +0200)]
Cannot destroy iface before impl.

HostImpl::destroy() calls s4u::Host::on_destruction(*this->get_iface());

Move bogus XBT_DEBUG instead.

2 years agoFix use-after-free with VirtualMachine::destroy().
Arnaud Giersch [Thu, 6 May 2021 11:41:41 +0000 (13:41 +0200)]
Fix use-after-free with VirtualMachine::destroy().

Postpone destruction of VirtualMachineImpl, and do it in kernel mode.

2 years agoThere is no need to have these functions 'virtual'.
Arnaud Giersch [Thu, 6 May 2021 11:24:00 +0000 (13:24 +0200)]
There is no need to have these functions 'virtual'.

2 years agoFix rst.
Arnaud Giersch [Wed, 5 May 2021 08:22:46 +0000 (10:22 +0200)]
Fix rst.

2 years ago[sonar] implicit casts
SUTER Frederic [Thu, 6 May 2021 08:30:18 +0000 (10:30 +0200)]
[sonar] implicit casts

2 years agoExtend the description of the IB configuration
Martin Quinson [Wed, 5 May 2021 15:43:52 +0000 (17:43 +0200)]
Extend the description of the IB configuration

2 years agoA doc section that I don't know where to put: citations in several languages [ci...
Martin Quinson [Wed, 5 May 2021 13:00:51 +0000 (15:00 +0200)]
A doc section that I don't know where to put: citations in several languages [ci-skip]

2 years agoMC: Start implementing the dependency functions on the AppSide (TBC)
Martin Quinson [Tue, 4 May 2021 22:24:10 +0000 (00:24 +0200)]
MC: Start implementing the dependency functions on the AppSide (TBC)

(code committed to gather feedback: it's not used yet)

Instead of one big function handling the dependencies for every kind
of transition on the CheckerSide, we will split that logic between the
observer subclasses and execute it on the AppSide. This will induce
more latencies, but hopefully this will make the code more managable.

This commit introduces a MutexSimcall observer, as we want to group
MutexLock and MutexUnlock together when computing the dependencies.

But we cannot use it yet, as we need to have asynchronous locks for
the existing independence theorems to be usable.

2 years agoSome sonar stuff...
Bruno Donassolo [Wed, 5 May 2021 09:02:07 +0000 (11:02 +0200)]
Some sonar stuff...

2 years agoDon't take default smpi compiler flags from the environment.
Arnaud Giersch [Tue, 4 May 2021 21:37:07 +0000 (23:37 +0200)]
Don't take default smpi compiler flags from the environment.

The user must explicitly define them through cmake parameters
SMPI_C_FLAGS, SMPI_CXX_FLAGS, or SMPI_Fortran_FLAGS.

2 years agoCosmetics.
Arnaud Giersch [Tue, 4 May 2021 20:37:59 +0000 (22:37 +0200)]
Cosmetics.

2 years agoPut stdout in line buffer mode for MCed apps.
Arnaud Giersch [Tue, 4 May 2021 20:08:58 +0000 (22:08 +0200)]
Put stdout in line buffer mode for MCed apps.

The call to fflush before backtrack/exit is certainly superfluous now,
but it doesn't harm.

2 years agofix my recent commit: build the binaries in the right directory
Martin Quinson [Tue, 4 May 2021 19:00:45 +0000 (21:00 +0200)]
fix my recent commit: build the binaries in the right directory

2 years agodistcheck, but in a new and shiny way with a lot of cmake stars in the sky
Martin Quinson [Tue, 4 May 2021 17:33:34 +0000 (19:33 +0200)]
distcheck, but in a new and shiny way with a lot of cmake stars in the sky

2 years agofactorize some code in examples/smpi/CMakeLists.txt
Martin Quinson [Tue, 4 May 2021 17:27:34 +0000 (19:27 +0200)]
factorize some code in examples/smpi/CMakeLists.txt

Because factorizing cmake code is what you need today.

2 years agoWarn the user if the sleep time is smaller than the numerical precision
Martin Quinson [Tue, 4 May 2021 15:51:40 +0000 (17:51 +0200)]
Warn the user if the sleep time is smaller than the numerical precision

2 years agocmake: Ensure that the users don't activate minimal-bindings and model-checking together
Martin Quinson [Tue, 4 May 2021 08:27:05 +0000 (10:27 +0200)]
cmake: Ensure that the users don't activate minimal-bindings and model-checking together

2 years agoMC: add a clone() method to all Observers
Martin Quinson [Tue, 4 May 2021 08:22:55 +0000 (10:22 +0200)]
MC: add a clone() method to all Observers

This will be useful for the AppSide to maintain a vector of all
observers on the stack, to move the independency tracking to that side.

2 years agoFix tesh file now that MC flushes the output on backtrack
Martin Quinson [Tue, 4 May 2021 17:22:28 +0000 (19:22 +0200)]
Fix tesh file now that MC flushes the output on backtrack

That's weird, it seems that we don't flush it when the application
ends, as one of the outputs arrives after the end of MC. But I fail to
see in the code where that would come from.

2 years agoMC: also flush application's stdout on backtrack
Martin Quinson [Fri, 30 Apr 2021 22:56:52 +0000 (00:56 +0200)]
MC: also flush application's stdout on backtrack

2 years agoDocument the fact that we have more documentation
Martin Quinson [Fri, 30 Apr 2021 22:32:37 +0000 (00:32 +0200)]
Document the fact that we have more documentation

2 years agoWork around a bug in vscode
Martin Quinson [Fri, 30 Apr 2021 21:20:46 +0000 (23:20 +0200)]
Work around a bug in vscode

2 years agoTuto MC: Add a word about the missing pieces
Martin Quinson [Fri, 30 Apr 2021 15:46:33 +0000 (17:46 +0200)]
Tuto MC: Add a word about the missing pieces

2 years agoDragonflyZone: Add limiters for switches
Bruno Donassolo [Tue, 4 May 2021 15:34:08 +0000 (17:34 +0200)]
DragonflyZone: Add limiters for switches

Final change to make uniform the behavior of limiters in the clusters:
Fat-Tree, Torus and Dragonfly.

Changes in tests flatifier and cluster-multicpu