Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
3 years agoNetZoneImpl: simpler constructor
Bruno Donassolo [Wed, 10 Mar 2021 18:53:33 +0000 (19:53 +0100)]
NetZoneImpl: simpler constructor

NetZoneImpl(std::string& name);
One step towards a simple contructor and set() idiom.
Removed father and network model from constructor.

Collateral effect:

NetPoint:
- removed NetZoneImpl* from its constructor
- added method set_englobing_zone(NetZoneImpl*)

In the past, we could create the NetPoint in NetZoneImpl with the
pointer to the father. But now, the father is only set latter at
set_father method.

3 years agoNetZoneImpl: rework seal
Bruno Donassolo [Thu, 25 Feb 2021 17:33:36 +0000 (18:33 +0100)]
NetZoneImpl: rework seal

Create a do_seal that can be rewritten by derived classes

Assure that flag sealed_ is sealed properly when derived classes
override the seal() method.

3 years agoMerge pull request #374 from adegomme/master
Martin Quinson [Thu, 11 Mar 2021 16:13:33 +0000 (17:13 +0100)]
Merge pull request #374 from adegomme/master

try to handle inconsistencies in github environments.

3 years agosometimes, it's still there...
adegomme [Thu, 11 Mar 2021 15:50:49 +0000 (16:50 +0100)]
sometimes, it's still there...

3 years ago[sonar] Move explaining comment inside body of empty function.
Arnaud Giersch [Thu, 11 Mar 2021 14:23:01 +0000 (15:23 +0100)]
[sonar] Move explaining comment inside body of empty function.

3 years ago[sonar] Use '=default'.
Arnaud Giersch [Thu, 11 Mar 2021 14:17:21 +0000 (15:17 +0100)]
[sonar] Use '=default'.

3 years ago[sonar] Declare functions 'const'.
Arnaud Giersch [Thu, 11 Mar 2021 14:10:07 +0000 (15:10 +0100)]
[sonar] Declare functions 'const'.

3 years ago[sonar] Use :: to call static member functions.
Arnaud Giersch [Thu, 11 Mar 2021 14:07:15 +0000 (15:07 +0100)]
[sonar] Use :: to call static member functions.

3 years ago[sonar] Pointer to const.
Arnaud Giersch [Thu, 11 Mar 2021 13:51:12 +0000 (14:51 +0100)]
[sonar] Pointer to const.

3 years ago[sonar] Favor using-declarations.
Arnaud Giersch [Thu, 11 Mar 2021 13:49:45 +0000 (14:49 +0100)]
[sonar] Favor using-declarations.

3 years agoMerge pull request #373 from adegomme/master
Martin Quinson [Thu, 11 Mar 2021 13:59:17 +0000 (14:59 +0100)]
Merge pull request #373 from adegomme/master

fix jar creation github action, and add weekly build

3 years agoadd weekly build at 6:00pm sundays
adegomme [Thu, 11 Mar 2021 13:54:15 +0000 (14:54 +0100)]
add weekly build at 6:00pm sundays

3 years agotry to put back boost on windows
adegomme [Thu, 11 Mar 2021 13:28:19 +0000 (14:28 +0100)]
try to put back boost on windows

https://github.com/actions/virtual-environments/issues/2667

3 years agotemporary attempt to workaround scoop bug
adegomme [Thu, 11 Mar 2021 12:56:58 +0000 (13:56 +0100)]
temporary attempt to workaround scoop bug

https://github.com/ScoopInstall er/Main/issues/1752

3 years agoRemove useless default destructor definitions
Martin Quinson [Thu, 11 Mar 2021 09:58:26 +0000 (10:58 +0100)]
Remove useless default destructor definitions

3 years agoTwo small sonar fixes
Martin Quinson [Wed, 10 Mar 2021 20:13:30 +0000 (21:13 +0100)]
Two small sonar fixes

- dead stores
- default destructor should not even be written

3 years agoDocument direct communications, deprecate Host::sendto() because Comm::sendto() is...
Martin Quinson [Tue, 9 Mar 2021 15:34:31 +0000 (16:34 +0100)]
Document direct communications, deprecate Host::sendto() because Comm::sendto() is better for that

3 years agoimplement MPI_File_set_size
Augustin Degomme [Wed, 10 Mar 2021 19:03:04 +0000 (20:03 +0100)]
implement MPI_File_set_size

3 years agoMerge branch 's4u/model_list' into 'master'
Arnaud Giersch [Wed, 10 Mar 2021 17:11:00 +0000 (17:11 +0000)]
Merge branch 's4u/model_list' into 'master'

s4u Engine: expose get_all_models, get_model_list

See merge request simgrid/simgrid!53

3 years agoMerge branch 'unify_models' into 'master'
Arnaud Giersch [Wed, 10 Mar 2021 16:52:05 +0000 (16:52 +0000)]
Merge branch 'unify_models' into 'master'

Unify treatment of models in the EngineImpl

See merge request simgrid/simgrid!52

3 years agoUniform treatment in EngineImpl for all models.
Bruno Donassolo [Wed, 10 Mar 2021 14:09:35 +0000 (15:09 +0100)]
Uniform treatment in EngineImpl for all models.

Override the update_action_state function in CPUL07 and LinkL07, they
are not necessary since the actions are updated by the HostL07Model, but
they allow to make the same treatment for all models.

3 years agoImprov comment
Bruno Donassolo [Wed, 10 Mar 2021 14:05:45 +0000 (15:05 +0100)]
Improv comment

3 years agoConst for some get functions
Bruno Donassolo [Wed, 10 Mar 2021 14:04:57 +0000 (15:04 +0100)]
Const for some get functions

3 years agos4u Engine: expose get_all_models, get_model_list
msimonin [Wed, 10 Mar 2021 15:40:09 +0000 (16:40 +0100)]
s4u Engine: expose get_all_models, get_model_list

Before e22da6010c6499813ff88c76041cf499ffbf2b67 the list of models
could be accessed using the global `all_existing_models`

This patch exposes two methods to get the list of models in the
s4u::Engine, they wrap those of `EngineImpl`.

3 years agoSonar prefers nullptr.
Arnaud Giersch [Wed, 10 Mar 2021 09:40:29 +0000 (10:40 +0100)]
Sonar prefers nullptr.

3 years agoCosmetics around #include.
Arnaud Giersch [Wed, 10 Mar 2021 09:11:29 +0000 (10:11 +0100)]
Cosmetics around #include.

3 years agoMore error messages.
Arnaud Giersch [Wed, 10 Mar 2021 09:09:02 +0000 (10:09 +0100)]
More error messages.

3 years agoPrefer xbt_assert here.
Arnaud Giersch [Wed, 10 Mar 2021 09:08:37 +0000 (10:08 +0100)]
Prefer xbt_assert here.

3 years agoUpdate .mailmap.
Arnaud Giersch [Tue, 9 Mar 2021 20:57:32 +0000 (21:57 +0100)]
Update .mailmap.

3 years agoMerge oberver classes MutexTrylockSimcall and MutexLockSimcall.
Arnaud Giersch [Tue, 9 Mar 2021 14:36:05 +0000 (15:36 +0100)]
Merge oberver classes MutexTrylockSimcall and MutexLockSimcall.

3 years agoModernize simcall mutex_lock.
Arnaud Giersch [Mon, 8 Mar 2021 13:55:22 +0000 (14:55 +0100)]
Modernize simcall mutex_lock.

3 years agoMove check from checker side to app. side.
Arnaud Giersch [Tue, 9 Mar 2021 14:15:33 +0000 (15:15 +0100)]
Move check from checker side to app. side.

3 years agoDefine (and use) a callback for RawImpl::finish.
Arnaud Giersch [Tue, 9 Mar 2021 12:03:01 +0000 (13:03 +0100)]
Define (and use) a callback for RawImpl::finish.

3 years agoMake scan-build ignore volontary null-pointer dereference.
Arnaud Giersch [Tue, 9 Mar 2021 08:22:03 +0000 (09:22 +0100)]
Make scan-build ignore volontary null-pointer dereference.

3 years agoMerge branch 'bruno.donassolo/simgrid-add_model_shared' into next
Arnaud Giersch [Tue, 9 Mar 2021 20:14:20 +0000 (21:14 +0100)]
Merge branch 'bruno.donassolo/simgrid-add_model_shared' into next

3 years agoalso test with several cores. Let's see how this goes
Augustin Degomme [Tue, 9 Mar 2021 19:18:22 +0000 (20:18 +0100)]
also test with several cores. Let's see how this goes

3 years agoEngine*::add_model: from unique to shared_ptr
Bruno Donassolo [Tue, 9 Mar 2021 19:04:53 +0000 (20:04 +0100)]
Engine*::add_model: from unique to shared_ptr

3 years agoMerge branch 'hotfix_add_model_api' into 'master'
Martin Quinson [Tue, 9 Mar 2021 17:51:28 +0000 (17:51 +0000)]
Merge branch 'hotfix_add_model_api' into 'master'

Hotfix: expose add_model method in s4u::Engine

See merge request simgrid/simgrid!50

3 years agoHotfix: expose add_model method in s4u::Engine
Bruno Donassolo [Tue, 9 Mar 2021 17:28:59 +0000 (18:28 +0100)]
Hotfix: expose add_model method in s4u::Engine

Expose the add_model API to external users.

3 years agonamespacing
Frederic Suter [Tue, 9 Mar 2021 15:58:08 +0000 (16:58 +0100)]
namespacing

3 years agoA canceled Activity is a completed Activity too
Frederic Suter [Tue, 9 Mar 2021 15:50:46 +0000 (16:50 +0100)]
A canceled Activity is a completed Activity too

3 years agonamespacing
Frederic Suter [Tue, 9 Mar 2021 15:46:08 +0000 (16:46 +0100)]
namespacing

3 years agobe more uniform on action cleaning accross activities
Frederic Suter [Tue, 9 Mar 2021 15:43:02 +0000 (16:43 +0100)]
be more uniform on action cleaning accross activities

3 years agoDo the same for IoImpl as for ExecImpl when timeout on completion
Frederic Suter [Tue, 9 Mar 2021 15:35:01 +0000 (16:35 +0100)]
Do the same for IoImpl as for ExecImpl when timeout on completion

3 years agouser bound is now stored at Action level and not modified by LMM
Frederic Suter [Tue, 9 Mar 2021 15:28:56 +0000 (16:28 +0100)]
user bound is now stored at Action level and not modified by LMM
Then it can be passed from old to new action when migrating the Exec

3 years agoAllow failure detection for parallel exec
Frederic Suter [Tue, 9 Mar 2021 15:27:02 +0000 (16:27 +0100)]
Allow failure detection for parallel exec
change nothing when hosts has size 1. use std::any_of for multiple hosts

3 years agoMerge branch 'multi_models_no_globals' into 'master'
Martin Quinson [Tue, 9 Mar 2021 15:02:50 +0000 (15:02 +0000)]
Merge branch 'multi_models_no_globals' into 'master'

Refactoring: remove surf_*_model globals

See merge request simgrid/simgrid!49

3 years agoMove globals to EngineImpl
Bruno Donassolo [Tue, 9 Mar 2021 13:31:56 +0000 (14:31 +0100)]
Move globals to EngineImpl

A step forwards encapsulation.
Still not good for ptask model and its particularities.

3 years agoSay goodbye to last global: surf_host_model
Bruno Donassolo [Thu, 4 Mar 2021 16:49:25 +0000 (17:49 +0100)]
Say goodbye to last global: surf_host_model

- By now, add the host_model in netZone too
- Probably need some check when running parallel_execute in a list of
hosts (all belongs to same model/netzone?)

3 years agoclang-format: ExecImpl.cpp and sd_task.cpp
Bruno Donassolo [Thu, 4 Mar 2021 16:31:25 +0000 (17:31 +0100)]
clang-format: ExecImpl.cpp and sd_task.cpp

3 years agosurf_disk_model: remove it.
Bruno Donassolo [Thu, 4 Mar 2021 14:52:10 +0000 (15:52 +0100)]
surf_disk_model: remove it.

- Add disk_model to NetZone as done for network and cpu models
- Add create_disk method in NetZone too: keep interface uniform

3 years agos4u_Host.cpp: clang-format
Bruno Donassolo [Thu, 4 Mar 2021 14:51:25 +0000 (15:51 +0100)]
s4u_Host.cpp: clang-format

3 years agoAdjust code after rebase.
Bruno Donassolo [Thu, 4 Mar 2021 14:08:53 +0000 (15:08 +0100)]
Adjust code after rebase.

surf_network_model doesn't exist anymore

3 years agosurf_cpu_model_pm: remove global
Bruno Donassolo [Thu, 4 Mar 2021 13:15:23 +0000 (14:15 +0100)]
surf_cpu_model_pm: remove global

3 years agoGet rid of surf_cpu_model_vm.
Bruno Donassolo [Thu, 4 Mar 2021 10:41:49 +0000 (11:41 +0100)]
Get rid of surf_cpu_model_vm.

- Add cpu_model_vm to NetZoneImpl. By now, it gets the global pointer in
models_by_type if available
- Separate CPU in CPU_PM and CPU_VM.
- Move next_occurring_event call to CPU_VM models to surf_solve. One step
closer to centralizing the models management

3 years agoNetZoneImpl::network_model_: get() and private object
Bruno Donassolo [Thu, 4 Mar 2021 09:49:51 +0000 (10:49 +0100)]
NetZoneImpl::network_model_: get() and private object

3 years agoGetting rid off surf_network_model global
Bruno Donassolo [Wed, 3 Mar 2021 10:43:23 +0000 (11:43 +0100)]
Getting rid off surf_network_model global

Adapt network model initialization to remove surf_network_model
occurrences.

3 years agoRemove surf_network_model from host_clm03.
Bruno Donassolo [Tue, 2 Mar 2021 17:41:44 +0000 (18:41 +0100)]
Remove surf_network_model from host_clm03.

surf_solve concentrates all the next_occurring_event calls.
Get network_model from zone of source host in communications

3 years agoRemove last entry from surf_solve to surf_network_model.
Bruno Donassolo [Tue, 2 Mar 2021 09:11:35 +0000 (10:11 +0100)]
Remove last entry from surf_solve to surf_network_model.

Improv doc.

3 years agoModify iteration over models in surf_solve
Bruno Donassolo [Mon, 1 Mar 2021 19:42:46 +0000 (20:42 +0100)]
Modify iteration over models in surf_solve

Added a map with the different models initialized to iterate in
surf_solve function.

Extra: clang-format

3 years agoAvoid using surf_network_model global
Bruno Donassolo [Mon, 1 Mar 2021 18:20:22 +0000 (19:20 +0100)]
Avoid using surf_network_model global

Get network model from NetZoneImpl instead of using the global.
First step to remove global model variables.

Extra: clang-format modified files.

3 years agoclang-format before starting changing files
Bruno Donassolo [Tue, 2 Mar 2021 17:50:41 +0000 (18:50 +0100)]
clang-format before starting changing files

3 years agopropagate the user bound down to the action
Frederic Suter [Tue, 9 Mar 2021 13:55:51 +0000 (14:55 +0100)]
propagate the user bound down to the action

3 years agomv NetworkAction::rate_ to Action::user_bound_
Frederic Suter [Tue, 9 Mar 2021 13:46:24 +0000 (14:46 +0100)]
mv NetworkAction::rate_ to Action::user_bound_

3 years agocosmetics
Frederic Suter [Tue, 9 Mar 2021 10:19:52 +0000 (11:19 +0100)]
cosmetics

3 years agoextend example to include a ptask with timeout
Frederic Suter [Tue, 9 Mar 2021 09:17:56 +0000 (10:17 +0100)]
extend example to include a ptask with timeout

3 years agoSplit the {TEST,WAIT}ANY translation away from MC_state_choose_request_for_process
Martin Quinson [Mon, 8 Mar 2021 23:53:42 +0000 (00:53 +0100)]
Split the {TEST,WAIT}ANY translation away from MC_state_choose_request_for_process

3 years agoPrepare to split the {TEST,WAIT}ANY translation away from MC_state_choose_request_for...
Martin Quinson [Mon, 8 Mar 2021 23:41:55 +0000 (00:41 +0100)]
Prepare to split the {TEST,WAIT}ANY translation away from MC_state_choose_request_for_process

3 years agofix GH#343
Frederic Suter [Mon, 8 Mar 2021 21:54:49 +0000 (22:54 +0100)]
fix GH#343

- An exec that ends right when the timeout expires is actually done
- when the timeout_detector finished, change the state of the action of
the ExecImpl that owns this detector to FAILED. This will trigger
on_state_change for the right action and solve the issue on energy
logging of this issue.
- Side effect, more instrumentation is displayed in another example of
a ptask with timeout.

3 years agotrigger Host::on_creation a bit earlier
Frederic Suter [Mon, 8 Mar 2021 18:44:32 +0000 (19:44 +0100)]
trigger Host::on_creation a bit earlier

3 years agoMerge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Mon, 8 Mar 2021 21:38:29 +0000 (22:38 +0100)]
Merge branch 'master' of framagit.org:simgrid/simgrid

3 years agoModernize simcall mutex_trylock.
Arnaud Giersch [Fri, 5 Mar 2021 22:44:33 +0000 (23:44 +0100)]
Modernize simcall mutex_trylock.

3 years agoFix deprecation message.
Arnaud Giersch [Mon, 8 Mar 2021 13:20:25 +0000 (14:20 +0100)]
Fix deprecation message.

3 years agoSonar wants one declaration per line.
Arnaud Giersch [Mon, 8 Mar 2021 09:18:38 +0000 (10:18 +0100)]
Sonar wants one declaration per line.

3 years agoDon't adjust variable name each time Api::get_maxpid() is called.
Arnaud Giersch [Sun, 7 Mar 2021 17:26:16 +0000 (18:26 +0100)]
Don't adjust variable name each time Api::get_maxpid() is called.

3 years agoCache result of Api::get_maxpid() when used multiple times.
Arnaud Giersch [Sun, 7 Mar 2021 17:06:23 +0000 (18:06 +0100)]
Cache result of Api::get_maxpid() when used multiple times.

3 years agoMinor reindent.
Arnaud Giersch [Mon, 8 Mar 2021 15:22:43 +0000 (16:22 +0100)]
Minor reindent.

3 years agoTypo.
Arnaud Giersch [Sun, 7 Mar 2021 21:45:32 +0000 (22:45 +0100)]
Typo.

3 years agoUseless braces.
Arnaud Giersch [Sun, 7 Mar 2021 13:58:09 +0000 (14:58 +0100)]
Useless braces.

3 years agoAdd 'explicit'.
Arnaud Giersch [Sun, 7 Mar 2021 14:36:25 +0000 (15:36 +0100)]
Add 'explicit'.

3 years agoRemove useless declaration of default destructor.
Arnaud Giersch [Mon, 8 Mar 2021 20:49:33 +0000 (21:49 +0100)]
Remove useless declaration of default destructor.

Remove public destructors defined '=default' at declaration, unless
they are virtual and the enclosing class is derived somewhere.

3 years agoThat was a nasty optimization :-/
Martin Quinson [Mon, 8 Mar 2021 19:51:01 +0000 (20:51 +0100)]
That was a nasty optimization :-/

3 years agonew example with ptasks on multi-core hosts
Frederic Suter [Mon, 8 Mar 2021 17:24:05 +0000 (18:24 +0100)]
new example with ptasks on multi-core hosts

3 years agoMC dependency: do the easy test before the harder one
Martin Quinson [Mon, 8 Mar 2021 16:24:52 +0000 (17:24 +0100)]
MC dependency: do the easy test before the harder one

3 years agoUse less of state->internal_req_ and more of state->executed_req_
Martin Quinson [Mon, 8 Mar 2021 16:17:37 +0000 (17:17 +0100)]
Use less of state->internal_req_ and more of state->executed_req_

The idea is to soon kill internal_req and have the dependency checking
do the conversion WAITANY -> WAIT and TESTANY -> TEST on its own.

3 years agocontinue to fluentify Cpu creation. Fix FG37 on the way
Frederic Suter [Mon, 8 Mar 2021 16:08:13 +0000 (17:08 +0100)]
continue to fluentify Cpu creation. Fix FG37 on the way

3 years agoMAIS C'ETAIT SUR, EN FAIT ! C'ETAIT SUR !
Martin Quinson [Mon, 8 Mar 2021 13:57:21 +0000 (14:57 +0100)]
MAIS C'ETAIT SUR, EN FAIT ! C'ETAIT SUR !

fix make distcheck, as usual.

3 years agoMC: Extend the random-bug example to test what's going on when the app is segfaulting
Martin Quinson [Mon, 8 Mar 2021 13:49:55 +0000 (14:49 +0100)]
MC: Extend the random-bug example to test what's going on when the app is segfaulting

3 years agoUse default parameter value instead of having an overload just for that
Martin Quinson [Mon, 8 Mar 2021 13:11:54 +0000 (14:11 +0100)]
Use default parameter value instead of having an overload just for that

3 years agodoc: further cosmetics in the TOC and in the pages' URLs
Martin Quinson [Sun, 7 Mar 2021 22:42:47 +0000 (23:42 +0100)]
doc: further cosmetics in the TOC and in the pages' URLs

3 years agodoc: put every info related to models on the same page
Martin Quinson [Sun, 7 Mar 2021 22:33:39 +0000 (23:33 +0100)]
doc: put every info related to models on the same page

The summary contains too many top level entries.

3 years agodoc: suppress more useless warnings
Martin Quinson [Sun, 7 Mar 2021 22:21:00 +0000 (23:21 +0100)]
doc: suppress more useless warnings

3 years agoDoc: Move the blurb about the default TCP model to the right location
Martin Quinson [Sun, 7 Mar 2021 22:20:43 +0000 (23:20 +0100)]
Doc: Move the blurb about the default TCP model to the right location

3 years agomove MPI_COMM_WORLD to smpi_comm.cpp.
Augustin Degomme [Mon, 8 Mar 2021 08:10:52 +0000 (09:10 +0100)]
move MPI_COMM_WORLD to smpi_comm.cpp.
It's better here.

3 years agogeneralize previous change to other MPI predefined globals.
Augustin Degomme [Mon, 8 Mar 2021 08:10:07 +0000 (09:10 +0100)]
generalize previous change to other MPI predefined globals.
Except MPI_COMM_WORLD because of its specificities (has to be a variable)

3 years agosonar is right here
Augustin Degomme [Mon, 8 Mar 2021 07:25:12 +0000 (08:25 +0100)]
sonar is right here

3 years agochange the way MPI datatypes are declared.
Augustin Degomme [Mon, 8 Mar 2021 00:05:00 +0000 (01:05 +0100)]
change the way MPI datatypes are declared.
Our previous solution did not let everything seen as const, and it was preventing some codes to compile (initializer element is not constant).
This allows to compile  https://github.com/open-mpi/mpi-test-suite.git without changint the code (will be added in proxy apps) in tst_types.c
todo : other types (op and co)

3 years agodebug message --
Augustin Degomme [Sun, 7 Mar 2021 19:38:24 +0000 (20:38 +0100)]
debug message --

3 years agoUse flags to handle cancellation instead of a tri-state int
Augustin Degomme [Sun, 7 Mar 2021 17:36:40 +0000 (18:36 +0100)]
Use flags to handle cancellation instead of a tri-state int

3 years agoChange handling of MPI_PROC_NULL as a src or a dest.
Augustin Degomme [Sun, 7 Mar 2021 17:10:58 +0000 (18:10 +0100)]
Change handling of MPI_PROC_NULL as a src or a dest.
We used to just skip the requests, but it was not possible to set status->MPI_SOURCE later in this case.