Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
3 years agoUse typed Mailbox::get<>() instead of using static_cast everywhere.
Arnaud Giersch [Thu, 17 Dec 2020 09:01:36 +0000 (10:01 +0100)]
Use typed Mailbox::get<>() instead of using static_cast everywhere.

3 years agoPrepare the deprecation of untyped Mailbox::get functions.
Arnaud Giersch [Thu, 17 Dec 2020 10:03:25 +0000 (11:03 +0100)]
Prepare the deprecation of untyped Mailbox::get functions.

3 years agoDefine typed templates for Mailbox::get and Mailbox::get_async.
Arnaud Giersch [Thu, 17 Dec 2020 08:27:50 +0000 (09:27 +0100)]
Define typed templates for Mailbox::get and Mailbox::get_async.

3 years agoFix use-after-scope.
Arnaud Giersch [Thu, 17 Dec 2020 08:43:19 +0000 (09:43 +0100)]
Fix use-after-scope.

3 years agoUse sensible names for variables.
Arnaud Giersch [Thu, 17 Dec 2020 11:00:15 +0000 (12:00 +0100)]
Use sensible names for variables.

3 years agoUseless std::move (sonar).
Arnaud Giersch [Thu, 17 Dec 2020 07:51:58 +0000 (08:51 +0100)]
Useless std::move (sonar).

3 years agoDocument deprecated features that got removed
Martin Quinson [Thu, 17 Dec 2020 08:24:16 +0000 (09:24 +0100)]
Document deprecated features that got removed

3 years agocleanup the release instructions according to the recent release experience
Martin Quinson [Thu, 17 Dec 2020 07:01:08 +0000 (08:01 +0100)]
cleanup the release instructions according to the recent release experience

3 years agoOpen target file with O_EXCL for smpi_copy_file.
Arnaud Giersch [Wed, 16 Dec 2020 17:55:30 +0000 (18:55 +0100)]
Open target file with O_EXCL for smpi_copy_file.

Rationale: target file may be in a publicly writable directory like /tmp and
subject to symlink attack.

Also unlink any previously existing file before calling open().

3 years agoAdd an assert for fopen.
Arnaud Giersch [Wed, 16 Dec 2020 16:56:42 +0000 (17:56 +0100)]
Add an assert for fopen.

3 years agoUse transparent comparator 'std::less<>' with associative string container (sonar).
Arnaud Giersch [Wed, 16 Dec 2020 16:40:57 +0000 (17:40 +0100)]
Use transparent comparator 'std::less<>' with associative string container (sonar).

See https://sonarcloud.io/organizations/simgrid/rules?open=cpp%3AS6045&rule_key=cpp%3AS6045

3 years agobind_flag() with valid_values only works with std:string anyway.
Arnaud Giersch [Wed, 16 Dec 2020 16:29:01 +0000 (17:29 +0100)]
bind_flag() with valid_values only works with std:string anyway.

Don't hide is behind template parameter.

3 years agoAvoid unnecessary copy by using a 'const' reference (sonar).
Arnaud Giersch [Wed, 16 Dec 2020 13:32:01 +0000 (14:32 +0100)]
Avoid unnecessary copy by using a 'const' reference (sonar).

3 years agoPrefer using emplace or emplace_back.
Arnaud Giersch [Wed, 16 Dec 2020 10:50:58 +0000 (11:50 +0100)]
Prefer using emplace or emplace_back.

3 years agoAvoid useless creation of temporary objects with emplace_back (sonar).
Arnaud Giersch [Wed, 16 Dec 2020 10:20:00 +0000 (11:20 +0100)]
Avoid useless creation of temporary objects with emplace_back (sonar).

3 years agoReplace for-loop with std::any_of.
Arnaud Giersch [Wed, 16 Dec 2020 10:14:23 +0000 (11:14 +0100)]
Replace for-loop with std::any_of.

3 years agoDeclare function 'const'.
Arnaud Giersch [Wed, 16 Dec 2020 10:22:50 +0000 (11:22 +0100)]
Declare function 'const'.

3 years agoUse a single =, for POSIX conformance.
Arnaud Giersch [Tue, 15 Dec 2020 22:02:47 +0000 (23:02 +0100)]
Use a single =, for POSIX conformance.

3 years agoCosmetics (and one less memleak).
Arnaud Giersch [Tue, 15 Dec 2020 22:02:47 +0000 (23:02 +0100)]
Cosmetics (and one less memleak).

3 years agoIntroduce next XBT_DEPRECATED macro.
Arnaud Giersch [Tue, 15 Dec 2020 22:01:53 +0000 (23:01 +0100)]
Introduce next XBT_DEPRECATED macro.

3 years agoRemove deprecated features for next release.
Arnaud Giersch [Fri, 21 Feb 2020 13:47:14 +0000 (14:47 +0100)]
Remove deprecated features for next release.

3 years agoImprove deprecation warning.
Arnaud Giersch [Tue, 15 Dec 2020 21:59:54 +0000 (22:59 +0100)]
Improve deprecation warning.

In fact, we remove deprecated feature at the start of each dev cycle, thus any following
minor version have them removed too.

3 years agoStart the dev of 3.27.
Arnaud Giersch [Tue, 15 Dec 2020 21:56:58 +0000 (22:56 +0100)]
Start the dev of 3.27.

3 years agofix github action
adegomme [Wed, 16 Dec 2020 11:32:31 +0000 (12:32 +0100)]
fix github action

see https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files

3 years agogithub-ci: try to use the new syntax to set env variables
Martin Quinson [Tue, 15 Dec 2020 23:39:17 +0000 (00:39 +0100)]
github-ci: try to use the new syntax to set env variables

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

3 years agogithub CI: try to ease its paranoia
Martin Quinson [Tue, 15 Dec 2020 23:31:08 +0000 (00:31 +0100)]
github CI: try to ease its paranoia

3 years agoCI: More robust way to compute the version on stable builds
Martin Quinson [Tue, 15 Dec 2020 23:20:40 +0000 (00:20 +0100)]
CI: More robust way to compute the version on stable builds

3 years agoOSX node on jenkins was renamed
Martin Quinson [Tue, 15 Dec 2020 23:10:56 +0000 (00:10 +0100)]
OSX node on jenkins was renamed

3 years agoRelease v3.26 v3.26
Martin Quinson [Tue, 15 Dec 2020 20:15:54 +0000 (21:15 +0100)]
Release v3.26

3 years agojenkins : expand OS list with NS3, as I just installed ns3 3.32 on nixos
Augustin Degomme [Tue, 15 Dec 2020 17:34:57 +0000 (18:34 +0100)]
jenkins : expand OS list with NS3, as I just installed ns3 3.32 on nixos

3 years agotest failure fix for #45.
Augustin Degomme [Tue, 15 Dec 2020 14:50:28 +0000 (15:50 +0100)]
test failure fix for #45.
On NS3 < 3.30 there was a constraint on NSS value vs MCS value, which was lifted since.
Add an explicit message and bail out before crashing.
And use a supported value for the example file, in order not to fail tests. This does not seem to affect tests.

3 years agowarning --
Augustin Degomme [Tue, 15 Dec 2020 12:28:31 +0000 (13:28 +0100)]
warning --

3 years agouse new name for wifi standard in recent NS3.
Augustin Degomme [Tue, 15 Dec 2020 11:00:00 +0000 (12:00 +0100)]
use new name for wifi standard in recent NS3.

3 years agoMerge branch 'Adrien.Gougeon/simgrid-master'
Augustin Degomme [Tue, 15 Dec 2020 09:44:33 +0000 (10:44 +0100)]
Merge branch 'Adrien.Gougeon/simgrid-master'

3 years agoUpdate MANIFEST.in.
Arnaud Giersch [Tue, 15 Dec 2020 08:34:35 +0000 (09:34 +0100)]
Update MANIFEST.in.

3 years agoRemove unused static functions.
Arnaud Giersch [Sat, 12 Dec 2020 16:36:39 +0000 (17:36 +0100)]
Remove unused static functions.

3 years agoPrefer range-based for loop.
Arnaud Giersch [Sat, 12 Dec 2020 13:08:25 +0000 (14:08 +0100)]
Prefer range-based for loop.

3 years agoDrop unused parameter.
Arnaud Giersch [Sat, 12 Dec 2020 12:40:43 +0000 (13:40 +0100)]
Drop unused parameter.

3 years agoTypo in function name.
Arnaud Giersch [Sat, 12 Dec 2020 12:39:11 +0000 (13:39 +0100)]
Typo in function name.

3 years agoRedundant blank line.
Arnaud Giersch [Fri, 11 Dec 2020 20:48:50 +0000 (21:48 +0100)]
Redundant blank line.

3 years agoUpdate ChangeLog
Augustin Degomme [Tue, 15 Dec 2020 08:30:44 +0000 (09:30 +0100)]
Update ChangeLog

3 years agoMerge pull request #371 from eazimi/master
Martin Quinson [Fri, 11 Dec 2020 15:35:43 +0000 (16:35 +0100)]
Merge pull request #371 from eazimi/master

In the LivenessChecker

3 years agoCleanup!
Ehsan Azimi [Fri, 11 Dec 2020 12:36:45 +0000 (13:36 +0100)]
Cleanup!

3 years agomc_api::set_checker() defined and called in Checker()
Ehsan Azimi [Fri, 11 Dec 2020 12:32:12 +0000 (13:32 +0100)]
mc_api::set_checker() defined and called in Checker()

3 years agocreate_checker without Session argument
Ehsan Azimi [Fri, 11 Dec 2020 12:00:31 +0000 (13:00 +0100)]
create_checker without Session argument

3 years agocreateCommunicationDeterminismChecker without Session argument
Ehsan Azimi [Fri, 11 Dec 2020 11:52:52 +0000 (12:52 +0100)]
createCommunicationDeterminismChecker without Session argument

3 years agoconstructor without Session argument
Ehsan Azimi [Fri, 11 Dec 2020 11:49:05 +0000 (12:49 +0100)]
constructor without Session argument

3 years agocreateSafetyChecker without Session argument
Ehsan Azimi [Fri, 11 Dec 2020 11:47:04 +0000 (12:47 +0100)]
createSafetyChecker without Session argument

3 years agoconstructor without Session argument
Ehsan Azimi [Fri, 11 Dec 2020 11:44:32 +0000 (12:44 +0100)]
constructor without Session argument

3 years agocreateLivenessChecker without Session argument
Ehsan Azimi [Fri, 11 Dec 2020 11:40:39 +0000 (12:40 +0100)]
createLivenessChecker without Session argument

3 years agoconstructor without Session argument
Ehsan Azimi [Fri, 11 Dec 2020 11:39:54 +0000 (12:39 +0100)]
constructor without Session argument

3 years agoSession instance removed from Checker class
Ehsan Azimi [Fri, 11 Dec 2020 11:17:06 +0000 (12:17 +0100)]
Session instance removed from Checker class

3 years agoget_session() deleted
Ehsan Azimi [Fri, 11 Dec 2020 11:08:32 +0000 (12:08 +0100)]
get_session() deleted

3 years agomcapi::mc_inc_executed_trans() in replay()
Ehsan Azimi [Fri, 11 Dec 2020 11:04:14 +0000 (12:04 +0100)]
mcapi::mc_inc_executed_trans() in replay()

3 years agomcapi::execute() in replay()
Ehsan Azimi [Fri, 11 Dec 2020 11:03:53 +0000 (12:03 +0100)]
mcapi::execute() in replay()

3 years agomcapi::restore_initial_state() in replay()
Ehsan Azimi [Fri, 11 Dec 2020 11:03:27 +0000 (12:03 +0100)]
mcapi::restore_initial_state() in replay()

3 years agomcapi::simcall_get_issuer() in replay()
Ehsan Azimi [Fri, 11 Dec 2020 10:46:37 +0000 (11:46 +0100)]
mcapi::simcall_get_issuer() in replay()

3 years agomcapi::restore_state() in replay()
Ehsan Azimi [Fri, 11 Dec 2020 10:42:12 +0000 (11:42 +0100)]
mcapi::restore_state() in replay()

3 years agomc_api::get().get_actors_size() called in VisitedPair()
Ehsan Azimi [Fri, 11 Dec 2020 09:53:15 +0000 (10:53 +0100)]
mc_api::get().get_actors_size() called in VisitedPair()

3 years agomcapi::get().get_remote_heap_bytes() called in VisitedPair()
Ehsan Azimi [Fri, 11 Dec 2020 09:52:53 +0000 (10:52 +0100)]
mcapi::get().get_remote_heap_bytes() called in VisitedPair()

3 years agoMerge with simgrid/master
Ehsan Azimi [Fri, 11 Dec 2020 08:59:39 +0000 (09:59 +0100)]
Merge with simgrid/master

3 years agoTry to fix download links in doc.
Arnaud Giersch [Thu, 10 Dec 2020 21:24:43 +0000 (22:24 +0100)]
Try to fix download links in doc.

3 years agoFix file names for examples in doc.
Arnaud Giersch [Thu, 10 Dec 2020 21:18:34 +0000 (22:18 +0100)]
Fix file names for examples in doc.

3 years agoAdd #include <simgrid/config.h>.
Arnaud Giersch [Thu, 10 Dec 2020 21:11:42 +0000 (22:11 +0100)]
Add #include <simgrid/config.h>.

3 years agoRemove mostly empty files.
Arnaud Giersch [Thu, 10 Dec 2020 21:06:12 +0000 (22:06 +0100)]
Remove mostly empty files.

3 years agoDon't define (nor use) any MSG symbol when MSG is not built in.
Arnaud Giersch [Thu, 10 Dec 2020 20:24:29 +0000 (21:24 +0100)]
Don't define (nor use) any MSG symbol when MSG is not built in.

3 years agoMove bits of documentation for recently converted tracing examples.
Arnaud Giersch [Thu, 10 Dec 2020 20:13:32 +0000 (21:13 +0100)]
Move bits of documentation for recently converted tracing examples.

3 years ago[jenkins] Temporary disable LTO on CentOS/ld 2.30-85.el8.
Arnaud Giersch [Thu, 10 Dec 2020 10:35:14 +0000 (11:35 +0100)]
[jenkins] Temporary disable LTO on CentOS/ld 2.30-85.el8.

3 years agoA bit of cleanup in .gitignore.
Arnaud Giersch [Thu, 10 Dec 2020 10:29:47 +0000 (11:29 +0100)]
A bit of cleanup in .gitignore.

3 years agoConvert deprecated/msg/trace-process-migration to s4u/trace-process-migration.
Arnaud Giersch [Tue, 8 Dec 2020 10:03:28 +0000 (11:03 +0100)]
Convert deprecated/msg/trace-process-migration to s4u/trace-process-migration.

3 years agoKill dead code: tracing_category is managed by AnyActivity.
Arnaud Giersch [Wed, 9 Dec 2020 23:28:43 +0000 (00:28 +0100)]
Kill dead code: tracing_category is managed by AnyActivity.

3 years agoMore conversions int -> aid_t.
Arnaud Giersch [Thu, 10 Dec 2020 07:56:03 +0000 (08:56 +0100)]
More conversions int -> aid_t.

3 years agoUse dedicated function to get config value.
Arnaud Giersch [Wed, 9 Dec 2020 13:06:50 +0000 (14:06 +0100)]
Use dedicated function to get config value.

3 years agoFix type for parameter 'issuer'.
Arnaud Giersch [Wed, 2 Dec 2020 10:56:53 +0000 (11:56 +0100)]
Fix type for parameter 'issuer'.

3 years agoConst pointer.
Arnaud Giersch [Wed, 2 Dec 2020 10:53:15 +0000 (11:53 +0100)]
Const pointer.

3 years agoRemove old deprecated aliases for runtime options.
Arnaud Giersch [Tue, 8 Dec 2020 20:15:32 +0000 (21:15 +0100)]
Remove old deprecated aliases for runtime options.

Add a 'DEPRECATED' comment for the more recent ones.

3 years agoRename runtime option 'tracing/msg/process' to 'tracing/actor'.
Arnaud Giersch [Tue, 8 Dec 2020 20:06:17 +0000 (21:06 +0100)]
Rename runtime option 'tracing/msg/process' to 'tracing/actor'.

3 years agoFix log category for example.
Arnaud Giersch [Tue, 8 Dec 2020 20:01:54 +0000 (21:01 +0100)]
Fix log category for example.

3 years agoFire Comm::on_completion in any case.
Arnaud Giersch [Tue, 8 Dec 2020 14:49:40 +0000 (15:49 +0100)]
Fire Comm::on_completion in any case.

3 years agomc_api::get_automaton_transition_dst() defined and called in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:51:48 +0000 (17:51 +0100)]
mc_api::get_automaton_transition_dst() defined and called in run()

3 years agomc_api::get_automaton_transition_label() defined and called in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:48:48 +0000 (17:48 +0100)]
mc_api::get_automaton_transition_label() defined and called in run()

3 years agomc_api::get_dynar_length() defined and called in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:33:30 +0000 (17:33 +0100)]
mc_api::get_dynar_length() defined and called in run()

3 years agomcapi::log_state() in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:14:27 +0000 (17:14 +0100)]
mcapi::log_state() in run()

3 years agomcapi::mc_wait_for_requests() in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:14:06 +0000 (17:14 +0100)]
mcapi::mc_wait_for_requests() in run()

3 years agomcapi::handle_simcall() in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:13:41 +0000 (17:13 +0100)]
mcapi::handle_simcall() in run()

3 years agomcapi::mc_inc_executed_trans() in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:13:15 +0000 (17:13 +0100)]
mcapi::mc_inc_executed_trans() in run()

3 years agonullptr one more time.
Arnaud Giersch [Tue, 8 Dec 2020 11:41:21 +0000 (12:41 +0100)]
nullptr one more time.

3 years agorequest_to_string() implementation in mc_api class
Ehsan Azimi [Tue, 8 Dec 2020 11:04:22 +0000 (12:04 +0100)]
request_to_string() implementation in mc_api class

3 years agoPull from simgrid/master and a subsequent merge with origin/master
Ehsan Azimi [Tue, 8 Dec 2020 10:41:59 +0000 (11:41 +0100)]
Pull from simgrid/master and a subsequent merge with origin/master

3 years agorequest_get_dot_output() implementation in mc_api class
Ehsan Azimi [Tue, 8 Dec 2020 10:41:37 +0000 (11:41 +0100)]
request_get_dot_output() implementation in mc_api class

3 years agomcapi::request_get_dot_output() called in run()
Ehsan Azimi [Tue, 8 Dec 2020 10:40:02 +0000 (11:40 +0100)]
mcapi::request_get_dot_output() called in run()

3 years agoConvert deprecated/msg/trace-masterworker to s4u/trace-masterworkers.
Arnaud Giersch [Mon, 7 Dec 2020 22:49:17 +0000 (23:49 +0100)]
Convert deprecated/msg/trace-masterworker to s4u/trace-masterworkers.

3 years agomcapi::snapshot_equal() in insert_visited_pair()
Ehsan Azimi [Tue, 8 Dec 2020 09:52:33 +0000 (10:52 +0100)]
mcapi::snapshot_equal() in insert_visited_pair()

3 years agomcapi::automaton_state_compare() in insert_visited_pair()
Ehsan Azimi [Tue, 8 Dec 2020 09:52:02 +0000 (10:52 +0100)]
mcapi::automaton_state_compare() in insert_visited_pair()

3 years agomcapi::snapshot_equal() called in insert_acceptance_pair()
Ehsan Azimi [Tue, 8 Dec 2020 09:37:36 +0000 (10:37 +0100)]
mcapi::snapshot_equal() called in insert_acceptance_pair()

3 years agomc_api::automaton_state_compare() defined. It's called in insert_acceptance_pair()
Ehsan Azimi [Tue, 8 Dec 2020 09:37:12 +0000 (10:37 +0100)]
mc_api::automaton_state_compare() defined. It's called in insert_acceptance_pair()

3 years agomcapi::compare_pair() in insert_acceptance_pair()
Ehsan Azimi [Tue, 8 Dec 2020 09:23:32 +0000 (10:23 +0100)]
mcapi::compare_pair() in insert_acceptance_pair()

3 years agomcapi::compare_pair() in addVisitedState()
Ehsan Azimi [Tue, 8 Dec 2020 09:07:59 +0000 (10:07 +0100)]
mcapi::compare_pair() in addVisitedState()

3 years agomc_api::compare_pair() defined, it's called in insert_visited_pair()
Ehsan Azimi [Tue, 8 Dec 2020 08:52:28 +0000 (09:52 +0100)]
mc_api::compare_pair() defined, it's called in insert_visited_pair()

3 years agoA Pull from simgrid/master and a subsequent merge
Ehsan Azimi [Tue, 8 Dec 2020 08:35:45 +0000 (09:35 +0100)]
A Pull from simgrid/master and a subsequent merge