Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
3 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
agougeon [Sun, 22 Nov 2020 15:20:30 +0000 (16:20 +0100)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

3 years agoUse ssize_t.
Arnaud Giersch [Sun, 22 Nov 2020 14:14:02 +0000 (15:14 +0100)]
Use ssize_t.

3 years ago[sonar] Extract assignment from sub-expression.
Arnaud Giersch [Sun, 22 Nov 2020 14:11:27 +0000 (15:11 +0100)]
[sonar] Extract assignment from sub-expression.

3 years agoGot SIGBUS with std::array; give std::vector a try.
Arnaud Giersch [Sun, 22 Nov 2020 13:45:26 +0000 (14:45 +0100)]
Got SIGBUS with std::array; give std::vector a try.

3 years agoRevert "Use nullptr for recvbuf when myrank != 0."
Arnaud Giersch [Sun, 22 Nov 2020 09:11:20 +0000 (10:11 +0100)]
Revert "Use nullptr for recvbuf when myrank != 0."

This reverts commit cc88d06e4fd1c32dddf17295ff750c60792588e5.

As expected it makes no difference, and it's simpler.

3 years agowe use this variable later on
Augustin Degomme [Sun, 22 Nov 2020 13:09:34 +0000 (14:09 +0100)]
we use this variable later on

3 years agopython detection with pythoninterp was deprecated in cmake 3.12. And breaks in 3.19
Augustin Degomme [Sun, 22 Nov 2020 12:19:51 +0000 (13:19 +0100)]
python detection with pythoninterp was deprecated in cmake 3.12. And breaks in 3.19

3 years agoUse nullptr for recvbuf when myrank != 0.
Arnaud Giersch [Sat, 21 Nov 2020 22:28:17 +0000 (23:28 +0100)]
Use nullptr for recvbuf when myrank != 0.

Not sure if it makes any difference, but it was like that before.

3 years agoFix test requirement (and add missing semicolon).
Arnaud Giersch [Sat, 21 Nov 2020 21:23:13 +0000 (22:23 +0100)]
Fix test requirement (and add missing semicolon).

3 years agoKill two unused helper functions.
Arnaud Giersch [Sat, 21 Nov 2020 14:51:29 +0000 (15:51 +0100)]
Kill two unused helper functions.

3 years agoRemove more new/delete, this time for lmm::System in maxmin tests.
Arnaud Giersch [Sat, 21 Nov 2020 14:33:46 +0000 (15:33 +0100)]
Remove more new/delete, this time for lmm::System in maxmin tests.

3 years agoRemove useless new/delete (please sonar).
Arnaud Giersch [Fri, 20 Nov 2020 23:19:38 +0000 (00:19 +0100)]
Remove useless new/delete (please sonar).

3 years agoAdapt to std::vector.
Arnaud Giersch [Sat, 21 Nov 2020 13:26:22 +0000 (14:26 +0100)]
Adapt to std::vector.

3 years agoReplace dynamic C-style arrays with std::vector.
Arnaud Giersch [Fri, 20 Nov 2020 20:54:06 +0000 (21:54 +0100)]
Replace dynamic C-style arrays with std::vector.

3 years agoReplace fixed-size C-style arrays with std::array.
Arnaud Giersch [Fri, 20 Nov 2020 20:52:39 +0000 (21:52 +0100)]
Replace fixed-size C-style arrays with std::array.

3 years agoUse more std::string.
Arnaud Giersch [Fri, 20 Nov 2020 20:43:47 +0000 (21:43 +0100)]
Use more std::string.

3 years agoMisc simplifications.
Arnaud Giersch [Fri, 20 Nov 2020 20:36:48 +0000 (21:36 +0100)]
Misc simplifications.

3 years agoMake pointer parameter const.
Arnaud Giersch [Fri, 20 Nov 2020 14:41:44 +0000 (15:41 +0100)]
Make pointer parameter const.

3 years agoone day, I'll add a test for this feature
Augustin Degomme [Thu, 19 Nov 2020 17:41:01 +0000 (18:41 +0100)]
one day, I'll add a test for this feature

3 years agoDefine NUM_SIMCALLS apart from the enum.
Arnaud Giersch [Thu, 19 Nov 2020 12:53:48 +0000 (13:53 +0100)]
Define NUM_SIMCALLS apart from the enum.

3 years agoDon't call function inside xbt_assert which may be disabled.
Arnaud Giersch [Thu, 19 Nov 2020 11:58:26 +0000 (12:58 +0100)]
Don't call function inside xbt_assert which may be disabled.

3 years agoVariables captured by copy are constant and cannot be std::move'd.
Arnaud Giersch [Thu, 19 Nov 2020 08:35:48 +0000 (09:35 +0100)]
Variables captured by copy are constant and cannot be std::move'd.

Try to fix with C++14 generalized lambda capture and 'mutable' specifier.

3 years agoMore useless std::move.
Arnaud Giersch [Thu, 19 Nov 2020 08:34:33 +0000 (09:34 +0100)]
More useless std::move.

3 years agoCosmetics.
Arnaud Giersch [Thu, 19 Nov 2020 07:44:47 +0000 (08:44 +0100)]
Cosmetics.

3 years agoConstify some sg_vm_t.
Arnaud Giersch [Thu, 19 Nov 2020 07:41:12 +0000 (08:41 +0100)]
Constify some sg_vm_t.

3 years agothis message does no harm
Augustin Degomme [Thu, 19 Nov 2020 09:59:21 +0000 (10:59 +0100)]
this message does no harm

3 years agoRevert "attempt to avoid ugly sed in privatize-libs. May break."
Augustin Degomme [Thu, 19 Nov 2020 09:40:56 +0000 (10:40 +0100)]
Revert "attempt to avoid ugly sed in privatize-libs. May break."

This reverts commit c8cd61907048eff98533558f3aa7393cb6cfd424.

3 years agoRevert "Intel icc doesn't like attribute [[deprecated]] with "using"."
Arnaud Giersch [Wed, 18 Nov 2020 23:01:48 +0000 (00:01 +0100)]
Revert "Intel icc doesn't like attribute [[deprecated]] with "using"."

This reverts commit b38bb1786983cd04c54ec57dc21d3f8a061e5f74.

3 years agoIcc: ignore #2651: attribute does not apply to any entity
Arnaud Giersch [Wed, 18 Nov 2020 23:00:36 +0000 (00:00 +0100)]
Icc: ignore #2651: attribute does not apply to any entity

See
https://community.intel.com/t5/Intel-C-Compiler/Bug-report-Spurious-2651-warning-for-deprecating-a-quot-using/td-p/1144317

Also write numbers in order.

3 years agoUseless std::move.
Arnaud Giersch [Wed, 18 Nov 2020 22:51:02 +0000 (23:51 +0100)]
Useless std::move.

3 years agoUse inherited constructors for derived exceptions.
Arnaud Giersch [Wed, 18 Nov 2020 22:29:04 +0000 (23:29 +0100)]
Use inherited constructors for derived exceptions.

3 years agoUse 'using-declarations' to inherit constructors.
Arnaud Giersch [Wed, 18 Nov 2020 22:15:52 +0000 (23:15 +0100)]
Use 'using-declarations' to inherit constructors.

3 years agoEnum class for Paje event types.
Arnaud Giersch [Wed, 18 Nov 2020 20:08:35 +0000 (21:08 +0100)]
Enum class for Paje event types.

3 years agoEnum class in examples/s4u/dht-chord/.
Arnaud Giersch [Wed, 18 Nov 2020 17:23:52 +0000 (18:23 +0100)]
Enum class in examples/s4u/dht-chord/.

3 years agoEnum class in examples/s4u/app-bittorrent/.
Arnaud Giersch [Wed, 18 Nov 2020 17:04:03 +0000 (18:04 +0100)]
Enum class in examples/s4u/app-bittorrent/.

3 years agoEnum class in teshsuite/mc/random-bug/.
Arnaud Giersch [Wed, 18 Nov 2020 16:58:40 +0000 (17:58 +0100)]
Enum class in teshsuite/mc/random-bug/.

3 years agoFix function name in doc.
Arnaud Giersch [Wed, 18 Nov 2020 21:14:57 +0000 (22:14 +0100)]
Fix function name in doc.

3 years agoIntel icc doesn't like attribute [[deprecated]] with "using".
Arnaud Giersch [Wed, 18 Nov 2020 16:45:21 +0000 (17:45 +0100)]
Intel icc doesn't like attribute [[deprecated]] with "using".

3 years agoPrefer "using" to "typedef".
Arnaud Giersch [Wed, 18 Nov 2020 15:11:29 +0000 (16:11 +0100)]
Prefer "using" to "typedef".

3 years agoMore const.
Arnaud Giersch [Wed, 18 Nov 2020 14:06:09 +0000 (15:06 +0100)]
More const.

3 years agoUse =default.
Arnaud Giersch [Wed, 18 Nov 2020 13:44:58 +0000 (14:44 +0100)]
Use =default.

3 years agoMore const pointers.
Arnaud Giersch [Wed, 18 Nov 2020 13:43:05 +0000 (14:43 +0100)]
More const pointers.

3 years agoKill dead code.
Arnaud Giersch [Wed, 18 Nov 2020 13:27:35 +0000 (14:27 +0100)]
Kill dead code.

3 years agoConst Disk*.
Arnaud Giersch [Wed, 18 Nov 2020 13:25:34 +0000 (14:25 +0100)]
Const Disk*.

3 years agoPlease Sonar (even if there was no bug).
Arnaud Giersch [Wed, 18 Nov 2020 12:00:11 +0000 (13:00 +0100)]
Please Sonar (even if there was no bug).

3 years agoRemove redundant "staitc" in anonymous namespaces.
Arnaud Giersch [Wed, 18 Nov 2020 09:52:00 +0000 (10:52 +0100)]
Remove redundant "staitc" in anonymous namespaces.

3 years agoagain..
Augustin Degomme [Wed, 18 Nov 2020 09:23:06 +0000 (10:23 +0100)]
again..

3 years agoet ça continue, encore et encore...
Augustin Degomme [Tue, 17 Nov 2020 23:28:01 +0000 (00:28 +0100)]
et ça continue, encore et encore...

3 years agoattempt to avoid ugly sed in privatize-libs. May break.
Augustin Degomme [Tue, 17 Nov 2020 22:14:21 +0000 (23:14 +0100)]
attempt to avoid ugly sed in privatize-libs. May break.

3 years agomove dlopen tmp files to tmp dir instead of executable dir, which could be not writeable.
Augustin Degomme [Tue, 17 Nov 2020 22:13:34 +0000 (23:13 +0100)]
move dlopen tmp files to tmp dir instead of executable dir, which could be not writeable.
todo :
- check portability
- move also smpirun tmp files there id this works.

3 years agoone more lib to exclude ... we should really get rid of this in MC, no?
Augustin Degomme [Tue, 17 Nov 2020 16:53:00 +0000 (17:53 +0100)]
one more lib to exclude ... we should really get rid of this in MC, no?

3 years agoPrefer class initializer for id_.
Arnaud Giersch [Wed, 11 Nov 2020 21:22:25 +0000 (22:22 +0100)]
Prefer class initializer for id_.

3 years agoCosmetics.
Arnaud Giersch [Wed, 11 Nov 2020 20:51:26 +0000 (21:51 +0100)]
Cosmetics.

3 years agoAvoid nested try-catch blocks.
Arnaud Giersch [Wed, 11 Nov 2020 14:21:41 +0000 (15:21 +0100)]
Avoid nested try-catch blocks.

3 years agoReduce scope for variable.
Arnaud Giersch [Wed, 11 Nov 2020 14:16:04 +0000 (15:16 +0100)]
Reduce scope for variable.

3 years agoexclude lib for mc on freebsd
Augustin Degomme [Mon, 9 Nov 2020 15:23:45 +0000 (16:23 +0100)]
exclude lib for mc on freebsd

3 years agoDocument recent bug fix
Martin Quinson [Sat, 7 Nov 2020 21:25:56 +0000 (22:25 +0100)]
Document recent bug fix

3 years agopython: force pybind11 discovery (#353)
Matthieu Simonin [Sat, 7 Nov 2020 21:23:25 +0000 (22:23 +0100)]
python: force pybind11 discovery (#353)

Fix #352

3 years agoFix the bug number, bummer
Martin Quinson [Thu, 5 Nov 2020 07:00:28 +0000 (08:00 +0100)]
Fix the bug number, bummer

3 years agobug fixed
Martin Quinson [Wed, 4 Nov 2020 20:51:30 +0000 (21:51 +0100)]
bug fixed

3 years agoMake code simpler.
Arnaud Giersch [Thu, 29 Oct 2020 20:43:20 +0000 (21:43 +0100)]
Make code simpler.

3 years agoDefine xbt::string::copy().
Arnaud Giersch [Thu, 29 Oct 2020 21:40:52 +0000 (22:40 +0100)]
Define xbt::string::copy().

3 years agoMove declarations.
Arnaud Giersch [Thu, 29 Oct 2020 21:40:30 +0000 (22:40 +0100)]
Move declarations.

3 years agoMore functions to declare "const".
Arnaud Giersch [Thu, 29 Oct 2020 16:38:51 +0000 (17:38 +0100)]
More functions to declare "const".

3 years agoUse xbt_die instead of xbt_assert(false).
Arnaud Giersch [Wed, 28 Oct 2020 17:03:57 +0000 (18:03 +0100)]
Use xbt_die instead of xbt_assert(false).

3 years agos/atof/stod/.
Arnaud Giersch [Wed, 28 Oct 2020 17:01:03 +0000 (18:01 +0100)]
s/atof/stod/.

3 years ago[sonar] global variable--
Arnaud Giersch [Wed, 28 Oct 2020 16:56:36 +0000 (17:56 +0100)]
[sonar] global variable--

3 years agoPrefer enum class over legacy enum.
Arnaud Giersch [Wed, 28 Oct 2020 16:32:40 +0000 (17:32 +0100)]
Prefer enum class over legacy enum.

3 years agoKill unused operator<<.
Arnaud Giersch [Wed, 28 Oct 2020 16:13:43 +0000 (17:13 +0100)]
Kill unused operator<<.

Moreover, the output format doesn't match the input format expected in Profile::from_string.

3 years agoOne more std::string.
Arnaud Giersch [Wed, 28 Oct 2020 10:52:35 +0000 (11:52 +0100)]
One more std::string.

3 years agoDon't keep port number 65535 apart.
Arnaud Giersch [Wed, 28 Oct 2020 10:32:40 +0000 (11:32 +0100)]
Don't keep port number 65535 apart.

3 years agoAvoid null pointer dereferencing.
Arnaud Giersch [Wed, 28 Oct 2020 10:02:02 +0000 (11:02 +0100)]
Avoid null pointer dereferencing.

3 years agoposix_fallocate does not exist on OSX, use ftruncate instead.
Arnaud Giersch [Tue, 27 Oct 2020 23:28:49 +0000 (00:28 +0100)]
posix_fallocate does not exist on OSX, use ftruncate instead.

3 years agoAdd a test for GH#345
Martin Quinson [Tue, 27 Oct 2020 23:24:27 +0000 (00:24 +0100)]
Add a test for GH#345

3 years agoKill redundant F2C::f2c_lookup.
Arnaud Giersch [Tue, 27 Oct 2020 22:00:37 +0000 (23:00 +0100)]
Kill redundant F2C::f2c_lookup.

3 years agoMake trivial functions inline.
Arnaud Giersch [Tue, 27 Oct 2020 22:03:19 +0000 (23:03 +0100)]
Make trivial functions inline.

3 years agoFinally use plain ints for f2c keys.
Arnaud Giersch [Tue, 27 Oct 2020 21:50:15 +0000 (22:50 +0100)]
Finally use plain ints for f2c keys.

3 years agoUse std::string for f2c keys.
Arnaud Giersch [Tue, 27 Oct 2020 21:42:34 +0000 (22:42 +0100)]
Use std::string for f2c keys.

3 years agoClosed bug.
Arnaud Giersch [Tue, 27 Oct 2020 17:04:08 +0000 (18:04 +0100)]
Closed bug.

3 years agoUse std::vector.
Arnaud Giersch [Mon, 26 Oct 2020 23:20:01 +0000 (00:20 +0100)]
Use std::vector.

3 years agoUse posix_fallocate to set file size.
Arnaud Giersch [Mon, 26 Oct 2020 23:14:05 +0000 (00:14 +0100)]
Use posix_fallocate to set file size.

3 years agons3 does not accept 0 as a port_number so don't let it nicely overleap
Martin Quinson [Tue, 27 Oct 2020 22:41:57 +0000 (23:41 +0100)]
ns3 does not accept 0 as a port_number so don't let it nicely overleap

3 years agons3: Fix a debug message (s/socket/flow/)
Martin Quinson [Tue, 27 Oct 2020 22:31:12 +0000 (23:31 +0100)]
ns3: Fix a debug message (s/socket/flow/)

3 years agoAccept very large port numbers, as ns-3 don't forbid them
Martin Quinson [Tue, 27 Oct 2020 22:09:14 +0000 (23:09 +0100)]
Accept very large port numbers, as ns-3 don't forbid them

3 years agoCorrectly set result for simcall_cond_wait_timeout.
Arnaud Giersch [Mon, 26 Oct 2020 10:58:32 +0000 (11:58 +0100)]
Correctly set result for simcall_cond_wait_timeout.

3 years agoUse std::vector.
Arnaud Giersch [Mon, 26 Oct 2020 10:41:46 +0000 (11:41 +0100)]
Use std::vector.

3 years agoUse std::array.
Arnaud Giersch [Mon, 26 Oct 2020 09:04:11 +0000 (10:04 +0100)]
Use std::array.

3 years agoUpdate, using std::string.
Arnaud Giersch [Mon, 26 Oct 2020 08:14:53 +0000 (09:14 +0100)]
Update, using std::string.

3 years agoFix UBSan warning.
Arnaud Giersch [Sun, 25 Oct 2020 13:55:01 +0000 (14:55 +0100)]
Fix UBSan warning.

smpi_datatype.cpp:360:15: runtime error: null pointer passed as argument 2, which is declared to never be null

3 years agoUse std::vector instead of C-style array.
Arnaud Giersch [Sat, 24 Oct 2020 21:25:58 +0000 (23:25 +0200)]
Use std::vector instead of C-style array.

3 years agoMake cast explicit.
Arnaud Giersch [Sat, 24 Oct 2020 20:54:12 +0000 (22:54 +0200)]
Make cast explicit.

3 years agoKill dead code (condition is always true).
Arnaud Giersch [Sat, 24 Oct 2020 20:11:15 +0000 (22:11 +0200)]
Kill dead code (condition is always true).

3 years agoRename local variable to not hide parameter.
Arnaud Giersch [Sat, 24 Oct 2020 19:35:28 +0000 (21:35 +0200)]
Rename local variable to not hide parameter.

3 years agoEscape dots in regexp.
Arnaud Giersch [Sat, 24 Oct 2020 19:30:59 +0000 (21:30 +0200)]
Escape dots in regexp.

3 years agoPrefer is/is not None.
Arnaud Giersch [Sat, 24 Oct 2020 19:24:10 +0000 (21:24 +0200)]
Prefer is/is not None.

3 years agoKill a no-op.
Arnaud Giersch [Sat, 24 Oct 2020 16:29:34 +0000 (18:29 +0200)]
Kill a no-op.

3 years agoCleanup.
Arnaud Giersch [Sat, 24 Oct 2020 16:27:05 +0000 (18:27 +0200)]
Cleanup.

3 years agoadd -lm to flags on smpicc smpicxx.
Augustin Degomme [Sat, 24 Oct 2020 15:30:39 +0000 (17:30 +0200)]
add -lm to flags on smpicc smpicxx.
We already had these in smpif90/ff, anf gcc10 seems to not be using it by default.
So this could help compatibility with some (proxy apps) codes, if harmless on other setups. Let's see.

3 years agoPointer-to-const for sonar.
Arnaud Giersch [Sat, 24 Oct 2020 08:38:56 +0000 (10:38 +0200)]
Pointer-to-const for sonar.

3 years agoDon't advertize a deprecated function.
Arnaud Giersch [Sat, 24 Oct 2020 08:35:16 +0000 (10:35 +0200)]
Don't advertize a deprecated function.