Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
2 years ago[sonar] Remove custom destructors for surf/PropertyHolder.
Arnaud Giersch [Wed, 17 Apr 2019 21:05:36 +0000 (23:05 +0200)]
[sonar] Remove custom destructors for surf/PropertyHolder.

2 years ago[sonar] Remove custom destructors for CpuTiProfile.
Arnaud Giersch [Wed, 17 Apr 2019 20:45:12 +0000 (22:45 +0200)]
[sonar] Remove custom destructors for CpuTiProfile.

2 years agoUse std algorithm for binary search.
Arnaud Giersch [Wed, 17 Apr 2019 20:37:11 +0000 (22:37 +0200)]
Use std algorithm for binary search.

2 years agoUseless smart pointer.
Arnaud Giersch [Wed, 17 Apr 2019 19:43:04 +0000 (21:43 +0200)]
Useless smart pointer.

2 years agoCosmetics.
Arnaud Giersch [Wed, 17 Apr 2019 19:31:37 +0000 (21:31 +0200)]
Cosmetics.

2 years agoTypo.
Arnaud Giersch [Wed, 17 Apr 2019 19:16:06 +0000 (21:16 +0200)]
Typo.

2 years agoUse the good interface.
Arnaud Giersch [Wed, 17 Apr 2019 19:13:32 +0000 (21:13 +0200)]
Use the good interface.

2 years agoSmart pointer is not necessary for Actor::self.
Arnaud Giersch [Wed, 17 Apr 2019 19:13:16 +0000 (21:13 +0200)]
Smart pointer is not necessary for Actor::self.

2 years agoInline Context::self().
Arnaud Giersch [Wed, 17 Apr 2019 19:03:36 +0000 (21:03 +0200)]
Inline Context::self().

2 years agoUniformize get_impl(): const attribute, and return raw pointer.
Arnaud Giersch [Wed, 17 Apr 2019 18:46:11 +0000 (20:46 +0200)]
Uniformize get_impl(): const attribute, and return raw pointer.

2 years agoMethods of simix::Global have direct access to their members.
Arnaud Giersch [Wed, 17 Apr 2019 10:55:08 +0000 (12:55 +0200)]
Methods of simix::Global have direct access to their members.

2 years ago[sonar] clean_action() called from destructor should not be overridable.
Arnaud Giersch [Wed, 10 Apr 2019 08:54:51 +0000 (10:54 +0200)]
[sonar] clean_action() called from destructor should not be overridable.

2 years agoDon't make exception on timeout.
Arnaud Giersch [Tue, 16 Apr 2019 12:08:42 +0000 (14:08 +0200)]
Don't make exception on timeout.

It breaks for example xbt_cond_timedwait which is expected to report timeout by
a regular return.

2 years agoDelete unused private function.
Arnaud Giersch [Mon, 15 Apr 2019 12:52:26 +0000 (14:52 +0200)]
Delete unused private function.

2 years ago[sonar] Remove custom destructors for routing/DragonflyZone.
Arnaud Giersch [Mon, 15 Apr 2019 12:32:52 +0000 (14:32 +0200)]
[sonar] Remove custom destructors for routing/DragonflyZone.

2 years ago[sonar] Remove custom destructors for surf/network_ib.
Arnaud Giersch [Mon, 15 Apr 2019 12:09:37 +0000 (14:09 +0200)]
[sonar] Remove custom destructors for surf/network_ib.

2 years ago[sonar] Remove custom destructors for xbt_replay.
Arnaud Giersch [Mon, 15 Apr 2019 10:01:10 +0000 (12:01 +0200)]
[sonar] Remove custom destructors for xbt_replay.

2 years ago[sonar] Remove custom destructors for examples/s4u/.
Arnaud Giersch [Mon, 15 Apr 2019 09:01:36 +0000 (11:01 +0200)]
[sonar] Remove custom destructors for examples/s4u/.

2 years agoDon't explode here, as flatifier may try exactly to do this.
degomme [Mon, 15 Apr 2019 10:44:47 +0000 (12:44 +0200)]
Don't explode here, as flatifier may try exactly to do this.

2 years agofrench comment --
degomme [Mon, 15 Apr 2019 09:51:06 +0000 (11:51 +0200)]
french comment --

2 years agoAllow units in smpi factors.
degomme [Mon, 15 Apr 2019 09:12:48 +0000 (11:12 +0200)]
Allow units in smpi factors.
To make it optional (as parse_factor is used for actual factors and not only seconds on some occasions), remove the warning in surf if a unit-less value is used.

2 years agoAvoid returning uninitialized bytes in fortran processor names.
degomme [Wed, 10 Apr 2019 09:25:33 +0000 (11:25 +0200)]
Avoid returning uninitialized bytes in fortran processor names.

2 years agoFix 32 bits build
Augustin Degomme [Sun, 14 Apr 2019 18:09:32 +0000 (20:09 +0200)]
Fix 32 bits build

2 years agoRevert "Reactivate an umpire test, once disabled in 56fefe1bf81ca."
Augustin Degomme [Sun, 14 Apr 2019 17:49:20 +0000 (19:49 +0200)]
Revert "Reactivate an umpire test, once disabled in 56fefe1bf81ca."

This reverts commit 1797da7d294b83c915fe49dad633855985eccb64.

2 years agodon't compile non working and non compiling test
Augustin Degomme [Sun, 14 Apr 2019 17:10:06 +0000 (19:10 +0200)]
don't compile non working and non compiling test

2 years agoPretend we support MPI 3.1.
Augustin Degomme [Sun, 14 Apr 2019 16:15:26 +0000 (18:15 +0200)]
Pretend we support MPI 3.1.
We don't support all of it, obviously, but what we have may be enough for some codes.

2 years agocomment tests we don't support in MPI3, and fix a few we support
Augustin Degomme [Sun, 14 Apr 2019 16:12:56 +0000 (18:12 +0200)]
comment tests we don't support in MPI3, and fix a few we support

2 years agoMPI_Count can be used in ops too.
Augustin Degomme [Sun, 14 Apr 2019 16:11:22 +0000 (18:11 +0200)]
MPI_Count can be used in ops too.

2 years agoMPI_INFO_ENV ... Still does nothing for now
Augustin Degomme [Sun, 14 Apr 2019 14:46:37 +0000 (16:46 +0200)]
MPI_INFO_ENV ... Still does nothing for now

2 years agoReactivate an umpire test, once disabled in 56fefe1bf81ca.
Augustin Degomme [Sun, 14 Apr 2019 14:09:43 +0000 (16:09 +0200)]
Reactivate an umpire test, once disabled in 56fefe1bf81ca.

2 years agoMPI_Comm_get_info, MPI_Comm_set_info
Augustin Degomme [Sun, 14 Apr 2019 14:08:37 +0000 (16:08 +0200)]
MPI_Comm_get_info, MPI_Comm_set_info

2 years agoSupport MPI3 datatype MPI_Count
Augustin Degomme [Sun, 14 Apr 2019 14:07:55 +0000 (16:07 +0200)]
Support MPI3 datatype MPI_Count

2 years agoplease sonar: replace void* by unsigned char* for raw buffer
Frederic Suter [Sat, 13 Apr 2019 15:50:40 +0000 (17:50 +0200)]
please sonar: replace void* by unsigned char* for raw buffer

2 years agoplease sonar
Frederic Suter [Sat, 13 Apr 2019 15:20:39 +0000 (17:20 +0200)]
please sonar

2 years agoyet another attempt to handle MPI special values in fortran
Augustin Degomme [Sat, 13 Apr 2019 10:57:10 +0000 (12:57 +0200)]
yet another attempt to handle MPI special values in fortran
Without dereferencing potentially unassigned variables.
Old way with a struct and common block does not work with dlopen provatization somehow.

2 years agomove CPU models to kernel::resource too
Frederic Suter [Fri, 12 Apr 2019 12:34:36 +0000 (14:34 +0200)]
move CPU models to kernel::resource too

2 years agocosmetic cleanups in network models
Frederic Suter [Fri, 12 Apr 2019 11:26:51 +0000 (13:26 +0200)]
cosmetic cleanups in network models

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Fri, 12 Apr 2019 11:01:51 +0000 (13:01 +0200)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years agochanging namespace for cpu_interface
Frederic Suter [Fri, 12 Apr 2019 11:01:15 +0000 (13:01 +0200)]
changing namespace for cpu_interface

2 years agocosmetics
Frederic Suter [Fri, 12 Apr 2019 09:29:43 +0000 (11:29 +0200)]
cosmetics

2 years agoFix hash update.
Arnaud Giersch [Fri, 12 Apr 2019 09:13:51 +0000 (11:13 +0200)]
Fix hash update.

2 years agostringify
Frederic Suter [Fri, 12 Apr 2019 09:08:31 +0000 (11:08 +0200)]
stringify

2 years agoWith a std::map, entries are already sorted by their keys.
Arnaud Giersch [Thu, 11 Apr 2019 20:08:26 +0000 (22:08 +0200)]
With a std::map, entries are already sorted by their keys.

2 years agoRemove unnecessary "else"s.
Arnaud Giersch [Tue, 9 Apr 2019 08:27:12 +0000 (10:27 +0200)]
Remove unnecessary "else"s.

Also reduce Sonar's cognitive complexity.

2 years agoCosmetics.
Arnaud Giersch [Fri, 5 Apr 2019 14:19:51 +0000 (16:19 +0200)]
Cosmetics.

2 years agoRestore environment variable used by StarPU.
Arnaud Giersch [Thu, 11 Apr 2019 15:31:21 +0000 (17:31 +0200)]
Restore environment variable used by StarPU.

2 years agoMemory leaks.
Arnaud Giersch [Thu, 11 Apr 2019 08:58:28 +0000 (10:58 +0200)]
Memory leaks.

2 years agoplease sonar (protected fields) and coding standards (uppercase enum)
Frederic Suter [Thu, 11 Apr 2019 12:14:12 +0000 (14:14 +0200)]
please sonar (protected fields) and coding standards (uppercase enum)

2 years agosimplify this live migration stuff
Frederic Suter [Thu, 11 Apr 2019 11:17:39 +0000 (13:17 +0200)]
simplify this live migration stuff

2 years agoExclude overlapping portions of regions.
Arnaud Giersch [Wed, 10 Apr 2019 19:06:35 +0000 (21:06 +0200)]
Exclude overlapping portions of regions.

Sometimes, offending regions don't match perfectly. Don't ask me why...

Should solve problems seen on Jenkins with UBSan or Coverage builds, and tests
*-mpich3-coll-*-mmap-*.

2 years agoSimplify deprecated function.
Arnaud Giersch [Mon, 8 Apr 2019 13:02:21 +0000 (15:02 +0200)]
Simplify deprecated function.

2 years agoA simcall seems superfluous here (+ constify).
Arnaud Giersch [Tue, 9 Apr 2019 15:29:25 +0000 (17:29 +0200)]
A simcall seems superfluous here (+ constify).

2 years agoUse already set variable.
Arnaud Giersch [Tue, 9 Apr 2019 15:29:03 +0000 (17:29 +0200)]
Use already set variable.

2 years ago[codacy] Reduce scope for variables.
Arnaud Giersch [Mon, 8 Apr 2019 20:16:31 +0000 (22:16 +0200)]
[codacy] Reduce scope for variables.

2 years agoLess casts.
Arnaud Giersch [Fri, 5 Apr 2019 14:25:06 +0000 (16:25 +0200)]
Less casts.

2 years agoRegenerated.
Arnaud Giersch [Fri, 5 Apr 2019 14:19:01 +0000 (16:19 +0200)]
Regenerated.

2 years agougly typo ...
Frederic Suter [Mon, 8 Apr 2019 13:45:42 +0000 (15:45 +0200)]
ugly typo ...

2 years agofurther simplify throw_exception
Frederic Suter [Mon, 8 Apr 2019 11:49:51 +0000 (13:49 +0200)]
further simplify throw_exception

2 years agosimplify throw_exception
Frederic Suter [Mon, 8 Apr 2019 11:09:46 +0000 (13:09 +0200)]
simplify throw_exception

2 years agofortran : avoid removing groups and communicators from the lookup table if they are...
degomme [Mon, 8 Apr 2019 09:54:19 +0000 (11:54 +0200)]
fortran : avoid removing groups and communicators from the lookup table if they are not really freed and possibly shared with other processes (comm_world).

2 years agoFix fortran f2c.
degomme [Mon, 8 Apr 2019 09:42:08 +0000 (11:42 +0200)]
Fix fortran f2c.
It was using hexa to store int strings, which led to issues as 1F was interpreted as 1 in the other direction.

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Mon, 8 Apr 2019 07:03:16 +0000 (09:03 +0200)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years agoplease herr sonar
Augustin Degomme [Sat, 6 Apr 2019 12:54:02 +0000 (14:54 +0200)]
please herr sonar

2 years agoprotect against bad buffer
Augustin Degomme [Sat, 6 Apr 2019 12:53:51 +0000 (14:53 +0200)]
protect against bad buffer

2 years agoplease sonar in various trivial ways
Martin Quinson [Sat, 6 Apr 2019 11:48:37 +0000 (13:48 +0200)]
please sonar in various trivial ways

2 years agoactivate a sleeping test
Augustin Degomme [Sat, 6 Apr 2019 10:40:24 +0000 (12:40 +0200)]
activate a sleeping test

2 years agomost linuxes seem to prefer resetting this value at 0 to initiate some cleanups
Augustin Degomme [Sat, 6 Apr 2019 10:40:12 +0000 (12:40 +0200)]
most linuxes seem to prefer resetting this value at 0 to initiate some cleanups
from the manpage :
(Resetting  to 0 forces the invocation of an internal initialization routine that rechecks POSIXLY_CORRECT and
       checks for GNU extensions in optstring.)

2 years agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Fri, 5 Apr 2019 15:57:54 +0000 (17:57 +0200)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

2 years agosimplify
Frederic Suter [Fri, 5 Apr 2019 15:57:14 +0000 (17:57 +0200)]
simplify

2 years agosimplify terminaison of activities in Actor::exit()
Frederic Suter [Fri, 5 Apr 2019 15:56:44 +0000 (17:56 +0200)]
simplify terminaison of activities in Actor::exit()

2 years agoFix getopt for BSD systems
degomme [Fri, 5 Apr 2019 15:29:29 +0000 (17:29 +0200)]
Fix getopt for BSD systems
optind should be set to 1, not 0. GNU was just more resilient.

2 years agogetopt seems to behave differently on BSD platforms, deactivate the test for them...
degomme [Fri, 5 Apr 2019 14:40:26 +0000 (16:40 +0200)]
getopt seems to behave differently on BSD platforms, deactivate the test for them, pending investigation.

2 years agofactor simcall/activity binding
Frederic Suter [Fri, 5 Apr 2019 14:19:59 +0000 (16:19 +0200)]
factor simcall/activity binding

2 years agoforgot to change fake option here as well
degomme [Fri, 5 Apr 2019 13:37:41 +0000 (15:37 +0200)]
forgot to change fake option here as well

2 years agomove newly implemented calls outside of the unimplemented section of the smpi.h file
degomme [Fri, 5 Apr 2019 13:34:28 +0000 (15:34 +0200)]
move newly implemented calls outside of the unimplemented section of the smpi.h file

2 years agotest getopt, getopt_long, getopt_long_only wrappers
degomme [Fri, 5 Apr 2019 13:12:52 +0000 (15:12 +0200)]
test getopt, getopt_long, getopt_long_only wrappers

2 years agotest --cfg=smpi/shared-malloc:local
degomme [Fri, 5 Apr 2019 13:10:33 +0000 (15:10 +0200)]
test --cfg=smpi/shared-malloc:local

2 years agosome potentially useful debug messages
degomme [Fri, 5 Apr 2019 13:10:12 +0000 (15:10 +0200)]
some potentially useful debug messages

2 years agoSpring cleaning : remove manual privatization from 2010.
degomme [Fri, 5 Apr 2019 13:09:12 +0000 (15:09 +0200)]
Spring cleaning : remove manual privatization from 2010.
It's 2019, dlopen and mmap are supported everywhere we want it to be.
So long, and thanks for all the fish.

2 years agoobjectify SIMIX_execute_tasks
Frederic Suter [Fri, 5 Apr 2019 09:53:49 +0000 (11:53 +0200)]
objectify SIMIX_execute_tasks

2 years agoget rid fo SIMIX_simcall_exit
Frederic Suter [Fri, 5 Apr 2019 09:35:20 +0000 (11:35 +0200)]
get rid fo SIMIX_simcall_exit

2 years agorelax some constraints
Augustin Degomme [Fri, 5 Apr 2019 06:59:35 +0000 (08:59 +0200)]
relax some constraints

2 years agotest more extensively error returns for collectives.
Augustin Degomme [Thu, 4 Apr 2019 21:42:38 +0000 (23:42 +0200)]
test more extensively error returns for collectives.

2 years agoBranch has been renamed.
Arnaud Giersch [Thu, 4 Apr 2019 13:36:42 +0000 (15:36 +0200)]
Branch has been renamed.

2 years agodocument last bug closed
Martin Quinson [Thu, 4 Apr 2019 20:05:07 +0000 (22:05 +0200)]
document last bug closed

2 years agochangelog update
degomme [Thu, 4 Apr 2019 15:06:19 +0000 (17:06 +0200)]
changelog update

2 years agoAdd checks for comms and datatypes as well
degomme [Thu, 4 Apr 2019 14:22:09 +0000 (16:22 +0200)]
Add checks for comms and datatypes as well

2 years agoAdd plenty more checks to MPI collectives, to comply with the standard.
degomme [Thu, 4 Apr 2019 13:29:05 +0000 (15:29 +0200)]
Add plenty more checks to MPI collectives, to comply with the standard.
Coverage was a bit too high, this should help reducing it.

2 years agoCheck validity for extension (Framagit issue #10).
Arnaud Giersch [Thu, 4 Apr 2019 12:48:23 +0000 (14:48 +0200)]
Check validity for extension (Framagit issue #10).

2 years agoCosmetic cleanups.
Arnaud Giersch [Thu, 4 Apr 2019 12:44:13 +0000 (14:44 +0200)]
Cosmetic cleanups.

2 years ago[codacy] Don't use assert for error checking.
Arnaud Giersch [Thu, 4 Apr 2019 10:08:19 +0000 (12:08 +0200)]
[codacy] Don't use assert for error checking.

2 years ago[sonar] Remove useless commented lines of code.
Arnaud Giersch [Thu, 4 Apr 2019 09:32:19 +0000 (11:32 +0200)]
[sonar] Remove useless commented lines of code.

2 years ago[sonar] Simplify nested try blocks.
Arnaud Giersch [Thu, 4 Apr 2019 08:51:11 +0000 (10:51 +0200)]
[sonar] Simplify nested try blocks.

2 years ago[sonar] Prefer ArrayList to Vector.
Arnaud Giersch [Thu, 4 Apr 2019 08:39:24 +0000 (10:39 +0200)]
[sonar] Prefer ArrayList to Vector.

2 years ago[sonar] Forbid construction of utility class.
Arnaud Giersch [Thu, 4 Apr 2019 08:33:03 +0000 (10:33 +0200)]
[sonar] Forbid construction of utility class.

2 years ago[sonar] Anonymize unused parameters.
Arnaud Giersch [Thu, 4 Apr 2019 08:11:56 +0000 (10:11 +0200)]
[sonar] Anonymize unused parameters.

2 years agoDeclare log category where it is actually used.
Arnaud Giersch [Thu, 4 Apr 2019 08:29:30 +0000 (10:29 +0200)]
Declare log category where it is actually used.

2 years agoStrengthen test.
Arnaud Giersch [Thu, 4 Apr 2019 07:45:57 +0000 (09:45 +0200)]
Strengthen test.

2 years agorename the 'releases' branch to 'stable'
Martin Quinson [Thu, 4 Apr 2019 05:50:51 +0000 (07:50 +0200)]
rename the 'releases' branch to 'stable'

2 years agoimprove the documentation of the minimal_java build option
Martin Quinson [Thu, 4 Apr 2019 05:50:05 +0000 (07:50 +0200)]
improve the documentation of the minimal_java build option