Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
2 years agoKill dead code: it's already split between CpuAction and NetworkCm02Action.
Arnaud Giersch [Thu, 5 Oct 2017 20:30:21 +0000 (22:30 +0200)]
Kill dead code: it's already split between CpuAction and NetworkCm02Action.

2 years agoFix invalid free when SIMIX_global_init() exits early.
Arnaud Giersch [Thu, 5 Oct 2017 19:48:33 +0000 (21:48 +0200)]
Fix invalid free when SIMIX_global_init() exits early.

2 years agoadd a test to cover the Constant-time network model
Martin Quinson [Thu, 5 Oct 2017 20:20:30 +0000 (22:20 +0200)]
add a test to cover the Constant-time network model

2 years agoAdd tests for xbt/log and fix some memory leaks.
Arnaud Giersch [Thu, 5 Oct 2017 11:36:23 +0000 (13:36 +0200)]
Add tests for xbt/log and fix some memory leaks.

2 years agoFactorize code.
Arnaud Giersch [Thu, 5 Oct 2017 07:55:48 +0000 (09:55 +0200)]
Factorize code.

2 years agoAnother try to silence sonar on commented lines of code.
Arnaud Giersch [Thu, 5 Oct 2017 06:53:09 +0000 (08:53 +0200)]
Another try to silence sonar on commented lines of code.

2 years agoRemove a few more commented lines of code.
Arnaud Giersch [Thu, 5 Oct 2017 06:48:49 +0000 (08:48 +0200)]
Remove a few more commented lines of code.

2 years agoReduce scope for variable.
Arnaud Giersch [Wed, 4 Oct 2017 21:43:39 +0000 (23:43 +0200)]
Reduce scope for variable.

2 years agothis variable is accessed concurrently (thanks TSan)
Martin Quinson [Thu, 5 Oct 2017 06:21:33 +0000 (08:21 +0200)]
this variable is accessed concurrently (thanks TSan)

2 years agoReduce cognitive complexity (sonar).
Arnaud Giersch [Wed, 4 Oct 2017 21:15:15 +0000 (23:15 +0200)]
Reduce cognitive complexity (sonar).

2 years agoAvoid implicit bool to int conversion.
Arnaud Giersch [Wed, 4 Oct 2017 20:56:01 +0000 (22:56 +0200)]
Avoid implicit bool to int conversion.

2 years agoRemove side effects from right hand operands of && or ||.
Arnaud Giersch [Wed, 4 Oct 2017 20:26:21 +0000 (22:26 +0200)]
Remove side effects from right hand operands of && or ||.

2 years agoAdd a dummy action in empty catch block (sonar).
Arnaud Giersch [Wed, 4 Oct 2017 20:07:32 +0000 (22:07 +0200)]
Add a dummy action in empty catch block (sonar).

2 years agoReduce code duplication.
Arnaud Giersch [Wed, 4 Oct 2017 20:06:12 +0000 (22:06 +0200)]
Reduce code duplication.

2 years agoRemove lines of commented code spotted by sonar.
Arnaud Giersch [Wed, 4 Oct 2017 16:43:57 +0000 (18:43 +0200)]
Remove lines of commented code spotted by sonar.

2 years agocosmetics in field names (and fix MC builds)
Martin Quinson [Wed, 4 Oct 2017 20:04:29 +0000 (22:04 +0200)]
cosmetics in field names (and fix MC builds)

2 years agosonar cleanups
Martin Quinson [Wed, 4 Oct 2017 19:40:54 +0000 (21:40 +0200)]
sonar cleanups

2 years agoDeprecate an obscure part of the XML format
Martin Quinson [Wed, 4 Oct 2017 19:02:39 +0000 (21:02 +0200)]
Deprecate an obscure part of the XML format

2 years agosonar: also exclude java tests from coverage
Martin Quinson [Wed, 4 Oct 2017 18:57:14 +0000 (20:57 +0200)]
sonar: also exclude java tests from coverage

2 years agoCannot have comm == MPI_COMM_NULL here.
Arnaud Giersch [Wed, 4 Oct 2017 14:45:38 +0000 (16:45 +0200)]
Cannot have comm == MPI_COMM_NULL here.

2 years agoDelete obsolete hack.
Arnaud Giersch [Wed, 4 Oct 2017 13:55:58 +0000 (15:55 +0200)]
Delete obsolete hack.

2 years agoRemove unused functions from xbt_os_thread.
Arnaud Giersch [Wed, 4 Oct 2017 13:38:29 +0000 (15:38 +0200)]
Remove unused functions from xbt_os_thread.

Functions: xbt_os_thread_cancel(), xbt_os_thread_detach(), _os_thread_ex_terminate().

2 years agoRemoved unused functions from xbt_str.
Arnaud Giersch [Wed, 4 Oct 2017 10:18:16 +0000 (12:18 +0200)]
Removed unused functions from xbt_str.

Functions: xbt_str_split_str(), xbt_str_subst(), xbt_str_ltrim(),
           xbt_str_rtrim(), xbt_str_trim().

2 years agoDelete trailing spaces.
Arnaud Giersch [Wed, 4 Oct 2017 13:40:59 +0000 (15:40 +0200)]
Delete trailing spaces.

2 years agoA call to bprintf is enough here.
Arnaud Giersch [Wed, 4 Oct 2017 09:24:06 +0000 (11:24 +0200)]
A call to bprintf is enough here.

2 years agoUse std::replace instead of xbt_str_subst in C++ files.
Arnaud Giersch [Tue, 3 Oct 2017 20:39:07 +0000 (22:39 +0200)]
Use std::replace instead of xbt_str_subst in C++ files.

2 years agoRemove useless includes for xbt/str.h.
Arnaud Giersch [Tue, 3 Oct 2017 19:43:05 +0000 (21:43 +0200)]
Remove useless includes for xbt/str.h.

2 years agoMerge branch 'master' of github.com:simgrid/simgrid
Martin Quinson [Wed, 4 Oct 2017 13:22:22 +0000 (15:22 +0200)]
Merge branch 'master' of github.com:simgrid/simgrid

2 years agocodacy
Martin Quinson [Wed, 4 Oct 2017 13:17:02 +0000 (15:17 +0200)]
codacy

2 years agocodacy
Martin Quinson [Wed, 4 Oct 2017 13:17:02 +0000 (15:17 +0200)]
codacy

2 years ago[SMPI] Renamed smpi_*_data_exe as a first step for overhaul of the privatization
Christian Heinrich [Tue, 3 Oct 2017 16:19:32 +0000 (18:19 +0200)]
[SMPI] Renamed smpi_*_data_exe as a first step for overhaul of the privatization

We will introduce a smpi_data_exe_copy variable soon and
we want more uniform names; having the (size|copy|start) at the end makes it much
simpler for us to grep for these variables.

2 years agoenable MPICH3 tests on travis to get the associated coverage on sonar
Martin Quinson [Tue, 3 Oct 2017 10:51:19 +0000 (12:51 +0200)]
enable MPICH3 tests on travis to get the associated coverage on sonar

2 years agofix teshfile according to my recent cosmetics
Martin Quinson [Mon, 2 Oct 2017 23:01:44 +0000 (01:01 +0200)]
fix teshfile according to my recent cosmetics

2 years agosonar: fix a syntax error in the file
Martin Quinson [Mon, 2 Oct 2017 22:55:48 +0000 (00:55 +0200)]
sonar: fix a syntax error in the file

2 years agoignore the newly created binary
Martin Quinson [Mon, 2 Oct 2017 22:43:12 +0000 (00:43 +0200)]
ignore the newly created binary

2 years agofurther reduce the differences between the s4u-async examples
Martin Quinson [Mon, 2 Oct 2017 22:27:13 +0000 (00:27 +0200)]
further reduce the differences between the s4u-async examples

2 years agovarious cosmetics in the s4u-async-wait example
Martin Quinson [Mon, 2 Oct 2017 22:05:38 +0000 (00:05 +0200)]
various cosmetics in the s4u-async-wait example

2 years agocosmetics and doc
Martin Quinson [Mon, 2 Oct 2017 21:28:11 +0000 (23:28 +0200)]
cosmetics and doc

2 years agosimplification, and don't miss any such file
Martin Quinson [Mon, 2 Oct 2017 21:21:40 +0000 (23:21 +0200)]
simplification, and don't miss any such file

2 years agoupdate changelog
Martin Quinson [Sun, 1 Oct 2017 21:57:10 +0000 (23:57 +0200)]
update changelog

2 years agoMerge pull request #224 from Takishipp/async-wait
Martin Quinson [Mon, 2 Oct 2017 19:49:53 +0000 (21:49 +0200)]
Merge pull request #224 from Takishipp/async-wait

Add s4u-async-wait to the examples of s4u

2 years agoMerge branch 'master' into async-wait
Zitagcc [Mon, 2 Oct 2017 16:02:10 +0000 (18:02 +0200)]
Merge branch 'master' into async-wait

2 years agos4u-async-wait is complete
Takishipp [Mon, 2 Oct 2017 16:02:57 +0000 (18:02 +0200)]
s4u-async-wait is complete

2 years agoReintroduce lines removed at commit 5bc3597e1513c7b94497ae0ea819e5fa2e28058a.
Arnaud Giersch [Sun, 1 Oct 2017 20:32:48 +0000 (22:32 +0200)]
Reintroduce lines removed at commit 5bc3597e1513c7b94497ae0ea819e5fa2e28058a.

Only put them in SIMIX_clean instead of SIMIX_process_killall.

I don't really understand when/why they are useful, but the call to
SIMIX_process_empty_trash() fixes a leak seen with teshsuite/mc/random-bug.

2 years agoCosmetics.
Arnaud Giersch [Sun, 1 Oct 2017 20:00:26 +0000 (22:00 +0200)]
Cosmetics.

2 years agoimprove changelog for the upcoming release
Martin Quinson [Sat, 30 Sep 2017 22:24:43 +0000 (00:24 +0200)]
improve changelog for the upcoming release

2 years agosonar: try to exclude java from coverage
Martin Quinson [Sat, 30 Sep 2017 22:24:24 +0000 (00:24 +0200)]
sonar: try to exclude java from coverage

2 years agodocument a class
Martin Quinson [Sat, 30 Sep 2017 21:31:58 +0000 (23:31 +0200)]
document a class

2 years agoshutdown all hosted VMs when an host is turned off
Martin Quinson [Sat, 30 Sep 2017 21:22:08 +0000 (23:22 +0200)]
shutdown all hosted VMs when an host is turned off

2 years agosonar: don't check for memleaks, you suck at it
Martin Quinson [Sat, 30 Sep 2017 21:20:12 +0000 (23:20 +0200)]
sonar: don't check for memleaks, you suck at it

2 years agoadd some bits of the commit log into the code comments
Martin Quinson [Sat, 30 Sep 2017 20:35:54 +0000 (22:35 +0200)]
add some bits of the commit log into the code comments

2 years agoComplete s4u-actor-kill to include a test for Actor::killAll().
Arnaud Giersch [Sat, 30 Sep 2017 19:46:54 +0000 (21:46 +0200)]
Complete s4u-actor-kill to include a test for Actor::killAll().

2 years agoFix process_killall. Closes #186.
Arnaud Giersch [Sat, 30 Sep 2017 19:40:08 +0000 (21:40 +0200)]
Fix process_killall.  Closes #186.

This was never tested, or it was a long time ago.

2 years agoSimply finish the surf sleep action on process join.
Arnaud Giersch [Fri, 29 Sep 2017 21:00:56 +0000 (23:00 +0200)]
Simply finish the surf sleep action on process join.

It is much more simpler, and permits to kill the processes involved in join.

Fixes github bug #225.

2 years agoRevert "Derive custom exception from std::exception."
Arnaud Giersch [Fri, 29 Sep 2017 20:39:56 +0000 (22:39 +0200)]
Revert "Derive custom exception from std::exception."

This reverts commit 7198a3162eaae82fa2ec5c612d5ae22e243055d7.

Make it impossible for user code to catch a StopRequest with a
try {} catch (std::exception).

Sonar will be whining but I don't care.

2 years agoAction::finish() is never used without setState().
Arnaud Giersch [Fri, 29 Sep 2017 20:23:01 +0000 (22:23 +0200)]
Action::finish() is never used without setState().

Add the new state as a parameter for finish().

2 years agoRemove function from list before use.
Arnaud Giersch [Fri, 29 Sep 2017 20:08:20 +0000 (22:08 +0200)]
Remove function from list before use.

2 years agoRemove old commented code.
Arnaud Giersch [Thu, 28 Sep 2017 20:23:53 +0000 (22:23 +0200)]
Remove old commented code.

2 years agoBoost contexts: inform ASan about context switches.
Arnaud Giersch [Thu, 28 Sep 2017 14:21:44 +0000 (16:21 +0200)]
Boost contexts: inform ASan about context switches.

2 years agoCheck if ASan is enabled from CMake, and define variables.
Arnaud Giersch [Thu, 28 Sep 2017 13:53:22 +0000 (15:53 +0200)]
Check if ASan is enabled from CMake, and define variables.

HAVE_SANITIZE_ADDRESS if AddressSanitizer is enabled
HAVE_SANITIZE_ADDRESS_FIBER_SUPPORT if current ASan version includes Fiber annotation interface

Update smpi_memory.cpp in consequence.

2 years agoAlign top of stacks to a multiple of 16.
Arnaud Giersch [Wed, 27 Sep 2017 21:31:25 +0000 (23:31 +0200)]
Align top of stacks to a multiple of 16.

It's needed for Asan not to whine.

2 years agofix build on weird clangs
Martin Quinson [Thu, 28 Sep 2017 05:58:08 +0000 (07:58 +0200)]
fix build on weird clangs

2 years agoinstr: prefer std::str to char*
Martin Quinson [Thu, 21 Sep 2017 23:08:47 +0000 (01:08 +0200)]
instr: prefer std::str to char*

2 years agoAdd explicit keyword, and remove default value for parameter.
Arnaud Giersch [Wed, 27 Sep 2017 09:41:54 +0000 (11:41 +0200)]
Add explicit keyword, and remove default value for parameter.

2 years agoDelete unused copy constructor.
Arnaud Giersch [Wed, 27 Sep 2017 09:23:55 +0000 (11:23 +0200)]
Delete unused copy constructor.

2 years agoUpdate ChangeLog.
Arnaud Giersch [Wed, 27 Sep 2017 08:44:39 +0000 (10:44 +0200)]
Update ChangeLog.

Close #120, #222.

2 years agoTest comm before cancelation, and kill last leak in this test! \o/
Arnaud Giersch [Wed, 27 Sep 2017 08:16:00 +0000 (10:16 +0200)]
Test comm before cancelation, and kill last leak in this test! \o/

2 years agoDelete timer on removal.
Arnaud Giersch [Tue, 26 Sep 2017 13:16:53 +0000 (15:16 +0200)]
Delete timer on removal.

2 years agoChange xbt_heap_rm_elm to return the removed element, or NULL.
Arnaud Giersch [Tue, 26 Sep 2017 13:14:56 +0000 (15:14 +0200)]
Change xbt_heap_rm_elm to return the removed element, or NULL.

2 years agos4u-dht-chord: cancel pending comm.
Arnaud Giersch [Tue, 26 Sep 2017 11:35:09 +0000 (13:35 +0200)]
s4u-dht-chord: cancel pending comm.

The timings are slightly changed (tesh updated).

2 years agos4u-dht-chord: free detached comms.
Arnaud Giersch [Tue, 26 Sep 2017 11:32:19 +0000 (13:32 +0200)]
s4u-dht-chord: free detached comms.

2 years agoAllow to specify a cleanup handler for detached comms.
Arnaud Giersch [Tue, 26 Sep 2017 09:38:02 +0000 (11:38 +0200)]
Allow to specify a cleanup handler for detached comms.

2 years agoImplement basic backtrace cut for --cfg=exception/cutpath.
Arnaud Giersch [Tue, 26 Sep 2017 09:27:34 +0000 (11:27 +0200)]
Implement basic backtrace cut for --cfg=exception/cutpath.

This option became a no-op when the exceptions were ported to C++.

2 years agoFix most of the remaining leaks in msg-host_on_off_processes.
Arnaud Giersch [Mon, 25 Sep 2017 20:23:10 +0000 (22:23 +0200)]
Fix most of the remaining leaks in msg-host_on_off_processes.

Only Test 6 remains unfixed, because it would change the test output.
See FIXME comment at line 179.

2 years agoDisable broken test.
Arnaud Giersch [Mon, 25 Sep 2017 09:03:29 +0000 (11:03 +0200)]
Disable broken test.

It gives a yellow bullet on Jenkins, and doesn't bring anything.

More precisely, the test aborts early because MPI_Type_extent doesn't give
the expected result (Unexpected extent for small struct). The result of
the test was however never verified, since the test is only used by the
model checker.

On the FreeBSD node (clang/libc++), something is broken with exception
handling and the model checker hangs indefinitely at context's ::stop(),
when a StopRequest exception is launched.

The test can be reactivated either when MPI_Type_extent is fixed, or an
update corrects the problems on FreeBSD.

2 years agoMore cleanup in contexts' stop().
Arnaud Giersch [Fri, 22 Sep 2017 22:21:41 +0000 (00:21 +0200)]
More cleanup in contexts' stop().

Call Context::stop() at upper level: save an exception, and hopefully fix
MC tests on FreeBSD, even if I don't really understand what's going wrong.

2 years agoSet (accidentally removed) SOCK_CLOEXEC again.
Arnaud Giersch [Fri, 22 Sep 2017 16:37:07 +0000 (18:37 +0200)]
Set (accidentally removed) SOCK_CLOEXEC again.

2 years agoAdd s4u-async-wait description to the readme
Takishipp [Fri, 22 Sep 2017 15:45:30 +0000 (17:45 +0200)]
Add s4u-async-wait description to the readme

2 years agomc/remote: switch to socket type SOCK_SEQPACKET to detect when the peer disconnected.
Arnaud Giersch [Fri, 22 Sep 2017 15:25:37 +0000 (17:25 +0200)]
mc/remote: switch to socket type SOCK_SEQPACKET to detect when the peer disconnected.

2 years agoReally kill the process.
Arnaud Giersch [Fri, 22 Sep 2017 13:02:28 +0000 (15:02 +0200)]
Really kill the process.

Some mc/umpire tests are deadlocking since commit 7b7b18bf7.

2 years agoMove around code to be consistent with other context factories.
Arnaud Giersch [Fri, 22 Sep 2017 11:20:50 +0000 (13:20 +0200)]
Move around code to be consistent with other context factories.

2 years agoCodacy is a bit picky about those.
Arnaud Giersch [Fri, 22 Sep 2017 11:16:26 +0000 (13:16 +0200)]
Codacy is a bit picky about those.

2 years agoFix build with -Werror=missing-declarations.
Arnaud Giersch [Fri, 22 Sep 2017 09:58:24 +0000 (11:58 +0200)]
Fix build with -Werror=missing-declarations.

2 years agoDerive custom exception from std::exception.
Arnaud Giersch [Fri, 22 Sep 2017 09:36:52 +0000 (11:36 +0200)]
Derive custom exception from std::exception.

2 years agoImprove context termination.
Arnaud Giersch [Thu, 21 Sep 2017 21:28:31 +0000 (23:28 +0200)]
Improve context termination.

Throw an exception to terminate the context at upper level, and have
resources freed by stack unwinding.

Closes #204, since pthread_exit is not called anymore.

2 years agoLeaks -= 2;
Arnaud Giersch [Thu, 21 Sep 2017 15:18:18 +0000 (17:18 +0200)]
Leaks -= 2;

2 years agosmpi_memory: don't copy poisoned regions when AddressSanitizer is in use.
Arnaud Giersch [Thu, 21 Sep 2017 11:30:30 +0000 (13:30 +0200)]
smpi_memory: don't copy poisoned regions when AddressSanitizer is in use.

Not sure if it's entirely correct, but it cannot be worse than the current state
where ASan stops in smpi_initialize_global_memory_segments.

2 years agoFix double-free error.
Arnaud Giersch [Wed, 20 Sep 2017 14:17:35 +0000 (16:17 +0200)]
Fix double-free error.

2 years agoRemove dead assignments spotted by scan-build.
Arnaud Giersch [Wed, 20 Sep 2017 13:25:06 +0000 (15:25 +0200)]
Remove dead assignments spotted by scan-build.

2 years agoFix memory leak in process-join.
Arnaud Giersch [Wed, 20 Sep 2017 10:13:56 +0000 (12:13 +0200)]
Fix memory leak in process-join.

2 years agoDisable stack-overflow tests with address sanitizer.
Arnaud Giersch [Wed, 20 Sep 2017 07:39:38 +0000 (09:39 +0200)]
Disable stack-overflow tests with address sanitizer.

2 years agoswitch a mpich3 coll test to boost contexts instead of thread if found
Augustin Degomme [Tue, 19 Sep 2017 10:58:28 +0000 (12:58 +0200)]
switch a mpich3 coll test to boost contexts instead of thread if found

2 years agoFix gcc's -Wmissing-field-initializers.
Arnaud Giersch [Tue, 19 Sep 2017 08:26:27 +0000 (10:26 +0200)]
Fix gcc's -Wmissing-field-initializers.

2 years agotry to silence some warnings
Augustin Degomme [Tue, 19 Sep 2017 08:08:24 +0000 (10:08 +0200)]
try to silence some warnings

2 years agoFully initialize struct, and please valgrind.
Arnaud Giersch [Tue, 19 Sep 2017 05:59:31 +0000 (07:59 +0200)]
Fully initialize struct, and please valgrind.

2 years agoDisable alternate signal stack before thread exit.
Arnaud Giersch [Mon, 18 Sep 2017 19:35:51 +0000 (21:35 +0200)]
Disable alternate signal stack before thread exit.

AddressSanitizer (ASan) reports an error if the alternate signal stack remains
active when a thread exits:

==28272==ERROR: AddressSanitizer failed to deallocate 0x2000 (8192) bytes at address 0x7f53ebba7c00
==28272==AddressSanitizer CHECK failed: ../../../../src/libsanitizer/sanitizer_common/sanitizer_posix.cc:141 "(("unable to unmap" && 0)) != (0)" (0x0, 0x0)
    #0 0x7f53ebc950e5  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xe40e5)
    #1 0x7f53ebcb1c15 in __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x100c15)
    #2 0x7f53ebca975f  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xf875f)
    #3 0x7f53ebcaa560  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xf9560)
    #4 0x7f53ebc98764  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xe7764)
    #5 0x7f53ea57a5e8 in __nptl_deallocate_tsd.part.4 (/lib/x86_64-linux-gnu/libpthread.so.0+0x65e8)
    #6 0x7f53ea57b647 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7647)
    #7 0x7f53e93e0abe in __clone (/lib/x86_64-linux-gnu/libc.so.6+0xe8abe)

2 years agoDelete ProcessArg.properties.
Arnaud Giersch [Sat, 16 Sep 2017 20:53:21 +0000 (22:53 +0200)]
Delete ProcessArg.properties.

2 years agoLeak-- (seen in maestro-set).
Arnaud Giersch [Sat, 16 Sep 2017 13:27:42 +0000 (15:27 +0200)]
Leak-- (seen in maestro-set).

2 years agoMemcheck: another kind of leak to ignore from smpi/dlopen.
Arnaud Giersch [Sat, 16 Sep 2017 12:44:46 +0000 (14:44 +0200)]
Memcheck: another kind of leak to ignore from smpi/dlopen.

2 years agoMemcheck: another try to make valgrind ignore memory leak in cmake.
Arnaud Giersch [Sat, 16 Sep 2017 12:32:09 +0000 (14:32 +0200)]
Memcheck: another try to make valgrind ignore memory leak in cmake.