Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
7 months ago[sonar] Use unsigned char* for smpi buffers.
Arnaud Giersch [Mon, 29 Apr 2019 19:36:48 +0000 (21:36 +0200)]
[sonar] Use unsigned char* for smpi buffers.

7 months agoChange malloc/free to new/delete.
Arnaud Giersch [Mon, 18 Mar 2019 15:10:01 +0000 (16:10 +0100)]
Change malloc/free to new/delete.

7 months agoUse C++ memory operators for smpi buffers.
Arnaud Giersch [Wed, 6 Mar 2019 22:07:09 +0000 (23:07 +0100)]
Use C++ memory operators for smpi buffers.

NOTE: there is a problem with the current implementation. When a resize() happen,
the previous pointer may be invalid, even if it is still in use.

7 months agoConst for MPI_Type_struct and MPI_Type_hindexed.
Arnaud Giersch [Mon, 29 Apr 2019 12:51:26 +0000 (14:51 +0200)]
Const for MPI_Type_struct and MPI_Type_hindexed.

7 months agoConstify third parameter of smpi::Op::apply, and save a few const_casts.
Arnaud Giersch [Mon, 29 Apr 2019 12:12:06 +0000 (14:12 +0200)]
Constify third parameter of smpi::Op::apply, and save a few const_casts.

7 months agoRemove another bunch of const_casts.
Arnaud Giersch [Mon, 29 Apr 2019 09:14:19 +0000 (11:14 +0200)]
Remove another bunch of const_casts.

7 months agoRename some variables for consistency.
Arnaud Giersch [Mon, 29 Apr 2019 09:01:11 +0000 (11:01 +0200)]
Rename some variables for consistency.

7 months agoGet rid of const_casts in pmpi_coll.
Arnaud Giersch [Mon, 29 Apr 2019 08:28:39 +0000 (10:28 +0200)]
Get rid of const_casts in pmpi_coll.

7 months agoMPI_Address gets const too.
Arnaud Giersch [Sat, 27 Apr 2019 12:53:01 +0000 (14:53 +0200)]
MPI_Address gets const too.

7 months agoRegenerated.
Arnaud Giersch [Sat, 27 Apr 2019 12:14:11 +0000 (14:14 +0200)]
Regenerated.

7 months agochangelog
Augustin Degomme [Fri, 26 Apr 2019 21:36:10 +0000 (23:36 +0200)]
changelog

7 months agoMPI_Comm_dup_with_info
Augustin Degomme [Fri, 26 Apr 2019 21:27:57 +0000 (23:27 +0200)]
MPI_Comm_dup_with_info

7 months agomove some calls out of the unimplemented zone
Augustin Degomme [Fri, 26 Apr 2019 21:27:04 +0000 (23:27 +0200)]
move some calls out of the unimplemented zone

7 months agosome forgotten consts
Augustin Degomme [Fri, 26 Apr 2019 15:01:57 +0000 (17:01 +0200)]
some forgotten consts

7 months ago(painfully) constify colls.
Augustin Degomme [Fri, 26 Apr 2019 14:13:56 +0000 (16:13 +0200)]
(painfully) constify colls.

7 months agoconstify MPI_Win*
Augustin Degomme [Fri, 26 Apr 2019 12:42:57 +0000 (14:42 +0200)]
constify MPI_Win*

7 months agoconstify MPI_Request*
Augustin Degomme [Fri, 26 Apr 2019 12:32:04 +0000 (14:32 +0200)]
constify MPI_Request*

7 months agoconstify MPI_Datatype*
Augustin Degomme [Fri, 26 Apr 2019 11:46:14 +0000 (13:46 +0200)]
constify MPI_Datatype*

7 months agoconstify MPI_Topo*
Augustin Degomme [Fri, 26 Apr 2019 11:17:21 +0000 (13:17 +0200)]
constify MPI_Topo*

7 months agoconstify MPI_File*
Augustin Degomme [Fri, 26 Apr 2019 10:15:27 +0000 (12:15 +0200)]
constify MPI_File*

7 months agoconstify MPI_Group*
Augustin Degomme [Fri, 26 Apr 2019 10:15:14 +0000 (12:15 +0200)]
constify MPI_Group*

7 months agoMerge branch 'master' of https://framagit.org/simgrid/simgrid
Frederic Suter [Fri, 26 Apr 2019 12:24:56 +0000 (14:24 +0200)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid

7 months agokill some dead code
Frederic Suter [Fri, 26 Apr 2019 12:22:58 +0000 (14:22 +0200)]
kill some dead code

7 months agoMPI3 changed MPI interface to use const everywhere it could.
degomme [Fri, 26 Apr 2019 09:30:56 +0000 (11:30 +0200)]
MPI3 changed MPI interface to use const everywhere it could.
Start with MPI_Info_*

7 months agoadd some unimplemented signatures.
degomme [Fri, 26 Apr 2019 09:04:27 +0000 (11:04 +0200)]
add some unimplemented signatures.

7 months agoFix again FG #11 (mixing daemonize and auto-restart).
Arnaud Giersch [Thu, 25 Apr 2019 06:18:29 +0000 (08:18 +0200)]
Fix again FG #11 (mixing daemonize and auto-restart).

Main changes:
* don't modify (clean) the on_exit vector on cleanup, but detach its shared_ptr instead;
* define ActorImpl::undaemonize() for daemon cleanup, and use it instead of using an
  on_exit callback (ensures that it is not added multiple times);
* complete test 'tesh-s4u-actor-autorestart' with an auto-restarting daemon.

7 months agoUnused function parameters.
Arnaud Giersch [Thu, 25 Apr 2019 06:12:46 +0000 (08:12 +0200)]
Unused function parameters.

7 months agoCheck result of lseek.
Arnaud Giersch [Wed, 24 Apr 2019 20:50:48 +0000 (22:50 +0200)]
Check result of lseek.

7 months agoFile "sampi.h" is already included here.
Arnaud Giersch [Wed, 24 Apr 2019 20:39:35 +0000 (22:39 +0200)]
File "sampi.h" is already included here.

7 months agoField seems unused since 10 years at least.
Arnaud Giersch [Wed, 24 Apr 2019 20:32:43 +0000 (22:32 +0200)]
Field seems unused since 10 years at least.

7 months agoUse bit shift operator (FIXME--).
Arnaud Giersch [Wed, 24 Apr 2019 20:17:30 +0000 (22:17 +0200)]
Use bit shift operator (FIXME--).

7 months agoFIXME is obsolete.
Arnaud Giersch [Wed, 24 Apr 2019 20:10:01 +0000 (22:10 +0200)]
FIXME is obsolete.

7 months agoFIXME is irrelevant.
Arnaud Giersch [Wed, 24 Apr 2019 19:58:45 +0000 (21:58 +0200)]
FIXME is irrelevant.

7 months ago[sonar] Unused function parameters.
Arnaud Giersch [Wed, 24 Apr 2019 19:55:10 +0000 (21:55 +0200)]
[sonar] Unused function parameters.

7 months agoCosmetics: conslidate TODO list.
Arnaud Giersch [Wed, 24 Apr 2019 19:21:39 +0000 (21:21 +0200)]
Cosmetics: conslidate TODO list.

7 months agoMany const to remove a mutable (TODO--).
Arnaud Giersch [Wed, 24 Apr 2019 19:13:07 +0000 (21:13 +0200)]
Many const to remove a mutable (TODO--).

7 months agoAdd test for FG#11.
Arnaud Giersch [Wed, 24 Apr 2019 18:44:52 +0000 (20:44 +0200)]
Add test for FG#11.

7 months agoClear the 'on_exit' vector when the actor doesn't have to restart.
Arnaud Giersch [Wed, 24 Apr 2019 12:09:23 +0000 (14:09 +0200)]
Clear the 'on_exit' vector when the actor doesn't have to restart.

The python tests actor-kill and actor-daemon were failing.

7 months agoFix 'on_exit' preservation which failed when auto_restart was set first (FG#11).
Arnaud Giersch [Wed, 24 Apr 2019 08:21:17 +0000 (10:21 +0200)]
Fix 'on_exit' preservation which failed when auto_restart was set first (FG#11).

The 'on_exit' vector is now shared between the ActorImpl and ProcessArg.

7 months agoPreserve on_exit funcions between restarts.
Arnaud Giersch [Tue, 23 Apr 2019 20:43:12 +0000 (22:43 +0200)]
Preserve on_exit funcions between restarts.

Add a member "on_exit" to kernel::actor::ProcessArg.
Fix Framagit isssue #11.

7 months agoMove some includes where they are used.
Arnaud Giersch [Sat, 20 Apr 2019 20:47:53 +0000 (22:47 +0200)]
Move some includes where they are used.

7 months agodrand48 is not used anymore; stop using srand48.
Arnaud Giersch [Sat, 20 Apr 2019 20:47:09 +0000 (22:47 +0200)]
drand48 is not used anymore; stop using srand48.

7 months agoUse C++ random for tracing colors.
Arnaud Giersch [Sat, 20 Apr 2019 20:44:43 +0000 (22:44 +0200)]
Use C++ random for tracing colors.

7 months agoSlight simplification.
Arnaud Giersch [Sat, 20 Apr 2019 20:21:32 +0000 (22:21 +0200)]
Slight simplification.

7 months agoUse what was previously added, and fix broken tests
degomme [Tue, 23 Apr 2019 13:38:32 +0000 (15:38 +0200)]
Use what was previously added, and fix broken tests

7 months agoIf size read is 0 (eof), don't initiate faulty comm which will crash.
degomme [Tue, 23 Apr 2019 12:50:37 +0000 (14:50 +0200)]
If size read is 0 (eof), don't initiate faulty comm which will crash.

7 months agostorage : Allow to write inside a file without reducing its final size (for parallel IO)
degomme [Tue, 23 Apr 2019 12:49:51 +0000 (14:49 +0200)]
storage : Allow to write inside a file without reducing its final size (for parallel IO)

7 months agoMPI_File_get_size, MPI_File_get_amode, MPI_File_get_group, MPI_File_sync
degomme [Tue, 23 Apr 2019 12:48:50 +0000 (14:48 +0200)]
MPI_File_get_size, MPI_File_get_amode, MPI_File_get_group, MPI_File_sync

7 months agoComplete --help-logs.
Arnaud Giersch [Fri, 19 Apr 2019 20:34:54 +0000 (22:34 +0200)]
Complete --help-logs.

7 months agoNew log appenders stdout and stderr. Use stdout for xbt_help.
Arnaud Giersch [Fri, 19 Apr 2019 20:18:09 +0000 (22:18 +0200)]
New log appenders stdout and stderr. Use stdout for xbt_help.

7 months agotry to address comment made in FG#8
Frederic Suter [Fri, 19 Apr 2019 17:23:10 +0000 (19:23 +0200)]
try to address comment made in FG#8

7 months agoSet cfg=smpi/simulate-computation:no.
Arnaud Giersch [Fri, 19 Apr 2019 15:51:27 +0000 (17:51 +0200)]
Set cfg=smpi/simulate-computation:no.

7 months agoFix default MPI_Barrier.
Arnaud Giersch [Fri, 19 Apr 2019 13:40:05 +0000 (15:40 +0200)]
Fix default MPI_Barrier.

Mpich3 test comm_group_rand was sometimes failing.

7 months agoRevise to fool cppcheck.
Arnaud Giersch [Fri, 19 Apr 2019 12:19:12 +0000 (14:19 +0200)]
Revise to fool cppcheck.

7 months agofix test binary path
Frederic Suter [Fri, 19 Apr 2019 13:01:37 +0000 (15:01 +0200)]
fix test binary path

7 months agofixed issue
Frederic Suter [Fri, 19 Apr 2019 11:43:00 +0000 (13:43 +0200)]
fixed issue

7 months agoAdd a test for callback disconnection
Frederic Suter [Fri, 19 Apr 2019 11:38:01 +0000 (13:38 +0200)]
Add a test for callback disconnection

7 months agoAllow for callback disconnection
Frederic Suter [Fri, 19 Apr 2019 11:35:00 +0000 (13:35 +0200)]
Allow for callback disconnection

xbt::signal::connect now returns an unsigned int id and callbacks are
stored in a map <id, callback>.
a new xbt::signal::disconnect(unsigned int id) method has been added.

7 months agoFix build errors with gcc 5.4.0.
Arnaud Giersch [Fri, 19 Apr 2019 11:20:29 +0000 (13:20 +0200)]
Fix build errors with gcc 5.4.0.

7 months agoUse default destructor for resource::Model.
Arnaud Giersch [Fri, 19 Apr 2019 09:18:43 +0000 (11:18 +0200)]
Use default destructor for resource::Model.

7 months agoRemove empty functions
Arnaud Giersch [Fri, 19 Apr 2019 08:32:29 +0000 (10:32 +0200)]
Remove empty functions

7 months agoUse std::unique_ptr to manage memory.
Arnaud Giersch [Fri, 19 Apr 2019 08:08:05 +0000 (10:08 +0200)]
Use std::unique_ptr to manage memory.

7 months agoleaks --
degomme [Fri, 19 Apr 2019 09:10:35 +0000 (11:10 +0200)]
leaks --

7 months agofix issue seen on 34f5b82ed231ecce .
degomme [Fri, 19 Apr 2019 08:41:02 +0000 (10:41 +0200)]
fix issue seen on 34f5b82ed231ecce .
We were writing inside an existing file, reducing its size for the fs.
And then used_size was becoming <0, which for an unsigned is quite large.
This seems to point to another issue in storage, as used_size might not be initialized properly

7 months agofix io-shared (remove spurious ordered_read) and do write then read.
degomme [Fri, 19 Apr 2019 08:32:24 +0000 (10:32 +0200)]
fix io-shared (remove spurious ordered_read) and do write then read.

7 months agocheck for readonly flag before writing to a file.
degomme [Fri, 19 Apr 2019 07:59:52 +0000 (09:59 +0200)]
check for readonly flag before writing to a file.

7 months ago[sonar] kill commented code
Martin Quinson [Fri, 19 Apr 2019 09:29:14 +0000 (11:29 +0200)]
[sonar] kill commented code

7 months ago[sonar] define each identifiers on its line
Martin Quinson [Fri, 19 Apr 2019 09:23:08 +0000 (11:23 +0200)]
[sonar] define each identifiers on its line

7 months agonope sonar, that's not commented code
Martin Quinson [Fri, 19 Apr 2019 09:18:51 +0000 (11:18 +0200)]
nope sonar, that's not commented code

7 months agoplease sonar
Martin Quinson [Fri, 19 Apr 2019 08:41:01 +0000 (10:41 +0200)]
please sonar

7 months agodoc: 2 more internal references
Martin Quinson [Wed, 17 Apr 2019 15:00:26 +0000 (17:00 +0200)]
doc: 2 more internal references

7 months agofix GH#133
Frederic Suter [Fri, 19 Apr 2019 08:35:14 +0000 (10:35 +0200)]
fix GH#133
When a host is turned off, also shutwdown and turn off the VMs hosted
by this host. This is a rather crude patch that implies to browse the
whole list of existing VMs. A better solution requires a bit more work
and time

7 months agoplease sonar
Augustin Degomme [Thu, 18 Apr 2019 22:06:03 +0000 (00:06 +0200)]
please sonar

7 months agoUse std::vector instead of plain arrays in smpi_topo.
Arnaud Giersch [Thu, 18 Apr 2019 20:35:24 +0000 (22:35 +0200)]
Use std::vector instead of plain arrays in smpi_topo.

7 months agoRemove a level of indirection in sd::Global.
Arnaud Giersch [Thu, 18 Apr 2019 16:34:58 +0000 (18:34 +0200)]
Remove a level of indirection in sd::Global.

7 months agoTidy up mc/mc_unw a little.
Arnaud Giersch [Thu, 18 Apr 2019 16:22:17 +0000 (18:22 +0200)]
Tidy up mc/mc_unw a little.

7 months agoRemove custom destructors for instr/paje.
Arnaud Giersch [Thu, 18 Apr 2019 15:28:53 +0000 (17:28 +0200)]
Remove custom destructors for instr/paje.

7 months agoRemove a level of indirection, and custom destructors for instr/jedule.
Arnaud Giersch [Thu, 18 Apr 2019 13:41:45 +0000 (15:41 +0200)]
Remove a level of indirection, and custom destructors for instr/jedule.

7 months agoRemove custom destructors for s4u_Filesystem.
Arnaud Giersch [Thu, 18 Apr 2019 12:51:02 +0000 (14:51 +0200)]
Remove custom destructors for s4u_Filesystem.

7 months agoRestore warning for unit-less values.
Arnaud Giersch [Thu, 18 Apr 2019 12:16:17 +0000 (14:16 +0200)]
Restore warning for unit-less values.

7 months ago32 bits insists of having some timestamps off by 1us ... Hide them.
Augustin Degomme [Thu, 18 Apr 2019 20:24:17 +0000 (22:24 +0200)]
32 bits insists of having some timestamps off by 1us ... Hide them.
And fix my windows line endings mess.

7 months agobe cleaner with memory
Augustin Degomme [Thu, 18 Apr 2019 19:47:41 +0000 (21:47 +0200)]
be cleaner with memory

7 months agofix out of source builds
Augustin Degomme [Thu, 18 Apr 2019 18:40:29 +0000 (20:40 +0200)]
fix out of source builds

7 months agoplease clang
Augustin Degomme [Thu, 18 Apr 2019 18:37:29 +0000 (20:37 +0200)]
please clang

7 months agoMerge branch 'file' into 'master'
Augustin Degomme [Thu, 18 Apr 2019 18:19:09 +0000 (20:19 +0200)]
Merge branch 'file' into 'master'

MPI IO

See merge request simgrid/simgrid!6

7 months agotry to get rid of some variability
Augustin Degomme [Thu, 18 Apr 2019 17:19:22 +0000 (19:19 +0200)]
try to get rid of some variability

7 months agoadd hostfile as well for tests
Augustin Degomme [Thu, 18 Apr 2019 16:41:56 +0000 (18:41 +0200)]
add hostfile as well for tests

7 months agoChange how we lock things up ...
Augustin Degomme [Thu, 18 Apr 2019 15:54:40 +0000 (17:54 +0200)]
Change how we lock things up ...
MPI RMA seemed a god idea, but it just did not work.

7 months agoAdd some tests for io.
Augustin Degomme [Thu, 18 Apr 2019 11:40:58 +0000 (13:40 +0200)]
Add some tests for io.

7 months agoComment out a buggy line... Can't put a finger on what goes wrong here, but values...
Augustin Degomme [Thu, 18 Apr 2019 11:40:22 +0000 (13:40 +0200)]
Comment out a buggy line... Can't put a finger on what goes wrong here, but values seem insane and break all tests
TODO : investigate

7 months agocleanups debug messages for read_all write_all
Augustin Degomme [Thu, 18 Apr 2019 11:39:20 +0000 (13:39 +0200)]
cleanups debug messages for read_all write_all

7 months agocleanups
Augustin Degomme [Thu, 18 Apr 2019 11:37:43 +0000 (13:37 +0200)]
cleanups

7 months agoRevert "Inline Context::self()."
Arnaud Giersch [Thu, 18 Apr 2019 11:30:28 +0000 (13:30 +0200)]
Revert "Inline Context::self()."

This reverts commit 92061e0bc62b9a2ef3bdc041e5e9fe716ada1120.

It's failing on appveyor (mingw64) with:
C:\mingw-w64\x86_64-7.2.0-posix-seh-rt_v5-rev1\mingw64\bin\g++.exe    -g3 -O3 -funroll-loops -fno-strict-aliasing  -finline-functions  -fdebug-prefix-map=C:/projects/simgrid=. -static-libgcc -static-libstdc++ -Wl,--add-stdcall-alias -m64  -shared -o lib\libsimgrid-java.dll -Wl,--out-implib,lib\libsimgrid-java.dll.a -Wl,--major-image-version,3,--minor-image-version,22 -Wl,--whole-archive CMakeFiles\simgrid-java.dir/objects.a -Wl,--no-whole-archive @CMakeFiles\simgrid-java.dir\linklibs.rsp
CMakeFiles\simgrid-java.dir/objects.a(jmsg.cpp.obj):././src/bindings/java/jmsg.cpp:342: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
CMakeFiles\simgrid-java.dir/objects.a(jmsg.cpp.obj):././src/bindings/java/jmsg.cpp:342: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
CMakeFiles\simgrid-java.dir/objects.a(jmsg.cpp.obj):././src/bindings/java/jmsg.cpp:342: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
CMakeFiles\simgrid-java.dir/objects.a(JavaContext.cpp.obj):././src/bindings/java/JavaContext.cpp:81: undefined reference to `__imp__ZTHN7simgrid6kernel7context7Context8current_E'
collect2.exe: error: ld returned 1 exit status

7 months ago[sonar] Remove the use of "sprintf".
Arnaud Giersch [Thu, 18 Apr 2019 11:28:39 +0000 (13:28 +0200)]
[sonar] Remove the use of "sprintf".

7 months agoDefine PropertyHolder::set_properties.
Arnaud Giersch [Thu, 18 Apr 2019 09:45:34 +0000 (11:45 +0200)]
Define PropertyHolder::set_properties.

It allows to have a single simcall when setting many properties.

7 months agoConstify get_properties() and and remove simcalls.
Arnaud Giersch [Wed, 17 Apr 2019 21:21:48 +0000 (23:21 +0200)]
Constify get_properties() and and remove simcalls.

7 months agochange verbosity of some messages, to ease testing
Augustin Degomme [Wed, 17 Apr 2019 21:35:19 +0000 (23:35 +0200)]
change verbosity of some messages, to ease testing

7 months agocomments about implem
Augustin Degomme [Wed, 17 Apr 2019 21:34:16 +0000 (23:34 +0200)]
comments about implem

7 months ago[sonar] Remove custom destructors for surf/PropertyHolder.
Arnaud Giersch [Wed, 17 Apr 2019 21:05:36 +0000 (23:05 +0200)]
[sonar] Remove custom destructors for surf/PropertyHolder.

7 months agomove everything to the implemented zone.
Augustin Degomme [Wed, 17 Apr 2019 20:54:22 +0000 (22:54 +0200)]
move everything to the implemented zone.