Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
3 years agons3: kill an unused global container :(
Martin Quinson [Mon, 31 Aug 2020 18:22:06 +0000 (20:22 +0200)]
ns3: kill an unused global container :(

3 years agoTry to fix crashing ns3 example. Not sure if it is correct.
Arnaud Giersch [Mon, 31 Aug 2020 14:38:46 +0000 (16:38 +0200)]
Try to fix crashing ns3 example. Not sure if it is correct.

3 years agoAdd some s4u::Link setters, and doc improvements
Martin Quinson [Wed, 26 Aug 2020 08:00:41 +0000 (10:00 +0200)]
Add some s4u::Link setters, and doc improvements

3 years agodoc: link++
Martin Quinson [Wed, 26 Aug 2020 07:48:09 +0000 (09:48 +0200)]
doc: link++

3 years agoSort list of filtered libraries, and add libzstd to the list.
Arnaud Giersch [Tue, 25 Aug 2020 20:52:09 +0000 (22:52 +0200)]
Sort list of filtered libraries, and add libzstd to the list.

3 years agoValgrind: ignore more unwind cruft.
Arnaud Giersch [Tue, 25 Aug 2020 13:25:49 +0000 (15:25 +0200)]
Valgrind: ignore more unwind cruft.

Seen with libunwind 1.3.2.

3 years agoMake sure that VM::get_speed() returns the correct value after a migration
Martin Quinson [Tue, 11 Aug 2020 23:37:39 +0000 (01:37 +0200)]
Make sure that VM::get_speed() returns the correct value after a migration

For that, I reset the physical fields of the CPU (speed_, pstate_ and
speed_per_pstate_) to the ones of the new physical host during the
migration.

Maybe we should change only the speed_, and prevent the use of pstate
things in VM?

Another approach for this commit could be to make Host::get_speed()
and friend virtual, and to override them in the VM to use the values
of the underlying physical CPU (ie, of get_pm()->pimple_cpu) instead
of the one of the VM's VCPU, but I fear to still use the wrong speed
in some cases, in particular when a new execution in created onto the
VCPU.

This forbids speed_per_pstate_ to be 'const', since we reset it for
VCPUs on VM migration. Another approach could have been to destroy and
re-create the VCPU on migration, but I'd have to update the LMM to
point the Execs to the newly created resource, which seems
troublesome.

3 years agoIgnore suspended VMs when computing the next_occurring_event at the VM level (patch...
Martin Quinson [Tue, 11 Aug 2020 23:26:36 +0000 (01:26 +0200)]
Ignore suspended VMs when computing the next_occurring_event at the VM level (patch by Fred)

3 years agoVM: allow to chain some setters
Martin Quinson [Mon, 10 Aug 2020 20:01:48 +0000 (22:01 +0200)]
VM: allow to chain some setters

3 years agoAdd jarfile generation script for github, using actions.
Augustin Degomme [Mon, 27 Jul 2020 19:39:58 +0000 (21:39 +0200)]
Add jarfile generation script for github, using actions.
This workflows builds jars on linux, osx, and windows, combine them in a final job, which outputs the jar (zipped :\ ) which can be downloaded and published.
The workflow is set up to be run on demand for now (from the actions tab on the github repo, link is a bit hidden as you have to click on the workflow descriptions to be able to run it), but we could have it run when a release is done, and the artifact attached automatically.

3 years agothese tests need debug messages, don't run them if not activated
Augustin Degomme [Mon, 27 Jul 2020 09:31:54 +0000 (11:31 +0200)]
these tests need debug messages, don't run them if not activated
"large" one is fine (less verbose), so testing is still performed

3 years agowhen enable_debug is turned off, these tests were failing.
Augustin Degomme [Mon, 27 Jul 2020 09:30:29 +0000 (11:30 +0200)]
when enable_debug is turned off, these tests were failing.
Raise the level of 3 underlying messages to verbose to avoid debug mode.

3 years agobetter this way.
Augustin Degomme [Sat, 25 Jul 2020 10:51:10 +0000 (12:51 +0200)]
better this way.

3 years agoAdd an assert to please scan-build.
Arnaud Giersch [Thu, 16 Jul 2020 20:18:01 +0000 (22:18 +0200)]
Add an assert to please scan-build.

Fix "Assigned value is garbage or undefined" in 2nd loop (around lines 43-44).

3 years agothat was failing and launching address for every sanitizer ...
Augustin Degomme [Thu, 16 Jul 2020 07:13:09 +0000 (09:13 +0200)]
that was failing and launching address for every sanitizer ...

3 years agoRename examples: slave -> worker.
Arnaud Giersch [Sat, 11 Jul 2020 14:35:31 +0000 (16:35 +0200)]
Rename examples: slave -> worker.

3 years agorevert some overzealous changes
Augustin Degomme [Wed, 15 Jul 2020 08:17:44 +0000 (10:17 +0200)]
revert some overzealous changes

3 years agooptimize a bit
Augustin Degomme [Wed, 15 Jul 2020 00:09:51 +0000 (02:09 +0200)]
optimize a bit

3 years agothese ones were critical actually.
Augustin Degomme [Wed, 15 Jul 2020 00:09:33 +0000 (02:09 +0200)]
these ones were critical actually.

3 years agocheck smpi compilation scripts with www.shellcheck.net
Augustin Degomme [Tue, 14 Jul 2020 23:35:09 +0000 (01:35 +0200)]
check smpi compilation scripts with shellcheck.net
surprisingly fine.
Sadly sonarcloud does not allow external plugins so checker can't be included.

3 years agoshellcheck tools/jenkins scripts.
Augustin Degomme [Tue, 14 Jul 2020 23:10:11 +0000 (01:10 +0200)]
shellcheck tools/jenkins scripts.
Mostly quoting stuff ..

3 years agouse shellcheck on smpirun
Augustin Degomme [Tue, 14 Jul 2020 22:52:05 +0000 (00:52 +0200)]
use shellcheck on smpirun
rules were mainly about escaping, quoting stuff, getting rid of -a and -o
but also some UUOC https://github.com/koalaman/shellcheck/wiki/SC2002
or performance improvement https://github.com/koalaman/shellcheck/wiki/SC2129
and some trap hint : https://github.com/koalaman/shellcheck/wiki/SC2064

two remainings : DEFAULT_NUMPROCS variable is unused. unclear what it was about, should it be the default num of cores in a generated platform ? or the default -np setting ?
"local" is not posix, but a proposal for now

3 years agoRemove unused state.
Arnaud Giersch [Fri, 10 Jul 2020 10:56:23 +0000 (12:56 +0200)]
Remove unused state.

3 years ago[sonar] Fix more implicit casts that should not lower precision (S5276).
Arnaud Giersch [Fri, 10 Jul 2020 09:27:15 +0000 (11:27 +0200)]
[sonar] Fix more implicit casts that should not lower precision (S5276).

3 years agoCosmetics.
Arnaud Giersch [Fri, 10 Jul 2020 06:51:03 +0000 (08:51 +0200)]
Cosmetics.

3 years agoTry to fix for 32bits systems.
Arnaud Giersch [Thu, 9 Jul 2020 22:33:51 +0000 (00:33 +0200)]
Try to fix for 32bits systems.

3 years ago[sonar] Explicit cast when loosing precision (src/xbt/, and parts of surf/).
Arnaud Giersch [Thu, 9 Jul 2020 21:05:45 +0000 (23:05 +0200)]
[sonar] Explicit cast when loosing precision (src/xbt/, and parts of surf/).

That's enough for tonight....

3 years ago[sonar] Explicit cast when loosing precision (teshsuite/).
Arnaud Giersch [Thu, 9 Jul 2020 19:55:23 +0000 (21:55 +0200)]
[sonar] Explicit cast when loosing precision (teshsuite/).

3 years ago[sonar] Explicit cast when loosing precision (C++ examples).
Arnaud Giersch [Thu, 9 Jul 2020 16:01:28 +0000 (18:01 +0200)]
[sonar] Explicit cast when loosing precision (C++ examples).

3 years ago[sonar] Explicit cast when loosing precision (C examples).
Arnaud Giersch [Thu, 9 Jul 2020 10:34:47 +0000 (12:34 +0200)]
[sonar] Explicit cast when loosing precision (C examples).

3 years agoconst++
Arnaud Giersch [Thu, 9 Jul 2020 10:03:22 +0000 (12:03 +0200)]
const++

3 years agoStick with brutal C-style casts (and fix compilation errors).
Arnaud Giersch [Thu, 9 Jul 2020 09:35:54 +0000 (11:35 +0200)]
Stick with brutal C-style casts (and fix compilation errors).

3 years agoFix parentheses around macro arguments (and prefer C++ style casts).
Arnaud Giersch [Thu, 9 Jul 2020 09:00:37 +0000 (11:00 +0200)]
Fix parentheses around macro arguments (and prefer C++ style casts).

3 years agoSuppress global variable.
Arnaud Giersch [Mon, 6 Jul 2020 08:22:16 +0000 (10:22 +0200)]
Suppress global variable.

3 years agocast hugepages macros parameters to int64 (#344)
Lucas Nesi [Thu, 9 Jul 2020 01:09:26 +0000 (22:09 -0300)]
cast hugepages macros parameters to int64 (#344)

cast hugepages macros parameters to int64

3 years agoAdd an example of wifi communication
Martin Quinson [Thu, 9 Jul 2020 00:44:01 +0000 (02:44 +0200)]
Add an example of wifi communication

3 years agoRemove this dupplicated and unused platform file
Martin Quinson [Wed, 8 Jul 2020 23:43:53 +0000 (01:43 +0200)]
Remove this dupplicated and unused platform file

3 years agoProvide a S4U function to control the SNR level of an host on a wifi link (+documenta...
Martin Quinson [Wed, 8 Jul 2020 23:42:30 +0000 (01:42 +0200)]
Provide a S4U function to control the SNR level of an host on a wifi link (+documentation)

3 years agoFix pip builds and distcheck
Martin Quinson [Wed, 8 Jul 2020 20:57:13 +0000 (22:57 +0200)]
Fix pip builds and distcheck

3 years agoTentative implementation of Activity::suspend() and resume()
Martin Quinson [Wed, 8 Jul 2020 14:48:57 +0000 (16:48 +0200)]
Tentative implementation of Activity::suspend() and resume()

I decided not to change the State when the activity is suspended,
because that State merely denotes whether pimpl_ was created already
or not.

This commit also adds a is_suspended() method, as well as an example.

3 years agodoc: simplify a sentence
Martin Quinson [Tue, 7 Jul 2020 10:36:01 +0000 (12:36 +0200)]
doc: simplify a sentence

3 years agoFix pip build
Martin Quinson [Tue, 7 Jul 2020 08:34:29 +0000 (10:34 +0200)]
Fix pip build

3 years agosmall improvements to the ns3 doc
Martin Quinson [Tue, 7 Jul 2020 08:29:43 +0000 (10:29 +0200)]
small improvements to the ns3 doc

3 years agoRename the async-* tests into comm-*
Martin Quinson [Mon, 6 Jul 2020 14:32:42 +0000 (16:32 +0200)]
Rename the async-* tests into comm-*

3 years agoUse correct type for variables, and avoid loosing precision.
Arnaud Giersch [Sat, 4 Jul 2020 20:48:52 +0000 (22:48 +0200)]
Use correct type for variables, and avoid loosing precision.

3 years ago[sonar] Make cast explicit.
Arnaud Giersch [Sat, 4 Jul 2020 20:29:03 +0000 (22:29 +0200)]
[sonar] Make cast explicit.

3 years agoFix return type.
Arnaud Giersch [Sat, 4 Jul 2020 12:32:06 +0000 (14:32 +0200)]
Fix return type.

3 years ago[sonar] Const etc. (round #3).
Arnaud Giersch [Fri, 3 Jul 2020 19:22:42 +0000 (21:22 +0200)]
[sonar] Const etc. (round #3).

3 years agoReindent.
Arnaud Giersch [Fri, 3 Jul 2020 12:27:29 +0000 (14:27 +0200)]
Reindent.

3 years ago[sonar] Const for pointer and reference parameters (slight return).
Arnaud Giersch [Fri, 3 Jul 2020 12:10:27 +0000 (14:10 +0200)]
[sonar] Const for pointer and reference parameters (slight return).

3 years ago[sonar] Const for local variables.
Arnaud Giersch [Fri, 3 Jul 2020 11:44:50 +0000 (13:44 +0200)]
[sonar] Const for local variables.

3 years ago[sonar] Declare functions "const" (round #2).
Arnaud Giersch [Fri, 3 Jul 2020 09:50:55 +0000 (11:50 +0200)]
[sonar] Declare functions "const" (round #2).

3 years agoMissing declarations for some fortran bindings.
Arnaud Giersch [Thu, 30 Jan 2020 15:39:02 +0000 (16:39 +0100)]
Missing declarations for some fortran bindings.

3 years ago[sonar] Convert integer literals to bool literals.
Arnaud Giersch [Thu, 2 Jul 2020 20:16:06 +0000 (22:16 +0200)]
[sonar] Convert integer literals to bool literals.

3 years agoFix simcalls.py after rename s/simcall/simcall_/.
Arnaud Giersch [Thu, 2 Jul 2020 20:41:22 +0000 (22:41 +0200)]
Fix simcalls.py after rename s/simcall/simcall_/.

3 years agoAny idea on how to fix this?
Arnaud Giersch [Thu, 2 Jul 2020 20:02:35 +0000 (22:02 +0200)]
Any idea on how to fix this?

As a wild guess, tried to change the condition with 'message->state->routing_table[i][j] != -1'
but got weird crash (double free detected).

3 years ago[sonar] Declare functions "const" in examples/ and teshsuite/.
Arnaud Giersch [Thu, 2 Jul 2020 19:42:09 +0000 (21:42 +0200)]
[sonar] Declare functions "const" in examples/ and teshsuite/.

3 years ago[sonar] Declare functions "const" in src/instr/.
Arnaud Giersch [Thu, 2 Jul 2020 15:54:00 +0000 (17:54 +0200)]
[sonar] Declare functions "const" in src/instr/.

3 years ago[sonar] Declare functions "const" in src/kernel/.
Arnaud Giersch [Thu, 2 Jul 2020 15:50:58 +0000 (17:50 +0200)]
[sonar] Declare functions "const" in src/kernel/.

3 years ago[sonar] Declare functions "const" in src/mc/.
Arnaud Giersch [Thu, 2 Jul 2020 15:30:56 +0000 (17:30 +0200)]
[sonar] Declare functions "const" in src/mc/.

3 years ago[sonar] Declare functions "const" in src/plugins/.
Arnaud Giersch [Thu, 2 Jul 2020 13:45:10 +0000 (15:45 +0200)]
[sonar] Declare functions "const" in src/plugins/.

3 years agoMake Engine::set_config(...) static functions.
Arnaud Giersch [Thu, 2 Jul 2020 13:17:04 +0000 (15:17 +0200)]
Make Engine::set_config(...) static functions.

3 years ago[sonar] Declare functions "const" in src/s4u/.
Arnaud Giersch [Thu, 2 Jul 2020 13:02:59 +0000 (15:02 +0200)]
[sonar] Declare functions "const" in src/s4u/.

3 years ago[sonar] Declare functions "const" in src/simix/.
Arnaud Giersch [Thu, 2 Jul 2020 12:56:13 +0000 (14:56 +0200)]
[sonar] Declare functions "const" in src/simix/.

3 years ago[sonar] Declare functions "const" in src/smpi/.
Arnaud Giersch [Thu, 2 Jul 2020 12:14:31 +0000 (14:14 +0200)]
[sonar] Declare functions "const" in src/smpi/.

3 years ago[sonar] Declare functions "const" in src/surf/.
Arnaud Giersch [Thu, 2 Jul 2020 12:01:57 +0000 (14:01 +0200)]
[sonar] Declare functions "const" in src/surf/.

3 years ago[sonar] Declare functions "const" in src/xbt/.
Arnaud Giersch [Thu, 2 Jul 2020 10:01:56 +0000 (12:01 +0200)]
[sonar] Declare functions "const" in src/xbt/.

3 years agoFix typo, and consider more files for exclusion.
Arnaud Giersch [Thu, 2 Jul 2020 06:39:54 +0000 (08:39 +0200)]
Fix typo, and consider more files for exclusion.

3 years ago[sonar] Add const qualifier for reference parameter.
Arnaud Giersch [Wed, 1 Jul 2020 20:52:16 +0000 (22:52 +0200)]
[sonar] Add const qualifier for reference parameter.

3 years ago[sonar] Declare function "noreturn".
Arnaud Giersch [Wed, 1 Jul 2020 20:33:07 +0000 (22:33 +0200)]
[sonar] Declare function "noreturn".

3 years ago[sonar] USe a typedef for type alias.
Arnaud Giersch [Wed, 1 Jul 2020 20:27:56 +0000 (22:27 +0200)]
[sonar] USe a typedef for type alias.

3 years ago[sonar] Remove redundant casts.
Arnaud Giersch [Wed, 1 Jul 2020 14:41:22 +0000 (16:41 +0200)]
[sonar] Remove redundant casts.

3 years agoIgnore sonar issues about concatenatable namespaces.
Arnaud Giersch [Wed, 1 Jul 2020 14:28:45 +0000 (16:28 +0200)]
Ignore sonar issues about concatenatable namespaces.

3 years agoKill unused ctor.
Arnaud Giersch [Fri, 12 Jun 2020 15:24:26 +0000 (17:24 +0200)]
Kill unused ctor.

3 years agoMerge branch 'smpi' into 'master'
Augustin Degomme [Thu, 25 Jun 2020 14:47:30 +0000 (16:47 +0200)]
Merge branch 'smpi' into 'master'

Typo in SMPI gather algorithm

See merge request simgrid/simgrid!37

3 years agoTypo in SMPI gather algorithm (comment)
Julien EMMANUEL [Thu, 25 Jun 2020 13:39:03 +0000 (15:39 +0200)]
Typo in SMPI gather algorithm (comment)

3 years agofix some long -> double faulty convertions reported by sonar
Martin Quinson [Sat, 13 Jun 2020 12:55:31 +0000 (14:55 +0200)]
fix some long -> double faulty convertions reported by sonar

3 years agoSpelling fix, just like the line below.
Arnaud Giersch [Fri, 12 Jun 2020 11:42:17 +0000 (13:42 +0200)]
Spelling fix, just like the line below.

3 years agoUse std::vector.
Arnaud Giersch [Tue, 9 Jun 2020 11:40:03 +0000 (13:40 +0200)]
Use std::vector.

3 years agoRemove redundant access specifier.
Arnaud Giersch [Tue, 9 Jun 2020 09:12:53 +0000 (11:12 +0200)]
Remove redundant access specifier.

3 years agoRegenerated.
Arnaud Giersch [Tue, 9 Jun 2020 09:08:32 +0000 (11:08 +0200)]
Regenerated.

3 years agoPrefer using initialization lists in ctors.
Arnaud Giersch [Tue, 9 Jun 2020 08:32:46 +0000 (10:32 +0200)]
Prefer using initialization lists in ctors.

3 years agotools and contrib spelling mistakes
Augustin Degomme [Fri, 12 Jun 2020 10:43:00 +0000 (12:43 +0200)]
tools and contrib spelling mistakes

3 years agospeeling mistakes in teshsuite (even mpich tests because why not)
Augustin Degomme [Fri, 12 Jun 2020 10:37:59 +0000 (12:37 +0200)]
speeling mistakes in teshsuite (even mpich tests because why not)

3 years agospellings mistakes in doc/
Augustin Degomme [Fri, 12 Jun 2020 10:15:58 +0000 (12:15 +0200)]
spellings mistakes in doc/

3 years agospelling mistakes in docs/
Augustin Degomme [Fri, 12 Jun 2020 10:11:04 +0000 (12:11 +0200)]
spelling mistakes in docs/

3 years agospelling mistakes in include/ and examples/
Augustin Degomme [Fri, 12 Jun 2020 10:01:06 +0000 (12:01 +0200)]
spelling mistakes in include/ and examples/
still with codespell

3 years agoFix most of spelling mistakes in src/
Augustin Degomme [Fri, 12 Jun 2020 09:52:57 +0000 (11:52 +0200)]
Fix most of spelling mistakes in src/
using codespell (https://github.com/codespell-project/codespell)
exclude catch.hpp

3 years agoFinish converting the way we use cfg=smpi/host-speed ourselves -- Bummer
Martin Quinson [Thu, 11 Jun 2020 00:13:29 +0000 (02:13 +0200)]
Finish converting the way we use cfg=smpi/host-speed ourselves -- Bummer

3 years agoFix pip builds
Martin Quinson [Wed, 10 Jun 2020 23:48:50 +0000 (01:48 +0200)]
Fix pip builds

3 years agoAlign the definitions of surf_parsed_filename accross files
Martin Quinson [Wed, 10 Jun 2020 23:43:21 +0000 (01:43 +0200)]
Align the definitions of surf_parsed_filename accross files

3 years agoClarify one paragraph in the doc
Martin Quinson [Wed, 10 Jun 2020 23:38:20 +0000 (01:38 +0200)]
Clarify one paragraph in the doc

3 years agoAccept units for 'smpi/host-speed' config element
Martin Quinson [Wed, 10 Jun 2020 23:24:35 +0000 (01:24 +0200)]
Accept units for 'smpi/host-speed' config element

3 years agosplit surf_parse into a separate file to make it reusable from elsewhere
Martin Quinson [Wed, 10 Jun 2020 21:35:42 +0000 (23:35 +0200)]
split surf_parse into a separate file to make it reusable from elsewhere

Also rename surf_parse_* functions into xbt_parse_*

Also, make the file name and line number explicit, as parameters to
functions that need it (less hidden global state is better). But I was
too lazy to clean smpi::parse_factor() tonight: the pandora box
remains closed for tonight.

3 years agoleaks --
Augustin Degomme [Tue, 9 Jun 2020 12:40:03 +0000 (14:40 +0200)]
leaks --
These lines were not supposed to be included in latest commit.
But as I had already written the commit message warning of memory leaks, I decided to add them anymway, in order not to lie.

3 years agodon't throw in smpi_helpers when passing configure, it may confuse some checkers
Augustin Degomme [Tue, 9 Jun 2020 09:28:50 +0000 (11:28 +0200)]
don't throw in smpi_helpers when passing configure, it may confuse some checkers
petsc fails detection of getcwd and others, because we are pulling them in our header with a different signature

3 years agoimprove handling of persistent requests.
Augustin Degomme [Mon, 8 Jun 2020 21:24:36 +0000 (23:24 +0200)]
improve handling of persistent requests.
not great, could leak in some cases.

3 years agoFinished = inactive
Augustin Degomme [Mon, 8 Jun 2020 14:05:42 +0000 (16:05 +0200)]
Finished = inactive
One is allowed to call MPI_WAIT with a null or inactive request argument. In this case the operation returns immediately with empty status.

3 years agostandard says handle should be set to MPI_DATATYPE_NULL.
Augustin Degomme [Mon, 8 Jun 2020 10:23:35 +0000 (12:23 +0200)]
standard says handle should be set to MPI_DATATYPE_NULL.

3 years agoThis call can be performed before MPI_Init, avoid bench_end/bench_start.
Augustin Degomme [Sun, 7 Jun 2020 15:39:33 +0000 (17:39 +0200)]
This call can be performed before MPI_Init, avoid bench_end/bench_start.