Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
3 years agoAdd a test for GH#345
Martin Quinson [Tue, 27 Oct 2020 23:24:27 +0000 (00:24 +0100)]
Add a test for GH#345

3 years agoKill redundant F2C::f2c_lookup.
Arnaud Giersch [Tue, 27 Oct 2020 22:00:37 +0000 (23:00 +0100)]
Kill redundant F2C::f2c_lookup.

3 years agoMake trivial functions inline.
Arnaud Giersch [Tue, 27 Oct 2020 22:03:19 +0000 (23:03 +0100)]
Make trivial functions inline.

3 years agoFinally use plain ints for f2c keys.
Arnaud Giersch [Tue, 27 Oct 2020 21:50:15 +0000 (22:50 +0100)]
Finally use plain ints for f2c keys.

3 years agoUse std::string for f2c keys.
Arnaud Giersch [Tue, 27 Oct 2020 21:42:34 +0000 (22:42 +0100)]
Use std::string for f2c keys.

3 years agoClosed bug.
Arnaud Giersch [Tue, 27 Oct 2020 17:04:08 +0000 (18:04 +0100)]
Closed bug.

3 years agoUse std::vector.
Arnaud Giersch [Mon, 26 Oct 2020 23:20:01 +0000 (00:20 +0100)]
Use std::vector.

3 years agoUse posix_fallocate to set file size.
Arnaud Giersch [Mon, 26 Oct 2020 23:14:05 +0000 (00:14 +0100)]
Use posix_fallocate to set file size.

3 years agons3 does not accept 0 as a port_number so don't let it nicely overleap
Martin Quinson [Tue, 27 Oct 2020 22:41:57 +0000 (23:41 +0100)]
ns3 does not accept 0 as a port_number so don't let it nicely overleap

3 years agons3: Fix a debug message (s/socket/flow/)
Martin Quinson [Tue, 27 Oct 2020 22:31:12 +0000 (23:31 +0100)]
ns3: Fix a debug message (s/socket/flow/)

3 years agoAccept very large port numbers, as ns-3 don't forbid them
Martin Quinson [Tue, 27 Oct 2020 22:09:14 +0000 (23:09 +0100)]
Accept very large port numbers, as ns-3 don't forbid them

3 years agoCorrectly set result for simcall_cond_wait_timeout.
Arnaud Giersch [Mon, 26 Oct 2020 10:58:32 +0000 (11:58 +0100)]
Correctly set result for simcall_cond_wait_timeout.

3 years agoUse std::vector.
Arnaud Giersch [Mon, 26 Oct 2020 10:41:46 +0000 (11:41 +0100)]
Use std::vector.

3 years agoUse std::array.
Arnaud Giersch [Mon, 26 Oct 2020 09:04:11 +0000 (10:04 +0100)]
Use std::array.

3 years agoUpdate, using std::string.
Arnaud Giersch [Mon, 26 Oct 2020 08:14:53 +0000 (09:14 +0100)]
Update, using std::string.

3 years agoFix UBSan warning.
Arnaud Giersch [Sun, 25 Oct 2020 13:55:01 +0000 (14:55 +0100)]
Fix UBSan warning.

smpi_datatype.cpp:360:15: runtime error: null pointer passed as argument 2, which is declared to never be null

3 years agoUse std::vector instead of C-style array.
Arnaud Giersch [Sat, 24 Oct 2020 21:25:58 +0000 (23:25 +0200)]
Use std::vector instead of C-style array.

3 years agoMake cast explicit.
Arnaud Giersch [Sat, 24 Oct 2020 20:54:12 +0000 (22:54 +0200)]
Make cast explicit.

3 years agoKill dead code (condition is always true).
Arnaud Giersch [Sat, 24 Oct 2020 20:11:15 +0000 (22:11 +0200)]
Kill dead code (condition is always true).

3 years agoRename local variable to not hide parameter.
Arnaud Giersch [Sat, 24 Oct 2020 19:35:28 +0000 (21:35 +0200)]
Rename local variable to not hide parameter.

3 years agoEscape dots in regexp.
Arnaud Giersch [Sat, 24 Oct 2020 19:30:59 +0000 (21:30 +0200)]
Escape dots in regexp.

3 years agoPrefer is/is not None.
Arnaud Giersch [Sat, 24 Oct 2020 19:24:10 +0000 (21:24 +0200)]
Prefer is/is not None.

3 years agoKill a no-op.
Arnaud Giersch [Sat, 24 Oct 2020 16:29:34 +0000 (18:29 +0200)]
Kill a no-op.

3 years agoCleanup.
Arnaud Giersch [Sat, 24 Oct 2020 16:27:05 +0000 (18:27 +0200)]
Cleanup.

3 years agoadd -lm to flags on smpicc smpicxx.
Augustin Degomme [Sat, 24 Oct 2020 15:30:39 +0000 (17:30 +0200)]
add -lm to flags on smpicc smpicxx.
We already had these in smpif90/ff, anf gcc10 seems to not be using it by default.
So this could help compatibility with some (proxy apps) codes, if harmless on other setups. Let's see.

3 years agoPointer-to-const for sonar.
Arnaud Giersch [Sat, 24 Oct 2020 08:38:56 +0000 (10:38 +0200)]
Pointer-to-const for sonar.

3 years agoDon't advertize a deprecated function.
Arnaud Giersch [Sat, 24 Oct 2020 08:35:16 +0000 (10:35 +0200)]
Don't advertize a deprecated function.

3 years agoNo need to keep functions that did not even exist in v3.25.
Arnaud Giersch [Sat, 24 Oct 2020 08:33:04 +0000 (10:33 +0200)]
No need to keep functions that did not even exist in v3.25.

3 years agoUpdate ChangeLog.
Arnaud Giersch [Fri, 23 Oct 2020 22:36:40 +0000 (00:36 +0200)]
Update ChangeLog.

3 years agoMore coding style updates for sg_host.
Arnaud Giersch [Fri, 23 Oct 2020 22:21:42 +0000 (00:21 +0200)]
More coding style updates for sg_host.

3 years agoMore coding style updates for sg_link.
Arnaud Giersch [Fri, 23 Oct 2020 21:44:51 +0000 (23:44 +0200)]
More coding style updates for sg_link.

3 years agoMore coding style updates for sg_disk.
Arnaud Giersch [Fri, 23 Oct 2020 21:27:13 +0000 (23:27 +0200)]
More coding style updates for sg_disk.

3 years agoCosmetics.
Arnaud Giersch [Fri, 23 Oct 2020 14:04:15 +0000 (16:04 +0200)]
Cosmetics.

3 years agoFollow coding style for sg_link_{get,set}_data.
Arnaud Giersch [Fri, 23 Oct 2020 14:00:43 +0000 (16:00 +0200)]
Follow coding style for sg_link_{get,set}_data.

3 years agoFollow coding style for sg_host_{get,set}_data.
Arnaud Giersch [Fri, 23 Oct 2020 13:55:53 +0000 (15:55 +0200)]
Follow coding style for sg_host_{get,set}_data.

3 years agoFollow coding style for sg_disk_{get,set}_data.
Arnaud Giersch [Fri, 23 Oct 2020 13:47:22 +0000 (15:47 +0200)]
Follow coding style for sg_disk_{get,set}_data.

3 years agoFollow coding style for sg_actor_{get,set}_data.
Arnaud Giersch [Fri, 23 Oct 2020 13:38:44 +0000 (15:38 +0200)]
Follow coding style for sg_actor_{get,set}_data.

3 years agoUpdate README.coding to match the current practice for getters/setters.
Arnaud Giersch [Fri, 23 Oct 2020 13:28:39 +0000 (15:28 +0200)]
Update README.coding to match the current practice for getters/setters.

3 years agoSimplify a bit simgrid::config::bind_flag().
Arnaud Giersch [Fri, 23 Oct 2020 12:51:18 +0000 (14:51 +0200)]
Simplify a bit simgrid::config::bind_flag().

3 years agoPolishing last merged bits.
Arnaud Giersch [Fri, 23 Oct 2020 12:37:52 +0000 (14:37 +0200)]
Polishing last merged bits.

3 years agoEnsure that the expected RNG (xbt) is used for unit-tests.
Arnaud Giersch [Fri, 23 Oct 2020 11:58:15 +0000 (13:58 +0200)]
Ensure that the expected RNG (xbt) is used for unit-tests.

Profile tests run through "./unit-tests --order rand" were sometimes failing.

3 years agoClose simgrid/simgrid!22 on Framagit.
Arnaud Giersch [Fri, 23 Oct 2020 11:34:33 +0000 (13:34 +0200)]
Close simgrid/simgrid!22 on Framagit.

(and minor related updates)

3 years agoMerge branch 'pikachuyann/simgrid-stoprofiles'
Arnaud Giersch [Fri, 23 Oct 2020 12:00:24 +0000 (14:00 +0200)]
Merge branch 'pikachuyann/simgrid-stoprofiles'

3 years agoUse consistent naming scheme.
Arnaud Giersch [Tue, 20 Oct 2020 19:23:04 +0000 (21:23 +0200)]
Use consistent naming scheme.

iface() becomes get_iface() for ActorImpl too.

3 years ago[sonar] Use template parameter.
Arnaud Giersch [Tue, 20 Oct 2020 19:10:06 +0000 (21:10 +0200)]
[sonar] Use template parameter.

3 years ago[codefactor.io] Trailing whitespaces.
Arnaud Giersch [Tue, 20 Oct 2020 10:00:22 +0000 (12:00 +0200)]
[codefactor.io] Trailing whitespaces.

3 years agoNow is still not in the past.
Arnaud Giersch [Tue, 20 Oct 2020 09:51:29 +0000 (11:51 +0200)]
Now is still not in the past.

Fix simgrid/simgrid#52

3 years agoFix format for tiny double values in --help.
Arnaud Giersch [Tue, 20 Oct 2020 09:12:27 +0000 (11:12 +0200)]
Fix format for tiny double values in --help.

3 years agofree jenkins builds from the bounds of /builds.
Augustin Degomme [Mon, 19 Oct 2020 13:24:04 +0000 (15:24 +0200)]
free jenkins builds from the bounds of /builds.
new install path is $HOME/simgrid_install

3 years agoDon't fail early.
Arnaud Giersch [Mon, 19 Oct 2020 13:21:48 +0000 (15:21 +0200)]
Don't fail early.

3 years agoCorrect a few a/an.
Arnaud Giersch [Mon, 19 Oct 2020 12:00:27 +0000 (14:00 +0200)]
Correct a few a/an.

3 years agoMove fucntion call out of xbt_assert.
Arnaud Giersch [Mon, 19 Oct 2020 11:45:59 +0000 (13:45 +0200)]
Move fucntion call out of xbt_assert.

3 years agoTypos.
Arnaud Giersch [Mon, 19 Oct 2020 11:42:20 +0000 (13:42 +0200)]
Typos.

3 years ago[codefactor] Blank line is redundant.
Arnaud Giersch [Mon, 19 Oct 2020 11:40:36 +0000 (13:40 +0200)]
[codefactor]  Blank line is redundant.

3 years agoCosmetics in the ns3 teshsuite
Martin Quinson [Sun, 18 Oct 2020 00:25:10 +0000 (02:25 +0200)]
Cosmetics in the ns3 teshsuite

3 years agons3: ensure that sending from an host to itself does not segfault
Martin Quinson [Sun, 18 Oct 2020 00:04:00 +0000 (02:04 +0200)]
ns3: ensure that sending from an host to itself does not segfault

Also add a word in the doc about how we deal with this border case,
and a little test case.

3 years agofix a memleak
Martin Quinson [Sat, 17 Oct 2020 23:59:50 +0000 (01:59 +0200)]
fix a memleak

3 years agoSort entries.
Arnaud Giersch [Sat, 17 Oct 2020 21:17:11 +0000 (23:17 +0200)]
Sort entries.

3 years agoTry to reduce requirements about C++ standard for smpicxx.
Arnaud Giersch [Sat, 17 Oct 2020 21:10:36 +0000 (23:10 +0200)]
Try to reduce requirements about C++ standard for smpicxx.

3 years agoAvoid buffer overflow.
Arnaud Giersch [Sat, 17 Oct 2020 20:51:07 +0000 (22:51 +0200)]
Avoid buffer overflow.

3 years agoMissing include.
Arnaud Giersch [Sat, 17 Oct 2020 20:42:24 +0000 (22:42 +0200)]
Missing include.

3 years agoFix another typo
Martin Quinson [Sat, 17 Oct 2020 20:36:44 +0000 (22:36 +0200)]
Fix another typo

3 years agoDocument a recent change
Martin Quinson [Sat, 17 Oct 2020 20:34:16 +0000 (22:34 +0200)]
Document a recent change

3 years agotiny cleanups in platform examples
Martin Quinson [Sat, 17 Oct 2020 20:27:56 +0000 (22:27 +0200)]
tiny cleanups in platform examples

3 years agoDon't include <xbt/functional.hpp> when it's not needed.
Arnaud Giersch [Sat, 17 Oct 2020 19:34:15 +0000 (21:34 +0200)]
Don't include <xbt/functional.hpp> when it's not needed.

This aims to reduce the need for C++14 in user codes.

3 years agoTypo.
Arnaud Giersch [Sat, 17 Oct 2020 18:47:38 +0000 (20:47 +0200)]
Typo.

Reported in https://github.com/simgrid/simgrid/issues/348.

3 years agoNested code block is useless.
Arnaud Giersch [Sat, 17 Oct 2020 12:03:54 +0000 (14:03 +0200)]
Nested code block is useless.

3 years agoMANIFEST.in once again.
Arnaud Giersch [Sat, 17 Oct 2020 11:54:41 +0000 (13:54 +0200)]
MANIFEST.in once again.

3 years agoMerge branch 'test-condvar-wait_until' into 'master'
Augustin Degomme [Fri, 16 Oct 2020 23:13:45 +0000 (01:13 +0200)]
Merge branch 'test-condvar-wait_until' into 'master'

test condition variable wait_until+notify_all

See merge request simgrid/simgrid!44

3 years agotest condition variable wait_until+notify_all
Millian Poquet [Fri, 16 Oct 2020 23:01:28 +0000 (01:01 +0200)]
test condition variable wait_until+notify_all

3 years agoKeep the right definition for type_names[].
Arnaud Giersch [Fri, 16 Oct 2020 21:11:41 +0000 (23:11 +0200)]
Keep the right definition for type_names[].

3 years agoCosmetics.
Arnaud Giersch [Fri, 16 Oct 2020 21:11:26 +0000 (23:11 +0200)]
Cosmetics.

3 years agoUse std::array and reduce scope for constant.
Arnaud Giersch [Fri, 16 Oct 2020 20:02:10 +0000 (22:02 +0200)]
Use std::array and reduce scope for constant.

3 years agoMake static stuff member of class Replayer.
Arnaud Giersch [Fri, 16 Oct 2020 19:49:06 +0000 (21:49 +0200)]
Make static stuff member of class Replayer.

3 years agoMake global variables const.
Arnaud Giersch [Fri, 16 Oct 2020 19:48:33 +0000 (21:48 +0200)]
Make global variables const.

3 years agoFix indentation.
Arnaud Giersch [Fri, 16 Oct 2020 08:32:56 +0000 (10:32 +0200)]
Fix indentation.

3 years agoForgotten guard.
Arnaud Giersch [Fri, 16 Oct 2020 07:36:55 +0000 (09:36 +0200)]
Forgotten guard.

3 years agoConst.
Arnaud Giersch [Fri, 16 Oct 2020 07:11:41 +0000 (09:11 +0200)]
Const.

3 years agoMove global variables to class Context.
Arnaud Giersch [Fri, 16 Oct 2020 06:52:20 +0000 (08:52 +0200)]
Move global variables to class Context.

3 years agoMove global variables to class Container.
Arnaud Giersch [Fri, 16 Oct 2020 06:30:28 +0000 (08:30 +0200)]
Move global variables to class Container.

3 years agoPlug memleak.
Arnaud Giersch [Thu, 15 Oct 2020 13:54:35 +0000 (15:54 +0200)]
Plug memleak.

3 years agoRewrite in a simpler manner.
Arnaud Giersch [Thu, 15 Oct 2020 12:45:42 +0000 (14:45 +0200)]
Rewrite in a simpler manner.

3 years agoMore char* -> std::string conversions.
Arnaud Giersch [Thu, 15 Oct 2020 12:18:54 +0000 (14:18 +0200)]
More char* -> std::string conversions.

3 years agoDefinitely remove deprecated stuff in private area.
Arnaud Giersch [Thu, 15 Oct 2020 12:02:14 +0000 (14:02 +0200)]
Definitely remove deprecated stuff in private area.

3 years agoConstify a parameter, fix name for another, and simplify code.
Arnaud Giersch [Thu, 15 Oct 2020 09:41:28 +0000 (11:41 +0200)]
Constify a parameter, fix name for another, and simplify code.

3 years ago[sonar] Replace some C-style arrays.
Arnaud Giersch [Wed, 14 Oct 2020 20:58:29 +0000 (22:58 +0200)]
[sonar] Replace some C-style arrays.

3 years agommalloc: cosmetics in an error message
Martin Quinson [Thu, 15 Oct 2020 06:54:36 +0000 (08:54 +0200)]
mmalloc: cosmetics in an error message

3 years agoCosmetics.
Arnaud Giersch [Wed, 14 Oct 2020 15:29:56 +0000 (17:29 +0200)]
Cosmetics.

Better than: if ((variable == true) != false) ...

3 years agoDrop unused parameters.
Arnaud Giersch [Wed, 14 Oct 2020 15:17:23 +0000 (17:17 +0200)]
Drop unused parameters.

3 years agoRevert "move fort_args test to a "fort args" folder, with a space"
Augustin Degomme [Tue, 13 Oct 2020 14:38:35 +0000 (16:38 +0200)]
Revert "move fort_args test to a "fort args" folder, with a space"

This reverts commit 3561c727ad711b8b1406e9f5a6f8d6390577f1e1.

3 years agoRevert "try to help cmake on freebsd"
Augustin Degomme [Tue, 13 Oct 2020 14:38:27 +0000 (16:38 +0200)]
Revert "try to help cmake on freebsd"

This reverts commit b449054b620aa87a5157d5f7e68e986dab3a25a2.

3 years agoRevert "Try to help for freebsd and paths. Thanks Matthieu Volat for the hints."
Augustin Degomme [Tue, 13 Oct 2020 14:38:02 +0000 (16:38 +0200)]
Revert "Try to help for freebsd and paths. Thanks Matthieu Volat for the hints."

This reverts commit 754ac435fbfe7234c539b500f49bba18241fcdb5.

3 years agoEnsure type > 0.
Arnaud Giersch [Tue, 13 Oct 2020 14:56:27 +0000 (16:56 +0200)]
Ensure type > 0.

3 years agoReduce scope for variables.
Arnaud Giersch [Tue, 13 Oct 2020 14:51:16 +0000 (16:51 +0200)]
Reduce scope for variables.

3 years ago"s < 0" is always true here.
Arnaud Giersch [Tue, 13 Oct 2020 14:48:49 +0000 (16:48 +0200)]
"s < 0" is always true here.

3 years agoDelete unused ctor.
Arnaud Giersch [Tue, 13 Oct 2020 14:34:33 +0000 (16:34 +0200)]
Delete unused ctor.

If it were used, private variables may be uninitialized.

3 years agoTry to help for freebsd and paths. Thanks Matthieu Volat for the hints.
Augustin Degomme [Tue, 13 Oct 2020 12:05:22 +0000 (14:05 +0200)]
Try to help for freebsd and paths. Thanks Matthieu Volat for the hints.
This does not mean simgrid can be compiled/installed in a directory with spaces in the path (still a lot of things to fix in cmakelists.txt for that).
But user's codes might work when calling smpi** scripts from directories with spaces.

3 years agopopping_enum.h becomes an hpp.
Arnaud Giersch [Tue, 13 Oct 2020 09:48:41 +0000 (11:48 +0200)]
popping_enum.h becomes an hpp.

3 years agoconst again
Arnaud Giersch [Tue, 13 Oct 2020 09:22:48 +0000 (11:22 +0200)]
const again

3 years agoRemove useless type aliases.
Arnaud Giersch [Tue, 13 Oct 2020 09:22:29 +0000 (11:22 +0200)]
Remove useless type aliases.