Frederic Suter [Thu, 16 Jan 2020 13:30:21 +0000 (14:30 +0100)]
namespace cleanups
Frederic Suter [Thu, 16 Jan 2020 09:11:20 +0000 (10:11 +0100)]
boring meeting commit: cognitive complexity reduction
Arnaud Giersch [Wed, 15 Jan 2020 20:47:05 +0000 (21:47 +0100)]
Make field 'Context::iwannadie' private.
I'm not fond of the names for the new methods, but don't have a better idea.
Arnaud Giersch [Wed, 15 Jan 2020 20:23:10 +0000 (21:23 +0100)]
Make field 'SwappedContext::worker_context_' private.
Arnaud Giersch [Wed, 15 Jan 2020 20:22:22 +0000 (21:22 +0100)]
Field 'SwappedContext::factory_' becomes a reference.
Arnaud Giersch [Thu, 16 Jan 2020 08:35:40 +0000 (09:35 +0100)]
Using extern "C" does not prevent name mangling for static functions.
See
https://en.cppreference.com/w/cpp/language/language_linkage
Arnaud Giersch [Wed, 15 Jan 2020 10:31:38 +0000 (11:31 +0100)]
[sonar] Add const qualifier.
Frederic Suter [Wed, 15 Jan 2020 12:15:54 +0000 (13:15 +0100)]
Seems to works now
Frederic Suter [Wed, 15 Jan 2020 11:40:08 +0000 (12:40 +0100)]
simplification commit
* Class methods do not need tu use accessor to own class field
* Prefer model->is_update_lazy() to
model->get_update_algorithm == Model::UpdateAlgo::LAZY
Frederic Suter [Wed, 15 Jan 2020 10:01:16 +0000 (11:01 +0100)]
cleanups
Frederic Suter [Wed, 15 Jan 2020 10:00:57 +0000 (11:00 +0100)]
fixedme
Frederic Suter [Tue, 14 Jan 2020 10:16:34 +0000 (11:16 +0100)]
plug leak
pimpl_->storage was directly accessed before without simcall and
adding one generate copies and leaks. Storage must die anyway ...
Frederic Suter [Mon, 13 Jan 2020 13:44:04 +0000 (14:44 +0100)]
namespace cosmetics
Frederic Suter [Mon, 13 Jan 2020 09:49:57 +0000 (10:49 +0100)]
[sonar] Don't mix public/private data members
Augustin Degomme [Fri, 10 Jan 2020 10:31:52 +0000 (11:31 +0100)]
oops
Martin Quinson [Fri, 10 Jan 2020 10:28:32 +0000 (11:28 +0100)]
document a recent change
Martin Quinson [Fri, 10 Jan 2020 10:26:44 +0000 (11:26 +0100)]
document Mailboxes in the new way
Martin Quinson [Thu, 9 Jan 2020 14:36:36 +0000 (15:36 +0100)]
document the this_actor namespace in the new way
Martin Quinson [Wed, 8 Jan 2020 23:20:37 +0000 (00:20 +0100)]
Kill a meaningless function: this_actor::resume()
How could the current actor resume itself if it's suspended in the
first place??
Martin Quinson [Wed, 8 Jan 2020 22:46:54 +0000 (23:46 +0100)]
Teach autodoxy about namespaces
Martin Quinson [Tue, 7 Jan 2020 21:40:15 +0000 (22:40 +0100)]
Improve docs/find-missing
- automatically extend PYTHONPATH on need. The python lib is searched
in the ../lib directory. If it's not there, add a symlink
- ignore some autodoxy symbols. Just add them in find-missing.ignore
Martin Quinson [Mon, 6 Jan 2020 21:41:17 +0000 (22:41 +0100)]
briefly document some more C types
Augustin Degomme [Fri, 10 Jan 2020 10:17:12 +0000 (11:17 +0100)]
update OS detection, fix openindiana, improve wsl detection to cover more than just ubuntu.
Augustin Degomme [Fri, 10 Jan 2020 09:35:34 +0000 (10:35 +0100)]
add missing links in dragonfly fig gh #335
Arnaud Giersch [Thu, 9 Jan 2020 14:33:21 +0000 (15:33 +0100)]
A simcall on Actor destruction doesn't make much sense.
This fixes Asan errors on s4u-actor-kill.
Arnaud Giersch [Thu, 9 Jan 2020 10:41:07 +0000 (11:41 +0100)]
Noreturn annotations in contexts.
Arnaud Giersch [Thu, 9 Jan 2020 07:38:13 +0000 (08:38 +0100)]
Pass large parameter by address.
Arnaud Giersch [Thu, 9 Jan 2020 07:32:19 +0000 (08:32 +0100)]
One import less.
Arnaud Giersch [Thu, 9 Jan 2020 07:31:00 +0000 (08:31 +0100)]
Use implicit string conversion.
It's strange to have different type on both sides of :
Arnaud Giersch [Wed, 8 Jan 2020 20:21:16 +0000 (21:21 +0100)]
Put the loop right (easier to read and more efficient when building string).
Frederic Suter [Wed, 8 Jan 2020 12:17:26 +0000 (13:17 +0100)]
[sonar] Don't mix public and private data members for ptasks
Frederic Suter [Wed, 8 Jan 2020 10:32:09 +0000 (11:32 +0100)]
[sonar] Don't mix public and private data members (easy ones)
Arnaud Giersch [Wed, 8 Jan 2020 17:29:28 +0000 (18:29 +0100)]
Use initialization list.
Arnaud Giersch [Wed, 8 Jan 2020 16:32:37 +0000 (17:32 +0100)]
[sonar] asks for std::forward.
Arnaud Giersch [Wed, 8 Jan 2020 16:13:40 +0000 (17:13 +0100)]
[sonar] Use std::move with rvalue references.
Martin Quinson [Wed, 8 Jan 2020 16:39:46 +0000 (17:39 +0100)]
Merge branch 'doc' into 'master'
Fix links in SMPI interface doc
See merge request simgrid/simgrid!26
Julien EMMANUEL [Wed, 8 Jan 2020 15:46:33 +0000 (16:46 +0100)]
Fix broken links in SMPI interface doc
Change HTML-style links to RST-style ones
Arnaud Giersch [Wed, 8 Jan 2020 13:35:30 +0000 (14:35 +0100)]
[sonar] Prefer lambda over anonymous class.
Arnaud Giersch [Wed, 8 Jan 2020 13:27:31 +0000 (14:27 +0100)]
Useless "import".
Arnaud Giersch [Wed, 8 Jan 2020 13:27:07 +0000 (14:27 +0100)]
Remove "--" from XML comments.
Arnaud Giersch [Wed, 8 Jan 2020 12:30:00 +0000 (13:30 +0100)]
Another superfluous 'throws'.
Arnaud Giersch [Wed, 8 Jan 2020 12:12:21 +0000 (13:12 +0100)]
Java 8 is required.
Arnaud Giersch [Wed, 8 Jan 2020 11:09:57 +0000 (12:09 +0100)]
[sonar] Mention new configuration keys.
Arnaud Giersch [Wed, 8 Jan 2020 11:02:59 +0000 (12:02 +0100)]
[sonar] Update rule keys for Java.
See https://community.sonarsource.com/t/java-rule-id-changes/18409
Arnaud Giersch [Wed, 8 Jan 2020 09:35:02 +0000 (10:35 +0100)]
Const + simplification for jedule::Container::get_child_position.
Arnaud Giersch [Wed, 8 Jan 2020 08:39:10 +0000 (09:39 +0100)]
[sonar] Avoid nested code block.
Arnaud Giersch [Wed, 8 Jan 2020 08:27:59 +0000 (09:27 +0100)]
[sonar] Superfluous 'throws'.
Arnaud Giersch [Tue, 7 Jan 2020 21:44:36 +0000 (22:44 +0100)]
Forgotten cleanups in includes.
Arnaud Giersch [Tue, 7 Jan 2020 21:14:54 +0000 (22:14 +0100)]
Simplify xbt:Backtrace.
Arnaud Giersch [Tue, 7 Jan 2020 12:40:50 +0000 (13:40 +0100)]
Complete ChangeLog.
Arnaud Giersch [Tue, 7 Jan 2020 08:43:15 +0000 (09:43 +0100)]
Test is redundant (already checked in xbt_dict_preinit).
Frederic Suter [Tue, 7 Jan 2020 11:11:56 +0000 (12:11 +0100)]
[sonar] don't mix public/private data members
Frederic Suter [Tue, 7 Jan 2020 11:11:09 +0000 (12:11 +0100)]
[sonar] don't mix public/private data members
Frederic Suter [Tue, 7 Jan 2020 08:52:06 +0000 (09:52 +0100)]
[sonar] don't mix public/private issues in jedule
Arnaud Giersch [Tue, 17 Sep 2019 08:23:17 +0000 (10:23 +0200)]
Explicit instanciation of xbt::Extendable<> specializations.
Fixes Asan warnings about odr-violations (default with current gcc-10, or with
ASAN_OPTIONS='use_odr_indicator=true detect_odr_violation=2').
It may also complete commit
f2e9bf81aebf9a0d39563c3f955fc24e9270d74f
"Explicit instanciation of Extendable<simgrid::s4u::Host>".
Arnaud Giersch [Mon, 6 Jan 2020 13:52:25 +0000 (14:52 +0100)]
Drop unused xbt dynar functions.
Arnaud Giersch [Mon, 6 Jan 2020 13:47:45 +0000 (14:47 +0100)]
Drop unused xbt dict functions.
Arnaud Giersch [Mon, 6 Jan 2020 10:49:31 +0000 (11:49 +0100)]
Drop never used macro XBT_UNREACHABLE.
Arnaud Giersch [Sun, 5 Jan 2020 16:49:10 +0000 (17:49 +0100)]
Use a std::unique_ptr.
Arnaud Giersch [Sun, 5 Jan 2020 16:22:18 +0000 (17:22 +0100)]
Boost 1.59 is required nowadays, remove support for older versions.
Martin Quinson [Sun, 5 Jan 2020 16:48:56 +0000 (17:48 +0100)]
fix the doc of const_sg_*_t types
Martin Quinson [Sun, 5 Jan 2020 00:36:04 +0000 (01:36 +0100)]
Fix make dist and pip install
Martin Quinson [Sat, 4 Jan 2020 18:15:53 +0000 (19:15 +0100)]
document Mutex and Semaphores in the new way
Martin Quinson [Sat, 4 Jan 2020 17:27:03 +0000 (18:27 +0100)]
document Barrier in the new way, and document the C version
Martin Quinson [Sat, 4 Jan 2020 17:13:57 +0000 (18:13 +0100)]
improve the doc of condition variables
Martin Quinson [Sat, 4 Jan 2020 17:05:08 +0000 (18:05 +0100)]
add an example for condition variables
Martin Quinson [Fri, 3 Jan 2020 23:03:47 +0000 (00:03 +0100)]
document ConditionVariables in the new way
Martin Quinson [Fri, 3 Jan 2020 22:40:12 +0000 (23:40 +0100)]
get useful warnings for broken links in the doc
Arnaud Giersch [Sat, 4 Jan 2020 14:38:34 +0000 (15:38 +0100)]
Use a std::unique_ptr, and remove custom destructor.
Gabriel Corona [Sat, 4 Jan 2020 09:31:36 +0000 (10:31 +0100)]
Martin Quinson [Fri, 3 Jan 2020 17:08:25 +0000 (18:08 +0100)]
Further reduce the amount of errors and warnings when rebuilding the doc
Martin Quinson [Thu, 2 Jan 2020 16:56:31 +0000 (17:56 +0100)]
various doc small fixups
Martin Quinson [Thu, 2 Jan 2020 16:16:01 +0000 (17:16 +0100)]
automatically determine the core amount
Martin Quinson [Thu, 2 Jan 2020 14:25:54 +0000 (15:25 +0100)]
one void* less
Arnaud Giersch [Fri, 3 Jan 2020 15:02:02 +0000 (16:02 +0100)]
Use different strings (and please sonar).
Arnaud Giersch [Fri, 3 Jan 2020 14:34:42 +0000 (15:34 +0100)]
[sonar] Make member variables "private".
Augustin Degomme [Thu, 2 Jan 2020 16:54:59 +0000 (17:54 +0100)]
xsltproc is not used since... a long time ago
Arnaud Giersch [Thu, 2 Jan 2020 11:03:51 +0000 (12:03 +0100)]
Small cleanups in kademlia::Answer.
Make field nodes_ private; remove field size_.
Arnaud Giersch [Thu, 2 Jan 2020 10:06:28 +0000 (11:06 +0100)]
Const is for the pointee, not the pointer.
Augustin Degomme [Wed, 1 Jan 2020 21:45:20 +0000 (22:45 +0100)]
changelog update for SMPI
Arnaud Giersch [Wed, 1 Jan 2020 21:02:00 +0000 (22:02 +0100)]
Update copyright lines with new year.
Arnaud Giersch [Tue, 31 Dec 2019 17:35:05 +0000 (18:35 +0100)]
[sonar] Constify pointer and reference parameters in teshsuite/.
Arnaud Giersch [Tue, 31 Dec 2019 15:41:05 +0000 (16:41 +0100)]
[sonar] Another bunch of const qualifiers.
Arnaud Giersch [Mon, 30 Dec 2019 23:11:53 +0000 (00:11 +0100)]
[sonar] Constify pointer and reference parameters in src/xbt/log.cpp.
Arnaud Giersch [Mon, 30 Dec 2019 23:03:43 +0000 (00:03 +0100)]
[sonar] Constify pointer and reference parameters in src/xbt/graph.c.
Arnaud Giersch [Mon, 30 Dec 2019 22:42:45 +0000 (23:42 +0100)]
[sonar] Constify pointer and reference parameters in src/xbt/dynar.cpp.
Also remove misleading const qualifiers for function parameters.
Arnaud Giersch [Mon, 30 Dec 2019 21:56:21 +0000 (22:56 +0100)]
[sonar] Constify pointer and reference parameters in src/xbt/dict.cpp.
Arnaud Giersch [Mon, 30 Dec 2019 21:17:13 +0000 (22:17 +0100)]
[sonar] Constify pointer and reference parameters in src/xbt/automaton/.
Arnaud Giersch [Mon, 30 Dec 2019 13:57:10 +0000 (14:57 +0100)]
Misc const qualifiers following yesterday's changes.
Arnaud Giersch [Sun, 29 Dec 2019 22:37:48 +0000 (23:37 +0100)]
[sonar] Constify pointer and reference parameters in src/surf/.
Arnaud Giersch [Sun, 29 Dec 2019 20:56:46 +0000 (21:56 +0100)]
[sonar] Constify pointer and reference parameters in src/smpi/.
Arnaud Giersch [Sun, 29 Dec 2019 20:24:48 +0000 (21:24 +0100)]
[sonar] Constify pointer and reference parameters in src/simdag/.
Arnaud Giersch [Sun, 29 Dec 2019 11:43:14 +0000 (12:43 +0100)]
[sonar] Constify pointer and reference parameters in src/s4u/.
This commit is too big, but it's too late to split it :(
Arnaud Giersch [Sun, 29 Dec 2019 08:31:38 +0000 (09:31 +0100)]
Sonar consts of the day.
Arnaud Giersch [Sat, 28 Dec 2019 22:47:44 +0000 (23:47 +0100)]
[sonar] Ignore cpp:S995 for src/smpi/bindings/.
Arnaud Giersch [Sat, 28 Dec 2019 22:02:11 +0000 (23:02 +0100)]
[sonar] Constify pointer and reference parameters in src/plugins/.
Arnaud Giersch [Sat, 28 Dec 2019 21:51:55 +0000 (22:51 +0100)]
[sonar] Constify pointer parameters in src/msg/.
Arnaud Giersch [Sat, 28 Dec 2019 13:11:19 +0000 (14:11 +0100)]
[sonar] Constify pointer and reference parameters in src/mc/.
Arnaud Giersch [Sat, 28 Dec 2019 10:28:59 +0000 (11:28 +0100)]
[sonar] More const for pointer and reference local variables and parameters.
Arnaud Giersch [Sat, 28 Dec 2019 13:44:26 +0000 (14:44 +0100)]
Cosmetics: use 's_xbt_mheap_t' instead of 'struct mdesc'.